210224 2020-04-08 16:03:40 -0700 Handle [PDFDocument initWithProvider:] returning nil 2020-04-08 16:51:15 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson ggaren webkit-bug-importer oldest_to_newest 1639340 0 beidson 2020-04-08 16:03:40 -0700 Handle [PDFDocument initWithProvider:] returning nil <rdar://problem/61482395> 1639343 1 395880 beidson 2020-04-08 16:07:36 -0700 Created attachment 395880 Patch 1639344 2 395880 ggaren 2020-04-08 16:10:07 -0700 Comment on attachment 395880 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395880&action=review r=me > Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:873 > + if (!m_incrementalPDFLoadingEnabled || !m_backgroundThreadDocument) { > m_backgroundThreadDocument = nil; You could just do a separate early return, since it's kinda silly to say "if m_backgroundThreadDocument is null, set m_backgroundThreadDocument to null". 1639346 3 395882 beidson 2020-04-08 16:16:14 -0700 Created attachment 395882 Patch 1639365 4 ews-feeder 2020-04-08 16:50:44 -0700 Committed r259765: <https://trac.webkit.org/changeset/259765> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395882. 1639366 5 webkit-bug-importer 2020-04-08 16:51:15 -0700 <rdar://problem/61485477> 395880 2020-04-08 16:07:36 -0700 2020-04-08 16:16:14 -0700 Patch patch text/plain 1634 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggYmQ0NmMyYmNkNGUuLmI5NTJlMTY1YjZiIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDEzIEBACisyMDIwLTA0LTA4ICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KKwor ICAgICAgICBIYW5kbGUgW1BERkRvY3VtZW50IGluaXRXaXRoUHJvdmlkZXI6XSByZXR1cm5pbmcg bmlsCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82MTQ4MjM5NT4gYW5kIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTAyMjQKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvUGx1Z2lucy9QREYvUERGUGx1 Z2luLm1tOgorICAgICAgICAoV2ViS2l0OjpQREZQbHVnaW46OnRocmVhZEVudHJ5KTogVHJlYXQg YSBuaWwgUERGRG9jdW1lbnQgYXMgIm5vbi1saW5lYXJpemVkLCBmYWxsYmFjayB0byBub3JtYWwg bG9hZGluZyIKKwogMjAyMC0wNC0wNiAgS2F0ZSBDaGVuZXkgIDxrYXRoZXJpbmVfY2hlbmV5QGFw cGxlLmNvbT4KIAogICAgICAgICBDcmVhdGUgYSB3YXkgdG8gc2lnbmFsIGlmIHRoZSBXS0FwcEJv dW5kRG9tYWlucyBsaXN0IGlzIGVtcHR5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlBy b2Nlc3MvUGx1Z2lucy9QREYvUERGUGx1Z2luLm1tIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNz L1BsdWdpbnMvUERGL1BERlBsdWdpbi5tbQppbmRleCBiYjc3MGEzN2Q3OS4uNDQzYTZjMGFjNDYg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9QREZQbHVn aW4ubW0KKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1BsdWdpbnMvUERGL1BERlBsdWdp bi5tbQpAQCAtODY3LDcgKzg2Nyw5IEBAIHZvaWQgUERGUGx1Z2luOjp0aHJlYWRFbnRyeShSZWY8 UERGUGx1Z2luPiYmIHByb3RlY3RlZFBsdWdpbikKICAgICBDR0RhdGFQcm92aWRlclNldFByb3Bl cnR5KGRhdGFQcm92aWRlci5nZXQoKSwga0NHRGF0YVByb3ZpZGVySGFzSGlnaExhdGVuY3ksIGtD RkJvb2xlYW5UcnVlKTsKICAgICBtX2JhY2tncm91bmRUaHJlYWREb2N1bWVudCA9IGFkb3B0TlMo W1twZGZEb2N1bWVudENsYXNzKCkgYWxsb2NdIGluaXRXaXRoUHJvdmlkZXI6ZGF0YVByb3ZpZGVy LmdldCgpXSk7CiAKLSAgICBpZiAoIW1faW5jcmVtZW50YWxQREZMb2FkaW5nRW5hYmxlZCkgewor ICAgIC8vIFtQREZEb2N1bWVudCBpbml0V2l0aFByb3ZpZGVyOl0gd2lsbCByZXR1cm4gbmlsIGlu IGNhc2VzIHdoZXJlIHRoZSBQREYgaXMgbm9uLWxpbmVhcml6ZWQuCisgICAgLy8gSW4gdGhvc2Ug Y2FzZXMgd2UnbGwganVzdCBrZWVwIGJ1ZmZlcmluZyB0aGUgZW50aXJlIFBERiBvbiB0aGUgbWFp biB0aHJlYWQuCisgICAgaWYgKCFtX2luY3JlbWVudGFsUERGTG9hZGluZ0VuYWJsZWQgfHwgIW1f YmFja2dyb3VuZFRocmVhZERvY3VtZW50KSB7CiAgICAgICAgIG1fYmFja2dyb3VuZFRocmVhZERv Y3VtZW50ID0gbmlsOwogICAgICAgICByZXR1cm47CiAgICAgfQo= 395882 2020-04-08 16:16:14 -0700 2020-04-08 16:50:44 -0700 Patch patch text/plain 1607 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggYmQ0NmMyYmNkNGUuLjI4Nzg0MjAxY2Y5IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDEzIEBACisyMDIwLTA0LTA4ICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KKwor ICAgICAgICBIYW5kbGUgW1BERkRvY3VtZW50IGluaXRXaXRoUHJvdmlkZXI6XSByZXR1cm5pbmcg bmlsCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82MTQ4MjM5NT4gYW5kIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTAyMjQKKworICAgICAgICBSZXZpZXdlZCBieSBH ZW9mZiBHYXJlbi4KKworICAgICAgICAqIFdlYlByb2Nlc3MvUGx1Z2lucy9QREYvUERGUGx1Z2lu Lm1tOgorICAgICAgICAoV2ViS2l0OjpQREZQbHVnaW46OnRocmVhZEVudHJ5KTogVHJlYXQgYSBu aWwgUERGRG9jdW1lbnQgYXMgIm5vbi1saW5lYXJpemVkLCBmYWxsYmFjayB0byBub3JtYWwgbG9h ZGluZyIKKwogMjAyMC0wNC0wNiAgS2F0ZSBDaGVuZXkgIDxrYXRoZXJpbmVfY2hlbmV5QGFwcGxl LmNvbT4KIAogICAgICAgICBDcmVhdGUgYSB3YXkgdG8gc2lnbmFsIGlmIHRoZSBXS0FwcEJvdW5k RG9tYWlucyBsaXN0IGlzIGVtcHR5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nl c3MvUGx1Z2lucy9QREYvUERGUGx1Z2luLm1tIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1Bs dWdpbnMvUERGL1BERlBsdWdpbi5tbQppbmRleCBiYjc3MGEzN2Q3OS4uNDVkNmQ3YWRmMzQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9QREZQbHVnaW4u bW0KKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1BsdWdpbnMvUERGL1BERlBsdWdpbi5t bQpAQCAtODY3LDYgKzg2NywxMSBAQCB2b2lkIFBERlBsdWdpbjo6dGhyZWFkRW50cnkoUmVmPFBE RlBsdWdpbj4mJiBwcm90ZWN0ZWRQbHVnaW4pCiAgICAgQ0dEYXRhUHJvdmlkZXJTZXRQcm9wZXJ0 eShkYXRhUHJvdmlkZXIuZ2V0KCksIGtDR0RhdGFQcm92aWRlckhhc0hpZ2hMYXRlbmN5LCBrQ0ZC b29sZWFuVHJ1ZSk7CiAgICAgbV9iYWNrZ3JvdW5kVGhyZWFkRG9jdW1lbnQgPSBhZG9wdE5TKFtb cGRmRG9jdW1lbnRDbGFzcygpIGFsbG9jXSBpbml0V2l0aFByb3ZpZGVyOmRhdGFQcm92aWRlci5n ZXQoKV0pOwogCisgICAgLy8gW1BERkRvY3VtZW50IGluaXRXaXRoUHJvdmlkZXI6XSB3aWxsIHJl dHVybiBuaWwgaW4gY2FzZXMgd2hlcmUgdGhlIFBERiBpcyBub24tbGluZWFyaXplZC4KKyAgICAv LyBJbiB0aG9zZSBjYXNlcyB3ZSdsbCBqdXN0IGtlZXAgYnVmZmVyaW5nIHRoZSBlbnRpcmUgUERG IG9uIHRoZSBtYWluIHRocmVhZC4KKyAgICBpZiAoIW1fYmFja2dyb3VuZFRocmVhZERvY3VtZW50 KQorICAgICAgICByZXR1cm47CisKICAgICBpZiAoIW1faW5jcmVtZW50YWxQREZMb2FkaW5nRW5h YmxlZCkgewogICAgICAgICBtX2JhY2tncm91bmRUaHJlYWREb2N1bWVudCA9IG5pbDsKICAgICAg ICAgcmV0dXJuOwo=