210207 2020-04-08 11:46:50 -0700 Web Inspector: Search: populate the search field with the current selection when using the global search shortcut 2020-04-08 13:03:12 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Local Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi hi inspector-bugzilla-changes timothy webkit-bug-importer oldest_to_newest 1639186 0 hi 2020-04-08 11:46:50 -0700 This is one of the things I love most about Sublime Text, in that I can select something, press ⇧⌘F, and immediately search for the selected string throughout my project without having to copy/paste it. 1639187 1 395848 hi 2020-04-08 11:47:41 -0700 Created attachment 395848 Patch 1639194 2 395848 timothy 2020-04-08 11:53:45 -0700 Comment on attachment 395848 Patch Should we just hook up Command-E? That is a system wide shortcut for this. No need for a preference in that case. 1639204 3 hi 2020-04-08 12:00:47 -0700 (In reply to Timothy Hatcher from comment #2) > Should we just hook up Command-E? That is a system wide shortcut for this. No need for a preference in that case. This is for the global search (⇧⌘F), not searching within a given resource. I think it makes sense to have it as a setting instead of always on because some people may use ⇧⌘F as just a way of quickly going to the Search Tab, not necessarily wanting to alter the current search query. We already have support for ⌘E from within Web Inspector (it doesn't propagate from the rest of the system though <https://webkit.org/b/151310>). 1639248 4 ews-feeder 2020-04-08 13:02:22 -0700 Committed r259748: <https://trac.webkit.org/changeset/259748> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395848. 1639249 5 webkit-bug-importer 2020-04-08 13:03:12 -0700 <rdar://problem/61471963> 395848 2020-04-08 11:47:41 -0700 2020-04-08 13:02:23 -0700 Patch 210207.diff text/plain 5329 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDgyNDVmMjRjNTM4Li40ZGUyYWUxMDY4NyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMjAtMDQtMDggIERldmlu IFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFNl YXJjaDogcG9wdWxhdGUgdGhlIHNlYXJjaCBmaWVsZCB3aXRoIHRoZSBjdXJyZW50IHNlbGVjdGlv biB3aGVuIHVzaW5nIHRoZSBnbG9iYWwgc2VhcmNoIHNob3J0Y3V0CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTAyMDcKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSBzZXR0aW5nIHRvIGNvbnRyb2wg d2hldGhlciB0aGUgZ2xvYmFsIHNlYXJjaCAo4oen4oyYRikgc2hvdWxkIGJlIHBvcHVsYXRlZCBi eSB0aGUgY3VycmVudAorICAgICAgICBzZWxlY3Rpb24gKGlmIGl0IGV4aXN0cyksIGFsbG93aW5n IGZvciBhIHF1aWNrZXIgZmxvdyBmb3IgInNob3cgbWUgZXZlcnl3aGVyZSB0aGlzIGV4aXN0cyIu CisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0Jhc2UvU2V0dGluZy5qczoKKyAgICAgICAgKiBV c2VySW50ZXJmYWNlL1ZpZXdzL1NldHRpbmdzVGFiQ29udGVudFZpZXcuanM6CisgICAgICAgIChX SS5TZXR0aW5nc1RhYkNvbnRlbnRWaWV3LnByb3RvdHlwZS5fY3JlYXRlR2VuZXJhbFNldHRpbmdz Vmlldyk6CisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qczoKKyAgICAgICAg KFdJLl9mb2N1c1NlYXJjaEZpZWxkKQorCisgICAgICAgICogTG9jYWxpemF0aW9ucy9lbi5scHJv ai9sb2NhbGl6ZWRTdHJpbmdzLmpzOgorCiAyMDIwLTA0LTA3ICBOaWtpdGEgVmFzaWx5ZXYgIDxu dmFzaWx5ZXZAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IGZvY3VzIG91dGxp bmUgb2Ygc2NvcGUgYmFyIGlzIGNsaXBwZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Mb2NhbGl6YXRpb25zL2VuLmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanMgYi9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvTG9jYWxpemF0aW9ucy9lbi5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpz CmluZGV4IGFlMjNhOWNjN2M0Li5jNTEwNDBhMjk4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYklu c3BlY3RvclVJL0xvY2FsaXphdGlvbnMvZW4ubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qcworKysg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvTG9jYWxpemF0aW9ucy9lbi5scHJvai9sb2NhbGl6ZWRT dHJpbmdzLmpzCkBAIC02MTIsNiArNjEyLDggQEAgbG9jYWxpemVkU3RyaW5nc1siR2VuZXJhbCJd ID0gIkdlbmVyYWwiOwogbG9jYWxpemVkU3RyaW5nc1siR2V0dGVyIl0gPSAiR2V0dGVyIjsKIGxv Y2FsaXplZFN0cmluZ3NbIkdsb2JhbCBDb2RlIl0gPSAiR2xvYmFsIENvZGUiOwogbG9jYWxpemVk U3RyaW5nc1siR2xvYmFsIExleGljYWwgRW52aXJvbm1lbnQiXSA9ICJHbG9iYWwgTGV4aWNhbCBF bnZpcm9ubWVudCI7CisvKiBTZXR0aW5ncyB0YWIgY2hlY2tib3ggbGFiZWwgZm9yIHdoZXRoZXIg dGhlIGdsb2JhbCBzZWFyY2ggc2hvdWxkIHBvcHVsYXRlIGZyb20gdGhlIGN1cnJlbnQgc2VsZWN0 aW9uLiAqLworbG9jYWxpemVkU3RyaW5nc1siR2xvYmFsIFNlYXJjaCBGcm9tIFNlbGVjdGlvbiBA IFNldHRpbmdzIl0gPSAiJXMgZnJvbSBzZWxlY3Rpb24iOwogbG9jYWxpemVkU3RyaW5nc1siR2xv YmFsIFZhcmlhYmxlcyJdID0gIkdsb2JhbCBWYXJpYWJsZXMiOwogbG9jYWxpemVkU3RyaW5nc1si R3JhbW1hciJdID0gIkdyYW1tYXIiOwogLyogTmFtZSBvZiBHcmFwaGljcyBUYWIgKi8KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcwppbmRleCAz MDA4NjljYzgzNy4uYWMzOTlhYmZiMDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9CYXNlL01haW4uanMKQEAgLTE1NDIsMTIgKzE1NDIsMjMgQEAgV0kuZGVi dWdnZXJTdGVwT3V0ID0gZnVuY3Rpb24oZXZlbnQpCiAKIFdJLl9mb2N1c1NlYXJjaEZpZWxkID0g ZnVuY3Rpb24oZXZlbnQpCiB7CisgICAgbGV0IHNlYXJjaFF1ZXJ5ID0gIiI7CisKKyAgICBpZiAo V0kuc2V0dGluZ3Muc2VhcmNoRnJvbVNlbGVjdGlvbi52YWx1ZSkgeworICAgICAgICBsZXQgc2Vs ZWN0aW9uID0gd2luZG93LmdldFNlbGVjdGlvbigpOworICAgICAgICBpZiAoc2VsZWN0aW9uLnR5 cGUgPT09ICJSYW5nZSIgfHwgIXNlbGVjdGlvbi5pc0NvbGxhcHNlZCkKKyAgICAgICAgICAgIHNl YXJjaFF1ZXJ5ID0gc2VsZWN0aW9uLnRvU3RyaW5nKCkucmVtb3ZlV29yZEJyZWFrQ2hhcmFjdGVy cygpOworICAgIH0KKwogICAgIFdJLnRhYkJyb3dzZXIuc2hvd1RhYkZvckNvbnRlbnRWaWV3KFdJ Ll9zZWFyY2hUYWJDb250ZW50VmlldywgewogICAgICAgICAvLyBDbGFzc2lmeSB0aGlzIGFzIGEg a2V5Ym9hcmQgc2hvcnRjdXQsIGFzIHRoZSBvbmx5IG90aGVyIHdheSB0byBnZXQgdG8gU2VhcmNo IFRhYiBpcyB2aWEgVGFiQmFyIGl0c2VsZi4KICAgICAgICAgaW5pdGlhdG9ySGludDogV0kuVGFi QnJvd3Nlci5UYWJOYXZpZ2F0aW9uSW5pdGlhdG9yLktleWJvYXJkU2hvcnRjdXQsCiAgICAgfSk7 CiAKICAgICBXSS5fc2VhcmNoVGFiQ29udGVudFZpZXcuZm9jdXNTZWFyY2hGaWVsZCgpOworCisg ICAgaWYgKHNlYXJjaFF1ZXJ5KQorICAgICAgICBXSS5fc2VhcmNoVGFiQ29udGVudFZpZXcucGVy Zm9ybVNlYXJjaChzZWFyY2hRdWVyeSk7CiB9OwogCiBXSS5fZm9jdXNDaGFuZ2VkID0gZnVuY3Rp b24oZXZlbnQpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9CYXNlL1NldHRpbmcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9C YXNlL1NldHRpbmcuanMKaW5kZXggOTlkN2FlOGQ4YTIuLmIxYTA1OGI2MmVlIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL1NldHRpbmcuanMKKysr IGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9TZXR0aW5nLmpzCkBA IC0xOTMsNiArMTkzLDcgQEAgV0kuc2V0dGluZ3MgPSB7CiAgICAgaW5kZW50V2l0aFRhYnM6IG5l dyBXSS5TZXR0aW5nKCJpbmRlbnQtd2l0aC10YWJzIiwgZmFsc2UpLAogICAgIHJlc291cmNlQ2Fj aGluZ0Rpc2FibGVkOiBuZXcgV0kuU2V0dGluZygiZGlzYWJsZS1yZXNvdXJjZS1jYWNoaW5nIiwg ZmFsc2UpLAogICAgIHNlYXJjaENhc2VTZW5zaXRpdmU6IG5ldyBXSS5TZXR0aW5nKCJzZWFyY2gt Y2FzZS1zZW5zaXRpdmUiLCBmYWxzZSksCisgICAgc2VhcmNoRnJvbVNlbGVjdGlvbjogbmV3IFdJ LlNldHRpbmcoInNlYXJjaC1mcm9tLXNlbGVjdGlvbiIsIGZhbHNlKSwKICAgICBzZWFyY2hSZWd1 bGFyRXhwcmVzc2lvbjogbmV3IFdJLlNldHRpbmcoInNlYXJjaC1yZWd1bGFyLWV4cHJlc3Npb24i LCBmYWxzZSksCiAgICAgc2VsZWN0ZWROZXR3b3JrRGV0YWlsQ29udGVudFZpZXdJZGVudGlmaWVy OiBuZXcgV0kuU2V0dGluZygibmV0d29yay1kZXRhaWwtY29udGVudC12aWV3LWlkZW50aWZpZXIi LCAicHJldmlldyIpLAogICAgIHNvdXJjZU1hcHNFbmFibGVkOiBuZXcgV0kuU2V0dGluZygic291 cmNlLW1hcHMtZW5hYmxlZCIsIHRydWUpLApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2V0dGluZ3NUYWJDb250ZW50Vmlldy5qcyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NldHRpbmdzVGFiQ29udGVudFZp ZXcuanMKaW5kZXggOTlhM2Q1N2Q0MjIuLjQ4NmIyOTg2ODA5IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TZXR0aW5nc1RhYkNvbnRlbnRWaWV3 LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NldHRp bmdzVGFiQ29udGVudFZpZXcuanMKQEAgLTI1MSw2ICsyNTEsNyBAQCBXSS5TZXR0aW5nc1RhYkNv bnRlbnRWaWV3ID0gY2xhc3MgU2V0dGluZ3NUYWJDb250ZW50VmlldyBleHRlbmRzIFdJLlRhYkNv bnRlbnRWaQogICAgICAgICBsZXQgc2VhcmNoR3JvdXAgPSBnZW5lcmFsU2V0dGluZ3NWaWV3LmFk ZEdyb3VwKFdJLlVJU3RyaW5nKCJTZWFyY2g6IiwgIlNlYXJjaDogQCBTZXR0aW5ncyIsICJTZXR0 aW5ncyB0YWIgbGFiZWwgZm9yIHNlYXJjaCByZWxhdGVkIHNldHRpbmdzIikpOwogICAgICAgICBz ZWFyY2hHcm91cC5hZGRTZXR0aW5nKFdJLnNldHRpbmdzLnNlYXJjaENhc2VTZW5zaXRpdmUsIFdJ LlVJU3RyaW5nKCJDYXNlIFNlbnNpdGl2ZSIsICJDYXNlIFNlbnNpdGl2ZSBAIFNldHRpbmdzIiwg IlNldHRpbmdzIHRhYiBjaGVja2JveCBsYWJlbCBmb3Igd2hldGhlciBzZWFyY2hlcyBzaG91bGQg YmUgY2FzZSBzZW5zaXRpdmUuIikpOwogICAgICAgICBzZWFyY2hHcm91cC5hZGRTZXR0aW5nKFdJ LnNldHRpbmdzLnNlYXJjaFJlZ3VsYXJFeHByZXNzaW9uLCBXSS5VSVN0cmluZygiUmVndWxhciBF eHByZXNzaW9uIiwgIlJlZ3VsYXIgRXhwcmVzc2lvbiBAIFNldHRpbmdzIiwgIlNldHRpbmdzIHRh YiBjaGVja2JveCBsYWJlbCBmb3Igd2hldGhlciBzZWFyY2hlcyBzaG91bGQgYmUgdHJlYXRlZCBh cyByZWd1bGFyIGV4cHJlc3Npb25zLiIpKTsKKyAgICAgICAgc2VhcmNoR3JvdXAuYWRkU2V0dGlu ZyhXSS5zZXR0aW5ncy5zZWFyY2hGcm9tU2VsZWN0aW9uLCBXSS5VSVN0cmluZygiJXMgZnJvbSBz ZWxlY3Rpb24iLCAiR2xvYmFsIFNlYXJjaCBGcm9tIFNlbGVjdGlvbiBAIFNldHRpbmdzIiwgIlNl dHRpbmdzIHRhYiBjaGVja2JveCBsYWJlbCBmb3Igd2hldGhlciB0aGUgZ2xvYmFsIHNlYXJjaCBz aG91bGQgcG9wdWxhdGUgZnJvbSB0aGUgY3VycmVudCBzZWxlY3Rpb24uIikuZm9ybWF0KFdJLnNl YXJjaEtleWJvYXJkU2hvcnRjdXQuZGlzcGxheU5hbWUpKTsKIAogICAgICAgICBnZW5lcmFsU2V0 dGluZ3NWaWV3LmFkZFNlcGFyYXRvcigpOwogCg==