210199 2020-04-08 10:50:22 -0700 Remove unused WebProcessPool::sendToAllProcessesRelaunchingThemIfNecessary and WebProcessPool::sendToOneProcess 2020-04-08 12:13:15 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build PC Linux RESOLVED FIXED InRadar P2 Minor --- 1 mcatanzaro mcatanzaro achristensen mcatanzaro webkit-bug-importer oldest_to_newest 1639149 0 mcatanzaro 2020-04-08 10:50:22 -0700 Sadly we have no automated way to detect dead code, and instead must wait for humans to stumble upon it. I only noticed these because WebProcessPool::sendToAllProcessesRelaunchingThemIfNecessary had a suspicious FIXME (which dates back to r129701). 1639151 1 395834 mcatanzaro 2020-04-08 10:51:22 -0700 Created attachment 395834 Patch 1639215 2 ews-feeder 2020-04-08 12:12:15 -0700 Committed r259743: <https://trac.webkit.org/changeset/259743> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395834. 1639216 3 webkit-bug-importer 2020-04-08 12:13:15 -0700 <rdar://problem/61468898> 395834 2020-04-08 10:51:22 -0700 2020-04-08 12:12:16 -0700 Patch bug-210199-20200408125122.patch text/plain 2841 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5MDgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGUzYzdhNDFlOTIzODdkNmUy MzU5NzQxZjYwM2EzZmZmMmM4ODQ3ODQuLjI0ZWE0N2E3NmI0ODIwNTRlYjBhMGM3MjZlM2NjZDVm MWUxMTBhMjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMDQtMDggIE1pY2hhZWwg Q2F0YW56YXJvICA8bWNhdGFuemFyb0Bnbm9tZS5vcmc+CisKKyAgICAgICAgUmVtb3ZlIHVudXNl ZCBXZWJQcm9jZXNzUG9vbDo6c2VuZFRvQWxsUHJvY2Vzc2VzUmVsYXVuY2hpbmdUaGVtSWZOZWNl c3NhcnkgYW5kIFdlYlByb2Nlc3NQb29sOjpzZW5kVG9PbmVQcm9jZXNzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTAxOTkKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgdW51c2VkIGZ1bmN0aW9u cy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQcm9jZXNzUG9vbC5oOgorICAgICAgICAoV2Vi S2l0OjpXZWJQcm9jZXNzUG9vbDo6c2VuZFRvQWxsUHJvY2Vzc2VzUmVsYXVuY2hpbmdUaGVtSWZO ZWNlc3NhcnkpOiBEZWxldGVkLgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzUG9vbDo6c2Vu ZFRvT25lUHJvY2Vzcyk6IERlbGV0ZWQuCisKIDIwMjAtMDMtMjYgIENocmlzIER1bWV6ICA8Y2R1 bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBSZWdyZXNzaW9uKHIyNTg5NDkpIFNhZmFyaSBzb21l dGltZXMgY3Jhc2hlcyB3aGVuIGJlY29taW5nIHRoZSBmb3JlZ3JvdW5kIGFwcGxpY2F0aW9uCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzUG9vbC5oIGIvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Bvb2wuaAppbmRleCBmYWUxODVlZDYzYWQ4 MDI2YWEyNGQ5NGE0MDZhN2ZjYjE1ODBhNzQxLi4xM2Q3NmNiNGZjODgwNWMxZDVkZmNiNWI3MWZj MTE1OTE2ZmRiZjMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9j ZXNzUG9vbC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlByb2Nlc3NQb29sLmgK QEAgLTE5Miw4ICsxOTIsNiBAQCBwdWJsaWM6CiAKICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiB2 b2lkIHNlbmRUb0FsbFByb2Nlc3Nlcyhjb25zdCBUJiBtZXNzYWdlKTsKICAgICB0ZW1wbGF0ZTx0 eXBlbmFtZSBUPiB2b2lkIHNlbmRUb0FsbFByb2Nlc3Nlc0ZvclNlc3Npb24oY29uc3QgVCYgbWVz c2FnZSwgUEFMOjpTZXNzaW9uSUQpOwotICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQ+IHZvaWQgc2Vu ZFRvQWxsUHJvY2Vzc2VzUmVsYXVuY2hpbmdUaGVtSWZOZWNlc3NhcnkoY29uc3QgVCYgbWVzc2Fn ZSk7Ci0gICAgdGVtcGxhdGU8dHlwZW5hbWUgVD4gdm9pZCBzZW5kVG9PbmVQcm9jZXNzKFQmJiBt ZXNzYWdlKTsKIAogICAgIC8vIFNlbmRzIHRoZSBtZXNzYWdlIHRvIFdlYlByb2Nlc3Mgb3IgTmV0 d29ya1Byb2Nlc3MgYXMgYXBwcm9wb3JpYXRlIGZvciBjdXJyZW50IHByb2Nlc3MgbW9kZWwuCiAg ICAgdGVtcGxhdGU8dHlwZW5hbWUgVD4gdm9pZCBzZW5kVG9OZXR3b3JraW5nUHJvY2VzcyhUJiYg bWVzc2FnZSk7CkBAIC04NDQsMzMgKzg0Miw0IEBAIHZvaWQgV2ViUHJvY2Vzc1Bvb2w6OnNlbmRU b0FsbFByb2Nlc3Nlc0ZvclNlc3Npb24oY29uc3QgVCYgbWVzc2FnZSwgUEFMOjpTZXNzaW9uCiAg ICAgfQogfQogCi10ZW1wbGF0ZTx0eXBlbmFtZSBUPgotdm9pZCBXZWJQcm9jZXNzUG9vbDo6c2Vu ZFRvQWxsUHJvY2Vzc2VzUmVsYXVuY2hpbmdUaGVtSWZOZWNlc3NhcnkoY29uc3QgVCYgbWVzc2Fn ZSkKLXsKLSAgICAvLyBGSVhNRSAoTXVsdGktV2ViUHJvY2Vzcyk6IFdlYlByb2Nlc3NQb29sIGRv ZXNuJ3QgdHJhY2sgcHJvY2Vzc2VzIHRoYXQgaGF2ZSBleGl0ZWQsIHNvIGl0IGNhbm5vdCByZWxh dW5jaCB0aGVzZS4gUGVyaGFwcyB0aGlzIGZ1bmN0aW9uYWxpdHkgd29uJ3QgYmUgbmVlZGVkIGlu IHRoaXMgbW9kZS4KLSAgICBzZW5kVG9BbGxQcm9jZXNzZXMobWVzc2FnZSk7Ci19Ci0KLXRlbXBs YXRlPHR5cGVuYW1lIFQ+Ci12b2lkIFdlYlByb2Nlc3NQb29sOjpzZW5kVG9PbmVQcm9jZXNzKFQm JiBtZXNzYWdlKQotewotICAgIGJvb2wgbWVzc2FnZVNlbnQgPSBmYWxzZTsKLSAgICBzaXplX3Qg cHJvY2Vzc0NvdW50ID0gbV9wcm9jZXNzZXMuc2l6ZSgpOwotICAgIGZvciAoc2l6ZV90IGkgPSAw OyBpIDwgcHJvY2Vzc0NvdW50OyArK2kpIHsKLSAgICAgICAgV2ViUHJvY2Vzc1Byb3h5KiBwcm9j ZXNzID0gbV9wcm9jZXNzZXNbaV0uZ2V0KCk7Ci0gICAgICAgIGlmIChwcm9jZXNzLT5jYW5TZW5k TWVzc2FnZSgpKSB7Ci0gICAgICAgICAgICBwcm9jZXNzLT5zZW5kKHN0ZDo6Zm9yd2FyZDxUPiht ZXNzYWdlKSwgMCk7Ci0gICAgICAgICAgICBtZXNzYWdlU2VudCA9IHRydWU7Ci0gICAgICAgICAg ICBicmVhazsKLSAgICAgICAgfQotICAgIH0KLQotICAgIGlmICghbWVzc2FnZVNlbnQpIHsKLSAg ICAgICAgcHJld2FybVByb2Nlc3MoKTsKLSAgICAgICAgUmVmUHRyPFdlYlByb2Nlc3NQcm94eT4g cHJvY2VzcyA9IG1fcHJvY2Vzc2VzLmxhc3QoKTsKLSAgICAgICAgaWYgKHByb2Nlc3MtPmNhblNl bmRNZXNzYWdlKCkpCi0gICAgICAgICAgICBwcm9jZXNzLT5zZW5kKHN0ZDo6Zm9yd2FyZDxUPiht ZXNzYWdlKSwgMCk7Ci0gICAgfQotfQotCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQK