210193 2020-04-08 09:53:29 -0700 [lldb-webkit] Pretty-print NSEventModifierFlags 2020-04-08 10:01:15 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dbates dbates jer.noble webkit-bug-importer oldest_to_newest 1639104 0 dbates 2020-04-08 09:53:29 -0700 Add a pretty printer for NSEventModifierFlags. 1639105 1 395823 dbates 2020-04-08 09:57:22 -0700 Created attachment 395823 Patch 1639111 2 395823 dbates 2020-04-08 10:00:23 -0700 Comment on attachment 395823 Patch Clearing flags on attachment: 395823 Committed r259721: <https://trac.webkit.org/changeset/259721> 1639112 3 dbates 2020-04-08 10:00:24 -0700 All reviewed patches have been landed. Closing bug. 1639114 4 webkit-bug-importer 2020-04-08 10:01:15 -0700 <rdar://problem/61460434> 395823 2020-04-08 09:57:22 -0700 2020-04-08 10:00:23 -0700 Patch bug-210193-20200408095721.patch text/plain 3633 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5MDcxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDM1MmYyYzk3Y2JmNTBhOTU3YTllYmNjMjY4MmMxYTVj NzQ2NWQzNi4uNzJlMzNjMTM4YjkzZTQ4MmY0YmI3NThhMGI0NDI0MTFjMDYwMWJlZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIz IEBACisyMDIwLTA0LTA4ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAg ICAgICBbbGxkYi13ZWJraXRdIFByZXR0eS1wcmludCBOU0V2ZW50TW9kaWZpZXJGbGFncworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEwMTkzCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRW51bWVyYXRpb25z IHN1Y2ggYXMgTlNFdmVudE1vZGlmaWVyRmxhZ3MgZGVzY3JpYmUgZGlzam9pbnQgc2V0cyBvZiBm bGFncy4gSW4gdGhlIGNhc2Ugb2YKKyAgICAgICAgTlNFdmVudE1vZGlmaWVyRmxhZ3MgaXQgZGVz Y3JpYmVzIGJvdGggZGV2aWNlIGluZGVwZW5kZW50IGFuZCBkZXBlbmRlbnQgZmxhZ3MuIFdoZW4g cHJldHR5CisgICAgICAgIHByaW50aW5nIHN1Y2ggdHlwZXMgb25lIG9yIG1vcmUgc2V0cyBvZiBm bGFncyBtYXkgbm90IGJlIHB1YmxpY2FsbHkgYXZhaWxhYmxlLiBTbywgYWRkCisgICAgICAgIHN1 cHBvcnQgbWFza2luZyBvZmYgc3VjaCBpbmFjY2Vzc2libGUgc2V0cyBvZiBmbGFncyBiZWZvcmUg cHJldHR5IHByaW50aW5nIHRoZSByZXN0IG9mCisgICAgICAgIHRoZSBzZXQuCisKKyAgICAgICAg KiBsbGRiL2xsZGJfd2Via2l0LnB5OgorICAgICAgICAoYWRkU3VtbWFyeUFuZFN5bnRoZXRpY0Zv cm1hdHRlcnNGb3JSYXdCaXRtYXNrVHlwZSk6CisgICAgICAgIChhZGRTdW1tYXJ5QW5kU3ludGhl dGljRm9ybWF0dGVyc0ZvclJhd0JpdG1hc2tUeXBlLkdlbmVyYXRlZFJhd0JpdG1hc2tQcm92aWRl cik6CisgICAgICAgIChfX2xsZGJfaW5pdF9tb2R1bGUpOgorICAgICAgICAoUmF3Qml0bWFza1By b3ZpZGVyQmFzZSk6CisgICAgICAgIChSYXdCaXRtYXNrUHJvdmlkZXJCYXNlLl9iaXRtYXNrKToK KwogMjAyMC0wMy0yNiAgQWFrYXNoIEphaW4gIDxhYWthc2hfamFpbkBhcHBsZS5jb20+CiAKICAg ICAgICAgW2V3c10gc3RhdHVzLWJ1YmJsZSBmb3IgdGVzdGVyIHF1ZXVlcyBzaG91bGQgcG9pbnQg dG8gdGVzdGVyIHF1ZXVlIHdoaWxlIHdhaXRpbmcgaW4gcXVldWUgKEZvbGxvdy11cCBmaXgpCmRp ZmYgLS1naXQgYS9Ub29scy9sbGRiL2xsZGJfd2Via2l0LnB5IGIvVG9vbHMvbGxkYi9sbGRiX3dl YmtpdC5weQppbmRleCBmZTYwNzRiOTVlMTlmNDAyODAwZDU3NGViOTQzMGVhMjA5NWMxMTQ0Li4x YmI3ZWUxYzYzMGIyYTQzYWE5MGIxNzU1YmVkYjk1ODk0ZmViZmM0IDEwMDY0NAotLS0gYS9Ub29s cy9sbGRiL2xsZGJfd2Via2l0LnB5CisrKyBiL1Rvb2xzL2xsZGIvbGxkYl93ZWJraXQucHkKQEAg LTM0LDkgKzM0LDEwIEBAIGltcG9ydCBzdHJpbmcKIGltcG9ydCBzdHJ1Y3QKIAogCi1kZWYgYWRk U3VtbWFyeUFuZFN5bnRoZXRpY0Zvcm1hdHRlcnNGb3JSYXdCaXRtYXNrVHlwZShkZWJ1Z2dlciwg dHlwZV9uYW1lLCBlbnVtZXJhdG9yX3ZhbHVlX3RvX25hbWVfbWFwKToKK2RlZiBhZGRTdW1tYXJ5 QW5kU3ludGhldGljRm9ybWF0dGVyc0ZvclJhd0JpdG1hc2tUeXBlKGRlYnVnZ2VyLCB0eXBlX25h bWUsIGVudW1lcmF0b3JfdmFsdWVfdG9fbmFtZV9tYXAsIGZsYWdzX21hc2s9Tm9uZSk6CiAgICAg Y2xhc3MgR2VuZXJhdGVkUmF3Qml0bWFza1Byb3ZpZGVyKFJhd0JpdG1hc2tQcm92aWRlckJhc2Up OgogICAgICAgICBFTlVNRVJBVE9SX1ZBTFVFX1RPX05BTUVfTUFQID0gZW51bWVyYXRvcl92YWx1 ZV90b19uYW1lX21hcC5jb3B5KCkKKyAgICAgICAgRkxBR1NfTUFTSyA9IGZsYWdzX21hc2sKIAog ICAgIGRlZiByYXdfYml0bWFza19zdW1tYXJ5X3Byb3ZpZGVyKHZhbG9iaiwgZGljdCk6CiAgICAg ICAgIHByb3ZpZGVyID0gR2VuZXJhdGVkUmF3Qml0bWFza1Byb3ZpZGVyKHZhbG9iaiwgZGljdCkK QEAgLTEwNCw2ICsxMDUsMTkgQEAgZGVmIF9fbGxkYl9pbml0X21vZHVsZShkZWJ1Z2dlciwgZGlj dCk6CiAgICAgICAgIDB4MDEwMDAwMDA6ICJXZWJFdmVudEZsYWdNYXNrUmlnaHRDb21tYW5kS2V5 IiwKICAgICB9KQogCisgICAgIyBBcHBLaXQKKyAgICBOU0V2ZW50TW9kaWZpZXJGbGFnRGV2aWNl SW5kZXBlbmRlbnRGbGFnc01hc2sgPSAweGZmZmYwMDAwCisgICAgYWRkU3VtbWFyeUFuZFN5bnRo ZXRpY0Zvcm1hdHRlcnNGb3JSYXdCaXRtYXNrVHlwZShkZWJ1Z2dlciwgIk5TRXZlbnRNb2RpZmll ckZsYWdzIiwgeworICAgICAgICAxIDw8IDE2OiAiTlNFdmVudE1vZGlmaWVyRmxhZ0NhcHNMb2Nr IiwKKyAgICAgICAgMSA8PCAxNzogIk5TRXZlbnRNb2RpZmllckZsYWdTaGlmdCIsCisgICAgICAg IDEgPDwgMTg6ICJOU0V2ZW50TW9kaWZpZXJGbGFnQ29udHJvbCIsCisgICAgICAgIDEgPDwgMTk6 ICJOU0V2ZW50TW9kaWZpZXJGbGFnT3B0aW9uIiwKKyAgICAgICAgMSA8PCAyMDogIk5TRXZlbnRN b2RpZmllckZsYWdDb21tYW5kIiwKKyAgICAgICAgMSA8PCAyMTogIk5TRXZlbnRNb2RpZmllckZs YWdOdW1lcmljUGFkIiwKKyAgICAgICAgMSA8PCAyMjogIk5TRXZlbnRNb2RpZmllckZsYWdIZWxw IiwKKyAgICAgICAgMSA8PCAyMzogIk5TRXZlbnRNb2RpZmllckZsYWdGdW5jdGlvbiIsCisgICAg fSwgZmxhZ3NfbWFzaz1OU0V2ZW50TW9kaWZpZXJGbGFnRGV2aWNlSW5kZXBlbmRlbnRGbGFnc01h c2spCisKIAogZGVmIFdURlN0cmluZ19TdW1tYXJ5UHJvdmlkZXIodmFsb2JqLCBkaWN0KToKICAg ICBwcm92aWRlciA9IFdURlN0cmluZ1Byb3ZpZGVyKHZhbG9iaiwgZGljdCkKQEAgLTgyMywxMiAr ODM3LDE2IEBAIGNsYXNzIFdURk9wdGlvblNldFByb3ZpZGVyKEZsYWdFbnVtZXJhdGlvblByb3Zp ZGVyKToKIAogY2xhc3MgUmF3Qml0bWFza1Byb3ZpZGVyQmFzZShGbGFnRW51bWVyYXRpb25Qcm92 aWRlcik6CiAgICAgRU5VTUVSQVRPUl9WQUxVRV9UT19OQU1FX01BUCA9IHt9CisgICAgRkxBR1Nf TUFTSyA9IE5vbmUgICMgVXNlZnVsIHdoZW4gYSBiaXRtYXNrIHJlcHJlc2VudHMgbXVsdGlwbGUg ZGlzam9pbnQgc2V0cyBvZiBmbGFncyAoZS5nLiBOU0V2ZW50TW9kaWZpZXJGbGFncykuCiAKICAg ICBkZWYgX2VudW1lcmF0b3JfdmFsdWVfdG9fbmFtZV9tYXAoc2VsZik6CiAgICAgICAgIHJldHVy biBzZWxmLkVOVU1FUkFUT1JfVkFMVUVfVE9fTkFNRV9NQVAKIAogICAgIGRlZiBfYml0bWFzayhz ZWxmKToKLSAgICAgICAgcmV0dXJuIHNlbGYudmFsb2JqLkdldFZhbHVlQXNVbnNpZ25lZCgwKQor ICAgICAgICByZXN1bHQgPSBzZWxmLnZhbG9iai5HZXRWYWx1ZUFzVW5zaWduZWQoMCkKKyAgICAg ICAgaWYgc2VsZi5GTEFHU19NQVNLIGlzIG5vdCBOb25lOgorICAgICAgICAgICAgcmVzdWx0ID0g cmVzdWx0ICYgc2VsZi5GTEFHU19NQVNLCisgICAgICAgIHJldHVybiByZXN1bHQKIAogCiBjbGFz cyBXVEZDb21wYWN0UG9pbnRlclR1cGxlUHJvdmlkZXIob2JqZWN0KToK