21019 2008-09-22 22:17:23 -0700 make FunctionBodyNode::ref/deref fast 2008-09-22 22:23:06 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 20813 1 darin darin oldest_to_newest 92282 0 darin 2008-09-22 22:17:23 -0700 Right now we call these functions a lot. Later we might fix that by changing how we do ScopeChain, but for now this can be sped up just by making them standard ref/deref functions instead of ParserRefCounted. 92283 1 23694 darin 2008-09-22 22:18:58 -0700 Created attachment 23694 patch 92284 2 darin 2008-09-22 22:23:06 -0700 http://trac.webkit.org/changeset/36794 23694 2008-09-22 22:18:58 -0700 2008-09-22 22:21:14 -0700 patch FuncRefDerefPatch.txt text/plain 2693 darin SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDM2NzkzKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMDgtMDktMjIgIERhcmluIEFk bGVyICA8ZGFyaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIC0gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIxMDE5CisgICAgICAgICAgbWFrZSBGdW5jdGlvbkJvZHlOb2RlOjpyZWYvZGVyZWYgZmFzdAor CisgICAgICAgIFNwZWVkcyB1cCB2OC1yYXl0cmFjZSBieSA3LjIlLgorCisgICAgICAgICoga2pz L25vZGVzLmNwcDoKKyAgICAgICAgKEpTQzo6RnVuY3Rpb25Cb2R5Tm9kZTo6RnVuY3Rpb25Cb2R5 Tm9kZSk6IEluaXRpYWxpemUgbV9yZWZDb3VudCB0byAwLgorICAgICAgICAqIGtqcy9ub2Rlcy5o OgorICAgICAgICAoSlNDOjpGdW5jdGlvbkJvZHlOb2RlOjpyZWYpOiBDYWxsIGJhc2UgY2xhc3Mg cmVmIG9uY2UsIGFuZCB0aGVyZWFmdGVyIHVzZQorICAgICAgICBtX3JlZkNvdW50LgorICAgICAg ICAoSlNDOjpGdW5jdGlvbkJvZHlOb2RlOjpkZXJlZik6IERpdHRvLCBidXQgdGhlIGRlcmVmIHNp ZGUuCisKIDIwMDgtMDktMjIgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAg ICAgIFBvaW50ZWQgb3V0IGJ5IFNhbSBXZWluaWcuCkluZGV4OiBKYXZhU2NyaXB0Q29yZS9ranMv bm9kZXMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL2tqcy9ub2Rlcy5jcHAJKHJl dmlzaW9uIDM2Nzg4KQorKysgSmF2YVNjcmlwdENvcmUva2pzL25vZGVzLmNwcAkod29ya2luZyBj b3B5KQpAQCAtMTc4Miw2ICsxNzgyLDcgQEAgRXZhbE5vZGUqIEV2YWxOb2RlOjpjcmVhdGUoSlNH bG9iYWxEYXRhKgogCiBGdW5jdGlvbkJvZHlOb2RlOjpGdW5jdGlvbkJvZHlOb2RlKEpTR2xvYmFs RGF0YSogZ2xvYmFsRGF0YSwgU291cmNlRWxlbWVudHMqIGNoaWxkcmVuLCBWYXJTdGFjayogdmFy U3RhY2ssIEZ1bmN0aW9uU3RhY2sqIGZ1bmNTdGFjaywgYm9vbCB1c2VzRXZhbCwgYm9vbCBuZWVk c0Nsb3N1cmUsIGludCBudW1Db25zdGFudHMpCiAgICAgOiBTY29wZU5vZGUoZ2xvYmFsRGF0YSwg Y2hpbGRyZW4sIHZhclN0YWNrLCBmdW5jU3RhY2ssIHVzZXNFdmFsLCBuZWVkc0Nsb3N1cmUsIG51 bUNvbnN0YW50cykKKyAgICAsIG1fcmVmQ291bnQoMCkKIHsKIH0KIApJbmRleDogSmF2YVNjcmlw dENvcmUva2pzL25vZGVzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUva2pzL25vZGVz LmgJKHJldmlzaW9uIDM2Nzg4KQorKysgSmF2YVNjcmlwdENvcmUva2pzL25vZGVzLmgJKHdvcmtp bmcgY29weSkKQEAgLTIyNjksNiArMjI2OSwyMSBAQCBuYW1lc3BhY2UgSlNDIHsKIAogICAgICAg ICB2b2lkIHNldFNvdXJjZShjb25zdCBTb3VyY2VSYW5nZSYgc291cmNlKSB7IG1fc291cmNlID0g c291cmNlOyB9IAogICAgICAgICBVU3RyaW5nIHRvU291cmNlU3RyaW5nKCkgY29uc3QgSlNDX0ZB U1RfQ0FMTCB7IHJldHVybiBVU3RyaW5nKCJ7IikgKyBtX3NvdXJjZS50b1N0cmluZygpICsgVVN0 cmluZygifSIpOyB9CisKKyAgICAgICAgLy8gVGhlc2Ugb2JqZWN0cyBhcmUgcmVmL2RlcmVmJ2Qg YSBsb3QgaW4gdGhlIHNjb3BlIGNoYWluLCBzbyB0aGlzIGlzIGEgZmFzdGVyIHJlZi9kZXJlZi4K KyAgICAgICAgLy8gSWYgdGhlIHZpcnR1YWwgbWFjaGluZSBjaGFuZ2VzIHNvIHRoaXMgZG9lc24n dCBoYXBwZW4gYXMgbXVjaCB3ZSBjYW4gY2hhbmdlIGJhY2suCisgICAgICAgIHZvaWQgcmVmKCkK KyAgICAgICAgeworICAgICAgICAgICAgaWYgKCsrbV9yZWZDb3VudCA9PSAxKQorICAgICAgICAg ICAgICAgIFNjb3BlTm9kZTo6cmVmKCk7CisgICAgICAgIH0KKyAgICAgICAgdm9pZCBkZXJlZigp CisgICAgICAgIHsKKyAgICAgICAgICAgIEFTU0VSVChtX3JlZkNvdW50KTsKKyAgICAgICAgICAg IGlmICghLS1tX3JlZkNvdW50KQorICAgICAgICAgICAgICAgIFNjb3BlTm9kZTo6ZGVyZWYoKTsK KyAgICAgICAgfQorCiAgICAgcHJvdGVjdGVkOgogICAgICAgICBGdW5jdGlvbkJvZHlOb2RlKEpT R2xvYmFsRGF0YSosIFNvdXJjZUVsZW1lbnRzKiwgVmFyU3RhY2sqLCBGdW5jdGlvblN0YWNrKiwg Ym9vbCB1c2VzRXZhbCwgYm9vbCBuZWVkc0Nsb3N1cmUsIGludCBudW1Db25zdGFudHMpIEpTQ19G QVNUX0NBTEw7CiAKQEAgLTIyNzksNiArMjI5NCw3IEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAg ICBTeW1ib2xUYWJsZSBtX3N5bWJvbFRhYmxlOwogICAgICAgICBPd25QdHI8Q29kZUJsb2NrPiBt X2NvZGU7CiAgICAgICAgIFNvdXJjZVJhbmdlIG1fc291cmNlOworICAgICAgICB1bnNpZ25lZCBt X3JlZkNvdW50OwogICAgIH07CiAKICAgICBjbGFzcyBGdW5jRXhwck5vZGUgOiBwdWJsaWMgRXhw cmVzc2lvbk5vZGUgewo=