210169 2020-04-07 18:51:01 -0700 fastclick.com: A Gradient banner is missing 2020-04-07 20:36:12 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham esprehn+autocc ews-watchlist glenn kondapallykalyan pdr simon.fraser zalan oldest_to_newest 1638911 0 zalan 2020-04-07 18:51:01 -0700 <rdar://problem/60680979> 1638914 1 395765 zalan 2020-04-07 19:26:18 -0700 Created attachment 395765 Patch 1638925 2 ews-feeder 2020-04-07 20:36:11 -0700 Committed r259701: <https://trac.webkit.org/changeset/259701> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395765. 395765 2020-04-07 19:26:18 -0700 2020-04-07 20:36:11 -0700 Patch bug-210169-20200407192617.patch text/plain 6326 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5NjExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjliMDE1MmE5OWEwOWI1 OTZmYzRiNzBhZDI4OTVhZGEyMTZmNGZjMS4uMWFlNjE2OGRkNzRkNGEzYzExN2M4MjRhNmIwZTBi NWJmNjNjY2IyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTA0LTA3ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgZmFzdGNsaWNrLmNvbTogQSBH cmFkaWVudCBiYW5uZXIgaXMgbWlzc2luZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjEwMTY5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82MDY4MDk3 OT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlz IHBhdGNoIGVuc3VyZXMgdGhhdCBpZiB0aGUgbm9uLWZpeGVkIHNwZWNpZmllZCBzaXplIGZvciB0 aGUgYmFja2dyb3VuZCBjb250ZW50IGNvbXB1dGVzIHRvIGJlIGEgY2xvc2UtdG8temVybyB2YWx1 ZSwgd2UgcHJvZHVjZSBhdCBsZWFzdCBvbmUgZGV2aWNlIHBpeGVsIHNpemUgY29udGVudC4KKyAg ICAgICAgKGFuZCB0aGlzIGlzIHNpbWlsYXIgdG8gd2hhdCB3ZSBkbyBmb3IgRmlsbFNpemVUeXBl OjpDb250YWluL0NvdmVyLikKKworICAgICAgICBUZXN0OiBmYXN0L2JhY2tncm91bmRzL2dlbmVy YXRlZC1iY2staW1hZ2Utd2l0aC1zbWFsbC1yZWxhdGl2ZS1zaXplLmh0bWwKKworICAgICAgICAq IHJlbmRlcmluZy9SZW5kZXJCb3hNb2RlbE9iamVjdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpS ZW5kZXJCb3hNb2RlbE9iamVjdDo6Y2FsY3VsYXRlRmlsbFRpbGVTaXplIGNvbnN0KToKKwogMjAy MC0wNC0wNiAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIERlbGV0 ZSBsaW5lIGJveGVzIHdoZW4gbW92aW5nIHRleHQgcmVuZGVyZXJzIGJldHdlZW4gYmxvY2sgZmxv d3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3hNb2RlbE9i amVjdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94TW9kZWxPYmplY3Qu Y3BwCmluZGV4IDMxZWZhNWE0MDVhOGY1MGQ4YjlmODhhZjQzZjQ2MzBiODJiMmYwZmEuLmI5Zjli NGFjNjlmOTVjNzk4YjA3ZTdmNTcxZTkxOTIzZDhkYjU1YjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3hNb2RlbE9iamVjdC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveE1vZGVsT2JqZWN0LmNwcApAQCAtMTA2OSw2ICsxMDY5 LDcgQEAgTGF5b3V0U2l6ZSBSZW5kZXJCb3hNb2RlbE9iamVjdDo6Y2FsY3VsYXRlRmlsbFRpbGVT aXplKGNvbnN0IEZpbGxMYXllciYgZmlsbExheWUKIHsKICAgICBTdHlsZUltYWdlKiBpbWFnZSA9 IGZpbGxMYXllci5pbWFnZSgpOwogICAgIEZpbGxTaXplVHlwZSB0eXBlID0gZmlsbExheWVyLnNp emUoKS50eXBlOworICAgIGF1dG8gZGV2aWNlUGl4ZWxTaXplID0gTGF5b3V0VW5pdCB7IDEuMCAv IGRvY3VtZW50KCkuZGV2aWNlU2NhbGVGYWN0b3IoKSB9OwogCiAgICAgTGF5b3V0U2l6ZSBpbWFn ZUludHJpbnNpY1NpemU7CiAgICAgaWYgKGltYWdlKSB7CkBAIC0xMDg2LDEzICsxMDg3LDE5IEBA IExheW91dFNpemUgUmVuZGVyQm94TW9kZWxPYmplY3Q6OmNhbGN1bGF0ZUZpbGxUaWxlU2l6ZShj b25zdCBGaWxsTGF5ZXImIGZpbGxMYXllCiAKICAgICAgICAgaWYgKGxheWVyV2lkdGguaXNGaXhl ZCgpKQogICAgICAgICAgICAgdGlsZVNpemUuc2V0V2lkdGgobGF5ZXJXaWR0aC52YWx1ZSgpKTsK LSAgICAgICAgZWxzZSBpZiAobGF5ZXJXaWR0aC5pc1BlcmNlbnRPckNhbGN1bGF0ZWQoKSkKLSAg ICAgICAgICAgIHRpbGVTaXplLnNldFdpZHRoKHZhbHVlRm9yTGVuZ3RoKGxheWVyV2lkdGgsIHBv c2l0aW9uaW5nQXJlYVNpemUud2lkdGgoKSkpOworICAgICAgICBlbHNlIGlmIChsYXllcldpZHRo LmlzUGVyY2VudE9yQ2FsY3VsYXRlZCgpKSB7CisgICAgICAgICAgICBhdXRvIHJlc29sdmVkV2lk dGggPSB2YWx1ZUZvckxlbmd0aChsYXllcldpZHRoLCBwb3NpdGlvbmluZ0FyZWFTaXplLndpZHRo KCkpOworICAgICAgICAgICAgLy8gTm9uLXplcm8gcmVzb2x2ZWQgdmFsdWUgc2hvdWxkIGFsd2F5 cyBwcm9kdWNlIHNvbWUgY29udGVudC4KKyAgICAgICAgICAgIHRpbGVTaXplLnNldFdpZHRoKCFy ZXNvbHZlZFdpZHRoID8gcmVzb2x2ZWRXaWR0aCA6IHN0ZDo6bWF4KGRldmljZVBpeGVsU2l6ZSwg cmVzb2x2ZWRXaWR0aCkpOworICAgICAgICB9CiAgICAgICAgIAogICAgICAgICBpZiAobGF5ZXJI ZWlnaHQuaXNGaXhlZCgpKQogICAgICAgICAgICAgdGlsZVNpemUuc2V0SGVpZ2h0KGxheWVySGVp Z2h0LnZhbHVlKCkpOwotICAgICAgICBlbHNlIGlmIChsYXllckhlaWdodC5pc1BlcmNlbnRPckNh bGN1bGF0ZWQoKSkKLSAgICAgICAgICAgIHRpbGVTaXplLnNldEhlaWdodCh2YWx1ZUZvckxlbmd0 aChsYXllckhlaWdodCwgcG9zaXRpb25pbmdBcmVhU2l6ZS5oZWlnaHQoKSkpOworICAgICAgICBl bHNlIGlmIChsYXllckhlaWdodC5pc1BlcmNlbnRPckNhbGN1bGF0ZWQoKSkgeworICAgICAgICAg ICAgYXV0byByZXNvbHZlZEhlaWdodCA9IHZhbHVlRm9yTGVuZ3RoKGxheWVySGVpZ2h0LCBwb3Np dGlvbmluZ0FyZWFTaXplLmhlaWdodCgpKTsKKyAgICAgICAgICAgIC8vIE5vbi16ZXJvIHJlc29s dmVkIHZhbHVlIHNob3VsZCBhbHdheXMgcHJvZHVjZSBzb21lIGNvbnRlbnQuCisgICAgICAgICAg ICB0aWxlU2l6ZS5zZXRIZWlnaHQoIXJlc29sdmVkSGVpZ2h0ID8gcmVzb2x2ZWRIZWlnaHQgOiBz dGQ6Om1heChkZXZpY2VQaXhlbFNpemUsIHJlc29sdmVkSGVpZ2h0KSk7CisgICAgICAgIH0KIAog ICAgICAgICAvLyBJZiBvbmUgb2YgdGhlIHZhbHVlcyBpcyBhdXRvIHdlIGhhdmUgdG8gdXNlIHRo ZSBhcHByb3ByaWF0ZQogICAgICAgICAvLyBzY2FsZSB0byBtYWludGFpbiBvdXIgYXNwZWN0IHJh dGlvLgpAQCAtMTEyOCwxMiArMTEzNSwxMSBAQCBMYXlvdXRTaXplIFJlbmRlckJveE1vZGVsT2Jq ZWN0OjpjYWxjdWxhdGVGaWxsVGlsZVNpemUoY29uc3QgRmlsbExheWVyJiBmaWxsTGF5ZQogICAg ICAgICBmbG9hdCBob3Jpem9udGFsU2NhbGVGYWN0b3IgPSBsb2NhbEltYWdlSW50cmluc2ljU2l6 ZS53aWR0aCgpID8gKGxvY2FsUG9zaXRpb25pbmdBcmVhU2l6ZS53aWR0aCgpIC8gbG9jYWxJbWFn ZUludHJpbnNpY1NpemUud2lkdGgoKSkgOiAxOwogICAgICAgICBmbG9hdCB2ZXJ0aWNhbFNjYWxl RmFjdG9yID0gbG9jYWxJbWFnZUludHJpbnNpY1NpemUuaGVpZ2h0KCkgPyAobG9jYWxQb3NpdGlv bmluZ0FyZWFTaXplLmhlaWdodCgpIC8gbG9jYWxJbWFnZUludHJpbnNpY1NpemUuaGVpZ2h0KCkp IDogMTsKICAgICAgICAgZmxvYXQgc2NhbGVGYWN0b3IgPSB0eXBlID09IEZpbGxTaXplVHlwZTo6 Q29udGFpbiA/IHN0ZDo6bWluKGhvcml6b250YWxTY2FsZUZhY3RvciwgdmVydGljYWxTY2FsZUZh Y3RvcikgOiBzdGQ6Om1heChob3Jpem9udGFsU2NhbGVGYWN0b3IsIHZlcnRpY2FsU2NhbGVGYWN0 b3IpOwotICAgICAgICBmbG9hdCBzaW5nbGVTY2FsZWRQaXhlbCA9IDEuMCAvIGRvY3VtZW50KCku ZGV2aWNlU2NhbGVGYWN0b3IoKTsKICAgICAgICAgCiAgICAgICAgIGlmIChsb2NhbEltYWdlSW50 cmluc2ljU2l6ZS5pc0VtcHR5KCkpCiAgICAgICAgICAgICByZXR1cm4geyB9OwogICAgICAgICAK LSAgICAgICAgcmV0dXJuIExheW91dFNpemUobG9jYWxJbWFnZUludHJpbnNpY1NpemUuc2NhbGVk KHNjYWxlRmFjdG9yKS5leHBhbmRlZFRvKHsgc2luZ2xlU2NhbGVkUGl4ZWwsIHNpbmdsZVNjYWxl ZFBpeGVsIH0pKTsKKyAgICAgICAgcmV0dXJuIExheW91dFNpemUobG9jYWxJbWFnZUludHJpbnNp Y1NpemUuc2NhbGVkKHNjYWxlRmFjdG9yKS5leHBhbmRlZFRvKHsgZGV2aWNlUGl4ZWxTaXplLCBk ZXZpY2VQaXhlbFNpemUgfSkpOwogICAgIH0KICAgICB9CiAKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAxODIwODllODIwYzU2 ZTdlNzMxNWFmNWVlMmJkN2ExZTY3MmNmYWFhLi43ZGE4NTQ2MDNkZTYxNGIwYTk5YTE3OTZiOTA4 MGJlODI1ZGI5MTJiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjAtMDQtMDcgIFphbGFuIEJ1 anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBmYXN0Y2xpY2suY29tOiBBIEdyYWRp ZW50IGJhbm5lciBpcyBtaXNzaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMTAxNjkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzYwNjgwOTc5Pgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC9i YWNrZ3JvdW5kcy9nZW5lcmF0ZWQtYmNrLWltYWdlLXdpdGgtc21hbGwtcmVsYXRpdmUtc2l6ZS1l eHBlY3RlZC5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2JhY2tncm91bmRzL2dlbmVyYXRl ZC1iY2staW1hZ2Utd2l0aC1zbWFsbC1yZWxhdGl2ZS1zaXplLmh0bWw6IEFkZGVkLgorCiAyMDIw LTA0LTA2ICBKYXNvbiBMYXdyZW5jZSAgPGxhd3JlbmNlLmpAYXBwbGUuY29tPgogCiAgICAgICAg IHN0b3JhZ2UvaW5kZXhlZGRiL3ZhbHVlLWN1cnNvci1jeWNsZS5odG1sIGlzIGZsYWt5IGZhaWxp bmcgYmVjYXVzZSBpdCBpbmNvcnJlY3RseSB0aGlua3Mgb3VyIEpTIEdDIGlzIHByZWNpc2UuCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2JhY2tncm91bmRzL2dlbmVyYXRlZC1iY2staW1h Z2Utd2l0aC1zbWFsbC1yZWxhdGl2ZS1zaXplLWV4cGVjdGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9m YXN0L2JhY2tncm91bmRzL2dlbmVyYXRlZC1iY2staW1hZ2Utd2l0aC1zbWFsbC1yZWxhdGl2ZS1z aXplLWV4cGVjdGVkLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZDAzNzNmNTczMTM5YmQ5OWU3YzdiMzQyZDA5 MTg1MjNhZGU2MzBlNAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvYmFja2dy b3VuZHMvZ2VuZXJhdGVkLWJjay1pbWFnZS13aXRoLXNtYWxsLXJlbGF0aXZlLXNpemUtZXhwZWN0 ZWQuaHRtbApAQCAtMCwwICsxLDggQEAKKzxzdHlsZT4KK2RpdiB7CisgICAgYmFja2dyb3VuZC1j b2xvcjogZ3JlZW47Cit9Cis8L3N0eWxlPgorVGhpcyB0ZXN0cyB0aGF0IGdlbmVyYXRlZCBiYWNr Z3JvdW5kIGltYWdlcyB3aXRoIHJlbGF0aXZlbHkgc21hbGwgc2l6ZSBzaG93IHVwLgorPGRpdiBz dHlsZT0iaGVpZ2h0OiAxMHB4OyB3aWR0aDogMTAwcHg7Ij48L2Rpdj4KKzxkaXYgc3R5bGU9Imhl aWdodDogMTAwcHg7IHdpZHRoOiAxMHB4OyI+PC9kaXY+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9mYXN0L2JhY2tncm91bmRzL2dlbmVyYXRlZC1iY2staW1hZ2Utd2l0aC1zbWFsbC1yZWxhdGl2 ZS1zaXplLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2JhY2tncm91bmRzL2dlbmVyYXRlZC1iY2st aW1hZ2Utd2l0aC1zbWFsbC1yZWxhdGl2ZS1zaXplLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQK aW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNGZmYTZhNDRi NWQzYTAzNGM1MTlmMTZjNGU5YmU4YmQyNzMxMWFhZAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91 dFRlc3RzL2Zhc3QvYmFja2dyb3VuZHMvZ2VuZXJhdGVkLWJjay1pbWFnZS13aXRoLXNtYWxsLXJl bGF0aXZlLXNpemUuaHRtbApAQCAtMCwwICsxLDggQEAKKzxzdHlsZT4KK2RpdiB7CisgICAgYmFj a2dyb3VuZDogbGluZWFyLWdyYWRpZW50KGdyZWVuLCBncmVlbik7Cit9Cis8L3N0eWxlPgorVGhp cyB0ZXN0cyB0aGF0IGdlbmVyYXRlZCBiYWNrZ3JvdW5kIGltYWdlcyB3aXRoIHJlbGF0aXZlbHkg c21hbGwgc2l6ZSBzaG93IHVwLgorPGRpdiBzdHlsZT0iaGVpZ2h0OiAxMHB4OyB3aWR0aDogMTAw cHg7IGJhY2tncm91bmQtc2l6ZTogMTAwJSAxJTsiPjwvZGl2PgorPGRpdiBzdHlsZT0iaGVpZ2h0 OiAxMDBweDsgd2lkdGg6IDEwcHg7IGJhY2tncm91bmQtc2l6ZTogMSUgMTAwJTsiPjwvZGl2Pgo=