210163 2020-04-07 15:29:41 -0700 [JSC] Collect-continuously thread should take m_collectContinuouslyLock while it is waking up concurrent collector thread 2020-04-07 16:25:00 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1638845 0 ysuzuki 2020-04-07 15:29:41 -0700 [JSC] Collect-continuously thread should take m_collectContinuouslyLock while it is waking up concurrent collector thread 1638858 1 395753 ysuzuki 2020-04-07 15:45:53 -0700 Created attachment 395753 Patch 1638860 2 ysuzuki 2020-04-07 15:46:28 -0700 <rdar://problem/61392945> 1638864 3 395753 saam 2020-04-07 15:52:04 -0700 Comment on attachment 395753 Patch r=me 1638866 4 395753 ysuzuki 2020-04-07 16:09:18 -0700 Comment on attachment 395753 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395753&action=review > Source/JavaScriptCore/heap/Heap.cpp:2902 > while (!m_shouldStopCollectingContinuously) { I'll put this condition under the lock of m_collectContinuouslyLock 1638876 5 ysuzuki 2020-04-07 16:25:00 -0700 Committed r259683: <https://trac.webkit.org/changeset/259683> 395753 2020-04-07 15:45:53 -0700 2020-04-07 15:52:04 -0700 Patch bug-210163-20200407154552.patch text/plain 6266 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5NjQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 MzMzMmM3ZWEzZTM3YjI5MDk3MmZjOTQ2OTM3NDEyMjk2Mjc0MWUwLi5lMGIyYTgyMDVlNGZlYTA5 YTg0ODQyNjA1NTU0NWFmMjY5MjM0MTc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSw0OCBAQAorMjAyMC0wNC0wNyAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIENvbGxlY3QtY29udGludW91c2x5IHRocmVhZCBzaG91bGQgdGFr ZSBtX2NvbGxlY3RDb250aW51b3VzbHlMb2NrIHdoaWxlIGl0IGlzIHdha2luZyB1cCBjb25jdXJy ZW50IGNvbGxlY3RvciB0aHJlYWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIxMDE2MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIENvbGxlY3QtQ29udGludW91c2x5IHRocmVhZCBoYXMgZmFuY3kgcmFjZSBp c3N1ZS4KKworICAgICAgICBJbiBIZWFwOjpwcmV2ZW50Q29sbGVjdGlvbiwgd2UgZmlyc3QgdGFr ZSBtX2NvbGxlY3RDb250aW51b3VzbHlMb2NrIHRvIGVuc3VyZSBjb2xsZWN0LWNvbnRpbnVvdXNs eSB0aHJlYWQgaXMgbm90IHdvcmtpbmcsIGFuZCB0aGVuCisgICAgICAgIHdlIGVuc3VyZSBjb2xs ZWN0b3IgdGhyZWFkIGlzIHN0b3BwZWQgYnkgdXNpbmcgd2FpdEZvckNvbGxlY3Rvci4gSG93ZXZl ciBvdXIgY29sbGVjdC1jb250aW51b3VzbHkgdGhyZWFkIGlzIGltcGxlbWVudGVkIGxpa2UgdGhp cy4KKworICAgICAgICAgICAgICAgIHdoaWxlICghbV9zaG91bGRTdG9wQ29sbGVjdGluZ0NvbnRp bnVvdXNseSkgeworICAgICAgICAgICAgICAgICAgICB7IC8vIChBKQorICAgICAgICAgICAgICAg ICAgICAgICAgTG9ja0hvbGRlciBsb2NrZXIoKm1fdGhyZWFkTG9jayk7CisgICAgICAgICAgICAg ICAgICAgICAgICBpZiAobV9yZXF1ZXN0cy5pc0VtcHR5KCkpIHsKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICBtX3JlcXVlc3RzLmFwcGVuZChXVEY6Om51bGxvcHQpOworICAgICAgICAgICAg ICAgICAgICAgICAgICAgIG1fbGFzdEdyYW50ZWRUaWNrZXQrKzsKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICBtX3RocmVhZENvbmRpdGlvbi0+bm90aWZ5T25lKGxvY2tlcik7ICAvLyAoQikg V0FLSU5HIFVQIGNvbmN1cnJlbnQgY29sbGVjdG9yIHRocmVhZC4KKyAgICAgICAgICAgICAgICAg ICAgICAgIH0KKyAgICAgICAgICAgICAgICAgICAgfQorCisgICAgICAgICAgICAgICAgICAgIHsK KyAgICAgICAgICAgICAgICAgICAgICAgIExvY2tIb2xkZXIgbG9ja2VyKG1fY29sbGVjdENvbnRp bnVvdXNseUxvY2spOworICAgICAgICAgICAgICAgICAgICAgICAgLi4uCisgICAgICAgICAgICAg ICAgICAgICAgICB3aGlsZSAoIWhhc0VsYXBzZWQodGltZVRvV2FrZVVwKSAmJiAhbV9zaG91bGRT dG9wQ29sbGVjdGluZ0NvbnRpbnVvdXNseSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICBt X2NvbGxlY3RDb250aW51b3VzbHlDb25kaXRpb24ud2FpdFVudGlsKG1fY29sbGVjdENvbnRpbnVv dXNseUxvY2ssIHRpbWVUb1dha2VVcCk7CisgICAgICAgICAgICAgICAgICAgIH0KKyAgICAgICAg ICAgICAgICB9CisKKyAgICAgICAgRXZlbiBpZiBtX2NvbGxlY3RDb250aW51b3VzbHlMb2NrIGlz IHRha2VuLCBjb2xsZWN0LWNvbnRpbnVvdXNseSB0aHJlYWQgaXMgc3RpbGwgYWJsZSB0byB3YWtl IHVwIGNvbmN1cnJlbnQgY29sbGVjdG9yIHRocmVhZAorICAgICAgICBzaW5jZSAoQikncyBjb2Rl IGlzIG5vdCBndWFyZGVkIGJ5IG1fY29sbGVjdENvbnRpbnVvdXNseUxvY2suIFRoZSBmb2xsb3dp bmcgc2VxdWVuY2UgY2FuIGhhcHBlbiwKKworICAgICAgICAgICAgMS4gVGhlIG1haW4gdGhyZWFk IGNhbGxzIEhlYXA6OnByZXZlbnRDb2xsZWN0aW9uIHRvIGVuc3VyZSBhbGwgY29sbGVjdGlvbiBp cyBzdG9wcGVkLgorICAgICAgICAgICAgMi4gVGhlIGNvbGxlY3QtY29udGludW91c2x5IHRocmVh ZCBpcyBhdCAoQSkgcG9pbnQuCisgICAgICAgICAgICAzLiBUaGUgbWFpbiB0aHJlYWQgdGFrZXMg bV9jb2xsZWN0Q29udGludW91c2x5TG9jay4gVGhpcyBpcyBPSy4KKyAgICAgICAgICAgIDQuIFRo ZSBtYWluIHRocmVhZCBjYWxscyB3YWl0Rm9yQ29sbGVjdG9yIHRvIGVuc3VyZSB0aGF0IGNvbmN1 cnJlbnQgY29sbGVjdG9yIHRocmVhZCBpcyBzdG9wcGVkLgorICAgICAgICAgICAgNS4gVGhlIGNv bGxlY3QtY29udGludW91c2x5IHRocmVhZCBleGVjdXRlcyAoQikuIEl0IGlzIGFsbG93ZWQgc2lu Y2UgdGhpcyBpcyBub3QgZ3VhcmRlZCBieSBtX2NvbGxlY3RDb250aW51b3VzbHlMb2NrLiBTbywg Y29uY3VycmVudCBjb2xsZWN0b3Igc3RhcnRzIHdvcmtpbmcuCisgICAgICAgICAgICA2LiBXaGls ZSB0aGUgbWFpbiB0aHJlYWQgY2FsbGVkIEhlYXA6OnByZXZlbnRDb2xsZWN0aW9uLCBjb25jdXJy ZW50IGNvbGxlY3RvciBzdGFydHMgY29sbGVjdGlvbiEKKworICAgICAgICBXZSBzaG91bGQgZ3Vh cmQgKEEpJ3MgYmxvY2sgd2l0aCBtX2NvbGxlY3RDb250aW51b3VzbHlMb2NrIHRvby4KKworICAg ICAgICAqIGhlYXAvSGVhcC5jcHA6CisgICAgICAgIChKU0M6OkhlYXA6Om5vdGlmeUlzU2FmZVRv Q29sbGVjdCk6CisKIDIwMjAtMDQtMDcgIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNv bT4KIAogICAgICAgICBbSlNDXSBTY29wZWRBcmd1bWVudHNUYWJsZSBzaG91bGQgaGFuZGxlIE9P TSBpbiB0b2xlcmFudCBtYW5uZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9o ZWFwL0hlYXAuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5jcHAKaW5kZXgg NmM1ODE0OGMxZWUyNjQyYmNhMjZkN2EyZjA3NmEwMGE3NDk3YTFhMi4uZmNjNjk3NmZiYjFkZTFl N2I1NTE5ZWZmYzg3ZmNlOTBhMjU0OTVjOCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRD b3JlL2hlYXAvSGVhcC5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5j cHAKQEAgLTI5MDAsNiArMjkwMCw3IEBAIHZvaWQgSGVhcDo6bm90aWZ5SXNTYWZlVG9Db2xsZWN0 KCkKICAgICAgICAgICAgICAgICBNb25vdG9uaWNUaW1lIGluaXRpYWxUaW1lID0gTW9ub3Rvbmlj VGltZTo6bm93KCk7CiAgICAgICAgICAgICAgICAgU2Vjb25kcyBwZXJpb2QgPSBTZWNvbmRzOjpm cm9tTWlsbGlzZWNvbmRzKE9wdGlvbnM6OmNvbGxlY3RDb250aW51b3VzbHlQZXJpb2RNUygpKTsK ICAgICAgICAgICAgICAgICB3aGlsZSAoIW1fc2hvdWxkU3RvcENvbGxlY3RpbmdDb250aW51b3Vz bHkpIHsKKyAgICAgICAgICAgICAgICAgICAgTG9ja0hvbGRlciBsb2NrZXIobV9jb2xsZWN0Q29u dGludW91c2x5TG9jayk7CiAgICAgICAgICAgICAgICAgICAgIHsKICAgICAgICAgICAgICAgICAg ICAgICAgIExvY2tIb2xkZXIgbG9ja2VyKCptX3RocmVhZExvY2spOwogICAgICAgICAgICAgICAg ICAgICAgICAgaWYgKG1fcmVxdWVzdHMuaXNFbXB0eSgpKSB7CkBAIC0yOTEwLDcgKzI5MTEsNiBA QCB2b2lkIEhlYXA6Om5vdGlmeUlzU2FmZVRvQ29sbGVjdCgpCiAgICAgICAgICAgICAgICAgICAg IH0KICAgICAgICAgICAgICAgICAgICAgCiAgICAgICAgICAgICAgICAgICAgIHsKLSAgICAgICAg ICAgICAgICAgICAgICAgIExvY2tIb2xkZXIgbG9ja2VyKG1fY29sbGVjdENvbnRpbnVvdXNseUxv Y2spOwogICAgICAgICAgICAgICAgICAgICAgICAgU2Vjb25kcyBlbGFwc2VkID0gTW9ub3Rvbmlj VGltZTo6bm93KCkgLSBpbml0aWFsVGltZTsKICAgICAgICAgICAgICAgICAgICAgICAgIFNlY29u ZHMgZWxhcHNlZEluUGVyaW9kID0gZWxhcHNlZCAlIHBlcmlvZDsKICAgICAgICAgICAgICAgICAg ICAgICAgIE1vbm90b25pY1RpbWUgdGltZVRvV2FrZVVwID0KZGlmZiAtLWdpdCBhL0pTVGVzdHMv Q2hhbmdlTG9nIGIvSlNUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNTMwZWNmNmQ4OTk4M2UxZjBkOWZh YzM1OWE5NzA0YWRkY2ZjMDNmYi4uY2Y5MjI0NGFlNTU5MzM4OTgwMWZmYjhjM2VjNGRjNDE1NjBj ODRkNCAxMDA2NDQKLS0tIGEvSlNUZXN0cy9DaGFuZ2VMb2cKKysrIGIvSlNUZXN0cy9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxMyBAQAorMjAyMC0wNC0wNyAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lA YXBwbGUuY29tPgorCisgICAgICAgIFtKU0NdIENvbGxlY3QtY29udGludW91c2x5IHRocmVhZCBz aG91bGQgdGFrZSBtX2NvbGxlY3RDb250aW51b3VzbHlMb2NrIHdoaWxlIGl0IGlzIHdha2luZyB1 cCBjb25jdXJyZW50IGNvbGxlY3RvciB0aHJlYWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMDE2MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogc3RyZXNzL2NvbGxlY3QtY29udGludW91c2x5LXNob3Vs ZC1ub3Qtd2FrZS1jb25jdXJyZW50LWNvbGxlY3Rvci1hZnRlci1wcmV2ZW50LWNvbGxlY3Rpb24t aXMtY2FsbGVkLmpzOiBBZGRlZC4KKyAgICAgICAgKGxldC50aGVDb2RlKToKKwogMjAyMC0wNC0w NyAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAgICAgIFtKU0NdIFNj b3BlZEFyZ3VtZW50c1RhYmxlIHNob3VsZCBoYW5kbGUgT09NIGluIHRvbGVyYW50IG1hbm5lcgpk aWZmIC0tZ2l0IGEvSlNUZXN0cy9zdHJlc3MvY29sbGVjdC1jb250aW51b3VzbHktc2hvdWxkLW5v dC13YWtlLWNvbmN1cnJlbnQtY29sbGVjdG9yLWFmdGVyLXByZXZlbnQtY29sbGVjdGlvbi1pcy1j YWxsZWQuanMgYi9KU1Rlc3RzL3N0cmVzcy9jb2xsZWN0LWNvbnRpbnVvdXNseS1zaG91bGQtbm90 LXdha2UtY29uY3VycmVudC1jb2xsZWN0b3ItYWZ0ZXItcHJldmVudC1jb2xsZWN0aW9uLWlzLWNh bGxlZC5qcwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwLi5kNjMyNjRkZWVhZjAxMWNjYzYwMzIyZTE2OWQyOWQwMWI2NjRk Y2EzCi0tLSAvZGV2L251bGwKKysrIGIvSlNUZXN0cy9zdHJlc3MvY29sbGVjdC1jb250aW51b3Vz bHktc2hvdWxkLW5vdC13YWtlLWNvbmN1cnJlbnQtY29sbGVjdG9yLWFmdGVyLXByZXZlbnQtY29s bGVjdGlvbi1pcy1jYWxsZWQuanMKQEAgLTAsMCArMSwyMiBAQAorLy9AIHJ1bkRlZmF1bHQoIi0t bWF4UGVyVGhyZWFkU3RhY2tVc2FnZT0xNTcyODY0IiwgIi0tZm9yY2VNaW5pVk1Nb2RlPTEiLCAi LS1zdGVhbEVtcHR5QmxvY2tzRnJvbU90aGVyQWxsb2NhdG9ycz0wIiwgIi0tY29sbGVjdENvbnRp bnVvdXNseT0xIiwgIi0td2F0Y2hkb2c9MzAwMCIsICItLXdhdGNoZG9nLWV4Y2VwdGlvbi1vayIp CisvLyBSZXByb2R1Y2luZyB0aGUgY3Jhc2ggd2l0aCB0aGlzIHRlc3QgaXMgdmVyeSBoYXJkLiBZ b3Ugc2hvdWxkIGV4ZWN1dGUgc29tZXRoaW5nIGxpa2UgdGhpcy4KKy8vIHdoaWxlIHRydWU7IGRv IGZvciB4IGluIHswLi40fTsgZG8gRFlMRF9GUkFNRVdPUktfUEFUSD0kVk0gJFZNL2pzYyAtLW1h eFBlclRocmVhZFN0YWNrVXNhZ2U9MTU3Mjg2NCAtLWZvcmNlTWluaVZNTW9kZT0xIC0tc3RlYWxF bXB0eUJsb2Nrc0Zyb21PdGhlckFsbG9jYXRvcnM9MCAtLWNvbGxlY3RDb250aW51b3VzbHk9MSBj b2xsZWN0LWNvbnRpbnVvdXNseS1zaG91bGQtbm90LXdha2UtY29uY3VycmVudC1jb2xsZWN0b3It YWZ0ZXItcHJldmVudC1jb2xsZWN0aW9uLWlzLWNhbGxlZC5qcyAtLXdhdGNoZG9nPTMwMDAmOyBk b25lOyB3YWl0OyBzbGVlcCAwLjE7IGRvbmUKKworYXJyYXkgPSBbXTsKK2ZvciAodmFyIGkgPSAw OyBpIDwgODAwOyArK2kpIHsKKyAgYXJyYXlbaV0gPSBuZXcgRGF0YVZpZXcobmV3IEFycmF5QnVm ZmVyKCkpOworfQorCitsZXQgdGhlQ29kZSA9IGAKK2ZvciAobGV0IGogPSAwOyBqIDwgMTAwOyBq KyspIHsKKyAgZ2VuZXJhdGVIZWFwU25hcHNob3RGb3JHQ0RlYnVnZ2luZygpOworfQorYAorCitm b3IgKGxldCBpPTA7IGk8NTsgaSsrKSB7CisgICQuYWdlbnQuc3RhcnQodGhlQ29kZSk7Cit9CisK K2ZvciAobGV0IGk9MDsgaTwzOyBpKyspIHsKKyAgcnVuU3RyaW5nKHRoZUNvZGUpOworfQo=