210159 2020-04-07 15:05:35 -0700 Regression(r259610) [RBSTarget targetWithPid:] may throw a 'must specify a valid pid' exception 2020-04-08 08:38:12 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 209990 1 cdumez cdumez achristensen eric.carlson ggaren webkit-bug-importer oldest_to_newest 1638825 0 cdumez 2020-04-07 15:05:35 -0700 [RBSTarget targetWithPid:] may throw a 'must specify a valid pid' exception since r259610. There are apparently cases where the PID we are passing the ProcessAssertion is 0 (likely process crash on startup). BKSAssertion used to deal with this silently but RBSAssertion actually throws an exception in this case. To maintain the old behavior, we should do an explicit check to make sure the PID is valid before passing it to RunningBoard. 1638826 1 395743 cdumez 2020-04-07 15:07:03 -0700 Created attachment 395743 Patch 1639069 2 ews-feeder 2020-04-08 08:37:59 -0700 Committed r259717: <https://trac.webkit.org/changeset/259717> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395743. 1639071 3 webkit-bug-importer 2020-04-08 08:38:12 -0700 <rdar://problem/61456395> 395743 2020-04-07 15:07:03 -0700 2020-04-08 08:37:59 -0700 Patch bug-210159-20200407150703.patch text/plain 2487 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5NjcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDlkMmQ0MmMwNmEzZjI0NWNi ZWEzNDY1MjIwZDBiNTZkOWU1MjYzZjMuLjExYzEyMDM1Y2E1YWJhNjQ2MzBlN2JhMGJhYmYwNmZh OTU2ZjJmZWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjAtMDQtMDcgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBSZWdyZXNzaW9uKHIyNTk2MTApIFtS QlNUYXJnZXQgdGFyZ2V0V2l0aFBpZDpdIG1heSB0aHJvdyBhICdtdXN0IHNwZWNpZnkgYSB2YWxp ZCBwaWQnIGV4Y2VwdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjEwMTU5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgW1JCU1RhcmdldCB0YXJnZXRXaXRoUGlkOl0gbWF5IHRocm93IGEgJ211c3Qgc3Bl Y2lmeSBhIHZhbGlkIHBpZCcgZXhjZXB0aW9uIHNpbmNlIHIyNTk2MTAuIFRoZXJlCisgICAgICAg IGFyZSBhcHBhcmVudGx5IGNhc2VzIHdoZXJlIHRoZSBQSUQgd2UgYXJlIHBhc3NpbmcgdGhlIFBy b2Nlc3NBc3NlcnRpb24gaXMgMCAobGlrZWx5IHByb2Nlc3MgY3Jhc2gKKyAgICAgICAgb24gc3Rh cnR1cCkuIEJLU0Fzc2VydGlvbiB1c2VkIHRvIGRlYWwgd2l0aCB0aGlzIHNpbGVudGx5IGJ1dCBS QlNBc3NlcnRpb24gYWN0dWFsbHkgdGhyb3dzIGFuCisgICAgICAgIGV4Y2VwdGlvbiBpbiB0aGlz IGNhc2UuIFRvIG1haW50YWluIHRoZSBvbGQgYmVoYXZpb3IsIHdlIHNob3VsZCBkbyBhbiBleHBs aWNpdCBjaGVjayB0byBtYWtlIHN1cmUKKyAgICAgICAgdGhlIFBJRCBpcyB2YWxpZCBiZWZvcmUg cGFzc2luZyBpdCB0byBSdW5uaW5nQm9hcmQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1By b2Nlc3NBc3NlcnRpb25JT1MubW06CisgICAgICAgIChXZWJLaXQ6OlByb2Nlc3NBc3NlcnRpb246 OlByb2Nlc3NBc3NlcnRpb24pOgorCiAyMDIwLTA0LTA3ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5m cmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFVzZSBSZWN0RWRnZXM8PiBpbiBzb21lIHNjcm9s bGluZyB0cmVlIGNvZGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9Q cm9jZXNzQXNzZXJ0aW9uSU9TLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1Byb2Nl c3NBc3NlcnRpb25JT1MubW0KaW5kZXggYzU0YWE0MDZkOWVjMzI2YjJlMzhiMzQ3YjE4MTg2N2Y5 NDViYzcyNy4uZDIyYjY2MzVlNTQyZWUzY2JkODUzMjdjMTY2YTQ0ZDFlMGNhZTI4MyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1Byb2Nlc3NBc3NlcnRpb25JT1MubW0K KysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1Byb2Nlc3NBc3NlcnRpb25JT1MubW0K QEAgLTM1MCw2ICszNTAsMTEgQEAgUHJvY2Vzc0Fzc2VydGlvbjo6UHJvY2Vzc0Fzc2VydGlvbihw aWRfdCBwaWQsIEFTQ0lJTGl0ZXJhbCByZWFzb24sIFByb2Nlc3NBc3NlcnQKICAgICBOU1N0cmlu ZyAqbnNSZWFzb24gPSBbTlNTdHJpbmcgc3RyaW5nV2l0aENTdHJpbmc6cmVhc29uLmNoYXJhY3Rl cnMoKSBlbmNvZGluZzpOU0FTQ0lJU3RyaW5nRW5jb2RpbmddOwogICAgIE5TU3RyaW5nICpydW5u aW5nQm9hcmRBc3NlcnRpb25OYW1lID0gcnVubmluZ0JvYXJkTmFtZUZvckFzc2VydGlvblR5cGUo YXNzZXJ0aW9uVHlwZSk7CiAgICAgaWYgKHJ1bm5pbmdCb2FyZEFzc2VydGlvbk5hbWUpIHsKKyAg ICAgICAgaWYgKCFwaWQpIHsKKyAgICAgICAgICAgIFJFTEVBU0VfTE9HX0VSUk9SKFByb2Nlc3NT dXNwZW5zaW9uLCAiJXAgLSBQcm9jZXNzQXNzZXJ0aW9uOiBGYWlsZWQgdG8gYWNxdWlyZSBSQlMg JXtwdWJsaWN9QCBhc3NlcnRpb24gJyV7cHVibGljfXMnIGZvciBwcm9jZXNzIGJlY2F1c2UgUElE IGlzIGludmFsaWQiLCB0aGlzLCBydW5uaW5nQm9hcmRBc3NlcnRpb25OYW1lLCByZWFzb24uY2hh cmFjdGVycygpKTsKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgfQorCiAgICAgICAgIFJC U1RhcmdldCAqdGFyZ2V0ID0gW1JCU1RhcmdldCB0YXJnZXRXaXRoUGlkOnBpZF07CiAgICAgICAg IFJCU0RvbWFpbkF0dHJpYnV0ZSAqZG9tYWluQXR0cmlidXRlID0gW1JCU0RvbWFpbkF0dHJpYnV0 ZSBhdHRyaWJ1dGVXaXRoRG9tYWluOkAiY29tLmFwcGxlLndlYmtpdCIgbmFtZTpydW5uaW5nQm9h cmRBc3NlcnRpb25OYW1lXTsKICAgICAgICAgbV9yYnNBc3NlcnRpb24gPSBhZG9wdE5TKFtbUkJT QXNzZXJ0aW9uIGFsbG9jXSBpbml0V2l0aEV4cGxhbmF0aW9uOm5zUmVhc29uIHRhcmdldDp0YXJn ZXQgYXR0cmlidXRlczpAW2RvbWFpbkF0dHJpYnV0ZV1dKTsK