210158 2020-04-07 15:01:06 -0700 [GTK4] Make PAL::systemBeep() work 2020-04-08 13:55:59 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 210100 1 aperez aperez benjamin bugs-noreply cdumez cgarcia cmarcelo csaavedra ews-watchlist mcatanzaro oldest_to_newest 1638824 0 aperez 2020-04-07 15:01:06 -0700 gdk_beep() is no more in GTK4 1638829 1 395744 aperez 2020-04-07 15:08:35 -0700 Created attachment 395744 Patch 1638966 2 aperez 2020-04-08 00:58:22 -0700 Thanks, I'll land this once the patch for bug #210154 is in the tree =) 1639024 3 395744 mcatanzaro 2020-04-08 06:24:19 -0700 Comment on attachment 395744 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395744&action=review > Source/WebCore/PAL/pal/system/gtk/SoundGtk.cpp:31 > + if (auto* display = gdk_display_get_default()) > + gdk_display_beep(display); This is available since GDK 2.2. There's no need to use #if here. 1639049 4 aperez 2020-04-08 07:44:50 -0700 (In reply to Michael Catanzaro from comment #3) > Comment on attachment 395744 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=395744&action=review > > > Source/WebCore/PAL/pal/system/gtk/SoundGtk.cpp:31 > > + if (auto* display = gdk_display_get_default()) > > + gdk_display_beep(display); > > This is available since GDK 2.2. There's no need to use #if here. Good point, I'll remove the conditional Note to self: Always check which version first introduced a symbol, for those cases where we can update the code in ways that it will work both with GTK3 and GTK4. 1639050 5 395808 aperez 2020-04-08 07:50:11 -0700 Created attachment 395808 Patch for lnding 1639275 6 aperez 2020-04-08 13:55:38 -0700 Committed r259754: <https://trac.webkit.org/changeset/259754> 395744 2020-04-07 15:08:35 -0700 2020-04-08 07:50:05 -0700 Patch bug-210158-20200408010831.patch text/plain 2367 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5NjQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGNlYTQ1MGVhYzIxZDU4OWI2YTk5NmI0 ZTI4NDFjZTE2ZWE1NWM0YTkuLjM4ODkwNDJjZDIwZmEwN2MxNTQwMzQ5ZDVkMTAwYjVlNThhMzk5 MWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMjAtMDQtMDcgIEFkcmlhbiBQZXJleiBkZSBDYXN0 cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLNF0gTWFrZSBQQUw6OnN5c3Rl bUJlZXAoKSB3b3JrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMTAxNTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIHd0Zi9QbGF0Zm9ybS5oOiBEZWZpbmUgYSB2YWx1ZSBmb3IgR0RLX1ZFUlNJT05fTUlO X1JFUVVJUkVEIHN1aXRhYmxlIGZvciBHVEs0LgorCiAyMDIwLTA0LTA2ICBSb3NzIEtpcnNsaW5n ICA8cm9zcy5raXJzbGluZ0Bzb255LmNvbT4KIAogICAgICAgICBVcGRhdGUgbWluaW11bSBJQ1Ug dmVyc2lvbiB0byA2MC4yCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9QQUwvQ2hhbmdlTG9n IGIvU291cmNlL1dlYkNvcmUvUEFML0NoYW5nZUxvZwppbmRleCA5MDIyMzhjYWIzNWU4YWM2MTI3 NWMyNWY2ZTM4NjQ5OGM1MTAxNjkxLi4yZmYzNGMwODMxOWYxMzAzNmZiMGJmZWQyZjA5NmI3MDVk MGY3MTlkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QQUwvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAyMC0wNC0wNyAg QWRyaWFuIFBlcmV6IGRlIENhc3RybyAgPGFwZXJlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFtH VEs0XSBNYWtlIFBBTDo6c3lzdGVtQmVlcCgpIHdvcmsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMDE1OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGFsL3N5c3RlbS9ndGsvU291bmRHdGsuY3BwOgor ICAgICAgICAoUEFMOjpzeXN0ZW1CZWVwKTogVXNlIGdka19kaXNwbGF5X2JlZXAoKSB3aXRoIEdU SzQuCisKIDIwMjAtMDQtMDcgIEFkcmlhbiBQZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlh LmNvbT4KIAogICAgICAgICBbR1RLXSBDTWFrZSBmaW5kIG1vZHVsZSBmb3IgR1RLNApkaWZmIC0t Z2l0IGEvU291cmNlL1dURi93dGYvUGxhdGZvcm0uaCBiL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3Jt LmgKaW5kZXggNjgwMmNjOGNjYjE1YTg0ZjExZDBkM2YwNzdmY2U5MjdiNjQ0MDY5MC4uNGQ0OGU5 NGZkMTA3NGZiOGIxNzRhOGFlY2Y5YWFkZTZkMTNiNDc2ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dU Ri93dGYvUGxhdGZvcm0uaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCkBAIC04NCw4 ICs4NCwxMiBAQAogCiAjaWYgUExBVEZPUk0oR1RLKQogI2RlZmluZSBHTElCX1ZFUlNJT05fTUlO X1JFUVVJUkVEIEdMSUJfVkVSU0lPTl8yXzM2CisjaWYgVVNFKEdUSzQpCisjZGVmaW5lIEdES19W RVJTSU9OX01JTl9SRVFVSVJFRCBHREtfVkVSU0lPTl8zXzkyCisjZWxzZQogI2RlZmluZSBHREtf VkVSU0lPTl9NSU5fUkVRVUlSRUQgR0RLX1ZFUlNJT05fM182CiAjZW5kaWYKKyNlbmRpZgogCiAj aWYgUExBVEZPUk0oV1BFKQogI2RlZmluZSBHTElCX1ZFUlNJT05fTUlOX1JFUVVJUkVEIEdMSUJf VkVSU0lPTl8yXzQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFsL3N5c3RlbS9n dGsvU291bmRHdGsuY3BwIGIvU291cmNlL1dlYkNvcmUvUEFML3BhbC9zeXN0ZW0vZ3RrL1NvdW5k R3RrLmNwcAppbmRleCAyMWRmOTlhMjE3NzhhNDBmYTUxNzUwYTRhZmQ2OWQzMDMzM2NjZWE0Li5l MzYxZDAyYmEyNDAxNTM0Njk2NzQzYzcwMGZjNjQwYTI3Y2Q3ZTUzIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9QQUwvcGFsL3N5c3RlbS9ndGsvU291bmRHdGsuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL1BBTC9wYWwvc3lzdGVtL2d0ay9Tb3VuZEd0ay5jcHAKQEAgLTI2LDcgKzI2LDEyIEBA IG5hbWVzcGFjZSBQQUwgewogCiB2b2lkIHN5c3RlbUJlZXAoKQogeworI2lmIFVTRShHVEs0KQor ICAgIGlmIChhdXRvKiBkaXNwbGF5ID0gZ2RrX2Rpc3BsYXlfZ2V0X2RlZmF1bHQoKSkKKyAgICAg ICAgZ2RrX2Rpc3BsYXlfYmVlcChkaXNwbGF5KTsKKyNlbHNlCiAgICAgZ2RrX2JlZXAoKTsKKyNl bmRpZgogfQogCiB9IC8vIG5hbWVzcGFjZSBQQUwK 395808 2020-04-08 07:50:11 -0700 2020-04-08 07:50:11 -0700 Patch for lnding bug-210158-20200408175009.patch text/plain 2385 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5NzE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGFmM2E5YThhZjVjNDQyYzY0YjI2YzYw NmQzOWRhN2FkN2YwYjk3MjcuLjkyYjYwY2NhM2U0MDJiODcyNWI0MDhjMWIyOWQ5YWRlMWM2NzBm ZmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMjAtMDQtMDggIEFkcmlhbiBQZXJleiBkZSBDYXN0 cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLNF0gTWFrZSBQQUw6OnN5c3Rl bUJlZXAoKSB3b3JrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMTAxNTgKKworICAgICAgICBSZXZpZXdlZCBieSBDYXJsb3MgR2FyY2lhIENhbXBvcy4K KworICAgICAgICAqIHd0Zi9QbGF0Zm9ybS5oOiBEZWZpbmUgYSB2YWx1ZSBmb3IgR0RLX1ZFUlNJ T05fTUlOX1JFUVVJUkVEIHN1aXRhYmxlIGZvciBHVEs0LgorCiAyMDIwLTA0LTA4ICBUaW0gSG9y dG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIFJlYXJyYW5nZSBhbmQg c2ltcGxpZnkgc29tZSBKU0MgZmVhdHVyZSBmbGFncwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvUEFML0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cKaW5kZXggOTAy MjM4Y2FiMzVlOGFjNjEyNzVjMjVmNmUzODY0OThjNTEwMTY5MS4uNWJhZGFhYmRjOTA0NGUzNDRj MGU3NzAxMzk2ZjRkODY5M2E5OGE0YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvUEFML0No YW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9QQUwvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMjAtMDQtMDggIEFkcmlhbiBQZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNv bT4KKworICAgICAgICBbR1RLNF0gTWFrZSBQQUw6OnN5c3RlbUJlZXAoKSB3b3JrCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTAxNTgKKworICAgICAg ICBSZXZpZXdlZCBieSBDYXJsb3MgR2FyY2lhIENhbXBvcy4KKworICAgICAgICAqIHBhbC9zeXN0 ZW0vZ3RrL1NvdW5kR3RrLmNwcDoKKyAgICAgICAgKFBBTDo6c3lzdGVtQmVlcCk6IFVzZSBnZGtf ZGlzcGxheV9iZWVwKCksIHdoaWNoIHdvcmtzIGJvdGggd2l0aCBHVEszIGFuZCBHVEs0LgorCiAy MDIwLTA0LTA3ICBBZHJpYW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CiAK ICAgICAgICAgW0dUS10gQ01ha2UgZmluZCBtb2R1bGUgZm9yIEdUSzQKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XVEYvd3RmL1BsYXRmb3JtLmggYi9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCmluZGV4 IDY4MDJjYzhjY2IxNWE4NGYxMWQwZDNmMDc3ZmNlOTI3YjY0NDA2OTAuLjRkNDhlOTRmZDEwNzRm YjhiMTc0YThhZWNmOWFhZGU2ZDEzYjQ3NmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1Bs YXRmb3JtLmgKKysrIGIvU291cmNlL1dURi93dGYvUGxhdGZvcm0uaApAQCAtODQsOCArODQsMTIg QEAKIAogI2lmIFBMQVRGT1JNKEdUSykKICNkZWZpbmUgR0xJQl9WRVJTSU9OX01JTl9SRVFVSVJF RCBHTElCX1ZFUlNJT05fMl8zNgorI2lmIFVTRShHVEs0KQorI2RlZmluZSBHREtfVkVSU0lPTl9N SU5fUkVRVUlSRUQgR0RLX1ZFUlNJT05fM185MgorI2Vsc2UKICNkZWZpbmUgR0RLX1ZFUlNJT05f TUlOX1JFUVVJUkVEIEdES19WRVJTSU9OXzNfNgogI2VuZGlmCisjZW5kaWYKIAogI2lmIFBMQVRG T1JNKFdQRSkKICNkZWZpbmUgR0xJQl9WRVJTSU9OX01JTl9SRVFVSVJFRCBHTElCX1ZFUlNJT05f Ml80MApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvUEFML3BhbC9zeXN0ZW0vZ3RrL1NvdW5k R3RrLmNwcCBiL1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwvc3lzdGVtL2d0ay9Tb3VuZEd0ay5jcHAK aW5kZXggMjFkZjk5YTIxNzc4YTQwZmE1MTc1MGE0YWZkNjlkMzAzMzNjY2VhNC4uYTRlZTViNGVj OWE5YTkzZDJlZmRkYjBlZjkxYmNkZDhmMWEyZDQ5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvUEFML3BhbC9zeXN0ZW0vZ3RrL1NvdW5kR3RrLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Q QUwvcGFsL3N5c3RlbS9ndGsvU291bmRHdGsuY3BwCkBAIC0yNiw3ICsyNiw4IEBAIG5hbWVzcGFj ZSBQQUwgewogCiB2b2lkIHN5c3RlbUJlZXAoKQogewotICAgIGdka19iZWVwKCk7CisgICAgaWYg KGF1dG8qIGRpc3BsYXkgPSBnZGtfZGlzcGxheV9nZXRfZGVmYXVsdCgpKQorICAgICAgICBnZGtf ZGlzcGxheV9iZWVwKGRpc3BsYXkpOwogfQogCiB9IC8vIG5hbWVzcGFjZSBQQUwK