210150 2020-04-07 13:44:40 -0700 [ews] Add unit tests for layout tests factories 2020-04-07 18:40:11 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain ap jbedard webkit-bug-importer oldest_to_newest 1638777 0 aakash_jain 2020-04-07 13:44:40 -0700 [ews] Add unit tests for layout tests factories. 1638780 1 395733 aakash_jain 2020-04-07 13:50:08 -0700 Created attachment 395733 Patch 1638909 2 ews-feeder 2020-04-07 18:38:47 -0700 Committed r259699: <https://trac.webkit.org/changeset/259699> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395733. 1638910 3 webkit-bug-importer 2020-04-07 18:40:11 -0700 <rdar://problem/61423494> 395733 2020-04-07 13:50:08 -0700 2020-04-07 18:38:47 -0700 Patch bug-210150-20200407165007.patch text/plain 5476 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1OTY2NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDIwLTA0LTA3ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBBZGQgdW5pdCB0ZXN0cyBmb3IgbGF5b3V0IHRlc3RzIGZhY3Rv cmllcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEw MTUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBC dWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvZmFjdG9yaWVzX3VuaXR0ZXN0LnB5OgorICAgICAg ICAoVGVzdExheW91dFRlc3RzRmFjdG9yeSk6CisgICAgICAgIChUZXN0TGF5b3V0VGVzdHNGYWN0 b3J5LnRlc3RfbWFjb3Nfd2sxX3JlbGVhc2VfZmFjdG9yeSk6IEFkZGVkIHVuaXQtdGVzdC4KKyAg ICAgICAgKFRlc3RMYXlvdXRUZXN0c0ZhY3RvcnkudGVzdF9tYWNvc193azFfZGVidWdfZmFjdG9y eSk6IERpdHRvLgorICAgICAgICAoVGVzdExheW91dFRlc3RzRmFjdG9yeS50ZXN0X21hY29zX3dr Ml9mYWN0b3J5KTogRGl0dG8uCisgICAgICAgIChUZXN0TGF5b3V0VGVzdHNGYWN0b3J5LnRlc3Rf aW9zX3drMl9mYWN0b3J5KTogRGl0dG8uCisgICAgICAgIChUZXN0R1RLRmFjdG9yeSk6IFJlbmFt ZWQuCisKIDIwMjAtMDQtMDcgIFRydWl0dCBTYXZlbGwgIDx0c2F2ZWxsQGFwcGxlLmNvbT4KIAog ICAgICAgICBVbnJldmlld2VkLCByZXZlcnRpbmcgcjI1OTQ0Ni4KSW5kZXg6IFRvb2xzL0J1aWxk U2xhdmVTdXBwb3J0L2V3cy1idWlsZC9mYWN0b3JpZXNfdW5pdHRlc3QucHkKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2ZhY3Rvcmllc191bml0dGVzdC5w eQkocmV2aXNpb24gMjU5NjY3KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxk L2ZhY3Rvcmllc191bml0dGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAtMjAzLDcgKzIwMyw3MSBA QCBjbGFzcyBUZXN0Q29tbWl0UXVldWVGYWN0b3J5KFRlc3RDYXNlKToKICAgICAgICAgXSkKIAog Ci1jbGFzcyBUZXN0R1RLRmFjdG9yeShUZXN0Q2FzZSk6CitjbGFzcyBUZXN0TGF5b3V0VGVzdHNG YWN0b3J5KFRlc3RDYXNlKToKKyAgICBkZWYgdGVzdF9tYWNvc193azFfcmVsZWFzZV9mYWN0b3J5 KHNlbGYpOgorICAgICAgICBmYWN0b3J5ID0gZmFjdG9yaWVzLm1hY09TV0sxRmFjdG9yeShwbGF0 Zm9ybT0nbWFjLW1vamF2ZScsIGNvbmZpZ3VyYXRpb249J3JlbGVhc2UnLCBhcmNoaXRlY3R1cmVz PVsieDg2XzY0Il0pCisgICAgICAgIHNlbGYuYXNzZXJ0QnVpbGRTdGVwcyhmYWN0b3J5LnN0ZXBz LCBbCisgICAgICAgICAgICBfQnVpbGRTdGVwRmFjdG9yeShzdGVwcy5Db25maWd1cmVCdWlsZCwg cGxhdGZvcm09J21hYy1tb2phdmUnLCBjb25maWd1cmF0aW9uPSdyZWxlYXNlJywgYXJjaGl0ZWN0 dXJlcz1bIng4Nl82NCJdLCBidWlsZE9ubHk9RmFsc2UsIHRyaWdnZXJzPU5vbmUsIHJlbW90ZXM9 Tm9uZSwgYWRkaXRpb25hbEFyZ3VtZW50cz1Ob25lKSwKKyAgICAgICAgICAgIF9CdWlsZFN0ZXBG YWN0b3J5KHN0ZXBzLlZhbGlkYXRlUGF0Y2gpLAorICAgICAgICAgICAgX0J1aWxkU3RlcEZhY3Rv cnkoc3RlcHMuUHJpbnRDb25maWd1cmF0aW9uKSwKKyAgICAgICAgICAgIF9CdWlsZFN0ZXBGYWN0 b3J5KHN0ZXBzLkNoZWNrT3V0U291cmNlKSwKKyAgICAgICAgICAgIF9CdWlsZFN0ZXBGYWN0b3J5 KHN0ZXBzLkNoZWNrT3V0U3BlY2lmaWNSZXZpc2lvbiksCisgICAgICAgICAgICBfQnVpbGRTdGVw RmFjdG9yeShzdGVwcy5BcHBseVBhdGNoKSwKKyAgICAgICAgICAgIF9CdWlsZFN0ZXBGYWN0b3J5 KHN0ZXBzLkRvd25sb2FkQnVpbHRQcm9kdWN0KSwKKyAgICAgICAgICAgIF9CdWlsZFN0ZXBGYWN0 b3J5KHN0ZXBzLkV4dHJhY3RCdWlsdFByb2R1Y3QpLAorICAgICAgICAgICAgX0J1aWxkU3RlcEZh Y3Rvcnkoc3RlcHMuS2lsbE9sZFByb2Nlc3NlcyksCisgICAgICAgICAgICBfQnVpbGRTdGVwRmFj dG9yeShzdGVwcy5SdW5XZWJLaXQxVGVzdHMpLAorICAgICAgICAgICAgX0J1aWxkU3RlcEZhY3Rv cnkoc3RlcHMuU2V0QnVpbGRTdW1tYXJ5KSwKKyAgICAgICAgXSkKKworICAgIGRlZiB0ZXN0X21h Y29zX3drMV9kZWJ1Z19mYWN0b3J5KHNlbGYpOgorICAgICAgICBmYWN0b3J5ID0gZmFjdG9yaWVz Lm1hY09TV0sxRmFjdG9yeShwbGF0Zm9ybT0nbWFjLW1vamF2ZScsIGNvbmZpZ3VyYXRpb249J2Rl YnVnJywgYXJjaGl0ZWN0dXJlcz1bIng4Nl82NCJdKQorICAgICAgICBzZWxmLmFzc2VydEJ1aWxk U3RlcHMoZmFjdG9yeS5zdGVwcywgWworICAgICAgICAgICAgX0J1aWxkU3RlcEZhY3Rvcnkoc3Rl cHMuQ29uZmlndXJlQnVpbGQsIHBsYXRmb3JtPSdtYWMtbW9qYXZlJywgY29uZmlndXJhdGlvbj0n ZGVidWcnLCBhcmNoaXRlY3R1cmVzPVsieDg2XzY0Il0sIGJ1aWxkT25seT1GYWxzZSwgdHJpZ2dl cnM9Tm9uZSwgcmVtb3Rlcz1Ob25lLCBhZGRpdGlvbmFsQXJndW1lbnRzPU5vbmUpLAorICAgICAg ICAgICAgX0J1aWxkU3RlcEZhY3Rvcnkoc3RlcHMuVmFsaWRhdGVQYXRjaCksCisgICAgICAgICAg ICBfQnVpbGRTdGVwRmFjdG9yeShzdGVwcy5QcmludENvbmZpZ3VyYXRpb24pLAorICAgICAgICAg ICAgX0J1aWxkU3RlcEZhY3Rvcnkoc3RlcHMuQ2hlY2tPdXRTb3VyY2UpLAorICAgICAgICAgICAg X0J1aWxkU3RlcEZhY3Rvcnkoc3RlcHMuQ2hlY2tPdXRTcGVjaWZpY1JldmlzaW9uKSwKKyAgICAg ICAgICAgIF9CdWlsZFN0ZXBGYWN0b3J5KHN0ZXBzLkFwcGx5UGF0Y2gpLAorICAgICAgICAgICAg X0J1aWxkU3RlcEZhY3Rvcnkoc3RlcHMuRG93bmxvYWRCdWlsdFByb2R1Y3QpLAorICAgICAgICAg ICAgX0J1aWxkU3RlcEZhY3Rvcnkoc3RlcHMuRXh0cmFjdEJ1aWx0UHJvZHVjdCksCisgICAgICAg ICAgICBfQnVpbGRTdGVwRmFjdG9yeShzdGVwcy5LaWxsT2xkUHJvY2Vzc2VzKSwKKyAgICAgICAg ICAgIF9CdWlsZFN0ZXBGYWN0b3J5KHN0ZXBzLlJ1bldlYktpdDFUZXN0cyksCisgICAgICAgICAg ICBfQnVpbGRTdGVwRmFjdG9yeShzdGVwcy5TZXRCdWlsZFN1bW1hcnkpLAorICAgICAgICBdKQor CisgICAgZGVmIHRlc3RfbWFjb3Nfd2syX2ZhY3Rvcnkoc2VsZik6CisgICAgICAgIGZhY3Rvcnkg PSBmYWN0b3JpZXMubWFjT1NXSzJGYWN0b3J5KHBsYXRmb3JtPSdtYWMtbW9qYXZlJywgY29uZmln dXJhdGlvbj0ncmVsZWFzZScsIGFyY2hpdGVjdHVyZXM9WyJ4ODZfNjQiXSkKKyAgICAgICAgc2Vs Zi5hc3NlcnRCdWlsZFN0ZXBzKGZhY3Rvcnkuc3RlcHMsIFsKKyAgICAgICAgICAgIF9CdWlsZFN0 ZXBGYWN0b3J5KHN0ZXBzLkNvbmZpZ3VyZUJ1aWxkLCBwbGF0Zm9ybT0nbWFjLW1vamF2ZScsIGNv bmZpZ3VyYXRpb249J3JlbGVhc2UnLCBhcmNoaXRlY3R1cmVzPVsieDg2XzY0Il0sIGJ1aWxkT25s eT1GYWxzZSwgdHJpZ2dlcnM9Tm9uZSwgcmVtb3Rlcz1Ob25lLCBhZGRpdGlvbmFsQXJndW1lbnRz PU5vbmUpLAorICAgICAgICAgICAgX0J1aWxkU3RlcEZhY3Rvcnkoc3RlcHMuVmFsaWRhdGVQYXRj aCksCisgICAgICAgICAgICBfQnVpbGRTdGVwRmFjdG9yeShzdGVwcy5QcmludENvbmZpZ3VyYXRp b24pLAorICAgICAgICAgICAgX0J1aWxkU3RlcEZhY3Rvcnkoc3RlcHMuQ2hlY2tPdXRTb3VyY2Up LAorICAgICAgICAgICAgX0J1aWxkU3RlcEZhY3Rvcnkoc3RlcHMuQ2hlY2tPdXRTcGVjaWZpY1Jl dmlzaW9uKSwKKyAgICAgICAgICAgIF9CdWlsZFN0ZXBGYWN0b3J5KHN0ZXBzLkFwcGx5UGF0Y2gp LAorICAgICAgICAgICAgX0J1aWxkU3RlcEZhY3Rvcnkoc3RlcHMuRG93bmxvYWRCdWlsdFByb2R1 Y3QpLAorICAgICAgICAgICAgX0J1aWxkU3RlcEZhY3Rvcnkoc3RlcHMuRXh0cmFjdEJ1aWx0UHJv ZHVjdCksCisgICAgICAgICAgICBfQnVpbGRTdGVwRmFjdG9yeShzdGVwcy5LaWxsT2xkUHJvY2Vz c2VzKSwKKyAgICAgICAgICAgIF9CdWlsZFN0ZXBGYWN0b3J5KHN0ZXBzLlJ1bldlYktpdFRlc3Rz KSwKKyAgICAgICAgICAgIF9CdWlsZFN0ZXBGYWN0b3J5KHN0ZXBzLlNldEJ1aWxkU3VtbWFyeSks CisgICAgICAgIF0pCisKKyAgICBkZWYgdGVzdF9pb3Nfd2syX2ZhY3Rvcnkoc2VsZik6CisgICAg ICAgIGZhY3RvcnkgPSBmYWN0b3JpZXMuaU9TVGVzdHNGYWN0b3J5KHBsYXRmb3JtPSdpb3Mtc2lt dWxhdG9yLTEzJywgY29uZmlndXJhdGlvbj0ncmVsZWFzZScsIGFyY2hpdGVjdHVyZXM9WyJ4ODZf NjQiXSkKKyAgICAgICAgc2VsZi5hc3NlcnRCdWlsZFN0ZXBzKGZhY3Rvcnkuc3RlcHMsIFsKKyAg ICAgICAgICAgIF9CdWlsZFN0ZXBGYWN0b3J5KHN0ZXBzLkNvbmZpZ3VyZUJ1aWxkLCBwbGF0Zm9y bT0naW9zLXNpbXVsYXRvci0xMycsIGNvbmZpZ3VyYXRpb249J3JlbGVhc2UnLCBhcmNoaXRlY3R1 cmVzPVsieDg2XzY0Il0sIGJ1aWxkT25seT1GYWxzZSwgdHJpZ2dlcnM9Tm9uZSwgcmVtb3Rlcz1O b25lLCBhZGRpdGlvbmFsQXJndW1lbnRzPU5vbmUpLAorICAgICAgICAgICAgX0J1aWxkU3RlcEZh Y3Rvcnkoc3RlcHMuVmFsaWRhdGVQYXRjaCksCisgICAgICAgICAgICBfQnVpbGRTdGVwRmFjdG9y eShzdGVwcy5QcmludENvbmZpZ3VyYXRpb24pLAorICAgICAgICAgICAgX0J1aWxkU3RlcEZhY3Rv cnkoc3RlcHMuQ2hlY2tPdXRTb3VyY2UpLAorICAgICAgICAgICAgX0J1aWxkU3RlcEZhY3Rvcnko c3RlcHMuQ2hlY2tPdXRTcGVjaWZpY1JldmlzaW9uKSwKKyAgICAgICAgICAgIF9CdWlsZFN0ZXBG YWN0b3J5KHN0ZXBzLkFwcGx5UGF0Y2gpLAorICAgICAgICAgICAgX0J1aWxkU3RlcEZhY3Rvcnko c3RlcHMuRG93bmxvYWRCdWlsdFByb2R1Y3QpLAorICAgICAgICAgICAgX0J1aWxkU3RlcEZhY3Rv cnkoc3RlcHMuRXh0cmFjdEJ1aWx0UHJvZHVjdCksCisgICAgICAgICAgICBfQnVpbGRTdGVwRmFj dG9yeShzdGVwcy5LaWxsT2xkUHJvY2Vzc2VzKSwKKyAgICAgICAgICAgIF9CdWlsZFN0ZXBGYWN0 b3J5KHN0ZXBzLlJ1bldlYktpdFRlc3RzKSwKKyAgICAgICAgICAgIF9CdWlsZFN0ZXBGYWN0b3J5 KHN0ZXBzLlNldEJ1aWxkU3VtbWFyeSksCisgICAgICAgIF0pCisKICAgICBkZWYgdGVzdF9ndGtf ZmFjdG9yeShzZWxmKToKICAgICAgICAgZmFjdG9yeSA9IGZhY3Rvcmllcy5HVEtUZXN0c0ZhY3Rv cnkocGxhdGZvcm09J2d0aycsIGNvbmZpZ3VyYXRpb249J3JlbGVhc2UnLCBhcmNoaXRlY3R1cmVz PVsieDg2XzY0Il0pCiAgICAgICAgIHNlbGYuYXNzZXJ0QnVpbGRTdGVwcyhmYWN0b3J5LnN0ZXBz LCBbCg==