210149 2020-04-07 13:32:32 -0700 [GLIB] Avoid potential segfault in getPlatformEditorState 2020-04-07 14:09:51 -0700 1 1 1 Unclassified WebKit WebKitGTK Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=209966 P2 Normal --- 1 lmoura lmoura bugs-noreply clopez oldest_to_newest 1638770 0 lmoura 2020-04-07 13:32:32 -0700 Missing extra check dereferencing a range. This seems to be causing some segfaults in the GTK EWS test bot: https://ews-build.webkit-uat.org/#/builders/34/builds/245 1638774 1 395731 lmoura 2020-04-07 13:36:14 -0700 Created attachment 395731 Patch 1638791 2 ews-feeder 2020-04-07 14:09:50 -0700 Committed r259670: <https://trac.webkit.org/changeset/259670> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395731. 395731 2020-04-07 13:36:14 -0700 2020-04-07 14:09:50 -0700 Patch bug-210149-20200407173612.patch text/plain 1830 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5NjU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDk2NDU2OGE2NWFlYmNjMDg3 OGJhYjRhMzdiZTExZTc3NGEyNGRmYmIuLmE5NTIxZmViZjg3MzU5NmQ0YTc1NGIwODBhNzBkYjY4 NDgwYjIyMzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjAtMDQtMDcgIExhdXJvIE1v dXJhICA8bG1vdXJhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dMSUJdIEF2b2lkIHBvdGVudGlh bCBzZWdmYXVsdCBpbiBnZXRQbGF0Zm9ybUVkaXRvclN0YXRlCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTAxNDkKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBdm9pZCBwb3RlbnRpYWwgc3Vycm91bmRpbmdS YW5nZSBkZXJlZmVyZW5jZSBzZWdmYXVsdC4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFn ZS9nbGliL1dlYlBhZ2VHTGliLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6Z2V0UGxh dGZvcm1FZGl0b3JTdGF0ZSBjb25zdCk6CisKIDIwMjAtMDQtMDcgIEthdGUgQ2hlbmV5ICA8a2F0 aGVyaW5lX2NoZW5leUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV0dXJuIGFwcC1ib3VuZCBzZXNz aW9ucyBmb3IgaW5zdGFuY2VzIHdoZXJlIFdLQXBwQm91bmREb21haW5zIGlzCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9nbGliL1dlYlBhZ2VHTGliLmNwcCBi L1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2dsaWIvV2ViUGFnZUdMaWIuY3BwCmlu ZGV4IGUzYmIzNGNjN2FjM2RkY2U2YTEyYWRmODc1MzEyNTM3NmQ2NjNkZWUuLjkzNGJhNTAxN2Q3 ZjMzNWNkZmFlODdmMmM2MTNjMWY4NWZlMmE2NWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv V2ViUHJvY2Vzcy9XZWJQYWdlL2dsaWIvV2ViUGFnZUdMaWIuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2dsaWIvV2ViUGFnZUdMaWIuY3BwCkBAIC0xMDksNyArMTA5 LDcgQEAgdm9pZCBXZWJQYWdlOjpnZXRQbGF0Zm9ybUVkaXRvclN0YXRlKEZyYW1lJiBmcmFtZSwg RWRpdG9yU3RhdGUmIHJlc3VsdCkgY29uc3QKICAgICAgICAgYXV0byBzdXJyb3VuZGluZ0VuZCA9 IGVuZE9mRWRpdGFibGVDb250ZW50KHNlbGVjdGlvblN0YXJ0KTsKICAgICAgICAgYXV0byBzdXJy b3VuZGluZ1JhbmdlID0gbWFrZVJhbmdlKHN1cnJvdW5kaW5nU3RhcnQsIHN1cnJvdW5kaW5nRW5k KTsKICAgICAgICAgYXV0byBjb21wb3NpdGlvblJhbmdlID0gZnJhbWUuZWRpdG9yKCkuY29tcG9z aXRpb25SYW5nZSgpOwotICAgICAgICBpZiAoY29tcG9zaXRpb25SYW5nZSAmJiBzdXJyb3VuZGlu Z1JhbmdlLT5jb250YWlucygqY29tcG9zaXRpb25SYW5nZSkpIHsKKyAgICAgICAgaWYgKGNvbXBv c2l0aW9uUmFuZ2UgJiYgc3Vycm91bmRpbmdSYW5nZSAmJiBzdXJyb3VuZGluZ1JhbmdlLT5jb250 YWlucygqY29tcG9zaXRpb25SYW5nZSkpIHsKICAgICAgICAgICAgIGF1dG8gY2xvbmVkUmFuZ2Ug PSBzdXJyb3VuZGluZ1JhbmdlLT5jbG9uZVJhbmdlKCk7CiAgICAgICAgICAgICBzdXJyb3VuZGlu Z1JhbmdlLT5zZXRFbmQoY29tcG9zaXRpb25SYW5nZS0+c3RhcnRQb3NpdGlvbigpKTsKICAgICAg ICAgICAgIGNsb25lZFJhbmdlLT5zZXRTdGFydChjb21wb3NpdGlvblJhbmdlLT5lbmRQb3NpdGlv bigpKTsK