210147 2020-04-07 13:28:24 -0700 Delete ICs should not cache dictionaries 2020-04-07 16:11:27 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin fpizlo ggaren gskachkov guijemont keith_miller mark.lam msaboff rmorisset ticaiolima tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1638766 0 saam 2020-04-07 13:28:24 -0700 ... 1638767 1 saam 2020-04-07 13:28:53 -0700 <rdar://problem/61382405> 1638771 2 395730 saam 2020-04-07 13:33:02 -0700 Created attachment 395730 patch 1638773 3 395730 saam 2020-04-07 13:34:18 -0700 Comment on attachment 395730 patch View in context: https://bugs.webkit.org/attachment.cgi?id=395730&action=review > Source/JavaScriptCore/jit/Repatch.cpp:760 > + jsCast<JSObject*>(baseValue)->flattenDictionaryObject(vm); oops, I need to check hasBeenFlattenedBefore 1638775 4 395732 saam 2020-04-07 13:38:15 -0700 Created attachment 395732 patch 1638810 5 395732 tzagallo 2020-04-07 14:50:13 -0700 Comment on attachment 395732 patch r=me 1638867 6 ews-feeder 2020-04-07 16:11:26 -0700 Committed r259681: <https://trac.webkit.org/changeset/259681> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395732. 395730 2020-04-07 13:33:02 -0700 2020-04-07 13:38:15 -0700 patch c-backup.diff text/plain 3606 saam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNTk2NjcpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE5IEBACisyMDIwLTA0LTA3ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgorCisgICAgICAgIERlbGV0ZSBJQ3MgY2FuJ3QgY2FjaGUgZGljdGlvbmFyaWVzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTAxNDcKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzYxMzgyNDA1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogc3RyZXNzL2RvbnQtY2FjaGUtZGVsZXRlLWljLW9uLWRp Y3Rpb25hcnktMi5qczogQWRkZWQuCisgICAgICAgIChhc3NlcnQpOgorICAgICAgICAobWFrZURp Y3Rpb25hcnkpOgorICAgICAgICAoZm9vKToKKyAgICAgICAgKiBzdHJlc3MvZG9udC1jYWNoZS1k ZWxldGUtaWMtb24tZGljdGlvbmFyeS5qczogQWRkZWQuCisgICAgICAgIChhc3NlcnQpOgorICAg ICAgICAoZm9vKToKKwogMjAyMC0wNC0wNyAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdA c29ueS5jb20+CiAKICAgICAgICAgVXBkYXRlIEpTVGVzdHMgdG8gYXNzdW1lIElDVSA2MCsKSW5k ZXg6IEpTVGVzdHMvc3RyZXNzL2RvbnQtY2FjaGUtZGVsZXRlLWljLW9uLWRpY3Rpb25hcnktMi5q cwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBKU1Rlc3RzL3N0cmVzcy9kb250LWNhY2hlLWRlbGV0ZS1pYy1vbi1k aWN0aW9uYXJ5LTIuanMJKG5vbmV4aXN0ZW50KQorKysgSlNUZXN0cy9zdHJlc3MvZG9udC1jYWNo ZS1kZWxldGUtaWMtb24tZGljdGlvbmFyeS0yLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEs MjUgQEAKK2Z1bmN0aW9uIGFzc2VydChiKSB7CisgICAgaWYgKCFiKQorICAgICAgICB0aHJvdyBu ZXcgRXJyb3I7Cit9CisKK2Z1bmN0aW9uIG1ha2VEaWN0aW9uYXJ5KCkgeworICAgIGxldCBvID0g e307CisgICAgZm9yIChsZXQgaSA9IDA7IGkgPCAxMDAwOyArK2kpCisgICAgICAgIG9bImYiICsg aV0gPSA0MjsKKyAgICByZXR1cm4gbzsKK30KKworZnVuY3Rpb24gZm9vKG8pIHsKKyAgICBkZWxl dGUgby54OworfQorCitsZXQgZCA9IG1ha2VEaWN0aW9uYXJ5KCk7Citmb3IgKGxldCBpID0gMDsg aSA8IDE1MDsgKytpKSB7CisgICAgZm9vKGQpOworfQorCitkLnggPSA0MjsKK2ZvbyhkKTsKKwor YXNzZXJ0KCFkLngpOwpJbmRleDogSlNUZXN0cy9zdHJlc3MvZG9udC1jYWNoZS1kZWxldGUtaWMt b24tZGljdGlvbmFyeS5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKU1Rlc3RzL3N0cmVzcy9kb250LWNhY2hl LWRlbGV0ZS1pYy1vbi1kaWN0aW9uYXJ5LmpzCShub25leGlzdGVudCkKKysrIEpTVGVzdHMvc3Ry ZXNzL2RvbnQtY2FjaGUtZGVsZXRlLWljLW9uLWRpY3Rpb25hcnkuanMJKHdvcmtpbmcgY29weSkK QEAgLTAsMCArMSwxNyBAQAorLy9AIHJ1bkRlZmF1bHQoIi0tcmVwYXRjaEJ1ZmZlcmluZ0NvdW50 ZG93bj04IiwgIi0tdXNlREZHSklUPTAiLCAiLS1qaXRQb2xpY3lTY2FsZT0wIiwgIi0tdXNlQ29u Y3VycmVudEpJVD0wIikKKworZnVuY3Rpb24gYXNzZXJ0KGIpIHsKKyAgICBpZiAoIWIpCisgICAg ICAgIHRocm93IG5ldyBFcnJvcjsKK30KKworZnVuY3Rpb24gZm9vKGkpIHsKKyAgICBPYmplY3Qu ZGVmaW5lUHJvcGVydHkoUmVmbGVjdCwgImdldCIsIHt9KTsKKyAgICBmb3IgKGxldCBpID0gMDsg aSA8IDI7IGkrKykgeworICAgICAgICBkZWxldGUgUmVmbGVjdC5nZXQ7CisgICAgfQorfQorCitm b3IgKGxldCBpPTA7IGk8MTAwOyBpKyspIHsKKyAgICBmb28oaSk7Cit9CkluZGV4OiBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI1OTY0OSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxOSBAQAorMjAyMC0wNC0wNyAg U2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KKworICAgICAgICBEZWxldGUgSUNzIGNh bid0IGNhY2hlIGRpY3Rpb25hcmllcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjEwMTQ3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82MTM4MjQwNT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSB3ZXJl IGhhcHBpbHkgY2FjaGluZyBkZWxldGUgSUMgY2FzZXMgb24gYSBkaWN0aW9uYXJ5IG9iamVjdC4K KyAgICAgICAgVGhpcyBpcyBjbGVhcmx5IHdyb25nLCBhcyB3ZSBtaWdodCBjYWNoZSBhIG1pc3Mg b24gYSBkaWN0aW9uYXJ5CisgICAgICAgIG9uIGEgcHJvcGVydHkgIlAiLCBldmVuIHRob3VnaCB3 ZSBtaWdodCBhZGQgIlAiIHRvIHRoZSBzdHJ1Y3R1cmUKKyAgICAgICAgd2l0aG91dCB0cmFuc2l0 aW9uaW5nIGl0LgorCisgICAgICAgICogaml0L1JlcGF0Y2guY3BwOgorICAgICAgICAoSlNDOjp0 cnlDYWNoZURlbGV0ZUJ5KToKKwogMjAyMC0wNC0wNyAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lA YXBwbGUuY29tPgogCiAgICAgICAgIFtKU0NdIFNjb3BlZEFyZ3VtZW50c1RhYmxlIHNob3VsZCBo YW5kbGUgT09NIGluIHRvbGVyYW50IG1hbm5lcgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3Jl L2ppdC9SZXBhdGNoLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0 L1JlcGF0Y2guY3BwCShyZXZpc2lvbiAyNTk2NDkpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUv aml0L1JlcGF0Y2guY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03NTYsNiArNzU2LDExIEBAIHN0YXRp YyBJbmxpbmVDYWNoZUFjdGlvbiB0cnlDYWNoZURlbGV0ZUIKICAgICAgICAgaWYgKCFzbG90Lmlz Q2FjaGVhYmxlRGVsZXRlKCkpCiAgICAgICAgICAgICByZXR1cm4gR2l2ZVVwT25DYWNoZTsKIAor ICAgICAgICBpZiAob2xkU3RydWN0dXJlLT5pc0RpY3Rpb25hcnkoKSB8fCBiYXNlVmFsdWUuYXND ZWxsKCktPnN0cnVjdHVyZSgpLT5pc0RpY3Rpb25hcnkoKSkgeworICAgICAgICAgICAganNDYXN0 PEpTT2JqZWN0Kj4oYmFzZVZhbHVlKS0+ZmxhdHRlbkRpY3Rpb25hcnlPYmplY3Qodm0pOworICAg ICAgICAgICAgcmV0dXJuIFJldHJ5Q2FjaGVMYXRlcjsKKyAgICAgICAgfQorCiAgICAgICAgIHN0 ZDo6dW5pcXVlX3B0cjxBY2Nlc3NDYXNlPiBuZXdDYXNlOwogCiAgICAgICAgIGlmIChzbG90Lmlz RGVsZXRlSGl0KCkpIHsK 395732 2020-04-07 13:38:15 -0700 2020-04-07 16:11:26 -0700 patch c-backup.diff text/plain 3771 saam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNTk2NjcpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE5IEBACisyMDIwLTA0LTA3ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgorCisgICAgICAgIERlbGV0ZSBJQ3MgY2FuJ3QgY2FjaGUgZGljdGlvbmFyaWVzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTAxNDcKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzYxMzgyNDA1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogc3RyZXNzL2RvbnQtY2FjaGUtZGVsZXRlLWljLW9uLWRp Y3Rpb25hcnktMi5qczogQWRkZWQuCisgICAgICAgIChhc3NlcnQpOgorICAgICAgICAobWFrZURp Y3Rpb25hcnkpOgorICAgICAgICAoZm9vKToKKyAgICAgICAgKiBzdHJlc3MvZG9udC1jYWNoZS1k ZWxldGUtaWMtb24tZGljdGlvbmFyeS5qczogQWRkZWQuCisgICAgICAgIChhc3NlcnQpOgorICAg ICAgICAoZm9vKToKKwogMjAyMC0wNC0wNyAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdA c29ueS5jb20+CiAKICAgICAgICAgVXBkYXRlIEpTVGVzdHMgdG8gYXNzdW1lIElDVSA2MCsKSW5k ZXg6IEpTVGVzdHMvc3RyZXNzL2RvbnQtY2FjaGUtZGVsZXRlLWljLW9uLWRpY3Rpb25hcnktMi5q cwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBKU1Rlc3RzL3N0cmVzcy9kb250LWNhY2hlLWRlbGV0ZS1pYy1vbi1k aWN0aW9uYXJ5LTIuanMJKG5vbmV4aXN0ZW50KQorKysgSlNUZXN0cy9zdHJlc3MvZG9udC1jYWNo ZS1kZWxldGUtaWMtb24tZGljdGlvbmFyeS0yLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEs MjUgQEAKK2Z1bmN0aW9uIGFzc2VydChiKSB7CisgICAgaWYgKCFiKQorICAgICAgICB0aHJvdyBu ZXcgRXJyb3I7Cit9CisKK2Z1bmN0aW9uIG1ha2VEaWN0aW9uYXJ5KCkgeworICAgIGxldCBvID0g e307CisgICAgZm9yIChsZXQgaSA9IDA7IGkgPCAxMDAwOyArK2kpCisgICAgICAgIG9bImYiICsg aV0gPSA0MjsKKyAgICByZXR1cm4gbzsKK30KKworZnVuY3Rpb24gZm9vKG8pIHsKKyAgICBkZWxl dGUgby54OworfQorCitsZXQgZCA9IG1ha2VEaWN0aW9uYXJ5KCk7Citmb3IgKGxldCBpID0gMDsg aSA8IDE1MDsgKytpKSB7CisgICAgZm9vKGQpOworfQorCitkLnggPSA0MjsKK2ZvbyhkKTsKKwor YXNzZXJ0KCFkLngpOwpJbmRleDogSlNUZXN0cy9zdHJlc3MvZG9udC1jYWNoZS1kZWxldGUtaWMt b24tZGljdGlvbmFyeS5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKU1Rlc3RzL3N0cmVzcy9kb250LWNhY2hl LWRlbGV0ZS1pYy1vbi1kaWN0aW9uYXJ5LmpzCShub25leGlzdGVudCkKKysrIEpTVGVzdHMvc3Ry ZXNzL2RvbnQtY2FjaGUtZGVsZXRlLWljLW9uLWRpY3Rpb25hcnkuanMJKHdvcmtpbmcgY29weSkK QEAgLTAsMCArMSwxNyBAQAorLy9AIHJ1bkRlZmF1bHQoIi0tcmVwYXRjaEJ1ZmZlcmluZ0NvdW50 ZG93bj04IiwgIi0tdXNlREZHSklUPTAiLCAiLS1qaXRQb2xpY3lTY2FsZT0wIiwgIi0tdXNlQ29u Y3VycmVudEpJVD0wIikKKworZnVuY3Rpb24gYXNzZXJ0KGIpIHsKKyAgICBpZiAoIWIpCisgICAg ICAgIHRocm93IG5ldyBFcnJvcjsKK30KKworZnVuY3Rpb24gZm9vKGkpIHsKKyAgICBPYmplY3Qu ZGVmaW5lUHJvcGVydHkoUmVmbGVjdCwgImdldCIsIHt9KTsKKyAgICBmb3IgKGxldCBpID0gMDsg aSA8IDI7IGkrKykgeworICAgICAgICBkZWxldGUgUmVmbGVjdC5nZXQ7CisgICAgfQorfQorCitm b3IgKGxldCBpPTA7IGk8MTAwOyBpKyspIHsKKyAgICBmb28oaSk7Cit9CkluZGV4OiBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI1OTY0OSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxOSBAQAorMjAyMC0wNC0wNyAg U2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KKworICAgICAgICBEZWxldGUgSUNzIGNh bid0IGNhY2hlIGRpY3Rpb25hcmllcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjEwMTQ3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82MTM4MjQwNT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSB3ZXJl IGhhcHBpbHkgY2FjaGluZyBkZWxldGUgSUMgY2FzZXMgb24gYSBkaWN0aW9uYXJ5IG9iamVjdC4K KyAgICAgICAgVGhpcyBpcyBjbGVhcmx5IHdyb25nLCBhcyB3ZSBtaWdodCBjYWNoZSBhIG1pc3Mg b24gYSBkaWN0aW9uYXJ5CisgICAgICAgIG9uIGEgcHJvcGVydHkgIlAiLCBldmVuIHRob3VnaCB3 ZSBtaWdodCBhZGQgIlAiIHRvIHRoZSBzdHJ1Y3R1cmUKKyAgICAgICAgd2l0aG91dCB0cmFuc2l0 aW9uaW5nIGl0LgorCisgICAgICAgICogaml0L1JlcGF0Y2guY3BwOgorICAgICAgICAoSlNDOjp0 cnlDYWNoZURlbGV0ZUJ5KToKKwogMjAyMC0wNC0wNyAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lA YXBwbGUuY29tPgogCiAgICAgICAgIFtKU0NdIFNjb3BlZEFyZ3VtZW50c1RhYmxlIHNob3VsZCBo YW5kbGUgT09NIGluIHRvbGVyYW50IG1hbm5lcgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3Jl L2ppdC9SZXBhdGNoLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0 L1JlcGF0Y2guY3BwCShyZXZpc2lvbiAyNTk2NDkpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUv aml0L1JlcGF0Y2guY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03NTYsNiArNzU2LDE2IEBAIHN0YXRp YyBJbmxpbmVDYWNoZUFjdGlvbiB0cnlDYWNoZURlbGV0ZUIKICAgICAgICAgaWYgKCFzbG90Lmlz Q2FjaGVhYmxlRGVsZXRlKCkpCiAgICAgICAgICAgICByZXR1cm4gR2l2ZVVwT25DYWNoZTsKIAor ICAgICAgICBpZiAoYmFzZVZhbHVlLmFzQ2VsbCgpLT5zdHJ1Y3R1cmUoKS0+aXNEaWN0aW9uYXJ5 KCkpIHsKKyAgICAgICAgICAgIGlmIChiYXNlVmFsdWUuYXNDZWxsKCktPnN0cnVjdHVyZSgpLT5o YXNCZWVuRmxhdHRlbmVkQmVmb3JlKCkpCisgICAgICAgICAgICAgICAgcmV0dXJuIEdpdmVVcE9u Q2FjaGU7CisgICAgICAgICAgICBqc0Nhc3Q8SlNPYmplY3QqPihiYXNlVmFsdWUpLT5mbGF0dGVu RGljdGlvbmFyeU9iamVjdCh2bSk7CisgICAgICAgICAgICByZXR1cm4gUmV0cnlDYWNoZUxhdGVy OworICAgICAgICB9CisKKyAgICAgICAgaWYgKG9sZFN0cnVjdHVyZS0+aXNEaWN0aW9uYXJ5KCkp CisgICAgICAgICAgICByZXR1cm4gUmV0cnlDYWNoZUxhdGVyOworCiAgICAgICAgIHN0ZDo6dW5p cXVlX3B0cjxBY2Nlc3NDYXNlPiBuZXdDYXNlOwogCiAgICAgICAgIGlmIChzbG90LmlzRGVsZXRl SGl0KCkpIHsK