210146 2020-04-07 13:16:24 -0700 [ews] Improve summary for CheckPatchRelevance build step 2020-04-08 09:19:55 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain ap jbedard webkit-bug-importer oldest_to_newest 1638759 0 aakash_jain 2020-04-07 13:16:24 -0700 [ews] Improve summary for CheckPatchRelevance build step. Currently, if the patch doesn't have any relevant changes, the message is: 'Checked patch relevance (failure)', which is incorrect since there was no failure. It should be "Patch doesn't contain relevant changes". 1638763 1 395729 aakash_jain 2020-04-07 13:19:22 -0700 Created attachment 395729 Patch 1638903 2 ews-feeder 2020-04-07 17:38:39 -0700 Committed r259694: <https://trac.webkit.org/changeset/259694> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395729. 1638904 3 webkit-bug-importer 2020-04-07 17:39:16 -0700 <rdar://problem/61420422> 1639086 4 aakash_jain 2020-04-08 09:19:55 -0700 Landed follow-up fix in r259719 since the failure message for CheckPatchRelevance needs to match with status-bubble code https://trac.webkit.org/browser/webkit/trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py#L277 395729 2020-04-07 13:19:22 -0700 2020-04-07 17:38:39 -0700 Patch bug-210146-20200407161921.patch text/plain 5430 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1OTY2NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDIwLTA0LTA3ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBJbXByb3ZlIHN1bW1hcnkgZm9yIENoZWNrUGF0Y2hSZWxldmFu Y2UgYnVpbGQgc3RlcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjEwMTQ2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHk6CisgICAgICAgIChD aGVja1BhdGNoUmVsZXZhbmNlKTogSW1wcm92ZWQgc3VjY2VzcyBtZXNzYWdlLgorICAgICAgICAo Q2hlY2tQYXRjaFJlbGV2YW5jZS5zdGFydCk6CisgICAgICAgIChDaGVja1BhdGNoUmVsZXZhbmNl LmdldFJlc3VsdFN1bW1hcnkpOiBJbXByb3ZlZCBmYWlsdXJlIG1lc3NhZ2UuCisgICAgICAgICog QnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5OiBVcGRhdGVkIHVu aXQtdGVzdHMuCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3Mvdmlld3Mv c3RhdHVzYnViYmxlLnB5OiBVcGRhdGVkIGFjY29yZGluZ2x5LgorCiAyMDIwLTA0LTA3ICBBYWth c2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNvbT4KIAogICAgICAgICBbZXdzXSBBZGQgdW5p dC10ZXN0IGZvciBDaGVja1BhdGNoUmVsZXZhbmNlIGJ1aWxkIHN0ZXAKSW5kZXg6IFRvb2xzL0J1 aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL3ZpZXdzL3N0YXR1c2J1YmJsZS5weQo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy92aWV3cy9zdGF0dXNi dWJibGUucHkJKHJldmlzaW9uIDI1OTY2NSkKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3 cy1hcHAvZXdzL3ZpZXdzL3N0YXR1c2J1YmJsZS5weQkod29ya2luZyBjb3B5KQpAQCAtNjIsNyAr NjIsNyBAQCBjbGFzcyBTdGF0dXNCdWJibGUoVmlldyk6CiAgICAgICAgICAgICAgICAgICAgICAn XkRvd25sb2FkZWQgYnVpbHQgcHJvZHVjdCQnLCAnXkV4dHJhY3RlZCBidWlsdCBwcm9kdWN0JCcs CiAgICAgICAgICAgICAgICAgICAgICAnXkNsZWFuZWQgYW5kIHVwZGF0ZWQgd29ya2luZyBkaXJl Y3RvcnkkJywgJ15DaGVja2VkIG91dCByZXF1aXJlZCByZXZpc2lvbiQnLCAnXlVwZGF0ZWQgd29y a2luZyBkaXJlY3RvcnkkJywKICAgICAgICAgICAgICAgICAgICAgICdeVmFsaWRhdGVkIHBhdGNo JCcsICdeS2lsbGVkIG9sZCBwcm9jZXNzZXMkJywgJ15Db25maWd1cmVkIGJ1aWxkJCcsICdeT1M6 LipYY29kZTonLCAnKHNraXBwZWQpJywKLSAgICAgICAgICAgICAgICAgICAgICdeUHJpbnRlZCBj b25maWd1cmF0aW9uJCcsICdeQ2hlY2tlZCBwYXRjaCByZWxldmFuY2UkJywgJ15EZWxldGVkIC5n aXQvaW5kZXgubG9jayQnLAorICAgICAgICAgICAgICAgICAgICAgJ15QcmludGVkIGNvbmZpZ3Vy YXRpb24kJywgJ15QYXRjaCBjb250YWlucyByZWxldmFudCBjaGFuZ2VzJCcsICdeRGVsZXRlZCAu Z2l0L2luZGV4LmxvY2skJywKICAgICAgICAgICAgICAgICAgICAgICdedHJpZ2dlcmVkLiokJywg J15Gb3VuZCBtb2RpZmllZCBDaGFuZ2VMb2dzJCcsICdeQ3JlYXRlZCBsb2NhbCBnaXQgY29tbWl0 JCcsICdeU2V0IGJ1aWxkIHN1bW1hcnkkJywKICAgICAgICAgICAgICAgICAgICAgICdeVmFsaWRh dGVkIGNvbW1pdGVyJCcsICdeVmFsaWRhdGVkIGNvbW1pdGVyIGFuZCByZXZpZXdlciQnLCAnXlZh bGlkYXRlZCBDaGFuZ2VMb2cgYW5kIFJldmlld2VyJCcsCiAgICAgICAgICAgICAgICAgICAgICAn XlJlbW92ZWQgZmxhZ3Mgb24gYnVnemlsbGEgcGF0Y2gkJywgJ15DaGVja2VkIHBhdGNoIHN0YXR1 cyBvbiBvdGhlciBxdWV1ZXMkJ10KSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1i dWlsZC9zdGVwcy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3Mt YnVpbGQvc3RlcHMucHkJKHJldmlzaW9uIDI1OTY2NSkKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBw b3J0L2V3cy1idWlsZC9zdGVwcy5weQkod29ya2luZyBjb3B5KQpAQCAtMjQzLDcgKzI0Myw3IEBA IGNsYXNzIEFwcGx5UGF0Y2goc2hlbGwuU2hlbGxDb21tYW5kLCBDb20KIGNsYXNzIENoZWNrUGF0 Y2hSZWxldmFuY2UoYnVpbGRzdGVwLkJ1aWxkU3RlcCk6CiAgICAgbmFtZSA9ICdjaGVjay1wYXRj aC1yZWxldmFuY2UnCiAgICAgZGVzY3JpcHRpb24gPSBbJ2NoZWNrLXBhdGNoLXJlbGV2YW5jZSBy dW5uaW5nJ10KLSAgICBkZXNjcmlwdGlvbkRvbmUgPSBbJ0NoZWNrZWQgcGF0Y2ggcmVsZXZhbmNl J10KKyAgICBkZXNjcmlwdGlvbkRvbmUgPSBbJ1BhdGNoIGNvbnRhaW5zIHJlbGV2YW50IGNoYW5n ZXMnXQogICAgIGZsdW5rT25GYWlsdXJlID0gVHJ1ZQogICAgIGhhbHRPbkZhaWx1cmUgPSBUcnVl CiAKQEAgLTMzMiwxMiArMzMyLDE2IEBAIGNsYXNzIENoZWNrUGF0Y2hSZWxldmFuY2UoYnVpbGRz dGVwLkJ1aWwKICAgICAgICAgICAgIHNlbGYuZmluaXNoZWQoU1VDQ0VTUykKICAgICAgICAgICAg IHJldHVybiBOb25lCiAKLSAgICAgICAgc2VsZi5fYWRkVG9Mb2coJ3N0ZGlvJywgJ1RoaXMgcGF0 Y2ggZG9lcyBub3QgaGF2ZSByZWxldmFudCBjaGFuZ2VzLicpCisgICAgICAgIHNlbGYuX2FkZFRv TG9nKCdzdGRpbycsICdUaGlzIHBhdGNoIGRvZXMgbm90IGNvbnRhaW4gcmVsZXZhbnQgY2hhbmdl cy4nKQogICAgICAgICBzZWxmLmZpbmlzaGVkKEZBSUxVUkUpCiAgICAgICAgIHNlbGYuYnVpbGQu cmVzdWx0cyA9IFNLSVBQRUQKLSAgICAgICAgc2VsZi5idWlsZC5idWlsZEZpbmlzaGVkKFsnUGF0 Y2gge30gZG9lc25cJ3QgaGF2ZSByZWxldmFudCBjaGFuZ2VzJy5mb3JtYXQoc2VsZi5nZXRQcm9w ZXJ0eSgncGF0Y2hfaWQnLCAnJykpXSwgU0tJUFBFRCkKKyAgICAgICAgc2VsZi5idWlsZC5idWls ZEZpbmlzaGVkKFsnUGF0Y2gge30gZG9lc25cJ3QgY29udGFpbiByZWxldmFudCBjaGFuZ2VzJy5m b3JtYXQoc2VsZi5nZXRQcm9wZXJ0eSgncGF0Y2hfaWQnLCAnJykpXSwgU0tJUFBFRCkKICAgICAg ICAgcmV0dXJuIE5vbmUKIAorICAgIGRlZiBnZXRSZXN1bHRTdW1tYXJ5KHNlbGYpOgorICAgICAg ICBpZiBzZWxmLnJlc3VsdHMgPT0gRkFJTFVSRToKKyAgICAgICAgICAgIHJldHVybiB7dSdzdGVw JzogdSdQYXRjaCBkb2VzblwndCBjb250YWluIHJlbGV2YW50IGNoYW5nZXMnfQorICAgICAgICBy ZXR1cm4gc3VwZXIoQ2hlY2tQYXRjaFJlbGV2YW5jZSwgc2VsZikuZ2V0UmVzdWx0U3VtbWFyeSgp CiAKIGNsYXNzIEJ1Z3ppbGxhTWl4aW4ob2JqZWN0KToKICAgICBhZGRVUkxzID0gRmFsc2UKSW5k ZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwc191bml0dGVzdC5weQo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5p dHRlc3QucHkJKHJldmlzaW9uIDI1OTY2NSkKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3 cy1idWlsZC9zdGVwc191bml0dGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAtMjE2NSw3ICsyMTY1 LDcgQEAgY2xhc3MgVGVzdENoZWNrUGF0Y2hSZWxldmFuY2UoQnVpbGRTdGVwTQogICAgICAgICBz ZWxmLnNldFByb3BlcnR5KCdidWlsZGVybmFtZScsICdKU0MtVGVzdHMtRVdTJykKICAgICAgICAg c2VsZi5hc3NlcnRFcXVhbChDaGVja1BhdGNoUmVsZXZhbmNlLmhhbHRPbkZhaWx1cmUsIFRydWUp CiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoQ2hlY2tQYXRjaFJlbGV2YW5jZS5mbHVua09uRmFp bHVyZSwgVHJ1ZSkKLSAgICAgICAgc2VsZi5leHBlY3RPdXRjb21lKHJlc3VsdD1TVUNDRVNTLCBz dGF0ZV9zdHJpbmc9J0NoZWNrZWQgcGF0Y2ggcmVsZXZhbmNlJykKKyAgICAgICAgc2VsZi5leHBl Y3RPdXRjb21lKHJlc3VsdD1TVUNDRVNTLCBzdGF0ZV9zdHJpbmc9J1BhdGNoIGNvbnRhaW5zIHJl bGV2YW50IGNoYW5nZXMnKQogICAgICAgICByZXR1cm4gc2VsZi5ydW5TdGVwKCkKIAogICAgIGRl ZiB0ZXN0X3F1ZXVlX3dpdGhvdXRfcmVsZXZhbmNlX2luZm8oc2VsZik6CkBAIC0yMTczLDcgKzIx NzMsNyBAQCBjbGFzcyBUZXN0Q2hlY2tQYXRjaFJlbGV2YW5jZShCdWlsZFN0ZXBNCiAgICAgICAg IHNlbGYuc2V0dXBTdGVwKENoZWNrUGF0Y2hSZWxldmFuY2UoKSkKICAgICAgICAgc2VsZi5zZXRQ cm9wZXJ0eSgnYnVpbGRlcm5hbWUnLCAnQ29tbWl0LVF1ZXVlJykKICAgICAgICAgQ2hlY2tQYXRj aFN0YXR1c09uRVdTUXVldWVzLmdldF9wYXRjaF9zdGF0dXMgPSBsYW1iZGEgY2xzLCBwYXRjaF9p ZCwgcXVldWU6IEZBSUxVUkUKLSAgICAgICAgc2VsZi5leHBlY3RPdXRjb21lKHJlc3VsdD1TVUND RVNTLCBzdGF0ZV9zdHJpbmc9J0NoZWNrZWQgcGF0Y2ggcmVsZXZhbmNlJykKKyAgICAgICAgc2Vs Zi5leHBlY3RPdXRjb21lKHJlc3VsdD1TVUNDRVNTLCBzdGF0ZV9zdHJpbmc9J1BhdGNoIGNvbnRh aW5zIHJlbGV2YW50IGNoYW5nZXMnKQogICAgICAgICByZXR1cm4gc2VsZi5ydW5TdGVwKCkKIAog ICAgIGRlZiB0ZXN0X25vbl9yZWxldmFudF9wYXRjaChzZWxmKToKQEAgLTIxODIsNyArMjE4Miw3 IEBAIGNsYXNzIFRlc3RDaGVja1BhdGNoUmVsZXZhbmNlKEJ1aWxkU3RlcE0KICAgICAgICAgc2Vs Zi5zZXRQcm9wZXJ0eSgnYnVpbGRlcm5hbWUnLCAnSlNDLVRlc3RzLUVXUycpCiAgICAgICAgIHNl bGYuc2V0UHJvcGVydHkoJ3BhdGNoX2lkJywgJzEyMzQnKQogICAgICAgICBDaGVja1BhdGNoU3Rh dHVzT25FV1NRdWV1ZXMuZ2V0X3BhdGNoX3N0YXR1cyA9IGxhbWJkYSBjbHMsIHBhdGNoX2lkLCBx dWV1ZTogRkFJTFVSRQotICAgICAgICBzZWxmLmV4cGVjdE91dGNvbWUocmVzdWx0PUZBSUxVUkUs IHN0YXRlX3N0cmluZz0nQ2hlY2tlZCBwYXRjaCByZWxldmFuY2UgKGZhaWx1cmUpJykKKyAgICAg ICAgc2VsZi5leHBlY3RPdXRjb21lKHJlc3VsdD1GQUlMVVJFLCBzdGF0ZV9zdHJpbmc9J1BhdGNo IGRvZXNuXCd0IGNvbnRhaW4gcmVsZXZhbnQgY2hhbmdlcycpCiAgICAgICAgIHJldHVybiBzZWxm LnJ1blN0ZXAoKQogCiAK