210137 2020-04-07 11:50:29 -0700 Web Automation: Automation.inspectBrowsingContext should bring Web Inspector to front automatically 2020-04-07 13:08:13 -0700 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg bburg hi joepeck webkit-bug-importer oldest_to_newest 1638697 0 bburg 2020-04-07 11:50:29 -0700 . 1638705 1 395719 bburg 2020-04-07 11:56:45 -0700 Created attachment 395719 Patch 1638738 2 395719 joepeck 2020-04-07 12:46:20 -0700 Comment on attachment 395719 Patch rs=me 1638739 3 395719 hi 2020-04-07 12:48:28 -0700 Comment on attachment 395719 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395719&action=review r=me > Source/WebKit/UIProcess/Automation/mac/WebAutomationSessionMac.mm:59 > if (page->inspector()) { NIT: why not save this result so you don't have to call it again? ``` if (auto* inspector = page->inspector()) inspector->show(); ``` 1638751 4 ews-feeder 2020-04-07 13:07:52 -0700 Committed r259665: <https://trac.webkit.org/changeset/259665> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395719. 1638754 5 webkit-bug-importer 2020-04-07 13:08:13 -0700 <rdar://problem/61406816> 395719 2020-04-07 11:56:45 -0700 2020-04-07 13:07:52 -0700 Patch bug-210137-20200407115644.patch text/plain 1946 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5MjM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDVkNWQ1MDlhZTk4OWM4ZDFk NDUzNTAzY2ZlNDk2NjY4ZTI5ZDFhNDYuLmMyYzMyN2YzMDhkYmExZmIxZDlkMjE5ZjYzOTllNzE4 MjI1ZGVmY2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMDQtMDcgIEJyaWFuIEJ1 cmcgIDxiYnVyZ0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEF1dG9tYXRpb246IEF1dG9tYXRp b24uaW5zcGVjdEJyb3dzaW5nQ29udGV4dCBzaG91bGQgYnJpbmcgV2ViIEluc3BlY3RvciB0byBm cm9udCBhdXRvbWF0aWNhbGx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMTAxMzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIFVJUHJvY2Vzcy9BdXRvbWF0aW9uL21hYy9XZWJBdXRvbWF0aW9uU2Vzc2lv bk1hYy5tbToKKyAgICAgICAgKFdlYktpdDo6V2ViQXV0b21hdGlvblNlc3Npb246Omluc3BlY3RC cm93c2luZ0NvbnRleHQpOgorICAgICAgICBQcmV2aW91c2x5LCBjYWxsaW5nIGNvbm5lY3QoKSB3 b3VsZCBwcmVsb2FkIFdlYiBJbnNwZWN0b3IgYnV0IG5vdCBzaG93IGl0cyB3aW5kb3cuIFRoaXMK KyAgICAgICAgbWFkZSBpdCBhd2t3YXJkIHRvIHVzZSB0aGUgJ3NhZmFyaTphdXRvbWF0aWNJbnNw ZWN0aW9uJyBjYXBhYmlsaXR5IHdpdGhvdXQgc3Vic2VxdWVudGx5CisgICAgICAgIGV2YWx1YXRp bmcgYSBgZGVidWdnZXI7YCBzdGF0ZW1lbnQgdG8gYnJpbmcgV2ViIEluc3BlY3RvciB0byBmcm9u dC4KKwogMjAyMC0wMy0zMCAgUGVyIEFybmUgVm9sbGFuICA8cHZvbGxhbkBhcHBsZS5jb20+CiAK ICAgICAgICAgVW5yZXZpZXdlZCBidWlsZCBmaXggYWZ0ZXIgcjI1OTIwMC4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0F1dG9tYXRpb24vbWFjL1dlYkF1dG9tYXRpb25TZXNz aW9uTWFjLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQXV0b21hdGlvbi9tYWMvV2ViQXV0 b21hdGlvblNlc3Npb25NYWMubW0KaW5kZXggMTE3ZGZkNGFmZTE4MWQyZjk0NjM0YmExMGJlNzhi YzY5NzA4Mzk3Ny4uZTdlYjA3OGMyZGIxZGFjYTMzNTU2YmEzNjEyY2U4ZWE2ZDU3YjU3MCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQXV0b21hdGlvbi9tYWMvV2ViQXV0b21h dGlvblNlc3Npb25NYWMubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQXV0b21hdGlv bi9tYWMvV2ViQXV0b21hdGlvblNlc3Npb25NYWMubW0KQEAgLTU3LDcgKzU3LDcgQEAgdm9pZCBX ZWJBdXRvbWF0aW9uU2Vzc2lvbjo6aW5zcGVjdEJyb3dzaW5nQ29udGV4dChjb25zdCBTdHJpbmcm IGhhbmRsZSwgY29uc3QgYm8KICAgICAvLyBEb24ndCBicmluZyB0aGUgaW5zcGVjdG9yIHRvIGZy b250IHNpbmNlIHRoaXMgbWF5IGJlIGRvbmUgYXV0b21hdGljYWxseS4KICAgICAvLyBXZSBqdXN0 IHdhbnQgaXQgbG9hZGVkIHNvIGl0IGNhbiBwYXVzZSBpZiBhIGJyZWFrcG9pbnQgaXMgaGl0IGR1 cmluZyBhIGNvbW1hbmQuCiAgICAgaWYgKHBhZ2UtPmluc3BlY3RvcigpKSB7Ci0gICAgICAgIHBh Z2UtPmluc3BlY3RvcigpLT5jb25uZWN0KCk7CisgICAgICAgIHBhZ2UtPmluc3BlY3RvcigpLT5z aG93KCk7CiAKICAgICAgICAgLy8gU3RhcnQgY29sbGVjdGluZyBwcm9maWxlIGluZm9ybWF0aW9u IGltbWVkaWF0ZWx5IHNvIHRoZSBlbnRpcmUgc2Vzc2lvbiBpcyBjYXB0dXJlZC4KICAgICAgICAg aWYgKG9wdGlvbmFsRW5hYmxlQXV0b0NhcHR1cmluZyAmJiAqb3B0aW9uYWxFbmFibGVBdXRvQ2Fw dHVyaW5nKQo=