210131 2020-04-07 10:14:46 -0700 WKUserScripts deferred from injection are not injected if -[WKWebView _notifyUserScripts] is called early 2020-04-07 11:37:50 -0700 1 1 1 Unclassified WebKit WebKit API WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy achristensen beidson thorton webkit-bug-importer oldest_to_newest 1638616 0 timothy 2020-04-07 10:14:46 -0700 If -[WKWebView _notifyUserScripts] is called early, before Frame::injectUserScripts() happens, pageWasNotified will still be false, allowing scripts to build up in m_userScriptsAwaitingNotification and never being injected (since -[WKWebView _notifyUserScripts] will not be called again). 1638648 1 395710 timothy 2020-04-07 11:03:19 -0700 Created attachment 395710 Patch 1638658 2 timothy 2020-04-07 11:16:03 -0700 <rdar://problem/61368446> 1638659 3 webkit-bug-importer 2020-04-07 11:16:25 -0700 <rdar://problem/61401382> 1638660 4 timothy 2020-04-07 11:17:31 -0700 <rdar://problem/61368446> 1638671 5 ews-feeder 2020-04-07 11:37:49 -0700 Committed r259650: <https://trac.webkit.org/changeset/259650> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395710. 395710 2020-04-07 11:03:19 -0700 2020-04-07 11:37:49 -0700 Patch bug-210131-20200407110319.patch text/plain 3872 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5NjE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODhjMjA2NzU2ODllNWEz NmY1NmYyZTU3ZGI0OTZiOGZiMjI3Yzc5Zi4uZmY4MzJkMmI0NjY0NGQ0NTE1OTIxOGE4YjZmOTdl MjZmNmYyMTFkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTA0LTA3ICBUaW1v dGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KKworICAgICAgICBXS1VzZXJTY3JpcHRz IGRlZmVycmVkIGZyb20gaW5qZWN0aW9uIGFyZSBub3QgaW5qZWN0ZWQgaWYgLVtXS1dlYlZpZXcg X25vdGlmeVVzZXJTY3JpcHRzXSBpcyBjYWxsZWQgZWFybHkuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTAxMzEKKyAgICAgICAgcmRhcjovL3Byb2Js ZW0vNjEzNjg0NDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBJZiBQYWdlOjpub3RpZnlUb0luamVjdFVzZXJTY3JpcHRzKCkgaXMgY2FsbGVkIGVhcmx5 LCBiZWZvcmUgRnJhbWU6OmluamVjdFVzZXJTY3JpcHRzKCkgaGFwcGVucywKKyAgICAgICAgbV9o YXNCZWVuTm90aWZpZWRUb0luamVjdFVzZXJTY3JpcHRzIHdpbGwgYmUgZmFsc2UsIGFsbG93aW5n IHNjcmlwdHMgdG8gYnVpbGQgdXAgaW4gbV91c2VyU2NyaXB0c0F3YWl0aW5nTm90aWZpY2F0aW9u CisgICAgICAgIGFuZCBuZXZlciBiZWluZyBpbmplY3RlZCAoc2luY2UgUGFnZTo6bm90aWZ5VG9J bmplY3RVc2VyU2NyaXB0cygpIHdpbGwgbm90IGJlIGNhbGxlZCBhZ2FpbikuCisKKyAgICAgICAg KiBwYWdlL1BhZ2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGFnZTo6bm90aWZ5VG9JbmplY3RV c2VyU2NyaXB0cyk6IFNldCBtX2hhc0JlZW5Ob3RpZmllZFRvSW5qZWN0VXNlclNjcmlwdHMgdG8g dHJ1ZSB3aGVuIGNhbGxlZC4KKwogMjAyMC0wNC0wNiAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0Bh cHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogYGNvbnNvbGUubG9nKC4uLilgIGFw cGVhciBhcyBgQ09OU09MRSBMT0cgTE9HYCBpbiB0aGUgc3lzdGVtIGNvbnNvbGUKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1Bh Z2UuY3BwCmluZGV4IDg0NDQ5MTI4ZDZmMGJiODQ5ZWNiMGRmMjE5OTdhMjMzNGRkMTAyODguLjIz MmZkNDMwNzk3MjY0MjI0MDJhZTY0NmM0ZmE4MDNlYjU2MDQ1NjggMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvUGFnZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmNw cApAQCAtMjQ3OSwxMCArMjQ3OSwxMyBAQCBVc2VyQ29udGVudFByb3ZpZGVyJiBQYWdlOjp1c2Vy Q29udGVudFByb3ZpZGVyKCkKIAogdm9pZCBQYWdlOjpub3RpZnlUb0luamVjdFVzZXJTY3JpcHRz KCkKIHsKKyAgICBtX2hhc0JlZW5Ob3RpZmllZFRvSW5qZWN0VXNlclNjcmlwdHMgPSB0cnVlOwor CiAgICAgZm9yIChhdXRvKiBmcmFtZSA9ICZtYWluRnJhbWUoKTsgZnJhbWU7IGZyYW1lID0gZnJh bWUtPnRyZWUoKS50cmF2ZXJzZU5leHQoKSkgewogICAgICAgICBmb3IgKGNvbnN0IGF1dG8mIHBh aXIgOiBtX3VzZXJTY3JpcHRzQXdhaXRpbmdOb3RpZmljYXRpb24pCiAgICAgICAgICAgICBmcmFt ZS0+aW5qZWN0VXNlclNjcmlwdEltbWVkaWF0ZWx5KHBhaXIuZmlyc3QsIHBhaXIuc2Vjb25kLmdl dCgpKTsKICAgICB9CisKICAgICBtX3VzZXJTY3JpcHRzQXdhaXRpbmdOb3RpZmljYXRpb24uY2xl YXIoKTsKIH0KIApkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9n CmluZGV4IDI3MDEyNTE1ODIwYjJlOGM3MjQ0YjgxYmViMDY3ZWZiMGZjM2ZhYjQuLjA2YjA4ZGIx NzM2NTlkZTE4ZDc0ZDcwNGU0Y2Q4M2VlYjcyOTQ1NDUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5n ZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAyMC0wNC0wNyAg VGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5jb20+CisKKyAgICAgICAgV0tVc2VyU2Ny aXB0cyBkZWZlcnJlZCBmcm9tIGluamVjdGlvbiBhcmUgbm90IGluamVjdGVkIGlmIC1bV0tXZWJW aWV3IF9ub3RpZnlVc2VyU2NyaXB0c10gaXMgY2FsbGVkIGVhcmx5LgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEwMTMxCisgICAgICAgIHJkYXI6Ly9w cm9ibGVtLzYxMzY4NDQ2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1VzZXJDb250ZW50Q29u dHJvbGxlci5tbToKKyAgICAgICAgKFRFU1QpOgorCiAyMDIwLTA0LTA2ICBEb24gT2xtc3RlYWQg IDxkb24ub2xtc3RlYWRAc29ueS5jb20+CiAKICAgICAgICAgW0NNYWtlXSBVc2UgV0VCS0lUX0VY RUNVVEFCTEUgaW4gRHVtcFJlbmRlclRyZWUKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRB UEkvVGVzdHMvV2ViS2l0Q29jb2EvVXNlckNvbnRlbnRDb250cm9sbGVyLm1tIGIvVG9vbHMvVGVz dFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9Vc2VyQ29udGVudENvbnRyb2xsZXIubW0KaW5k ZXggMWE2NTNkNzJmYjY1NmE4YmViZWZiMjlmODNhMmFiNzM2NTFhZDg2ZS4uOTQxMmE0ZjU2ZmM2 ZDQ3OTcxYTRhZWJjZWY1OWM5NGRhNWI2N2Y0NCAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktp dEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9Vc2VyQ29udGVudENvbnRyb2xsZXIubW0KKysrIGIvVG9v bHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9Vc2VyQ29udGVudENvbnRyb2xsZXIu bW0KQEAgLTg0Myw0ICs4NDMsMTUgQEAgVEVTVChXS1VzZXJDb250ZW50Q29udHJvbGxlciwgVXNl clNjcmlwdE5vdGlmaWNhdGlvbikKICAgICBbd2ViVmlldzIgbG9hZFRlc3RQYWdlTmFtZWQ6QCJz aW1wbGUiXTsKICAgICBFWFBFQ1RfV0tfU1RSRVEoW2RlbGVnYXRlIHdhaXRGb3JBbGVydF0sICJ3 YWl0ZWQgZm9yIG5vdGlmaWNhdGlvbiIpOwogICAgIEVYUEVDVF9XS19TVFJFUShbZGVsZWdhdGUg d2FpdEZvckFsZXJ0XSwgImRvY3VtZW50IHBhcnNpbmcgZW5kZWQiKTsKKworICAgIFRlc3RXS1dl YlZpZXcgKndlYlZpZXczID0gW1tUZXN0V0tXZWJWaWV3IG5ld10gYXV0b3JlbGVhc2VdOworICAg IEVYUEVDVF9UUlVFKHdlYlZpZXczLl9kZWZlcnJhYmxlVXNlclNjcmlwdHNOZWVkTm90aWZpY2F0 aW9uKTsKKyAgICBbd2ViVmlldzMuY29uZmlndXJhdGlvbi51c2VyQ29udGVudENvbnRyb2xsZXIg YWRkVXNlclNjcmlwdDp3YWl0c0Zvck5vdGlmaWNhdGlvbl07CisgICAgW3dlYlZpZXczLmNvbmZp Z3VyYXRpb24udXNlckNvbnRlbnRDb250cm9sbGVyIGFkZFVzZXJTY3JpcHQ6ZG9jdW1lbnRFbmRd OworICAgIHdlYlZpZXczLlVJRGVsZWdhdGUgPSBkZWxlZ2F0ZTsKKyAgICBbd2ViVmlldzMgbG9h ZFRlc3RQYWdlTmFtZWQ6QCJzaW1wbGUiXTsKKyAgICBbd2ViVmlldzMgX25vdGlmeVVzZXJTY3Jp cHRzXTsKKyAgICBFWFBFQ1RfRkFMU0Uod2ViVmlldzMuX2RlZmVycmFibGVVc2VyU2NyaXB0c05l ZWROb3RpZmljYXRpb24pOworICAgIEVYUEVDVF9XS19TVFJFUShbZGVsZWdhdGUgd2FpdEZvckFs ZXJ0XSwgIndhaXRlZCBmb3Igbm90aWZpY2F0aW9uIik7CisgICAgRVhQRUNUX1dLX1NUUkVRKFtk ZWxlZ2F0ZSB3YWl0Rm9yQWxlcnRdLCAiZG9jdW1lbnQgcGFyc2luZyBlbmRlZCIpOwogfQo=