210111 2020-04-07 07:28:02 -0700 documentFragment.getElementById() should not work for empty-string IDs 2020-04-07 11:41:19 -0700 1 1 1 Unclassified WebKit DOM Safari Technology Preview Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 d cdumez achristensen cdumez esprehn+autocc ews-watchlist ggaren kangil.han rniwa webkit-bug-importer youennf oldest_to_newest 1638528 0 d 2020-04-07 07:28:02 -0700 (This is tested using the bots on wpt.fyi; I do not have a Mac available in these working from home times.) URL: http://wpt.live/dom/nodes/DocumentFragment-getElementById.html Per spec, documentFragment.getElementById("") should return null, even if there is a <div id=""></div> inside the DocumentFragment. Safari passes the same test for document.getElementById(""): http://wpt.live/dom/nodes/Document-getElementById.html . Other browsers: Chrome fails, Firefox passes Spec reference: https://dom.spec.whatwg.org/#concept-id ("value is null or the empty string"). 1638626 1 395702 cdumez 2020-04-07 10:28:44 -0700 Created attachment 395702 Patch 1638663 2 395702 ggaren 2020-04-07 11:19:59 -0700 Comment on attachment 395702 Patch r=me 1638675 3 ews-feeder 2020-04-07 11:40:12 -0700 Committed r259651: <https://trac.webkit.org/changeset/259651> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395702. 1638677 4 webkit-bug-importer 2020-04-07 11:41:19 -0700 <rdar://problem/61402774> 395702 2020-04-07 10:28:44 -0700 2020-04-07 11:40:13 -0700 Patch bug-210111-20200407102843.patch text/plain 6331 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5NjM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOThmN2I0ZDRjNzY2N2Q3 ZWU3MzQ0Y2UxMTI0MGViMTgxZDM3NDYzMi4uN2I0MzAyZDIxZWQxYjVmMTc4NzcyZjM4NjNmNTRi ZDgyYzE5MTc5YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIwLTA0LTA3ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgZG9jdW1lbnRGcmFnbWVudC5n ZXRFbGVtZW50QnlJZCgpIHNob3VsZCBub3Qgd29yayBmb3IgZW1wdHktc3RyaW5nIElEcworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEwMTExCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSBzdXJlIHRo YXQgZ2V0RWxlbWVudEJ5SWQoKSByZXR1cm5zIG51bGwgd2hlbiBnaXZlbiBhbiBlbXB0eSBzdHJp bmcgSUQ6CisgICAgICAgIC0gaHR0cHM6Ly9kb20uc3BlYy53aGF0d2cub3JnLyNjb25jZXB0LWlk CisKKyAgICAgICAgVGVzdDogaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9kb20vbm9k ZXMvRG9jdW1lbnRGcmFnbWVudC1nZXRFbGVtZW50QnlJZC5odG1sCisKKyAgICAgICAgKiBkb20v RG9jdW1lbnRGcmFnbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudEZyYWdtZW50 OjpnZXRFbGVtZW50QnlJZCBjb25zdCk6CisgICAgICAgICogZG9tL1RyZWVTY29wZS5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpUcmVlU2NvcGU6OmdldEVsZW1lbnRCeUlkIGNvbnN0KToKKwogMjAy MC0wNC0wNyAgQW5kcmVzIEdvbnphbGV6ICA8YW5kcmVzZ18yMkBhcHBsZS5jb20+CiAKICAgICAg ICAgSW5pdGlhbGl6YXRpb24gb2YgbW9kYWwgbm9kZXMgc2hvdWxkIGhhcHBlbiBsYXppbHksIG5v dCBpbiB0aGUgQVhPYmplY3RDYWNoZSBjb25zdHJ1Y3Rvci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2RvbS9Eb2N1bWVudEZyYWdtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1 bWVudEZyYWdtZW50LmNwcAppbmRleCAyYTI1YWIyZTVhYTc2Nzk2NTA4MzcwYWVmYTI5MWU3MmM3 YzFjNjc3Li45Y2UxZWJkMWFlZWRjYjMzMjZlYzQwNmUyNGNmZDY0YWNiNWVkNzdmIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnRGcmFnbWVudC5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvZG9tL0RvY3VtZW50RnJhZ21lbnQuY3BwCkBAIC05NSw3ICs5NSw3IEBAIGJvb2wg RG9jdW1lbnRGcmFnbWVudDo6cGFyc2VYTUwoY29uc3QgU3RyaW5nJiBzb3VyY2UsIEVsZW1lbnQq IGNvbnRleHRFbGVtZW50LCBQCiAKIEVsZW1lbnQqIERvY3VtZW50RnJhZ21lbnQ6OmdldEVsZW1l bnRCeUlkKGNvbnN0IEF0b21TdHJpbmcmIGlkKSBjb25zdAogewotICAgIGlmIChpZC5pc051bGwo KSkKKyAgICBpZiAoaWQuaXNFbXB0eSgpKQogICAgICAgICByZXR1cm4gbnVsbHB0cjsKIAogICAg IC8vIEZhc3QgcGF0aCBmb3IgU2hhZG93Um9vdCwgd2hlcmUgd2UgYXJlIGJvdGggYSBEb2N1bWVu dEZyYWdtZW50IGFuZCBhIFRyZWVTY29wZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Rv bS9UcmVlU2NvcGUuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL1RyZWVTY29wZS5jcHAKaW5kZXgg MWFlMzYxMzhiZDk5YTE1MjNkMzU0Y2YxOGVhNGY5MTczNjMyMzQ5MS4uMWRhYTg1ODhkZjUzOTBh ZjgxMzFlMGRhZjA5N2E4OWZiNTc3YTU5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9t L1RyZWVTY29wZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL1RyZWVTY29wZS5jcHAKQEAg LTEwMCw3ICsxMDAsNyBAQCB2b2lkIFRyZWVTY29wZTo6c2V0UGFyZW50VHJlZVNjb3BlKFRyZWVT Y29wZSYgbmV3UGFyZW50U2NvcGUpCiAKIEVsZW1lbnQqIFRyZWVTY29wZTo6Z2V0RWxlbWVudEJ5 SWQoY29uc3QgQXRvbVN0cmluZyYgZWxlbWVudElkKSBjb25zdAogewotICAgIGlmIChlbGVtZW50 SWQuaXNOdWxsKCkpCisgICAgaWYgKGVsZW1lbnRJZC5pc0VtcHR5KCkpCiAgICAgICAgIHJldHVy biBudWxscHRyOwogICAgIGlmICghbV9lbGVtZW50c0J5SWQpCiAgICAgICAgIHJldHVybiBudWxs cHRyOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZyBiL0xh eW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKaW5kZXggY2Q4YzI1Mjk5YTU0OWE0YjJm OTYwNjM4NGE5MzE3OWMyNDE5Zjk4YS4uZmM3MDQ4MzAxZGU0YjFhYTYxZDBjNzMwOWVkYjE2NGY3 MmUxYjBmMCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwor KysgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMjAtMDQtMDcgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBk b2N1bWVudEZyYWdtZW50LmdldEVsZW1lbnRCeUlkKCkgc2hvdWxkIG5vdCB3b3JrIGZvciBlbXB0 eS1zdHJpbmcgSURzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMTAxMTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBJbXBvcnQgdGVzdCBjb3ZlcmFnZSBmcm9tIHVwc3RyZWFtIFdQVC4KKworICAgICAgICAq IHdlYi1wbGF0Zm9ybS10ZXN0cy9kb20vbm9kZXMvRG9jdW1lbnRGcmFnbWVudC1nZXRFbGVtZW50 QnlJZC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIHdlYi1wbGF0Zm9ybS10ZXN0cy9k b20vbm9kZXMvRG9jdW1lbnRGcmFnbWVudC1nZXRFbGVtZW50QnlJZC5odG1sOiBBZGRlZC4KKwog MjAyMC0wNC0wNiAgQW50b2luZSBRdWludCAgPGdyYW91dHNAYXBwbGUuY29tPgogCiAgICAgICAg IFtXZWIgQW5pbWF0aW9uc10gTW92ZSBEb2N1bWVudC5nZXRBbmltYXRpb25zKCkgdG8gRG9jdW1l bnRPclNoYWRvd1Jvb3QKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWIt cGxhdGZvcm0tdGVzdHMvZG9tL25vZGVzL0RvY3VtZW50RnJhZ21lbnQtZ2V0RWxlbWVudEJ5SWQt ZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0 cy9kb20vbm9kZXMvRG9jdW1lbnRGcmFnbWVudC1nZXRFbGVtZW50QnlJZC1leHBlY3RlZC50eHQK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMC4uNGJhMmQxZTg3NDhmNjBmZmFmZjAwMTYyY2I5ZWJiNzgwODFiMThjZQotLS0g L2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVz dHMvZG9tL25vZGVzL0RvY3VtZW50RnJhZ21lbnQtZ2V0RWxlbWVudEJ5SWQtZXhwZWN0ZWQudHh0 CkBAIC0wLDAgKzEsNyBAQAorCitQQVNTIFRoZSBtZXRob2QgbXVzdCBleGlzdCAKK1BBU1MgSXQg bXVzdCByZXR1cm4gbnVsbCB3aGVuIHRoZXJlIGFyZSBubyBtYXRjaGVzIAorUEFTUyBJdCBtdXN0 IHJldHVybiB0aGUgZmlyc3QgZWxlbWVudCB3aGVuIHRoZXJlIGFyZSBtYXRjaGVzIAorUEFTUyBF bXB0eSBzdHJpbmcgSUQgdmFsdWVzIAorUEFTUyBJdCBtdXN0IHJldHVybiB0aGUgZmlyc3QgZWxl bWVudCB3aGVuIHRoZXJlIGFyZSBtYXRjaGVzLCB1c2luZyBhIHRlbXBsYXRlIAorCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2RvbS9ub2Rl cy9Eb2N1bWVudEZyYWdtZW50LWdldEVsZW1lbnRCeUlkLmh0bWwgYi9MYXlvdXRUZXN0cy9pbXBv cnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2RvbS9ub2Rlcy9Eb2N1bWVudEZyYWdtZW50LWdl dEVsZW1lbnRCeUlkLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uY2UwZDMwMmMxMmI1YzRiZDA3ZWM4ZjRhZWU2 NzViMjA2MGY0ZGM3MgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3cz Yy93ZWItcGxhdGZvcm0tdGVzdHMvZG9tL25vZGVzL0RvY3VtZW50RnJhZ21lbnQtZ2V0RWxlbWVu dEJ5SWQuaHRtbApAQCAtMCwwICsxLDYyIEBACis8IURPQ1RZUEUgaHRtbD4KKzxtZXRhIGNoYXJz ZXQ9InV0Zi04Ij4KKzx0aXRsZT5Eb2N1bWVudEZyYWdtZW50LnByb3RvdHlwZS5nZXRFbGVtZW50 QnlJZDwvdGl0bGU+Cis8bGluayByZWw9ImhlbHAiIGhyZWY9Imh0dHBzOi8vZG9tLnNwZWMud2hh dHdnLm9yZy8jZG9tLW5vbmVsZW1lbnRwYXJlbnRub2RlLWdldGVsZW1lbnRieWlkIj4KKzxsaW5r IHJlbD0iYXV0aG9yIiB0aXRsZT0iRG9tZW5pYyBEZW5pY29sYSIgaHJlZj0ibWFpbHRvOmRAZG9t ZW5pYy5tZSI+CisKKzxzY3JpcHQgc3JjPSIvcmVzb3VyY2VzL3Rlc3RoYXJuZXNzLmpzIj48L3Nj cmlwdD4KKzxzY3JpcHQgc3JjPSIvcmVzb3VyY2VzL3Rlc3RoYXJuZXNzcmVwb3J0LmpzIj48L3Nj cmlwdD4KKworPHRlbXBsYXRlPgorICA8ZGl2IGlkPSJiYXIiPgorICAgIDxzcGFuIGlkPSJmb28i IGRhdGEteWVzPjwvc3Bhbj4KKyAgPC9kaXY+CisgIDxkaXYgaWQ9ImZvbyI+CisgICAgPHNwYW4g aWQ9ImZvbyI+PC9zcGFuPgorICAgIDx1bCBpZD0iYmFyIj4KKyAgICAgIDxsaSBpZD0iZm9vIj48 L2xpPgorICAgIDwvdWw+CisgIDwvZGl2PgorPC90ZW1wbGF0ZT4KKworPHNjcmlwdD4KKyJ1c2Ug c3RyaWN0IjsKKwordGVzdCgoKSA9PiB7CisgIGFzc2VydF9lcXVhbHModHlwZW9mIERvY3VtZW50 RnJhZ21lbnQucHJvdG90eXBlLmdldEVsZW1lbnRCeUlkLCAiZnVuY3Rpb24iLCAiSXQgbXVzdCBl eGlzdCBvbiB0aGUgcHJvdG90eXBlIik7CisgIGFzc2VydF9lcXVhbHModHlwZW9mIGRvY3VtZW50 LmNyZWF0ZURvY3VtZW50RnJhZ21lbnQoKS5nZXRFbGVtZW50QnlJZCwgImZ1bmN0aW9uIiwgIkl0 IG11c3QgZXhpc3Qgb24gYW4gaW5zdGFuY2UiKTsKK30sICJUaGUgbWV0aG9kIG11c3QgZXhpc3Qi KTsKKwordGVzdCgoKSA9PiB7CisgIGFzc2VydF9lcXVhbHMoZG9jdW1lbnQuY3JlYXRlRG9jdW1l bnRGcmFnbWVudCgpLmdldEVsZW1lbnRCeUlkKCJmb28iKSwgbnVsbCk7CisgIGFzc2VydF9lcXVh bHMoZG9jdW1lbnQuY3JlYXRlRG9jdW1lbnRGcmFnbWVudCgpLmdldEVsZW1lbnRCeUlkKCIiKSwg bnVsbCk7Cit9LCAiSXQgbXVzdCByZXR1cm4gbnVsbCB3aGVuIHRoZXJlIGFyZSBubyBtYXRjaGVz Iik7CisKK3Rlc3QoKCkgPT4geworICBjb25zdCBmcmFnID0gZG9jdW1lbnQuY3JlYXRlRG9jdW1l bnRGcmFnbWVudCgpOworICBmcmFnLmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQo ImRpdiIpKTsKKyAgZnJhZy5hcHBlbmRDaGlsZChkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJzcGFu IikpOworICBmcmFnLmNoaWxkTm9kZXNbMF0uaWQgPSAiZm9vIjsKKyAgZnJhZy5jaGlsZE5vZGVz WzFdLmlkID0gImZvbyI7CisKKyAgYXNzZXJ0X2VxdWFscyhmcmFnLmdldEVsZW1lbnRCeUlkKCJm b28iKSwgZnJhZy5jaGlsZE5vZGVzWzBdKTsKK30sICJJdCBtdXN0IHJldHVybiB0aGUgZmlyc3Qg ZWxlbWVudCB3aGVuIHRoZXJlIGFyZSBtYXRjaGVzIik7CisKK3Rlc3QoKCkgPT4geworICBjb25z dCBmcmFnID0gZG9jdW1lbnQuY3JlYXRlRG9jdW1lbnRGcmFnbWVudCgpOworICBmcmFnLmFwcGVu ZENoaWxkKGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIpKTsKKyAgZnJhZy5jaGlsZE5vZGVz WzBdLnNldEF0dHJpYnV0ZSgiaWQiLCAiIik7CisKKyAgYXNzZXJ0X2VxdWFscygKKyAgICBmcmFn LmdldEVsZW1lbnRCeUlkKCIiKSwKKyAgICBudWxsLAorICAgICJFdmVuIGlmIHRoZXJlIGlzIGFu IGVsZW1lbnQgd2l0aCBhbiBlbXB0eS1zdHJpbmcgSUQgYXR0cmlidXRlLCBpdCBtdXN0IG5vdCBi ZSByZXR1cm5lZCIKKyAgKTsKK30sICJFbXB0eSBzdHJpbmcgSUQgdmFsdWVzIik7CisKK3Rlc3Qo KCkgPT4geworICBjb25zdCBmcmFnID0gZG9jdW1lbnQucXVlcnlTZWxlY3RvcigidGVtcGxhdGUi KS5jb250ZW50OworCisgIGFzc2VydF90cnVlKGZyYWcuZ2V0RWxlbWVudEJ5SWQoImZvbyIpLmhh c0F0dHJpYnV0ZSgiZGF0YS15ZXMiKSk7Cit9LCAiSXQgbXVzdCByZXR1cm4gdGhlIGZpcnN0IGVs ZW1lbnQgd2hlbiB0aGVyZSBhcmUgbWF0Y2hlcywgdXNpbmcgYSB0ZW1wbGF0ZSIpOworPC9zY3Jp cHQ+Cg==