210109 2020-04-07 06:57:18 -0700 [Tools] Fix gdb WebCoreQualifiedNamePrinter 2020-04-10 08:23:55 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aboya aboya webkit-bug-importer oldest_to_newest 1638521 0 aboya 2020-04-07 06:57:18 -0700 My gdb was throwing exceptions like this when printing QualifiedName's: File "/webkit/Tools/gdb/webkit.py", line 205, in __init__ self.val['m_impl']['m_prefix']['m_string']) gdb.error: There is no member or method named m_prefix. This patch adds a missing m_ptr indirection to traverse RefPtr<QualifiedNameImpl>, fixing the issue. 1638522 1 395675 aboya 2020-04-07 06:58:22 -0700 Created attachment 395675 Patch 1640172 2 395675 dbates 2020-04-10 08:13:49 -0700 Comment on attachment 395675 Patch Patch looks good. A better patch would add test infra and a test for this change though this can be done in a separate patch. Inspiration can be taken from test-lldbWebKit. 1640175 3 ews-feeder 2020-04-10 08:19:03 -0700 Committed r259870: <https://trac.webkit.org/changeset/259870> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395675. 1640176 4 webkit-bug-importer 2020-04-10 08:20:17 -0700 <rdar://problem/61584950> 1640177 5 aboya 2020-04-10 08:23:55 -0700 (In reply to Daniel Bates from comment #2) > A better patch would add test infra and a test for this > change though this can be done in a separate patch. Inspiration can be taken > from test-lldbWebKit. That would be a considerable effort since there is no test coverage for the whole gdb helper at the moment. 395675 2020-04-07 06:58:22 -0700 2020-04-10 08:19:03 -0700 Patch bug-210109-20200407155821.patch text/plain 2026 aboya U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4OTg0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZWY5YzFiOWZlNDBiNTI3ZDdiMmNhZTczNjgwOWU4NTdm YjkzYTQyMS4uYzU3NmE5NTNkMWJhZjYzMDYxOTQzNDhiOWZhNGYzMzlkMjBiMzE1NyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIz IEBACisyMDIwLTA0LTA3ICBBbGljaWEgQm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4K KworICAgICAgICBbVG9vbHNdIEZpeCBnZGIgV2ViQ29yZVF1YWxpZmllZE5hbWVQcmludGVyCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTAxMDkKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNeSBnZGIgd2Fz IHRocm93aW5nIGV4Y2VwdGlvbnMgbGlrZSB0aGlzIHdoZW4gcHJpbnRpbmcKKyAgICAgICAgUXVh bGlmaWVkTmFtZSdzOgorCisgICAgICAgIEZpbGUgIi93ZWJraXQvVG9vbHMvZ2RiL3dlYmtpdC5w eSIsIGxpbmUgMjA1LCBpbiBfX2luaXRfXworICAgICAgICAgIHNlbGYudmFsWydtX2ltcGwnXVsn bV9wcmVmaXgnXVsnbV9zdHJpbmcnXSkKKyAgICAgICAgZ2RiLmVycm9yOiBUaGVyZSBpcyBubyBt ZW1iZXIgb3IgbWV0aG9kIG5hbWVkIG1fcHJlZml4LgorCisgICAgICAgIFRoaXMgcGF0Y2ggYWRk cyBhIG1pc3NpbmcgbV9wdHIgaW5kaXJlY3Rpb24gdG8gdHJhdmVyc2UKKyAgICAgICAgUmVmUHRy PFF1YWxpZmllZE5hbWVJbXBsPiwgZml4aW5nIHRoZSBpc3N1ZS4KKworICAgICAgICAqIGdkYi93 ZWJraXQucHk6CisgICAgICAgIChXZWJDb3JlUXVhbGlmaWVkTmFtZVByaW50ZXIuX19pbml0X18p OgorCiAyMDIwLTAzLTMxICBBbGljaWEgQm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4K IAogICAgICAgICBbV1RGXSBEYXRhTXV0ZXg6IEFkZCBydW5VbmxvY2tlZCgpCmRpZmYgLS1naXQg YS9Ub29scy9nZGIvd2Via2l0LnB5IGIvVG9vbHMvZ2RiL3dlYmtpdC5weQppbmRleCAxNDcyNWQ4 ODMyNDkyODQ4YTg4NWEyOGFiZGQ0Y2ZkYzI5N2I2ZTUxLi5jYmVhOGUyMjhiYWQxYTkyMWJhYzhl ODAzNDM5M2QwZWNiYjA3NWYxIDEwMDY0NAotLS0gYS9Ub29scy9nZGIvd2Via2l0LnB5CisrKyBi L1Rvb2xzL2dkYi93ZWJraXQucHkKQEAgLTIwMCwxMSArMjAwLDExIEBAIGNsYXNzIFdlYkNvcmVR dWFsaWZpZWROYW1lUHJpbnRlcihTdHJpbmdQcmludGVyKToKICAgICAgICAgc3VwZXIoV2ViQ29y ZVF1YWxpZmllZE5hbWVQcmludGVyLCBzZWxmKS5fX2luaXRfXyh2YWwpCiAgICAgICAgIHNlbGYu cHJlZml4X2xlbmd0aCA9IDAKICAgICAgICAgc2VsZi5sZW5ndGggPSAwCi0gICAgICAgIGlmIHNl bGYudmFsWydtX2ltcGwnXToKKyAgICAgICAgaWYgc2VsZi52YWxbJ21faW1wbCddWydtX3B0cidd OgogICAgICAgICAgICAgc2VsZi5wcmVmaXhfcHJpbnRlciA9IFdURlN0cmluZ1ByaW50ZXIoCi0g ICAgICAgICAgICAgICAgc2VsZi52YWxbJ21faW1wbCddWydtX3ByZWZpeCddWydtX3N0cmluZydd KQorICAgICAgICAgICAgICAgIHNlbGYudmFsWydtX2ltcGwnXVsnbV9wdHInXVsnbV9wcmVmaXgn XVsnbV9zdHJpbmcnXSkKICAgICAgICAgICAgIHNlbGYubG9jYWxfbmFtZV9wcmludGVyID0gV1RG U3RyaW5nUHJpbnRlcigKLSAgICAgICAgICAgICAgICBzZWxmLnZhbFsnbV9pbXBsJ11bJ21fbG9j YWxOYW1lJ11bJ21fc3RyaW5nJ10pCisgICAgICAgICAgICAgICAgc2VsZi52YWxbJ21faW1wbCdd WydtX3B0ciddWydtX2xvY2FsTmFtZSddWydtX3N0cmluZyddKQogICAgICAgICAgICAgc2VsZi5w cmVmaXhfbGVuZ3RoID0gc2VsZi5wcmVmaXhfcHJpbnRlci5nZXRfbGVuZ3RoKCkKICAgICAgICAg ICAgIGlmIHNlbGYucHJlZml4X2xlbmd0aCA+IDA6CiAgICAgICAgICAgICAgICAgc2VsZi5sZW5n dGggPSAoc2VsZi5wcmVmaXhfbGVuZ3RoICsgMSArCg==