210106 2020-04-07 05:33:19 -0700 [GTK][WPE] WTR: fix handling of WebsiteDataStore 2020-05-18 17:08:19 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=202236 https://bugs.webkit.org/show_bug.cgi?id=202237 https://bugs.webkit.org/show_bug.cgi?id=202238 https://bugs.webkit.org/show_bug.cgi?id=202240 https://bugs.webkit.org/show_bug.cgi?id=202234 https://bugs.webkit.org/show_bug.cgi?id=202241 https://bugs.webkit.org/show_bug.cgi?id=204230 https://bugs.webkit.org/show_bug.cgi?id=208180 https://bugs.webkit.org/show_bug.cgi?id=212044 Gtk, InRadar P2 Normal --- 1 cgarcia webkit-unassigned aperez bugs-noreply webkit-bug-importer oldest_to_newest 1638514 0 cgarcia 2020-04-07 05:33:19 -0700 The TestController::defaultWebsiteDataStore() is created and used but never really assigned to the context. Since we are not assigning a WebsiteDataStore to the context, and we don't use the default WebsiteDataStore, when a new page is created, we end up creating the default one (with the default config, instead of the one created by WTR). We should set the TestController::defaultWebsiteDataStore() as the primary data store of the context like the GLib API does. 1638515 1 395672 cgarcia 2020-04-07 05:36:01 -0700 Created attachment 395672 Patch 1638516 2 395672 aperez 2020-04-07 05:53:42 -0700 Comment on attachment 395672 Patch Please make sure that tests pass before landing, otherwise LGTM. 1638945 3 cgarcia 2020-04-07 23:19:30 -0700 Committed r259705: <https://trac.webkit.org/changeset/259705> 1638946 4 webkit-bug-importer 2020-04-07 23:20:15 -0700 <rdar://problem/61433923> 395672 2020-04-07 05:36:01 -0700 2020-04-07 05:53:42 -0700 Patch wtr-data-store.diff text/plain 3948 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggMTdiOTIxZjRkZDc4Li40MTA5MjQ3NGI1ZGYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTYgQEAKKzIwMjAtMDQtMDcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtHVEtdW1dQRV0gV1RSOiBmaXggaGFuZGxpbmcgb2YgV2Vic2l0 ZURhdGFTdG9yZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjEwMTA2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQWRkIFdLQ29udGV4dFNldFByaW1hcnlXZWJzaXRlRGF0YVN0b3JlKCkgdG8gZXhwb3NlIFdl YlByb2Nlc3NQb29sOjpzZXRQcmltYXJ5RGF0YVN0b3JlKCkuCisKKyAgICAgICAgKiBVSVByb2Nl c3MvQVBJL0MvV0tDb250ZXh0LmNwcDoKKyAgICAgICAgKFdLQ29udGV4dFNldFByaW1hcnlXZWJz aXRlRGF0YVN0b3JlKToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0MvV0tDb250ZXh0UHJpdmF0 ZS5oOgorCiAyMDIwLTA0LTA0ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29t PgogCiAgICAgICAgIEFkZCBhIGZvdXJ0aCByb3VuZCBvZiBsb2dnaW5nIHRvIGhlbHAgZGlhZ25v c2UgPHdlYmtpdC5vcmcvYi8yMDk2ODU+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9BUEkvQy9XS0NvbnRleHQuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0Mv V0tDb250ZXh0LmNwcAppbmRleCA2NDY4NWRhZDJlMTUuLjZkMjc4NDIzNjg1ZSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0MvV0tDb250ZXh0LmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQy9XS0NvbnRleHQuY3BwCkBAIC02NzAsMyArNjcwLDgg QEAgdm9pZCBXS0NvbnRleHRTZXRVc2VTZXBhcmF0ZVNlcnZpY2VXb3JrZXJQcm9jZXNzKFdLQ29u dGV4dFJlZiBjb250ZXh0UmVmLCBib29sIHUKIHsKICAgICBXZWJLaXQ6OnRvSW1wbChjb250ZXh0 UmVmKS0+c2V0VXNlU2VwYXJhdGVTZXJ2aWNlV29ya2VyUHJvY2Vzcyh1c2VTZXBhcmF0ZVNlcnZp Y2VXb3JrZXJQcm9jZXNzKTsKIH0KKwordm9pZCBXS0NvbnRleHRTZXRQcmltYXJ5V2Vic2l0ZURh dGFTdG9yZShXS0NvbnRleHRSZWYgY29udGV4dFJlZiwgV0tXZWJzaXRlRGF0YVN0b3JlUmVmIHdl YnNpdGVEYXRhU3RvcmUpCit7CisgICAgV2ViS2l0Ojp0b0ltcGwoY29udGV4dFJlZiktPnNldFBy aW1hcnlEYXRhU3RvcmUoKldlYktpdDo6dG9JbXBsKHdlYnNpdGVEYXRhU3RvcmUpKTsKK30KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9DL1dLQ29udGV4dFByaXZhdGUu aCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9DL1dLQ29udGV4dFByaXZhdGUuaAppbmRl eCBlNzc2Yjc0Yzk1NGYuLmE3NzFkNTgyZjBmZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvQVBJL0MvV0tDb250ZXh0UHJpdmF0ZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL0FQSS9DL1dLQ29udGV4dFByaXZhdGUuaApAQCAtMTE5LDYgKzExOSw4IEBAIFdLX0VY UE9SVCB2b2lkIFdLQ29udGV4dENsZWFyTGVnYWN5UHJpdmF0ZUJyb3dzaW5nTG9jYWxTdG9yYWdl KFdLQ29udGV4dFJlZiBjb250CiAKIFdLX0VYUE9SVCB2b2lkIFdLQ29udGV4dFNldFVzZVNlcGFy YXRlU2VydmljZVdvcmtlclByb2Nlc3MoV0tDb250ZXh0UmVmIGNvbnRleHQsIGJvb2wgZm9yY2VT ZXJ2aWNlV29ya2VyUHJvY2Vzcyk7CiAKK1dLX0VYUE9SVCB2b2lkIFdLQ29udGV4dFNldFByaW1h cnlXZWJzaXRlRGF0YVN0b3JlKFdLQ29udGV4dFJlZiBjb250ZXh0LCBXS1dlYnNpdGVEYXRhU3Rv cmVSZWYgd2Vic2l0ZURhdGFTdG9yZSk7CisKICNpZmRlZiBfX2NwbHVzcGx1cwogfQogI2VuZGlm CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTZk NWFkNzJkMDY3Li4wMDY2YzNjMGJjMzQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysg Yi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAyMC0wNC0wNyAgQ2FybG9zIEdh cmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS11bV1BFXSBX VFI6IGZpeCBoYW5kbGluZyBvZiBXZWJzaXRlRGF0YVN0b3JlCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTAxMDYKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgVGVzdENvbnRyb2xsZXI6OmRlZmF1bHRX ZWJzaXRlRGF0YVN0b3JlKCkgaXMgY3JlYXRlZCBhbmQgdXNlZCBidXQgbmV2ZXIgcmVhbGx5IGFz c2lnbmVkIHRvIHRoZQorICAgICAgICBjb250ZXh0LiBTaW5jZSB3ZSBhcmUgbm90IGFzc2lnbmlu ZyBhIFdlYnNpdGVEYXRhU3RvcmUgdG8gdGhlIGNvbnRleHQsIGFuZCB3ZSBkb24ndCB1c2UgdGhl IGRlZmF1bHQKKyAgICAgICAgV2Vic2l0ZURhdGFTdG9yZSwgd2hlbiBhIG5ldyBwYWdlIGlzIGNy ZWF0ZWQsIHdlIGVuZCB1cCBjcmVhdGluZyB0aGUgZGVmYXVsdCBvbmUgKHdpdGggdGhlIGRlZmF1 bHQgY29uZmlnLAorICAgICAgICBpbnN0ZWFkIG9mIHRoZSBvbmUgY3JlYXRlZCBieSBXVFIpLgor CisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHA6CisgICAgICAg IChXVFI6OlRlc3RDb250cm9sbGVyOjpwbGF0Zm9ybUFkanVzdENvbnRleHQpOiBTZXQgZGVmYXVs dFdlYnNpdGVEYXRhU3RvcmUoKSBhcyB0aGUgcHJpbWFyeSBkYXRhIHN0b3JlIG9mIHRoZQorICAg ICAgICBjb250ZXh0IGxpa2UgdGhlIEdMaWIgQVBJIGRvZXMuCisKIDIwMjAtMDQtMDQgIFdlbnNv biBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIGEgZm91cnRo IHJvdW5kIG9mIGxvZ2dpbmcgdG8gaGVscCBkaWFnbm9zZSA8d2Via2l0Lm9yZy9iLzIwOTY4NT4K ZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwIGIv VG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHAKaW5kZXggNzdhNjQ0MzUx NTRkLi40Yzc5MzYxNjc5YjAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVz dENvbnRyb2xsZXIuY3BwCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xs ZXIuY3BwCkBAIC0zMTEwLDcgKzMxMTAsMTIgQEAgUGxhdGZvcm1XZWJWaWV3KiBUZXN0Q29udHJv bGxlcjo6cGxhdGZvcm1DcmVhdGVPdGhlclBhZ2UoUGxhdGZvcm1XZWJWaWV3KiBwYXJlbnQKIAog V0tDb250ZXh0UmVmIFRlc3RDb250cm9sbGVyOjpwbGF0Zm9ybUFkanVzdENvbnRleHQoV0tDb250 ZXh0UmVmIGNvbnRleHQsIFdLQ29udGV4dENvbmZpZ3VyYXRpb25SZWYgY29udGV4dENvbmZpZ3Vy YXRpb24pCiB7CisjaWYgUExBVEZPUk0oR1RLKSB8fCBQTEFURk9STShXUEUpCisgICAgV0tXZWJz aXRlRGF0YVN0b3JlU2V0UmVzb3VyY2VMb2FkU3RhdGlzdGljc0VuYWJsZWQoZGVmYXVsdFdlYnNp dGVEYXRhU3RvcmUoKSwgdHJ1ZSk7CisgICAgV0tDb250ZXh0U2V0UHJpbWFyeVdlYnNpdGVEYXRh U3RvcmUoY29udGV4dCwgZGVmYXVsdFdlYnNpdGVEYXRhU3RvcmUoKSk7CisjZWxzZQogICAgIFdL V2Vic2l0ZURhdGFTdG9yZVNldFJlc291cmNlTG9hZFN0YXRpc3RpY3NFbmFibGVkKFdLQ29udGV4 dEdldFdlYnNpdGVEYXRhU3RvcmUoY29udGV4dCksIHRydWUpOworI2VuZGlmCiAgICAgcmV0dXJu IGNvbnRleHQ7CiB9CiAK