210094 2020-04-06 21:11:10 -0700 VisitedLinkStore.messages.in and VisitedLinkStore::addVisitedLinkHashFromPage() don't agree on type of `linkHash` 2020-04-07 09:00:59 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=210115 InRadar P2 Normal --- 1 ddkilzer ddkilzer cdumez webkit-bug-importer oldest_to_newest 1638441 0 ddkilzer 2020-04-06 21:11:10 -0700 VisitedLinkStore.messages.in and VisitedLinkStore::addVisitedLinkHashFromPage() don't agree on type of `linkHash`. messages -> VisitedLinkStore { AddVisitedLinkHashFromPage(WebKit::WebPageProxyIdentifier pageProxyID, uint64_t linkHash) } using SharedStringHash = uint32_t; void VisitedLinkStore::addVisitedLinkHashFromPage(WebPageProxyIdentifier pageProxyID, SharedStringHash linkHash) { [...] } <rdar://problem/60334644> 1638444 1 395651 ddkilzer 2020-04-06 21:17:05 -0700 Created attachment 395651 Patch v1 1638542 2 395651 cdumez 2020-04-07 08:15:07 -0700 Comment on attachment 395651 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=395651&action=review > Source/WebKit/Scripts/webkit/messages.py:618 > + 'WebCore::SharedStringHash': ['<WebCore/SharedStringHash.h>'], Why is this needed? Seems like this would be the default. 1638549 3 395651 ddkilzer 2020-04-07 08:27:52 -0700 Comment on attachment 395651 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=395651&action=review >> Source/WebKit/Scripts/webkit/messages.py:618 >> + 'WebCore::SharedStringHash': ['<WebCore/SharedStringHash.h>'], > > Why is this needed? Seems like this would be the default. Oops, it's not. I'm new to this code. Thanks! 1638551 4 395685 ddkilzer 2020-04-07 08:29:44 -0700 Created attachment 395685 Patch v2 1638564 5 ews-feeder 2020-04-07 09:00:58 -0700 Committed r259637: <https://trac.webkit.org/changeset/259637> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395685. 395651 2020-04-06 21:17:05 -0700 2020-04-07 08:29:42 -0700 Patch v1 bug-210094-20200406211714.patch text/plain 2908 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5NjIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGJkNDZjMmJjZDRlZTA0NWUy YjNiZjcxY2M5NjcxMmExZGM3M2E5MWYuLmYxNzBiYzNiYjU0MGRhNTFlZTQ3OTRjNmE0ZWQ1YWEz OTdjNGE3ODAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjAtMDQtMDYgIERhdmlkIEtp bHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBWaXNpdGVkTGlua1N0b3JlLm1l c3NhZ2VzLmluIGFuZCBWaXNpdGVkTGlua1N0b3JlOjphZGRWaXNpdGVkTGlua0hhc2hGcm9tUGFn ZSgpIGRvbid0IGFncmVlIG9uIHR5cGUgb2YgYGxpbmtIYXNoYAorICAgICAgICA8aHR0cHM6Ly93 ZWJraXQub3JnL2IvMjEwMDk0PgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjAzMzQ2NDQ+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRz L3dlYmtpdC9tZXNzYWdlcy5weToKKyAgICAgICAgLSBUZWFjaCBzY3JpcHQgaG93IHRvIGdlbmVy YXRlIGNvZGUgZm9yCisgICAgICAgICAgV2ViQ29yZTo6U2hhcmVkU3RyaW5nSGFzaCB0eXBlLgor ICAgICAgICAqIFVJUHJvY2Vzcy9WaXNpdGVkTGlua1N0b3JlLm1lc3NhZ2VzLmluOgorICAgICAg ICAtIFVzZSBXZWJDb3JlOjpTaGFyZWRTdHJpbmdIYXNoIHR5cGUgZm9yIGBsaW5rSGFzaGAuCisK IDIwMjAtMDQtMDYgIEthdGUgQ2hlbmV5ICA8a2F0aGVyaW5lX2NoZW5leUBhcHBsZS5jb20+CiAK ICAgICAgICAgQ3JlYXRlIGEgd2F5IHRvIHNpZ25hbCBpZiB0aGUgV0tBcHBCb3VuZERvbWFpbnMg bGlzdCBpcyBlbXB0eQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9TY3JpcHRzL3dlYmtpdC9t ZXNzYWdlcy5weSBiL1NvdXJjZS9XZWJLaXQvU2NyaXB0cy93ZWJraXQvbWVzc2FnZXMucHkKaW5k ZXggNDQ0NGYzMWY3ZThiYzQ4NmE3MmQ0YTg4ZTVlMjUyZTFiYzYxMTFjMy4uMDI3NDExYmU1YTg1 OGE2NjRiNTRlMzZmNjE5OWM5NzRkY2U5NTcxMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9T Y3JpcHRzL3dlYmtpdC9tZXNzYWdlcy5weQorKysgYi9Tb3VyY2UvV2ViS2l0L1NjcmlwdHMvd2Vi a2l0L21lc3NhZ2VzLnB5CkBAIC0yMjIsNiArMjIyLDcgQEAgZGVmIHR5cGVzX3RoYXRfY2Fubm90 X2JlX2ZvcndhcmRfZGVjbGFyZWQoKToKICAgICAgICAgJ1dlYkNvcmU6OlNlcnZpY2VXb3JrZXJP ckNsaWVudERhdGEnLAogICAgICAgICAnV2ViQ29yZTo6U2VydmljZVdvcmtlck9yQ2xpZW50SWRl bnRpZmllcicsCiAgICAgICAgICdXZWJDb3JlOjpTZXJ2aWNlV29ya2VyUmVnaXN0cmF0aW9uSWRl bnRpZmllcicsCisgICAgICAgICdXZWJDb3JlOjpTaGFyZWRTdHJpbmdIYXNoJywKICAgICAgICAg J1dlYkNvcmU6OlNsZWVwRGlzYWJsZXJJZGVudGlmaWVyJywKICAgICAgICAgJ1dlYkNvcmU6OlNX U2VydmVyQ29ubmVjdGlvbklkZW50aWZpZXInLAogICAgICAgICAnV2ViS2l0OjpBY3Rpdml0eVN0 YXRlQ2hhbmdlSUQnLApAQCAtNjE0LDYgKzYxNSw3IEBAIGRlZiBoZWFkZXJzX2Zvcl90eXBlKHR5 cGUpOgogICAgICAgICAnV2ViQ29yZTo6U2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbklkZW50aWZp ZXInOiBbJzxXZWJDb3JlL1NlcnZpY2VXb3JrZXJUeXBlcy5oPiddLAogICAgICAgICAnV2ViQ29y ZTo6U2VydmljZVdvcmtlclJlZ2lzdHJhdGlvblN0YXRlJzogWyc8V2ViQ29yZS9TZXJ2aWNlV29y a2VyVHlwZXMuaD4nXSwKICAgICAgICAgJ1dlYkNvcmU6OlNlcnZpY2VXb3JrZXJTdGF0ZSc6IFsn PFdlYkNvcmUvU2VydmljZVdvcmtlclR5cGVzLmg+J10sCisgICAgICAgICdXZWJDb3JlOjpTaGFy ZWRTdHJpbmdIYXNoJzogWyc8V2ViQ29yZS9TaGFyZWRTdHJpbmdIYXNoLmg+J10sCiAgICAgICAg ICdXZWJDb3JlOjpTaGlwcGluZ0NvbnRhY3RVcGRhdGUnOiBbJzxXZWJDb3JlL0FwcGxlUGF5U2Vz c2lvblBheW1lbnRSZXF1ZXN0Lmg+J10sCiAgICAgICAgICdXZWJDb3JlOjpTaGlwcGluZ01ldGhv ZFVwZGF0ZSc6IFsnPFdlYkNvcmUvQXBwbGVQYXlTZXNzaW9uUGF5bWVudFJlcXVlc3QuaD4nXSwK ICAgICAgICAgJ1dlYkNvcmU6OlNob3VsZEFza0lUUCc6IFsnPFdlYkNvcmUvTmV0d29ya1N0b3Jh Z2VTZXNzaW9uLmg+J10sCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9WaXNp dGVkTGlua1N0b3JlLm1lc3NhZ2VzLmluIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvVmlzaXRl ZExpbmtTdG9yZS5tZXNzYWdlcy5pbgppbmRleCAwNzMyMWM1MWY3ZTc5MDdmYjg0MDNhOWQzOTky ZDc0ZTdhNDk5NTQ3Li42ZGM0NjkzOWJiZGVmN2I1NDQ4ODA0NTc3ZjBmMThlYjc4NmEyYzJkIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9WaXNpdGVkTGlua1N0b3JlLm1lc3Nh Z2VzLmluCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1Zpc2l0ZWRMaW5rU3RvcmUubWVz c2FnZXMuaW4KQEAgLTIxLDUgKzIxLDUgQEAKICMgT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBB RFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KIAogbWVzc2FnZXMgLT4g VmlzaXRlZExpbmtTdG9yZSB7Ci0gICAgQWRkVmlzaXRlZExpbmtIYXNoRnJvbVBhZ2UoV2ViS2l0 OjpXZWJQYWdlUHJveHlJZGVudGlmaWVyIHBhZ2VQcm94eUlELCB1aW50NjRfdCBsaW5rSGFzaCkK KyAgICBBZGRWaXNpdGVkTGlua0hhc2hGcm9tUGFnZShXZWJLaXQ6OldlYlBhZ2VQcm94eUlkZW50 aWZpZXIgcGFnZVByb3h5SUQsIFdlYkNvcmU6OlNoYXJlZFN0cmluZ0hhc2ggbGlua0hhc2gpCiB9 Cg== 395685 2020-04-07 08:29:44 -0700 2020-04-07 09:00:59 -0700 Patch v2 bug-210094-20200407082955.patch text/plain 2378 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5NjIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGJkNDZjMmJjZDRlZTA0NWUy YjNiZjcxY2M5NjcxMmExZGM3M2E5MWYuLjdhYzE2ZDBiNjFkNzdmNzE0MzI3NzBmNzE2OGUwODIz ZTU4ZmZkZDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjAtMDQtMDcgIERhdmlkIEtp bHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBWaXNpdGVkTGlua1N0b3JlLm1l c3NhZ2VzLmluIGFuZCBWaXNpdGVkTGlua1N0b3JlOjphZGRWaXNpdGVkTGlua0hhc2hGcm9tUGFn ZSgpIGRvbid0IGFncmVlIG9uIHR5cGUgb2YgYGxpbmtIYXNoYAorICAgICAgICA8aHR0cHM6Ly93 ZWJraXQub3JnL2IvMjEwMDk0PgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjAzMzQ2NDQ+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRz L3dlYmtpdC9tZXNzYWdlcy5weToKKyAgICAgICAgKHR5cGVzX3RoYXRfY2Fubm90X2JlX2Zvcndh cmRfZGVjbGFyZWQpOgorICAgICAgICAtIERvbid0IGZvcndhcmQtZGVjbGFyZSBXZWJDb3JlOjpT aGFyZWRTdHJpbmdIYXNoIGFzIGEgY2xhc3MKKyAgICAgICAgICBzaW5jZSBpdCBpcyBhIHVpbnQz Ml90LgorICAgICAgICAqIFVJUHJvY2Vzcy9WaXNpdGVkTGlua1N0b3JlLm1lc3NhZ2VzLmluOgor ICAgICAgICAtIFVzZSBXZWJDb3JlOjpTaGFyZWRTdHJpbmdIYXNoIHR5cGUgZm9yIGBsaW5rSGFz aGAgdG8gZml4IHRoZQorICAgICAgICAgIHR5cGUgbWlzbWF0Y2guCisKIDIwMjAtMDQtMDYgIEth dGUgQ2hlbmV5ICA8a2F0aGVyaW5lX2NoZW5leUBhcHBsZS5jb20+CiAKICAgICAgICAgQ3JlYXRl IGEgd2F5IHRvIHNpZ25hbCBpZiB0aGUgV0tBcHBCb3VuZERvbWFpbnMgbGlzdCBpcyBlbXB0eQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9TY3JpcHRzL3dlYmtpdC9tZXNzYWdlcy5weSBiL1Nv dXJjZS9XZWJLaXQvU2NyaXB0cy93ZWJraXQvbWVzc2FnZXMucHkKaW5kZXggNDQ0NGYzMWY3ZThi YzQ4NmE3MmQ0YTg4ZTVlMjUyZTFiYzYxMTFjMy4uN2M5YzU0MTVlNzQwOThkODVjY2I1YTAzNmU1 YmIxYjJmMGFkOTgxYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9TY3JpcHRzL3dlYmtpdC9t ZXNzYWdlcy5weQorKysgYi9Tb3VyY2UvV2ViS2l0L1NjcmlwdHMvd2Via2l0L21lc3NhZ2VzLnB5 CkBAIC0yMjIsNiArMjIyLDcgQEAgZGVmIHR5cGVzX3RoYXRfY2Fubm90X2JlX2ZvcndhcmRfZGVj bGFyZWQoKToKICAgICAgICAgJ1dlYkNvcmU6OlNlcnZpY2VXb3JrZXJPckNsaWVudERhdGEnLAog ICAgICAgICAnV2ViQ29yZTo6U2VydmljZVdvcmtlck9yQ2xpZW50SWRlbnRpZmllcicsCiAgICAg ICAgICdXZWJDb3JlOjpTZXJ2aWNlV29ya2VyUmVnaXN0cmF0aW9uSWRlbnRpZmllcicsCisgICAg ICAgICdXZWJDb3JlOjpTaGFyZWRTdHJpbmdIYXNoJywKICAgICAgICAgJ1dlYkNvcmU6OlNsZWVw RGlzYWJsZXJJZGVudGlmaWVyJywKICAgICAgICAgJ1dlYkNvcmU6OlNXU2VydmVyQ29ubmVjdGlv bklkZW50aWZpZXInLAogICAgICAgICAnV2ViS2l0OjpBY3Rpdml0eVN0YXRlQ2hhbmdlSUQnLApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvVmlzaXRlZExpbmtTdG9yZS5tZXNz YWdlcy5pbiBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1Zpc2l0ZWRMaW5rU3RvcmUubWVzc2Fn ZXMuaW4KaW5kZXggMDczMjFjNTFmN2U3OTA3ZmI4NDAzYTlkMzk5MmQ3NGU3YTQ5OTU0Ny4uNmRj NDY5MzliYmRlZjdiNTQ0ODgwNDU3N2YwZjE4ZWI3ODZhMmMyZCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvVmlzaXRlZExpbmtTdG9yZS5tZXNzYWdlcy5pbgorKysgYi9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9WaXNpdGVkTGlua1N0b3JlLm1lc3NhZ2VzLmluCkBAIC0yMSw1 ICsyMSw1IEBACiAjIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9T U0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCiAKIG1lc3NhZ2VzIC0+IFZpc2l0ZWRMaW5rU3RvcmUg ewotICAgIEFkZFZpc2l0ZWRMaW5rSGFzaEZyb21QYWdlKFdlYktpdDo6V2ViUGFnZVByb3h5SWRl bnRpZmllciBwYWdlUHJveHlJRCwgdWludDY0X3QgbGlua0hhc2gpCisgICAgQWRkVmlzaXRlZExp bmtIYXNoRnJvbVBhZ2UoV2ViS2l0OjpXZWJQYWdlUHJveHlJZGVudGlmaWVyIHBhZ2VQcm94eUlE LCBXZWJDb3JlOjpTaGFyZWRTdHJpbmdIYXNoIGxpbmtIYXNoKQogfQo=