210084 2020-04-06 17:26:13 -0700 Add release asserts to KeyframeEffectStack::ensureEffectsAreSorted() 2020-04-07 01:26:06 -0700 1 1 1 Unclassified WebKit Animations WebKit Local Build Mac macOS 10.15 RESOLVED FIXED InRadar P2 Normal --- 1 dougk dougk dino ggaren graouts graouts rniwa webkit-bug-importer oldest_to_newest 1638390 0 dougk 2020-04-06 17:26:13 -0700 KeyframeEffectStack::ensureEffectsAreSorted() has several areas where either null pointers or an unexpected condition could cause a crash that's further away from the actual failure. To make these issues easier to detect and troubleshoot, add several RELEASE_ASSERTs to test these cases explicitly. <rdar://problem/61359275> 1638393 1 395638 dougk 2020-04-06 17:30:36 -0700 Created attachment 395638 Patch 1638430 2 395647 dougk 2020-04-06 20:23:48 -0700 Created attachment 395647 Patch 1638482 3 ews-feeder 2020-04-07 01:26:05 -0700 Committed r259630: <https://trac.webkit.org/changeset/259630> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395647. 395638 2020-04-06 17:30:36 -0700 2020-04-06 20:23:46 -0700 Patch bug-210084-20200406173035.patch text/plain 3323 dougk U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5NTk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTkxMjg0YThmY2FjOGNh NDllMTZmMTE0Mzg4NDExYWFiM2QzNzJiYi4uM2Y4YWQ0NTgzZjI1ZTg1N2ViZmZjMGRmNzhkYzZk MzhhNmU5YWJiNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDIwLTA0LTA2ICBEb3Vn IEtlbGx5ICA8ZG91Z2tAYXBwbGUuY29tPgorCisgICAgICAgIEFkZCByZWxlYXNlIGFzc2VydHMg dG8gS2V5ZnJhbWVFZmZlY3RTdGFjazo6ZW5zdXJlRWZmZWN0c0FyZVNvcnRlZCgpCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTAwODQKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzYxMzU5Mjc1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFRvIGVuc3VyZSBhbnkgcG90ZW50aWFsIHByb2JsZW1zIGluIEtl eWZyYW1lRWZmZWN0U3RhY2s6OmVuc3VyZUVmZmVjdHNBcmVTb3J0ZWQoKSBhcmUgZm91bmQgY2xv c2VyIHRvIHRoZQorICAgICAgICByb290IGNhdXNlLCBhZGQgc2V2ZXJhbCBSRUxFQVNFX0FTU0VS VHMgdGhyb3VnaG91dCB0aGlzIGZ1bmN0aW9uIChhbmQgaXRzIGFzc29jaWF0ZWQgY29tcGFyaXNv biBmdW5jdGlvbikuCisgICAgICAgIFRoaXMgc2hvdWxkIGd1YXJkIGFnYWluc3QgbnVsbCBwb2lu dGVycy9udWxsIFdlYWtQdHJzLCBhcyB3ZWxsIGFzIG90aGVyIHN0YXRlIHByb2JsZW1zIHdoaWNo IHdvdWxkIGJlCisgICAgICAgIHVuZXhwZWN0ZWQgZm9yIHRoZSBjb21wYXJpc29uIGZ1bmN0aW9u IHVzZWQgYnkgc3RkOjpzb3J0LgorCisgICAgICAgIE5vIG5ldyB0ZXN0czsgdGhpcyBvbmx5IGFk ZHMgYWRkaXRpb25hbCBhc3NlcnRzLCBzbyB0aGVyZSBpcyBubyBjaGFuZ2UgdG8gZnVuY3Rpb25h bGl0eSwgYW5kIHRoaXMgY29kZSBpcworICAgICAgICBjb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3Rz LgorCisgICAgICAgICogYW5pbWF0aW9uL0tleWZyYW1lRWZmZWN0U3RhY2suY3BwOgorICAgICAg ICAoV2ViQ29yZTo6S2V5ZnJhbWVFZmZlY3RTdGFjazo6ZW5zdXJlRWZmZWN0c0FyZVNvcnRlZCk6 CisgICAgICAgICogYW5pbWF0aW9uL1dlYkFuaW1hdGlvblV0aWxpdGllcy5jcHA6CisgICAgICAg IChXZWJDb3JlOjpjb21wYXJlQW5pbWF0aW9uc0J5Q29tcG9zaXRlT3JkZXIpOgorCiAyMDIwLTA0 LTA2ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIFN0cmVuZ3Ro ZW4gdGhlIEFTU0VSVCBpbiBJbWFnZURlY29kZXJBVkZPYmpDOjpzdG9yZVNhbXBsZUJ1ZmZlcigp LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYW5pbWF0aW9uL0tleWZyYW1lRWZmZWN0U3Rh Y2suY3BwIGIvU291cmNlL1dlYkNvcmUvYW5pbWF0aW9uL0tleWZyYW1lRWZmZWN0U3RhY2suY3Bw CmluZGV4IDI2OThlYTMwOGRmYjcwMjczMjJkYmI0MWVkNjdiNjY1ZDU1ZmQ2YWMuLmQwYmQ3Y2Y1 Y2RlOTIyMzJlZDllNDY2NWVjOTNkY2NmODU5ZTQzODYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2FuaW1hdGlvbi9LZXlmcmFtZUVmZmVjdFN0YWNrLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9hbmltYXRpb24vS2V5ZnJhbWVFZmZlY3RTdGFjay5jcHAKQEAgLTgwLDExICs4MCwxNCBAQCB2 b2lkIEtleWZyYW1lRWZmZWN0U3RhY2s6OmVuc3VyZUVmZmVjdHNBcmVTb3J0ZWQoKQogICAgICAg ICByZXR1cm47CiAKICAgICBzdGQ6OnNvcnQobV9lZmZlY3RzLmJlZ2luKCksIG1fZWZmZWN0cy5l bmQoKSwgWyZdKGF1dG8mIGxocywgYXV0byYgcmhzKSB7CisgICAgICAgIFJFTEVBU0VfQVNTRVJU KGxocy5nZXQoKSk7CisgICAgICAgIFJFTEVBU0VfQVNTRVJUKHJocy5nZXQoKSk7CisgICAgICAg IAogICAgICAgICBhdXRvKiBsaHNBbmltYXRpb24gPSBsaHMtPmFuaW1hdGlvbigpOwogICAgICAg ICBhdXRvKiByaHNBbmltYXRpb24gPSByaHMtPmFuaW1hdGlvbigpOwogCi0gICAgICAgIEFTU0VS VChsaHNBbmltYXRpb24pOwotICAgICAgICBBU1NFUlQocmhzQW5pbWF0aW9uKTsKKyAgICAgICAg UkVMRUFTRV9BU1NFUlQobGhzQW5pbWF0aW9uKTsKKyAgICAgICAgUkVMRUFTRV9BU1NFUlQocmhz QW5pbWF0aW9uKTsKIAogICAgICAgICByZXR1cm4gY29tcGFyZUFuaW1hdGlvbnNCeUNvbXBvc2l0 ZU9yZGVyKCpsaHNBbmltYXRpb24sICpyaHNBbmltYXRpb24sIG1fY3NzQW5pbWF0aW9uTGlzdC5n ZXQoKSk7CiAgICAgfSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9hbmltYXRpb24vV2Vi QW5pbWF0aW9uVXRpbGl0aWVzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2FuaW1hdGlvbi9XZWJBbmlt YXRpb25VdGlsaXRpZXMuY3BwCmluZGV4IDZkN2E2MGVkNTIzNjk1MGFhNzAyNGYyNWJiNmZiMmFi MGIwYjU5MDcuLjNjYTkyZDU4YjAzODZiYmUxOWU2ODBlYTliM2EzMGQzYWI5MzNhMDUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2FuaW1hdGlvbi9XZWJBbmltYXRpb25VdGlsaXRpZXMuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2FuaW1hdGlvbi9XZWJBbmltYXRpb25VdGlsaXRpZXMuY3Bw CkBAIC04NCwxMSArODQsMTMgQEAgYm9vbCBjb21wYXJlQW5pbWF0aW9uc0J5Q29tcG9zaXRlT3Jk ZXIoV2ViQW5pbWF0aW9uJiBsaHNBbmltYXRpb24sIFdlYkFuaW1hdGlvbiYKICAgICAgICAgfQog CiAgICAgICAgIC8vIFdlIHNob3VsZCBoYXZlIGZvdW5kIGVpdGhlciBvZiB0aG9zZSBDU1MgYW5p bWF0aW9ucyBpbiB0aGUgQ1NTIGFuaW1hdGlvbnMgbGlzdC4KLSAgICAgICAgQVNTRVJUX05PVF9S RUFDSEVEKCk7CisgICAgICAgIFJFTEVBU0VfQVNTRVJUX05PVF9SRUFDSEVEKCk7CiAgICAgfQog CiAgICAgLy8gSlMtb3JpZ2luYXRlZCBhbmltYXRpb25zIHNvcnQgbGFzdCBiYXNlZCBvbiB0aGVp ciBwb3NpdGlvbiBpbiB0aGUgZ2xvYmFsIGFuaW1hdGlvbiBsaXN0LgogICAgIC8vIGh0dHBzOi8v ZHJhZnRzLmNzc3dnLm9yZy93ZWItYW5pbWF0aW9ucy0xLyNhbmltYXRpb24tY29tcG9zaXRlLW9y ZGVyCisgICAgUkVMRUFTRV9BU1NFUlQobGhzQW5pbWF0aW9uLmdsb2JhbFBvc2l0aW9uKCkpOwor ICAgIFJFTEVBU0VfQVNTRVJUKGxoc0FuaW1hdGlvbi5nbG9iYWxQb3NpdGlvbigpKTsKICAgICBy ZXR1cm4gbGhzQW5pbWF0aW9uLmdsb2JhbFBvc2l0aW9uKCkgPCByaHNBbmltYXRpb24uZ2xvYmFs UG9zaXRpb24oKTsKIH0KIAo= 395647 2020-04-06 20:23:48 -0700 2020-04-07 01:26:05 -0700 Patch bug-210084-20200406202347.patch text/plain 3338 dougk U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5NTk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTkxMjg0YThmY2FjOGNh NDllMTZmMTE0Mzg4NDExYWFiM2QzNzJiYi4uM2Y4YWQ0NTgzZjI1ZTg1N2ViZmZjMGRmNzhkYzZk MzhhNmU5YWJiNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDIwLTA0LTA2ICBEb3Vn IEtlbGx5ICA8ZG91Z2tAYXBwbGUuY29tPgorCisgICAgICAgIEFkZCByZWxlYXNlIGFzc2VydHMg dG8gS2V5ZnJhbWVFZmZlY3RTdGFjazo6ZW5zdXJlRWZmZWN0c0FyZVNvcnRlZCgpCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTAwODQKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzYxMzU5Mjc1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFRvIGVuc3VyZSBhbnkgcG90ZW50aWFsIHByb2JsZW1zIGluIEtl eWZyYW1lRWZmZWN0U3RhY2s6OmVuc3VyZUVmZmVjdHNBcmVTb3J0ZWQoKSBhcmUgZm91bmQgY2xv c2VyIHRvIHRoZQorICAgICAgICByb290IGNhdXNlLCBhZGQgc2V2ZXJhbCBSRUxFQVNFX0FTU0VS VHMgdGhyb3VnaG91dCB0aGlzIGZ1bmN0aW9uIChhbmQgaXRzIGFzc29jaWF0ZWQgY29tcGFyaXNv biBmdW5jdGlvbikuCisgICAgICAgIFRoaXMgc2hvdWxkIGd1YXJkIGFnYWluc3QgbnVsbCBwb2lu dGVycy9udWxsIFdlYWtQdHJzLCBhcyB3ZWxsIGFzIG90aGVyIHN0YXRlIHByb2JsZW1zIHdoaWNo IHdvdWxkIGJlCisgICAgICAgIHVuZXhwZWN0ZWQgZm9yIHRoZSBjb21wYXJpc29uIGZ1bmN0aW9u IHVzZWQgYnkgc3RkOjpzb3J0LgorCisgICAgICAgIE5vIG5ldyB0ZXN0czsgdGhpcyBvbmx5IGFk ZHMgYWRkaXRpb25hbCBhc3NlcnRzLCBzbyB0aGVyZSBpcyBubyBjaGFuZ2UgdG8gZnVuY3Rpb25h bGl0eSwgYW5kIHRoaXMgY29kZSBpcworICAgICAgICBjb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3Rz LgorCisgICAgICAgICogYW5pbWF0aW9uL0tleWZyYW1lRWZmZWN0U3RhY2suY3BwOgorICAgICAg ICAoV2ViQ29yZTo6S2V5ZnJhbWVFZmZlY3RTdGFjazo6ZW5zdXJlRWZmZWN0c0FyZVNvcnRlZCk6 CisgICAgICAgICogYW5pbWF0aW9uL1dlYkFuaW1hdGlvblV0aWxpdGllcy5jcHA6CisgICAgICAg IChXZWJDb3JlOjpjb21wYXJlQW5pbWF0aW9uc0J5Q29tcG9zaXRlT3JkZXIpOgorCiAyMDIwLTA0 LTA2ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIFN0cmVuZ3Ro ZW4gdGhlIEFTU0VSVCBpbiBJbWFnZURlY29kZXJBVkZPYmpDOjpzdG9yZVNhbXBsZUJ1ZmZlcigp LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYW5pbWF0aW9uL0tleWZyYW1lRWZmZWN0U3Rh Y2suY3BwIGIvU291cmNlL1dlYkNvcmUvYW5pbWF0aW9uL0tleWZyYW1lRWZmZWN0U3RhY2suY3Bw CmluZGV4IDI2OThlYTMwOGRmYjcwMjczMjJkYmI0MWVkNjdiNjY1ZDU1ZmQ2YWMuLmQwYmQ3Y2Y1 Y2RlOTIyMzJlZDllNDY2NWVjOTNkY2NmODU5ZTQzODYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2FuaW1hdGlvbi9LZXlmcmFtZUVmZmVjdFN0YWNrLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9hbmltYXRpb24vS2V5ZnJhbWVFZmZlY3RTdGFjay5jcHAKQEAgLTgwLDExICs4MCwxNCBAQCB2 b2lkIEtleWZyYW1lRWZmZWN0U3RhY2s6OmVuc3VyZUVmZmVjdHNBcmVTb3J0ZWQoKQogICAgICAg ICByZXR1cm47CiAKICAgICBzdGQ6OnNvcnQobV9lZmZlY3RzLmJlZ2luKCksIG1fZWZmZWN0cy5l bmQoKSwgWyZdKGF1dG8mIGxocywgYXV0byYgcmhzKSB7CisgICAgICAgIFJFTEVBU0VfQVNTRVJU KGxocy5nZXQoKSk7CisgICAgICAgIFJFTEVBU0VfQVNTRVJUKHJocy5nZXQoKSk7CisgICAgICAg IAogICAgICAgICBhdXRvKiBsaHNBbmltYXRpb24gPSBsaHMtPmFuaW1hdGlvbigpOwogICAgICAg ICBhdXRvKiByaHNBbmltYXRpb24gPSByaHMtPmFuaW1hdGlvbigpOwogCi0gICAgICAgIEFTU0VS VChsaHNBbmltYXRpb24pOwotICAgICAgICBBU1NFUlQocmhzQW5pbWF0aW9uKTsKKyAgICAgICAg UkVMRUFTRV9BU1NFUlQobGhzQW5pbWF0aW9uKTsKKyAgICAgICAgUkVMRUFTRV9BU1NFUlQocmhz QW5pbWF0aW9uKTsKIAogICAgICAgICByZXR1cm4gY29tcGFyZUFuaW1hdGlvbnNCeUNvbXBvc2l0 ZU9yZGVyKCpsaHNBbmltYXRpb24sICpyaHNBbmltYXRpb24sIG1fY3NzQW5pbWF0aW9uTGlzdC5n ZXQoKSk7CiAgICAgfSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9hbmltYXRpb24vV2Vi QW5pbWF0aW9uVXRpbGl0aWVzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2FuaW1hdGlvbi9XZWJBbmlt YXRpb25VdGlsaXRpZXMuY3BwCmluZGV4IDZkN2E2MGVkNTIzNjk1MGFhNzAyNGYyNWJiNmZiMmFi MGIwYjU5MDcuLjY1MjZjNTE5ZWIyODg1M2M4ZDg0ZjIzZThlMjNmOTYxN2ZmMGIxMjAgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2FuaW1hdGlvbi9XZWJBbmltYXRpb25VdGlsaXRpZXMuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2FuaW1hdGlvbi9XZWJBbmltYXRpb25VdGlsaXRpZXMuY3Bw CkBAIC04NCwxMSArODQsMTIgQEAgYm9vbCBjb21wYXJlQW5pbWF0aW9uc0J5Q29tcG9zaXRlT3Jk ZXIoV2ViQW5pbWF0aW9uJiBsaHNBbmltYXRpb24sIFdlYkFuaW1hdGlvbiYKICAgICAgICAgfQog CiAgICAgICAgIC8vIFdlIHNob3VsZCBoYXZlIGZvdW5kIGVpdGhlciBvZiB0aG9zZSBDU1MgYW5p bWF0aW9ucyBpbiB0aGUgQ1NTIGFuaW1hdGlvbnMgbGlzdC4KLSAgICAgICAgQVNTRVJUX05PVF9S RUFDSEVEKCk7CisgICAgICAgIFJFTEVBU0VfQVNTRVJUX05PVF9SRUFDSEVEKCk7CiAgICAgfQog CiAgICAgLy8gSlMtb3JpZ2luYXRlZCBhbmltYXRpb25zIHNvcnQgbGFzdCBiYXNlZCBvbiB0aGVp ciBwb3NpdGlvbiBpbiB0aGUgZ2xvYmFsIGFuaW1hdGlvbiBsaXN0LgogICAgIC8vIGh0dHBzOi8v ZHJhZnRzLmNzc3dnLm9yZy93ZWItYW5pbWF0aW9ucy0xLyNhbmltYXRpb24tY29tcG9zaXRlLW9y ZGVyCisgICAgUkVMRUFTRV9BU1NFUlQobGhzQW5pbWF0aW9uLmdsb2JhbFBvc2l0aW9uKCkgIT0g cmhzQW5pbWF0aW9uLmdsb2JhbFBvc2l0aW9uKCkgfHwgJmxoc0FuaW1hdGlvbiA9PSAmcmhzQW5p bWF0aW9uKTsKICAgICByZXR1cm4gbGhzQW5pbWF0aW9uLmdsb2JhbFBvc2l0aW9uKCkgPCByaHNB bmltYXRpb24uZ2xvYmFsUG9zaXRpb24oKTsKIH0KIAo=