210078 2020-04-06 16:14:12 -0700 REGRESSION: 68000 JSC tests failing 2020-04-06 17:13:35 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=187526 InRadar P2 Normal --- 1 tsavell mark.lam ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bot-watchers-bugzilla webkit-bug-importer ysuzuki oldest_to_newest 1638354 0 tsavell 2020-04-06 16:14:12 -0700 recently 68000 JSC tests began failing. I do not have a solid regression point because the build stopped working on this queue today for a time. Build Queue: https://build.webkit.org/builders/Apple-Catalina-Debug-JSC-Tests?numbuilds=50 Build: https://build.webkit.org/builders/Apple-Catalina-Debug-JSC-Tests/builds/637 Stdio: https://build.webkit.org/builders/Apple-Catalina-Debug-JSC-Tests/builds/637/steps/jscore-test/logs/stdio 1638355 1 webkit-bug-importer 2020-04-06 16:15:13 -0700 <rdar://problem/61364513> 1638368 2 mark.lam 2020-04-06 16:36:53 -0700 This failure is caused by https://trac.webkit.org/r259587 for https://bugs.webkit.org/show_bug.cgi?id=187526. 1638374 3 395631 mark.lam 2020-04-06 16:44:09 -0700 Created attachment 395631 proposed patch. 1638375 4 395631 ysuzuki 2020-04-06 16:45:51 -0700 Comment on attachment 395631 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=395631&action=review r=me > Source/JavaScriptCore/jsc.cpp:603 > + RELEASE_ASSERT(!catchScope.exception()); how about using EXCEPTION_ASSERT? 1638378 5 mark.lam 2020-04-06 16:52:31 -0700 Thanks for the review. (In reply to Yusuke Suzuki from comment #4) > > Source/JavaScriptCore/jsc.cpp:603 > > + RELEASE_ASSERT(!catchScope.exception()); > > how about using EXCEPTION_ASSERT? Talked to Yusuke offline. Will use scope.releaseAssertNoException() instead. 1638386 6 mark.lam 2020-04-06 17:13:35 -0700 Landed in r259614: <http://trac.webkit.org/r259614>. 395631 2020-04-06 16:44:09 -0700 2020-04-06 16:45:51 -0700 proposed patch. bug-210078.patch text/plain 1845 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjU5NjExKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDIwLTA0LTA2ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBS RUdSRVNTSU9OOiA2ODAwMCBKU0MgdGVzdHMgZmFpbGluZy4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMDA3OAorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vNjEzNjQ1MTM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgVGhlIG1pc3NpbmcgZXhjZXB0aW9uIGNoZWNrIGlzIGluIGpzYyBzaGVsbCdzIEdsb2Jh bE9iamVjdDo6ZmluaXNoQ3JlYXRpb24oKS4KKyAgICAgICAgU2luY2UgdGhpcyBpcyBqdXN0IGEg ZGVidWdnaW5nIHRvb2wsIGFuZCB0aGlzIGV4Y2VwdGlvbiB3aWxsIG5ldmVyIGJlIHRocm93biBp bgorICAgICAgICBwcmFjdGljZSwgSSd2ZSBwbGFjYXRlZCB0aGUgdmFsaWRhdG9yIGJ5IFJFTEVB U0VfQVNTRVJUJ2luZyB0aGF0IHRoZSBleGNlcHRpb24KKyAgICAgICAgd2lsbCBuZXZlciBiZSB0 aHJvd24uCisKKyAgICAgICAgKiBqc2MuY3BwOgorCiAyMDIwLTA0LTA2ICBSb3NzIEtpcnNsaW5n ICA8cm9zcy5raXJzbGluZ0Bzb255LmNvbT4KIAogICAgICAgICBVcGRhdGUgbWluaW11bSBJQ1Ug dmVyc2lvbiB0byA2MC4yCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvanNjLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvanNjLmNwcAkocmV2aXNpb24gMjU5NjA1 KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2pzYy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ4 Niw2ICs0ODYsNyBAQCBwdWJsaWM6CiBwcm90ZWN0ZWQ6CiAgICAgdm9pZCBmaW5pc2hDcmVhdGlv bihWTSYgdm0sIGNvbnN0IFZlY3RvcjxTdHJpbmc+JiBhcmd1bWVudHMpCiAgICAgeworICAgICAg ICBhdXRvIGNhdGNoU2NvcGUgPSBERUNMQVJFX0NBVENIX1NDT1BFKHZtKTsKICAgICAgICAgQmFz ZTo6ZmluaXNoQ3JlYXRpb24odm0pOwogCiAgICAgICAgIGFkZEZ1bmN0aW9uKHZtLCAiZGVidWci LCBmdW5jdGlvbkRlYnVnLCAxKTsKQEAgLTU5OSw3ICs2MDAsOCBAQCBwcm90ZWN0ZWQ6CiAKICAg ICAgICAgSlNGdW5jdGlvbiogSXNIVE1MRERBR2V0dGVyID0gSlNGdW5jdGlvbjo6Y3JlYXRlKHZt LCB0aGlzLCAwLCAiSXNIVE1MRERBIl9zLCBmdW5jdGlvbk1ha2VNYXNxdWVyYWRlcik7CiAgICAg ICAgIGRvbGxhci0+cHV0R2V0dGVyKHRoaXMsIElkZW50aWZpZXI6OmZyb21TdHJpbmcodm0sICJJ c0hUTUxEREEiKSwgSXNIVE1MRERBR2V0dGVyLCBzdGF0aWNfY2FzdDx1bnNpZ25lZD4oUHJvcGVy dHlBdHRyaWJ1dGU6OkFjY2Vzc29yKSk7Ci0gICAgICAgIAorICAgICAgICBSRUxFQVNFX0FTU0VS VCghY2F0Y2hTY29wZS5leGNlcHRpb24oKSk7CisKICAgICAgICAgSlNPYmplY3QqIGFnZW50ID0g SlNGaW5hbE9iamVjdDo6Y3JlYXRlKHZtLCBwbGFpbk9iamVjdFN0cnVjdHVyZSk7CiAgICAgICAg IGRvbGxhci0+cHV0RGlyZWN0KHZtLCBJZGVudGlmaWVyOjpmcm9tU3RyaW5nKHZtLCAiYWdlbnQi KSwgYWdlbnQpOwogICAgICAgICAK