210057 2020-04-06 10:24:26 -0700 ImageDiff: Don't build with ASan in automation 2020-04-06 17:26:40 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=209963 https://bugs.webkit.org/show_bug.cgi?id=190327 InRadar P2 Normal --- 1 jbedard jbedard aakash_jain ap ddkilzer webkit-bug-importer oldest_to_newest 1638155 0 jbedard 2020-04-06 10:24:26 -0700 ImageDiff is crashing on some iOS Asan bots. This is one of the binaries that probably shouldn't be built with Asan in the first place, since it is not built with the target SDK. 1638156 1 jbedard 2020-04-06 10:24:52 -0700 <rdar://problem/61234753> 1638162 2 395584 jbedard 2020-04-06 10:36:23 -0700 Created attachment 395584 Patch 1638177 3 395584 ddkilzer 2020-04-06 11:03:56 -0700 Comment on attachment 395584 Patch r=me, although for the record, I always liked the idea of running tools with ASan because it would catch moar boogs. 1638178 4 395584 ddkilzer 2020-04-06 11:04:16 -0700 Comment on attachment 395584 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395584&action=review > Tools/ImageDiff/cg/Configurations/ImageDiff.xcconfig:1 > +// Copyright (C) 2009, 2020 Apple Inc. All rights reserved. Nit: Should be "2009-2020". 1638203 5 jbedard 2020-04-06 11:26:56 -0700 (In reply to David Kilzer (:ddkilzer) from comment #3) > Comment on attachment 395584 [details] > Patch > > r=me, although for the record, I always liked the idea of running tools with > ASan because it would catch moar boogs. For WebKitTetsRunner, TestWebKitAPI and friends, I totally agree. ImageDiff is a special situation, though, because it's always built with the Mac SDK, even when other projects are built with a different SDK (in this case, iOS was the SDK giving us issues). (just responding so we have a record of why I made this change to this particular tool in case someone wants to un-do this in the future :) ) 1638205 6 395595 jbedard 2020-04-06 11:31:05 -0700 Created attachment 395595 Patch for landing 1638284 7 ews-feeder 2020-04-06 13:35:21 -0700 Found 1 new test failure: inspector/canvas/shaderProgram-add-remove-webgpu.html 1638377 8 395595 jbedard 2020-04-06 16:46:42 -0700 Comment on attachment 395595 Patch for landing Commit queue is clearly wrong, this change could not have broken a test. 1638391 9 ews-feeder 2020-04-06 17:26:39 -0700 Committed r259616: <https://trac.webkit.org/changeset/259616> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395595. 395584 2020-04-06 10:36:23 -0700 2020-04-06 11:31:03 -0700 Patch bug-210057-20200406103622.patch text/plain 1498 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1OTU3NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDIwLTA0LTA2ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBJbWFnZURpZmY6IERvbid0IGJ1aWxkIHdpdGggQVNhbiBpbiBhdXRvbWF0 aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTAw NTcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzYxMjM0NzUzPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogSW1hZ2VEaWZmL2NnL0NvbmZpZ3VyYXRp b25zL0ltYWdlRGlmZi54Y2NvbmZpZzogRGlzYWJsZSBBU2FuLgorCiAyMDIwLTA0LTA0ICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBTdG9wIHVzaW5nIGxpdmUgcmFu Z2VzIGluIERvY3VtZW50TWFya2VyQ29udHJvbGxlcgpJbmRleDogVG9vbHMvSW1hZ2VEaWZmL2Nn L0NvbmZpZ3VyYXRpb25zL0ltYWdlRGlmZi54Y2NvbmZpZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9J bWFnZURpZmYvY2cvQ29uZmlndXJhdGlvbnMvSW1hZ2VEaWZmLnhjY29uZmlnCShyZXZpc2lvbiAy NTk1NzUpCisrKyBUb29scy9JbWFnZURpZmYvY2cvQ29uZmlndXJhdGlvbnMvSW1hZ2VEaWZmLnhj Y29uZmlnCSh3b3JraW5nIGNvcHkpCkBAIC0xLDQgKzEsNCBAQAotLy8gQ29weXJpZ2h0IChDKSAy MDA5IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKy8vIENvcHlyaWdodCAoQykgMjAw OSwgMjAyMCBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAvLwogLy8gUmVkaXN0cmli dXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0 CiAvLyBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93 aW5nIGNvbmRpdGlvbnMKQEAgLTI5LDMgKzI5LDUgQEAgUFJPRFVDVF9OQU1FID0gSW1hZ2VEaWZm OwogT1RIRVJfTERGTEFHU1tzZGs9bWFjb3N4Kl0gPSAkKGluaGVyaXRlZCkgLWZyYW1ld29yayBD YXJib24gLWZyYW1ld29yayBDb2NvYSAtZnJhbWV3b3JrIFF1YXJ0ekNvcmU7CiBPVEhFUl9MREZM QUdTW3Nkaz1pcGhvbmUqXSA9ICQoaW5oZXJpdGVkKSAtZnJhbWV3b3JrIENvcmVGb3VuZGF0aW9u IC1mcmFtZXdvcmsgQ29yZUdyYXBoaWNzIC1mcmFtZXdvcmsgTW9iaWxlQ29yZVNlcnZpY2VzIC1m cmFtZXdvcmsgSW1hZ2VJTzsKIFNUUklQX1NUWUxFID0gZGVidWdnaW5nOworCitXS19BU0FOX0RJ U0FMTE9XRUQgPSBZRVM7Cg== 395595 2020-04-06 11:31:05 -0700 2020-04-06 17:26:40 -0700 Patch for landing bug-210057-20200406113104.patch text/plain 1490 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1OTU4MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDIwLTA0LTA2ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBJbWFnZURpZmY6IERvbid0IGJ1aWxkIHdpdGggQVNhbiBpbiBhdXRvbWF0 aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTAw NTcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzYxMjM0NzUzPgorCisgICAgICAgIFJldmlld2Vk IGJ5IERhdmlkIEtpbHplci4KKworICAgICAgICAqIEltYWdlRGlmZi9jZy9Db25maWd1cmF0aW9u cy9JbWFnZURpZmYueGNjb25maWc6IERpc2FibGUgQVNhbi4KKwogMjAyMC0wNC0wNiAgU2FhbSBC YXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KIAogICAgICAgICBJbXBsZW1lbnQgMUdCIG9mIGV4 ZWN1dGFibGUgbWVtb3J5IG9uIGFybTY0CkluZGV4OiBUb29scy9JbWFnZURpZmYvY2cvQ29uZmln dXJhdGlvbnMvSW1hZ2VEaWZmLnhjY29uZmlnCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0ltYWdlRGlm Zi9jZy9Db25maWd1cmF0aW9ucy9JbWFnZURpZmYueGNjb25maWcJKHJldmlzaW9uIDI1OTU4MikK KysrIFRvb2xzL0ltYWdlRGlmZi9jZy9Db25maWd1cmF0aW9ucy9JbWFnZURpZmYueGNjb25maWcJ KHdvcmtpbmcgY29weSkKQEAgLTEsNCArMSw0IEBACi0vLyBDb3B5cmlnaHQgKEMpIDIwMDkgQXBw bGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorLy8gQ29weXJpZ2h0IChDKSAyMDA5LTIwMjAg QXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogLy8KIC8vIFJlZGlzdHJpYnV0aW9uIGFu ZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogLy8gbW9k aWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25k aXRpb25zCkBAIC0yOSwzICsyOSw1IEBAIFBST0RVQ1RfTkFNRSA9IEltYWdlRGlmZjsKIE9USEVS X0xERkxBR1Nbc2RrPW1hY29zeCpdID0gJChpbmhlcml0ZWQpIC1mcmFtZXdvcmsgQ2FyYm9uIC1m cmFtZXdvcmsgQ29jb2EgLWZyYW1ld29yayBRdWFydHpDb3JlOwogT1RIRVJfTERGTEFHU1tzZGs9 aXBob25lKl0gPSAkKGluaGVyaXRlZCkgLWZyYW1ld29yayBDb3JlRm91bmRhdGlvbiAtZnJhbWV3 b3JrIENvcmVHcmFwaGljcyAtZnJhbWV3b3JrIE1vYmlsZUNvcmVTZXJ2aWNlcyAtZnJhbWV3b3Jr IEltYWdlSU87CiBTVFJJUF9TVFlMRSA9IGRlYnVnZ2luZzsKKworV0tfQVNBTl9ESVNBTExPV0VE ID0gWUVTOwo=