210049 2020-04-06 08:27:32 -0700 ProcessAssertion should use ASCIILiteral for its reason 2020-04-06 11:41:10 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=209984 InRadar P2 Normal --- 209990 1 cdumez cdumez achristensen darin ggaren webkit-bug-importer oldest_to_newest 1638098 0 cdumez 2020-04-06 08:27:32 -0700 ProcessAssertion should use ASCIILiteral for its reason, instead of a String. 1638101 1 395568 cdumez 2020-04-06 08:29:40 -0700 Created attachment 395568 Patch 1638124 2 achristensen 2020-04-06 09:45:30 -0700 Why? 1638126 3 cdumez 2020-04-06 09:47:48 -0700 (In reply to Alex Christensen from comment #2) > Why? https://bugs.webkit.org/show_bug.cgi?id=209984#c3 1638144 4 395568 achristensen 2020-04-06 10:17:19 -0700 Comment on attachment 395568 Patch This seems silly to me. The API takes an NSString. Using stringWithCString and NSASCIIStringEncoding doesn't improve anything. This is just documenting that all the strings we use happen to be ASCII right now. 1638159 5 darin 2020-04-06 10:31:35 -0700 (In reply to Alex Christensen from comment #4) > This seems silly to me. The API takes an NSString. Using stringWithCString > and NSASCIIStringEncoding doesn't improve anything. This is just > documenting that all the strings we use happen to be ASCII right now. Seems great to me. Why turn literals into WTF::String just to turn them into NSString later? These are labels from the code, not arbitrary strings. 1638181 6 ews-feeder 2020-04-06 11:07:31 -0700 Committed r259579: <https://trac.webkit.org/changeset/259579> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395568. 1638182 7 webkit-bug-importer 2020-04-06 11:08:17 -0700 <rdar://problem/61350171> 1638211 8 achristensen 2020-04-06 11:41:10 -0700 I guess that's true. This reduces a few WTF::String constructions. 395568 2020-04-06 08:29:40 -0700 2020-04-06 11:07:31 -0700 Patch bug-210049-20200406082939.patch text/plain 6468 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5NTY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDM4MzQ2YzI5ZDk5MGQ0OWUy NDljY2UzNjIxYmIyMzc1Y2QxYTJhNzAuLmUxNWNjNGY2YWExZDYyMjFiY2Y0NDg3ZmJlNmY0Yzkw OWYyODQzZDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMjAtMDQtMDYgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBQcm9jZXNzQXNzZXJ0aW9uIHNob3Vs ZCB1c2UgQVNDSUlMaXRlcmFsIGZvciBpdHMgcmVhc29uCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTAwNDkKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQcm9jZXNzQXNzZXJ0aW9uIHNob3VsZCB1c2UgQVND SUlMaXRlcmFsIGZvciBpdHMgcmVhc29uLCBpbnN0ZWFkIG9mIGEgU3RyaW5nLgorCisgICAgICAg ICogU2hhcmVkL2lvcy9EZXBlbmRlbmN5UHJvY2Vzc0Fzc2VydGlvbklPUy5tbToKKyAgICAgICAg KFdlYktpdDo6RGVwZW5kZW5jeVByb2Nlc3NBc3NlcnRpb246OkRlcGVuZGVuY3lQcm9jZXNzQXNz ZXJ0aW9uKToKKyAgICAgICAgKiBVSVByb2Nlc3MvUHJvY2Vzc0Fzc2VydGlvbi5jcHA6CisgICAg ICAgIChXZWJLaXQ6OlByb2Nlc3NBc3NlcnRpb246OlByb2Nlc3NBc3NlcnRpb24pOgorICAgICAg ICAqIFVJUHJvY2Vzcy9Qcm9jZXNzQXNzZXJ0aW9uLmg6CisgICAgICAgICogVUlQcm9jZXNzL2lv cy9Qcm9jZXNzQXNzZXJ0aW9uSU9TLm1tOgorICAgICAgICAoV2ViS2l0OjpQcm9jZXNzQXNzZXJ0 aW9uOjpQcm9jZXNzQXNzZXJ0aW9uKToKKyAgICAgICAgKFdlYktpdDo6UHJvY2Vzc0FuZFVJQXNz ZXJ0aW9uOjpQcm9jZXNzQW5kVUlBc3NlcnRpb24pOgorCiAyMDIwLTA0LTA2ICB5b3Vlbm4gZmFi bGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgSEVWQyBzdXBwb3J0IGluIEdQ VSBQcm9jZXNzIGZvciBXZWJSVEMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL2lv cy9EZXBlbmRlbmN5UHJvY2Vzc0Fzc2VydGlvbklPUy5tbSBiL1NvdXJjZS9XZWJLaXQvU2hhcmVk L2lvcy9EZXBlbmRlbmN5UHJvY2Vzc0Fzc2VydGlvbklPUy5tbQppbmRleCAzZjVkYjhmMTQ1YzY0 YjI3NmIyZjY0NDc3OTQ4NjYyZjljMjA2YzgzLi45ZjIwYWVjZjFkYzY4ZGRlMDQwNDgwY2ZjMDNj MmM4OTI2OGZiYjI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9pb3MvRGVwZW5k ZW5jeVByb2Nlc3NBc3NlcnRpb25JT1MubW0KKysrIGIvU291cmNlL1dlYktpdC9TaGFyZWQvaW9z L0RlcGVuZGVuY3lQcm9jZXNzQXNzZXJ0aW9uSU9TLm1tCkBAIC0zNiw3ICszNiw5IEBAIERlcGVu ZGVuY3lQcm9jZXNzQXNzZXJ0aW9uOjpEZXBlbmRlbmN5UHJvY2Vzc0Fzc2VydGlvbihQcm9jZXNz SUQgdGFyZ2V0UElELCBBU0NJCiB7CiAgICAgUkJTVGFyZ2V0ICp0YXJnZXQgPSBbUkJTVGFyZ2V0 IHRhcmdldFdpdGhQaWQ6dGFyZ2V0UElEXTsKICAgICBSQlNEb21haW5BdHRyaWJ1dGUgKmRvbWFp bkF0dHJpYnV0ZSA9IFtSQlNEb21haW5BdHRyaWJ1dGUgYXR0cmlidXRlV2l0aERvbWFpbjpAImNv bS5hcHBsZS53ZWJraXQiIG5hbWU6QCJEZXBlbmRlbnRQcm9jZXNzTGluayJdOwotICAgIG1fYXNz ZXJ0aW9uID0gYWRvcHROUyhbW1JCU0Fzc2VydGlvbiBhbGxvY10gaW5pdFdpdGhFeHBsYW5hdGlv bjpTdHJpbmcgeyBkZXNjcmlwdGlvbiB9IHRhcmdldDp0YXJnZXQgYXR0cmlidXRlczpAW2RvbWFp bkF0dHJpYnV0ZV1dKTsKKworICAgIE5TU3RyaW5nICpuc0Rlc2NyaXB0aW9uID0gW05TU3RyaW5n IHN0cmluZ1dpdGhDU3RyaW5nOmRlc2NyaXB0aW9uLmNoYXJhY3RlcnMoKSBlbmNvZGluZzpOU0FT Q0lJU3RyaW5nRW5jb2RpbmddOworICAgIG1fYXNzZXJ0aW9uID0gYWRvcHROUyhbW1JCU0Fzc2Vy dGlvbiBhbGxvY10gaW5pdFdpdGhFeHBsYW5hdGlvbjpuc0Rlc2NyaXB0aW9uIHRhcmdldDp0YXJn ZXQgYXR0cmlidXRlczpAW2RvbWFpbkF0dHJpYnV0ZV1dKTsKICAgICBOU0Vycm9yICphY3F1aXNp dGlvbkVycm9yID0gbmlsOwogICAgIGlmICghW21fYXNzZXJ0aW9uIGFjcXVpcmVXaXRoRXJyb3I6 JmFjcXVpc2l0aW9uRXJyb3JdKQogICAgICAgICBSRUxFQVNFX0xPR19FUlJPUihQcm9jZXNzLCAi RGVwZW5kZW5jeVByb2Nlc3NBc3NlcnRpb246OkRlcGVuZGVuY3lQcm9jZXNzQXNzZXJ0aW9uOiBG YWlsZWQgdG8gYWNxdWlyZSBkZXBlbmRlbmN5IHByb2Nlc3MgYXNzZXJ0aW9uICcle3B1YmxpY31z JywgZXJyb3I6ICV7cHVibGljfUAiLCBkZXNjcmlwdGlvbi5jaGFyYWN0ZXJzKCksIGFjcXVpc2l0 aW9uRXJyb3IpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvUHJvY2Vzc0Fz c2VydGlvbi5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Qcm9jZXNzQXNzZXJ0aW9uLmNw cAppbmRleCA3MTJkMjBhZTAxYWY4NTdiNjY1MjkxNDkzMWU0ZDRlNTU5ZTNjNDNhLi42MzJlNDU2 ZDZjZWRmZTg4OWNlMmY4ZWZiNDcwZDE5MGMzNGQ3NmI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9Qcm9jZXNzQXNzZXJ0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9Qcm9jZXNzQXNzZXJ0aW9uLmNwcApAQCAtMzIsNyArMzIsNyBAQAogCiBuYW1lc3Bh Y2UgV2ViS2l0IHsKIAotUHJvY2Vzc0Fzc2VydGlvbjo6UHJvY2Vzc0Fzc2VydGlvbihQcm9jZXNz SUQsIGNvbnN0IFN0cmluZyYsIFByb2Nlc3NBc3NlcnRpb25UeXBlIGFzc2VydGlvblR5cGUpCitQ cm9jZXNzQXNzZXJ0aW9uOjpQcm9jZXNzQXNzZXJ0aW9uKFByb2Nlc3NJRCwgQVNDSUlMaXRlcmFs LCBQcm9jZXNzQXNzZXJ0aW9uVHlwZSBhc3NlcnRpb25UeXBlKQogICAgIDogbV9hc3NlcnRpb25U eXBlKGFzc2VydGlvblR5cGUpCiB7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9Qcm9jZXNzQXNzZXJ0aW9uLmggYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Qcm9jZXNz QXNzZXJ0aW9uLmgKaW5kZXggNTc3YmJjMjAzNjczMDQ3MDU0MGE5Y2M3NGQyNzg4MmM4Yjg1ZTZk Zi4uYThjNDQyMjkwMzBjZTczZGJjNDY5YTU5YTUzNjVlN2MxYTM4OWUyYSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvUHJvY2Vzc0Fzc2VydGlvbi5oCisrKyBiL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL1Byb2Nlc3NBc3NlcnRpb24uaApAQCAtNTgsNyArNTgsNyBAQCBwdWJs aWM6CiAgICAgICAgIHZpcnR1YWwgdm9pZCB1aUFzc2VydGlvbldpbGxFeHBpcmVJbW1pbmVudGx5 KCkgPSAwOwogICAgIH07CiAKLSAgICBQcm9jZXNzQXNzZXJ0aW9uKFByb2Nlc3NJRCwgY29uc3Qg U3RyaW5nJiByZWFzb24sIFByb2Nlc3NBc3NlcnRpb25UeXBlKTsKKyAgICBQcm9jZXNzQXNzZXJ0 aW9uKFByb2Nlc3NJRCwgQVNDSUlMaXRlcmFsIHJlYXNvbiwgUHJvY2Vzc0Fzc2VydGlvblR5cGUp OwogICAgIHZpcnR1YWwgflByb2Nlc3NBc3NlcnRpb24oKTsKIAogICAgIHZvaWQgc2V0Q2xpZW50 KENsaWVudCYgY2xpZW50KSB7IG1fY2xpZW50ID0gJmNsaWVudDsgfQpAQCAtODcsNyArODcsNyBA QCBwcml2YXRlOgogCiBjbGFzcyBQcm9jZXNzQW5kVUlBc3NlcnRpb24gZmluYWwgOiBwdWJsaWMg UHJvY2Vzc0Fzc2VydGlvbiB7CiBwdWJsaWM6Ci0gICAgUHJvY2Vzc0FuZFVJQXNzZXJ0aW9uKFBy b2Nlc3NJRCwgY29uc3QgU3RyaW5nJiByZWFzb24sIFByb2Nlc3NBc3NlcnRpb25UeXBlKTsKKyAg ICBQcm9jZXNzQW5kVUlBc3NlcnRpb24oUHJvY2Vzc0lELCBBU0NJSUxpdGVyYWwgcmVhc29uLCBQ cm9jZXNzQXNzZXJ0aW9uVHlwZSk7CiAgICAgflByb2Nlc3NBbmRVSUFzc2VydGlvbigpOwogCiAg ICAgdm9pZCB1aUFzc2VydGlvbldpbGxFeHBpcmVJbW1pbmVudGx5KCk7CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvUHJvY2Vzc0Fzc2VydGlvbklPUy5tbSBiL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9Qcm9jZXNzQXNzZXJ0aW9uSU9TLm1tCmluZGV4IDEyMmMx NmE1NWVmMmI4MjJhYzZlNjFiZjQ1Y2M3Yzg1YTc0ZTkwM2MuLjhmMTczYWRiMzYxOWFmYjI4MGFi NmY5ZThiM2E5NTZkMDBkZjBjMDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L2lvcy9Qcm9jZXNzQXNzZXJ0aW9uSU9TLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L2lvcy9Qcm9jZXNzQXNzZXJ0aW9uSU9TLm1tCkBAIC0yOTksNyArMjk5LDcgQEAgc3RhdGljIEJL U1Byb2Nlc3NBc3NlcnRpb25SZWFzb24gdG9CS1NQcm9jZXNzQXNzZXJ0aW9uUmVhc29uKFByb2Nl c3NBc3NlcnRpb25UeXAKICAgICB9CiB9CiAKLVByb2Nlc3NBc3NlcnRpb246OlByb2Nlc3NBc3Nl cnRpb24ocGlkX3QgcGlkLCBjb25zdCBTdHJpbmcmIG5hbWUsIFByb2Nlc3NBc3NlcnRpb25UeXBl IGFzc2VydGlvblR5cGUpCitQcm9jZXNzQXNzZXJ0aW9uOjpQcm9jZXNzQXNzZXJ0aW9uKHBpZF90 IHBpZCwgQVNDSUlMaXRlcmFsIHJlYXNvbiwgUHJvY2Vzc0Fzc2VydGlvblR5cGUgYXNzZXJ0aW9u VHlwZSkKICAgICA6IG1fYXNzZXJ0aW9uVHlwZShhc3NlcnRpb25UeXBlKQogewogICAgIGF1dG8g d2Vha1RoaXMgPSBtYWtlV2Vha1B0cigqdGhpcyk7CkBAIC0zMTIsOSArMzEyLDExIEBAIFByb2Nl c3NBc3NlcnRpb246OlByb2Nlc3NBc3NlcnRpb24ocGlkX3QgcGlkLCBjb25zdCBTdHJpbmcmIG5h bWUsIFByb2Nlc3NBc3NlcnRpCiAgICAgICAgICAgICB9KTsKICAgICAgICAgfQogICAgIH07Ci0g ICAgUkVMRUFTRV9MT0coUHJvY2Vzc1N1c3BlbnNpb24sICIlcCAtIFByb2Nlc3NBc3NlcnRpb24o KSBQSUQgJWQgYWNxdWlyaW5nIGFzc2VydGlvbiBmb3IgcHJvY2VzcyB3aXRoIFBJRCAlZCwgbmFt ZSAnJXMnIiwgdGhpcywgZ2V0cGlkKCksIHBpZCwgbmFtZS51dGY4KCkuZGF0YSgpKTsKKyAgICBS RUxFQVNFX0xPRyhQcm9jZXNzU3VzcGVuc2lvbiwgIiVwIC0gUHJvY2Vzc0Fzc2VydGlvbigpIFBJ RCAlZCBhY3F1aXJpbmcgYXNzZXJ0aW9uIGZvciBwcm9jZXNzIHdpdGggUElEICVkLCBuYW1lICcl cyciLCB0aGlzLCBnZXRwaWQoKSwgcGlkLCByZWFzb24uY2hhcmFjdGVycygpKTsKICAgICAKLSAg ICBtX2Fzc2VydGlvbiA9IGFkb3B0TlMoW1tCS1NQcm9jZXNzQXNzZXJ0aW9uIGFsbG9jXSBpbml0 V2l0aFBJRDpwaWQgZmxhZ3M6ZmxhZ3NGb3JBc3NlcnRpb25UeXBlKGFzc2VydGlvblR5cGUpIHJl YXNvbjp0b0JLU1Byb2Nlc3NBc3NlcnRpb25SZWFzb24oYXNzZXJ0aW9uVHlwZSkgbmFtZTooTlNT dHJpbmcgKiluYW1lIHdpdGhIYW5kbGVyOmhhbmRsZXJdKTsKKyAgICBOU1N0cmluZyAqbnNSZWFz b24gPSBbTlNTdHJpbmcgc3RyaW5nV2l0aENTdHJpbmc6cmVhc29uLmNoYXJhY3RlcnMoKSBlbmNv ZGluZzpOU0FTQ0lJU3RyaW5nRW5jb2RpbmddOworICAgIG1fYXNzZXJ0aW9uID0gYWRvcHROUyhb W0JLU1Byb2Nlc3NBc3NlcnRpb24gYWxsb2NdIGluaXRXaXRoUElEOnBpZCBmbGFnczpmbGFnc0Zv ckFzc2VydGlvblR5cGUoYXNzZXJ0aW9uVHlwZSkgcmVhc29uOnRvQktTUHJvY2Vzc0Fzc2VydGlv blJlYXNvbihhc3NlcnRpb25UeXBlKSBuYW1lOm5zUmVhc29uIHdpdGhIYW5kbGVyOmhhbmRsZXJd KTsKKwogICAgIG1fYXNzZXJ0aW9uLmdldCgpLmludmFsaWRhdGlvbkhhbmRsZXIgPSBeKCkgewog ICAgICAgICBkaXNwYXRjaF9hc3luYyhkaXNwYXRjaF9nZXRfbWFpbl9xdWV1ZSgpLCBeewogICAg ICAgICAgICAgUkVMRUFTRV9MT0coUHJvY2Vzc1N1c3BlbnNpb24sICIlcCAtIFByb2Nlc3NBc3Nl cnRpb24oKSBQcm9jZXNzIGFzc2VydGlvbiBmb3IgcHJvY2VzcyB3aXRoIFBJRCAlZCB3YXMgaW52 YWxpZGF0ZWQiLCB0aGlzLCBwaWQpOwpAQCAtMzU0LDcgKzM1Niw3IEBAIHZvaWQgUHJvY2Vzc0Fu ZFVJQXNzZXJ0aW9uOjp1cGRhdGVSdW5JbkJhY2tncm91bmRDb3VudCgpCiAgICAgbV9pc0hvbGRp bmdCYWNrZ3JvdW5kVGFzayA9IHNob3VsZEhvbGRCYWNrZ3JvdW5kVGFzazsKIH0KIAotUHJvY2Vz c0FuZFVJQXNzZXJ0aW9uOjpQcm9jZXNzQW5kVUlBc3NlcnRpb24ocGlkX3QgcGlkLCBjb25zdCBT dHJpbmcmIHJlYXNvbiwgUHJvY2Vzc0Fzc2VydGlvblR5cGUgYXNzZXJ0aW9uVHlwZSkKK1Byb2Nl c3NBbmRVSUFzc2VydGlvbjo6UHJvY2Vzc0FuZFVJQXNzZXJ0aW9uKHBpZF90IHBpZCwgQVNDSUlM aXRlcmFsIHJlYXNvbiwgUHJvY2Vzc0Fzc2VydGlvblR5cGUgYXNzZXJ0aW9uVHlwZSkKICAgICA6 IFByb2Nlc3NBc3NlcnRpb24ocGlkLCByZWFzb24sIGFzc2VydGlvblR5cGUpCiB7CiAgICAgdXBk YXRlUnVuSW5CYWNrZ3JvdW5kQ291bnQoKTsK