210045 2020-04-06 05:12:51 -0700 Remove instance fields and methods from StyleColor 2020-04-06 08:34:14 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned esprehn+autocc ews-watchlist glenn gyuyoung.kim macpherson menard simon.fraser webkit-bug-importer zalan oldest_to_newest 1638069 0 koivisto 2020-04-06 05:12:51 -0700 They are unused. The type can remain as a namespace for static functions. 1638070 1 395559 koivisto 2020-04-06 05:17:24 -0700 Created attachment 395559 patch 1638103 2 ews-feeder 2020-04-06 08:33:41 -0700 Committed r259571: <https://trac.webkit.org/changeset/259571> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395559. 1638104 3 webkit-bug-importer 2020-04-06 08:34:14 -0700 <rdar://problem/61343451> 395559 2020-04-06 05:17:24 -0700 2020-04-06 08:33:42 -0700 patch stylecolor-no-instance.patch text/plain 2582 koivisto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiMDY0YWVhZDczNC4uNzY1ZGMxNmZhN2EgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMiBAQAorMjAyMC0wNC0wNiAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+ CisKKyAgICAgICAgUmVtb3ZlIGluc3RhbmNlIGZpZWxkcyBhbmQgbWV0aG9kcyBmcm9tIFN0eWxl Q29sb3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIx MDA0NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo ZXkgYXJlIHVudXNlZC4gVGhlIHR5cGUgaXRzZWxmIHJlbWFpbnMgYXMgYSBuYW1lc3BhY2UgZm9y IHN0YXRpYyBmdW5jdGlvbnMuCisgICAgICAgIFdlIG1pZ2h0IHdhbnQgYnJpbmcgaXQgYmFjayBs YXRlciBidXQgdGhlcmUgaXMgbm8gbmVlZCB0byBsZWF2ZSBkZWFkIGNvZGUgYXJvdW5kIG5vdy4K KworICAgICAgICAqIGNzcy9TdHlsZUNvbG9yLmg6CisgICAgICAgIChXZWJDb3JlOjpTdHlsZUNv bG9yOjpTdHlsZUNvbG9yKTogRGVsZXRlZC4KKyAgICAgICAgKFdlYkNvcmU6OlN0eWxlQ29sb3I6 OmN1cnJlbnRDb2xvcik6IERlbGV0ZWQuCisgICAgICAgIChXZWJDb3JlOjpTdHlsZUNvbG9yOjpp c0N1cnJlbnRDb2xvciBjb25zdCk6IERlbGV0ZWQuCisgICAgICAgIChXZWJDb3JlOjpTdHlsZUNv bG9yOjpnZXRDb2xvciBjb25zdCk6IERlbGV0ZWQuCisgICAgICAgIChXZWJDb3JlOjpTdHlsZUNv bG9yOjpyZXNvbHZlIGNvbnN0KTogRGVsZXRlZC4KKyAgICAgICAgKFdlYkNvcmU6Om9wZXJhdG9y PT0pOiBEZWxldGVkLgorICAgICAgICAoV2ViQ29yZTo6b3BlcmF0b3IhPSk6IERlbGV0ZWQuCisK IDIwMjAtMDQtMDYgIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAg ICdjdXJyZW50Y29sb3InIGRvZXNuJ3QgbmVlZCBzZXRIYXNFeHBsaWNpdGx5SW5oZXJpdGVkUHJv cGVydGllcyBtYXJraW5nIGFueW1vcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9T dHlsZUNvbG9yLmggYi9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVDb2xvci5oCmluZGV4IDgwMDM0 M2E5M2NjLi45ZmRkY2I0MmUxMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxl Q29sb3IuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVDb2xvci5oCkBAIC0zNywyMCAr MzcsNyBAQAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKLWNsYXNzIFN0eWxlQ29sb3IgewotcHVi bGljOgotICAgIFN0eWxlQ29sb3IoKQotICAgICAgICA6IG1fY3VycmVudENvbG9yKHRydWUpIHsg fQotICAgIFN0eWxlQ29sb3IoQ29sb3IgY29sb3IpCi0gICAgICAgIDogbV9jb2xvcihjb2xvcikK LSAgICAgICAgLCBtX2N1cnJlbnRDb2xvcihmYWxzZSkgeyB9Ci0gICAgc3RhdGljIFN0eWxlQ29s b3IgY3VycmVudENvbG9yKCkgeyByZXR1cm4gU3R5bGVDb2xvcigpOyB9Ci0KLSAgICBib29sIGlz Q3VycmVudENvbG9yKCkgY29uc3QgeyByZXR1cm4gbV9jdXJyZW50Q29sb3I7IH0KLSAgICBjb25z dCBDb2xvciYgZ2V0Q29sb3IoKSBjb25zdCB7IEFTU0VSVCghaXNDdXJyZW50Q29sb3IoKSk7IHJl dHVybiBtX2NvbG9yOyB9Ci0KLSAgICBjb25zdCBDb2xvciYgcmVzb2x2ZShjb25zdCBDb2xvciYg Y3VycmVudENvbG9yKSBjb25zdCB7IHJldHVybiBtX2N1cnJlbnRDb2xvciA/IGN1cnJlbnRDb2xv ciA6IG1fY29sb3I7IH0KLQorc3RydWN0IFN0eWxlQ29sb3IgewogICAgIGVudW0gY2xhc3MgT3B0 aW9ucyA6IHVpbnQ4X3QgewogICAgICAgICBGb3JWaXNpdGVkTGluayA9IDEgPDwgMCwKICAgICAg ICAgVXNlU3lzdGVtQXBwZWFyYW5jZSA9IDEgPDwgMSwKQEAgLTYxLDIzICs0OCw2IEBAIHB1Ymxp YzoKICAgICBzdGF0aWMgQ29sb3IgY29sb3JGcm9tS2V5d29yZChDU1NWYWx1ZUlELCBPcHRpb25T ZXQ8T3B0aW9ucz4pOwogICAgIHN0YXRpYyBib29sIGlzQ29sb3JLZXl3b3JkKENTU1ZhbHVlSUQp OwogICAgIFdFQkNPUkVfRVhQT1JUIHN0YXRpYyBib29sIGlzU3lzdGVtQ29sb3IoQ1NTVmFsdWVJ RCk7Ci0KLXByaXZhdGU6Ci0gICAgQ29sb3IgbV9jb2xvcjsKLSAgICBib29sIG1fY3VycmVudENv bG9yOwogfTsKIAotaW5saW5lIGJvb2wgb3BlcmF0b3I9PShjb25zdCBTdHlsZUNvbG9yJiBhLCBj b25zdCBTdHlsZUNvbG9yJiBiKQotewotICAgIGlmIChhLmlzQ3VycmVudENvbG9yKCkgfHwgYi5p c0N1cnJlbnRDb2xvcigpKQotICAgICAgICByZXR1cm4gYS5pc0N1cnJlbnRDb2xvcigpICYmIGIu aXNDdXJyZW50Q29sb3IoKTsKLSAgICByZXR1cm4gYS5nZXRDb2xvcigpID09IGIuZ2V0Q29sb3Io KTsKLX0KLQotaW5saW5lIGJvb2wgb3BlcmF0b3IhPShjb25zdCBTdHlsZUNvbG9yJiBhLCBjb25z dCBTdHlsZUNvbG9yJiBiKQotewotICAgIHJldHVybiAhKGEgPT0gYik7Ci19Ci0KLQogfSAvLyBu YW1lc3BhY2UgV2ViQ29yZQo=