210040 2020-04-05 16:18:41 -0700 CrashTracer: MobileSafari at WebKit: WebKit::SystemPreviewController::updateProgress 2020-04-06 11:08:57 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino darin webkit-bug-importer oldest_to_newest 1637982 0 dino 2020-04-05 16:18:41 -0700 CrashTracer: MobileSafari at WebKit: WebKit::SystemPreviewController::updateProgress 1637983 1 dino 2020-04-05 16:19:20 -0700 rdar://51410841 1637987 2 395534 dino 2020-04-05 16:28:33 -0700 Created attachment 395534 Patch 1637988 3 395534 darin 2020-04-05 16:36:34 -0700 Comment on attachment 395534 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395534&action=review > Source/WebKit/UIProcess/Cocoa/DownloadClient.mm:70 > + auto* webPage = downloadProxy.originatingPage(); Just page? 1638173 4 395534 dino 2020-04-06 11:00:01 -0700 Comment on attachment 395534 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395534&action=review >> Source/WebKit/UIProcess/Cocoa/DownloadClient.mm:70 >> + auto* webPage = downloadProxy.originatingPage(); > > Just page? Will fix. 1638184 5 dino 2020-04-06 11:08:57 -0700 Committed r259580: <https://trac.webkit.org/changeset/259580> 395534 2020-04-05 16:28:33 -0700 2020-04-05 16:36:34 -0700 Patch bug-210040-20200406092832.patch text/plain 5694 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5MjM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGNiZWI4MjU4NzI4NjcwNDdj NzJjZjVmNTViOGU0MTYwYmQ5MjRlOGEuLmQ3OWMzMDc2YTViZjk0ODMzNTE5YmFiNGViMjEyZDI5 YzA0MjBkYjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMjAtMDQtMDUgIERlYW4gSmFj a3NvbiAgPGRpbm9AYXBwbGUuY29tPgorCisgICAgICAgIENyYXNoVHJhY2VyOiBNb2JpbGVTYWZh cmkgYXQgV2ViS2l0OiBXZWJLaXQ6OlN5c3RlbVByZXZpZXdDb250cm9sbGVyOjp1cGRhdGVQcm9n cmVzcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEw MDQwCisgICAgICAgIHJkYXI6Ly81MTQxMDg0MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEl0IGFwcGVhcnMgdGhhdCB0aGUgU3lzdGVtUHJldmlld0Nv bnRyb2xsZXIgb24gV2ViUGFnZVByb3h5IGNhbgorICAgICAgICBiZWNvbWUgbnVsbCBjYXVzaW5n IGEgY2FsbCB0byBhbiBpbi1wcm9ncmVzcyBkb3dubG9hZCB0byBjcmFzaAorICAgICAgICBhcyBp dCB0cmllcyB0byB0YWxrIHRvIHRoZSBRdWlja0xvb2sgZGVsZWdhdGUuIEd1YXJkIGFnYWluc3Qg dGhpcworICAgICAgICBieSBjaGVja2luZyB0aGUgU3lzdGVtUHJldmlld0NvbnRyb2xsZXIgZWFj aCB0aW1lLgorCisgICAgICAgICogVUlQcm9jZXNzL0NvY29hL0Rvd25sb2FkQ2xpZW50Lm1tOgor ICAgICAgICAoV2ViS2l0OjpzeXN0ZW1QcmV2aWV3Q29udHJvbGxlcik6CisgICAgICAgIChXZWJL aXQ6OkRvd25sb2FkQ2xpZW50OjpkaWRSZWNlaXZlUmVzcG9uc2UpOgorICAgICAgICAoV2ViS2l0 OjpEb3dubG9hZENsaWVudDo6ZGlkUmVjZWl2ZURhdGEpOgorICAgICAgICAoV2ViS2l0OjpEb3du bG9hZENsaWVudDo6cHJvY2Vzc0RpZENyYXNoKToKKyAgICAgICAgKFdlYktpdDo6RG93bmxvYWRD bGllbnQ6OmRpZEZpbmlzaCk6CisgICAgICAgIChXZWJLaXQ6OkRvd25sb2FkQ2xpZW50OjpkaWRG YWlsKToKKyAgICAgICAgKFdlYktpdDo6RG93bmxvYWRDbGllbnQ6OmRpZENhbmNlbCk6CisKIDIw MjAtMDMtMzAgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFdl YiBJbnNwZWN0b3I6IHByb3ZpZGUgYSB3YXkgdG8gbG9nIG1lc3NhZ2VzIGZyb20gdGhlIG5ldHdv cmsgcHJvY2VzcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvRG93 bmxvYWRDbGllbnQubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9Eb3dubG9hZENs aWVudC5tbQppbmRleCA2NGUzNjVlZGNmZmFjZGE1YWVhYzY3MDkwMDM2ZjlmZTEwYmY0ZDk1Li40 NTA0OTA2YWU2MmEyNmQ0MDJhYzViODUxM2MxMGQ5OThmY2QwMDQyIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9Eb3dubG9hZENsaWVudC5tbQorKysgYi9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9Eb3dubG9hZENsaWVudC5tbQpAQCAtNjUsNiArNjUsMTQg QEAgRG93bmxvYWRDbGllbnQ6OkRvd25sb2FkQ2xpZW50KGlkIDxfV0tEb3dubG9hZERlbGVnYXRl PiBkZWxlZ2F0ZSkKICAgICBtX2RlbGVnYXRlTWV0aG9kcy5kb3dubG9hZFByb2Nlc3NEaWRDcmFz aCA9IFtkZWxlZ2F0ZSByZXNwb25kc1RvU2VsZWN0b3I6QHNlbGVjdG9yKF9kb3dubG9hZFByb2Nl c3NEaWRDcmFzaDopXTsKIH0KIAorc3RhdGljIFN5c3RlbVByZXZpZXdDb250cm9sbGVyKiBzeXN0 ZW1QcmV2aWV3Q29udHJvbGxlcihEb3dubG9hZFByb3h5JiBkb3dubG9hZFByb3h5KQoreworICAg IGF1dG8qIHdlYlBhZ2UgPSBkb3dubG9hZFByb3h5Lm9yaWdpbmF0aW5nUGFnZSgpOworICAgIGlm ICghd2ViUGFnZSkKKyAgICAgICAgcmV0dXJuIG51bGxwdHI7CisgICAgcmV0dXJuIHdlYlBhZ2Ut PnN5c3RlbVByZXZpZXdDb250cm9sbGVyKCk7Cit9CisKIHZvaWQgRG93bmxvYWRDbGllbnQ6OmRp ZFN0YXJ0KERvd25sb2FkUHJveHkmIGRvd25sb2FkUHJveHkpCiB7CiAjaWYgVVNFKFNZU1RFTV9Q UkVWSUVXKQpAQCAtODgsOCArOTYsOCBAQCB2b2lkIERvd25sb2FkQ2xpZW50OjpkaWRSZWNlaXZl UmVzcG9uc2UoRG93bmxvYWRQcm94eSYgZG93bmxvYWRQcm94eSwgY29uc3QgV2ViQwogICAgIGlm IChkb3dubG9hZFByb3h5LmlzU3lzdGVtUHJldmlld0Rvd25sb2FkKCkgJiYgcmVzcG9uc2UuaXNT dWNjZXNzZnVsKCkpIHsKICAgICAgICAgZG93bmxvYWRQcm94eS5zZXRFeHBlY3RlZENvbnRlbnRM ZW5ndGgocmVzcG9uc2UuZXhwZWN0ZWRDb250ZW50TGVuZ3RoKCkpOwogICAgICAgICBkb3dubG9h ZFByb3h5LnNldEJ5dGVzTG9hZGVkKDApOwotICAgICAgICBpZiAoYXV0byogd2ViUGFnZSA9IGRv d25sb2FkUHJveHkub3JpZ2luYXRpbmdQYWdlKCkpCi0gICAgICAgICAgICB3ZWJQYWdlLT5zeXN0 ZW1QcmV2aWV3Q29udHJvbGxlcigpLT51cGRhdGVQcm9ncmVzcygwKTsKKyAgICAgICAgaWYgKGF1 dG8qIGNvbnRyb2xsZXIgPSBzeXN0ZW1QcmV2aWV3Q29udHJvbGxlcihkb3dubG9hZFByb3h5KSkK KyAgICAgICAgICAgIGNvbnRyb2xsZXItPnVwZGF0ZVByb2dyZXNzKDApOwogICAgICAgICByZXR1 cm47CiAgICAgfQogI2VuZGlmCkBAIC0xMDMsOCArMTExLDggQEAgdm9pZCBEb3dubG9hZENsaWVu dDo6ZGlkUmVjZWl2ZURhdGEoRG93bmxvYWRQcm94eSYgZG93bmxvYWRQcm94eSwgdWludDY0X3Qg bGVuZ3QKICNpZiBVU0UoU1lTVEVNX1BSRVZJRVcpCiAgICAgaWYgKGRvd25sb2FkUHJveHkuaXNT eXN0ZW1QcmV2aWV3RG93bmxvYWQoKSkgewogICAgICAgICBkb3dubG9hZFByb3h5LnNldEJ5dGVz TG9hZGVkKGRvd25sb2FkUHJveHkuYnl0ZXNMb2FkZWQoKSArIGxlbmd0aCk7Ci0gICAgICAgIGlm IChhdXRvKiB3ZWJQYWdlID0gZG93bmxvYWRQcm94eS5vcmlnaW5hdGluZ1BhZ2UoKSkKLSAgICAg ICAgICAgIHdlYlBhZ2UtPnN5c3RlbVByZXZpZXdDb250cm9sbGVyKCktPnVwZGF0ZVByb2dyZXNz KHN0YXRpY19jYXN0PGZsb2F0Pihkb3dubG9hZFByb3h5LmJ5dGVzTG9hZGVkKCkpIC8gZG93bmxv YWRQcm94eS5leHBlY3RlZENvbnRlbnRMZW5ndGgoKSk7CisgICAgICAgIGlmIChhdXRvKiBjb250 cm9sbGVyID0gc3lzdGVtUHJldmlld0NvbnRyb2xsZXIoZG93bmxvYWRQcm94eSkpCisgICAgICAg ICAgICBjb250cm9sbGVyLT51cGRhdGVQcm9ncmVzcyhzdGF0aWNfY2FzdDxmbG9hdD4oZG93bmxv YWRQcm94eS5ieXRlc0xvYWRlZCgpKSAvIGRvd25sb2FkUHJveHkuZXhwZWN0ZWRDb250ZW50TGVu Z3RoKCkpOwogICAgICAgICByZXR1cm47CiAgICAgfQogI2VuZGlmCkBAIC0xNjQsOCArMTcyLDgg QEAgdm9pZCBEb3dubG9hZENsaWVudDo6cHJvY2Vzc0RpZENyYXNoKERvd25sb2FkUHJveHkmIGRv d25sb2FkUHJveHkpCiB7CiAjaWYgVVNFKFNZU1RFTV9QUkVWSUVXKQogICAgIGlmIChkb3dubG9h ZFByb3h5LmlzU3lzdGVtUHJldmlld0Rvd25sb2FkKCkpIHsKLSAgICAgICAgaWYgKGF1dG8qIHdl YlBhZ2UgPSBkb3dubG9hZFByb3h5Lm9yaWdpbmF0aW5nUGFnZSgpKQotICAgICAgICAgICAgd2Vi UGFnZS0+c3lzdGVtUHJldmlld0NvbnRyb2xsZXIoKS0+Y2FuY2VsKCk7CisgICAgICAgIGlmIChh dXRvKiBjb250cm9sbGVyID0gc3lzdGVtUHJldmlld0NvbnRyb2xsZXIoZG93bmxvYWRQcm94eSkp CisgICAgICAgICAgICBjb250cm9sbGVyLT5jYW5jZWwoKTsKICAgICAgICAgcmVsZWFzZUFjdGl2 aXR5VG9rZW5JZk5lY2Vzc2FyeShkb3dubG9hZFByb3h5KTsKICAgICAgICAgcmV0dXJuOwogICAg IH0KQEAgLTIwOSwxMSArMjE3LDExIEBAIHZvaWQgRG93bmxvYWRDbGllbnQ6OmRpZEZpbmlzaChE b3dubG9hZFByb3h5JiBkb3dubG9hZFByb3h5KQogewogI2lmIFVTRShTWVNURU1fUFJFVklFVykK ICAgICBpZiAoZG93bmxvYWRQcm94eS5pc1N5c3RlbVByZXZpZXdEb3dubG9hZCgpKSB7Ci0gICAg ICAgIGlmIChhdXRvKiB3ZWJQYWdlID0gZG93bmxvYWRQcm94eS5vcmlnaW5hdGluZ1BhZ2UoKSkg eworICAgICAgICBpZiAoYXV0byogY29udHJvbGxlciA9IHN5c3RlbVByZXZpZXdDb250cm9sbGVy KGRvd25sb2FkUHJveHkpKSB7CiAgICAgICAgICAgICBXVEY6OlVSTCBkZXN0aW5hdGlvblVSTCA9 IFdURjo6VVJMOjpmaWxlVVJMV2l0aEZpbGVTeXN0ZW1QYXRoKGRvd25sb2FkUHJveHkuZGVzdGlu YXRpb25GaWxlbmFtZSgpKTsKICAgICAgICAgICAgIGlmICghZGVzdGluYXRpb25VUkwuZnJhZ21l bnRJZGVudGlmaWVyKCkubGVuZ3RoKCkpCiAgICAgICAgICAgICAgICAgZGVzdGluYXRpb25VUkwu c2V0RnJhZ21lbnRJZGVudGlmaWVyKGRvd25sb2FkUHJveHkucmVxdWVzdCgpLnVybCgpLmZyYWdt ZW50SWRlbnRpZmllcigpKTsKLSAgICAgICAgICAgIHdlYlBhZ2UtPnN5c3RlbVByZXZpZXdDb250 cm9sbGVyKCktPmZpbmlzaChkZXN0aW5hdGlvblVSTCk7CisgICAgICAgICAgICBjb250cm9sbGVy LT5maW5pc2goZGVzdGluYXRpb25VUkwpOwogICAgICAgICB9CiAgICAgICAgIHJlbGVhc2VBY3Rp dml0eVRva2VuSWZOZWNlc3NhcnkoZG93bmxvYWRQcm94eSk7CiAgICAgICAgIHJldHVybjsKQEAg LTIyOCw4ICsyMzYsOCBAQCB2b2lkIERvd25sb2FkQ2xpZW50OjpkaWRGYWlsKERvd25sb2FkUHJv eHkmIGRvd25sb2FkUHJveHksIGNvbnN0IFdlYkNvcmU6OlJlc291cgogewogI2lmIFVTRShTWVNU RU1fUFJFVklFVykKICAgICBpZiAoZG93bmxvYWRQcm94eS5pc1N5c3RlbVByZXZpZXdEb3dubG9h ZCgpKSB7Ci0gICAgICAgIGlmIChhdXRvKiB3ZWJQYWdlID0gZG93bmxvYWRQcm94eS5vcmlnaW5h dGluZ1BhZ2UoKSkKLSAgICAgICAgICAgIHdlYlBhZ2UtPnN5c3RlbVByZXZpZXdDb250cm9sbGVy KCktPmZhaWwoZXJyb3IpOworICAgICAgICBpZiAoYXV0byogY29udHJvbGxlciA9IHN5c3RlbVBy ZXZpZXdDb250cm9sbGVyKGRvd25sb2FkUHJveHkpKQorICAgICAgICAgICAgY29udHJvbGxlci0+ ZmFpbChlcnJvcik7CiAgICAgICAgIHJlbGVhc2VBY3Rpdml0eVRva2VuSWZOZWNlc3NhcnkoZG93 bmxvYWRQcm94eSk7CiAgICAgICAgIHJldHVybjsKICAgICB9CkBAIC0yNDMsOCArMjUxLDggQEAg dm9pZCBEb3dubG9hZENsaWVudDo6ZGlkQ2FuY2VsKERvd25sb2FkUHJveHkmIGRvd25sb2FkUHJv eHkpCiB7CiAjaWYgVVNFKFNZU1RFTV9QUkVWSUVXKQogICAgIGlmIChkb3dubG9hZFByb3h5Lmlz U3lzdGVtUHJldmlld0Rvd25sb2FkKCkpIHsKLSAgICAgICAgaWYgKGF1dG8qIHdlYlBhZ2UgPSBk b3dubG9hZFByb3h5Lm9yaWdpbmF0aW5nUGFnZSgpKQotICAgICAgICAgICAgd2ViUGFnZS0+c3lz dGVtUHJldmlld0NvbnRyb2xsZXIoKS0+Y2FuY2VsKCk7CisgICAgICAgIGlmIChhdXRvKiBjb250 cm9sbGVyID0gc3lzdGVtUHJldmlld0NvbnRyb2xsZXIoZG93bmxvYWRQcm94eSkpCisgICAgICAg ICAgICBjb250cm9sbGVyLT5jYW5jZWwoKTsKICAgICAgICAgcmVsZWFzZUFjdGl2aXR5VG9rZW5J Zk5lY2Vzc2FyeShkb3dubG9hZFByb3h5KTsKICAgICAgICAgcmV0dXJuOwogICAgIH0K