210039 2020-04-05 14:44:45 -0700 ARM64 moveConditionallyDouble() for DoubleNotEqualAndOrdered is wrong. 2020-04-05 16:00:30 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1637956 0 mark.lam 2020-04-05 14:44:45 -0700 For the scenario where the dest register is same as the then case register, there is one case instruction that should be executed based on the overflow flag to test for unordered operands. Instead, we were testing for the not equal condition. This bug was caught by testmasm. 1637957 1 webkit-bug-importer 2020-04-05 14:45:12 -0700 <rdar://problem/61321778> 1637959 2 395530 mark.lam 2020-04-05 14:53:10 -0700 Created attachment 395530 proposed patch. 1637974 3 395530 ysuzuki 2020-04-05 15:55:59 -0700 Comment on attachment 395530 proposed patch. r=me 1637975 4 mark.lam 2020-04-05 16:00:30 -0700 Thanks for the review. Landed in r259556: <http://trac.webkit.org/r259556>. 395530 2020-04-05 14:53:10 -0700 2020-04-05 15:55:59 -0700 proposed patch. bug-210039.patch text/plain 1960 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjU5NTU0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDIwLTA0LTA1ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBB Uk02NCBtb3ZlQ29uZGl0aW9uYWxseURvdWJsZSgpIGZvciBEb3VibGVOb3RFcXVhbEFuZE9yZGVy ZWQgaXMgd3JvbmcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMTAwMzkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzYxMzIxNzc4PgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZvciB0aGUgc2NlbmFyaW8g d2hlcmUgdGhlIGRlc3QgcmVnaXN0ZXIgaXMgc2FtZSBhcyB0aGUgdGhlbiBjYXNlIHJlZ2lzdGVy LCB0aGVyZQorICAgICAgICBpcyBvbmUgY3NlbCBpbnN0cnVjdGlvbiB0aGF0IHNob3VsZCBiZSBj aGVja2luZyB0aGUgb3ZlcmZsb3cgY29uZGl0aW9uIHRvIHRlc3QKKyAgICAgICAgZm9yIHVub3Jk ZXJlZCBvcGVyYW5kcy4gIEluc3RlYWQsIHdlIHdlcmUgdGVzdGluZyBmb3IgdGhlIG5vdCBlcXVh bCBjb25kaXRpb24uCisgICAgICAgIFRoaXMgcGF0Y2ggZml4ZXMgaXQgdG8gY2hlY2sgZm9yIHRo ZSBvdmVyZmxvdyBjb25kaXRpb24uCisKKyAgICAgICAgVGhpcyBidWcgd2FzIGNhdWdodCBieSB0 ZXN0bWFzbS4KKworICAgICAgICAqIGFzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTTY0Lmg6Cisg ICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyQVJNNjQ6Om1vdmVDb25kaXRpb25hbGx5QWZ0ZXJG bG9hdGluZ1BvaW50Q29tcGFyZSk6CisKIDIwMjAtMDQtMDUgIEtlaXRoIE1pbGxlciAgPGtlaXRo X21pbGxlckBhcHBsZS5jb20+CiAKICAgICAgICAgZW5zdXJlU3RpbGxBbGl2ZUhlcmUgY2FuIHRh a2UgdGhlIHZhbHVlIGluIGFueSBsb2NhdGlvbgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3Jl L2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTTY0LmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph dmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTTY0LmgJKHJldmlzaW9uIDI1 OTU1NCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJB Uk02NC5oCSh3b3JraW5nIGNvcHkpCkBAIC0yMDMzLDcgKzIwMzMsNyBAQCBwdWJsaWM6CiAgICAg ICAgICAgICAgICAgLy8gbmV4dCBjc2VsIGhhcyBhbGwgYXJndW1lbnRzIGVxdWFsIHRvIGVsc2VD YXNlLgogICAgICAgICAgICAgICAgIC8vIElmIHRoZSBjb21wYXJlIGlzIG9yZGVyZWQsIGRlc3Qg aXMgdW5jaGFuZ2VkIGFuZCBORSBkZWNpZGVzCiAgICAgICAgICAgICAgICAgLy8gd2hhdCB2YWx1 ZSB0byBzZXQuCi0gICAgICAgICAgICAgICAgbV9hc3NlbWJsZXIuY3NlbDxkYXRhc2l6ZT4odGhl bkNhc2UsIGVsc2VDYXNlLCB0aGVuQ2FzZSwgQXNzZW1ibGVyOjpDb25kaXRpb25ORSk7CisgICAg ICAgICAgICAgICAgbV9hc3NlbWJsZXIuY3NlbDxkYXRhc2l6ZT4odGhlbkNhc2UsIGVsc2VDYXNl LCB0aGVuQ2FzZSwgQXNzZW1ibGVyOjpDb25kaXRpb25WUyk7CiAgICAgICAgICAgICAgICAgbV9h c3NlbWJsZXIuY3NlbDxkYXRhc2l6ZT4oZGVzdCwgdGhlbkNhc2UsIGVsc2VDYXNlLCBBc3NlbWJs ZXI6OkNvbmRpdGlvbk5FKTsKICAgICAgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgICAgICAg bW92ZShlbHNlQ2FzZSwgZGVzdCk7Cg==