210038 2020-04-05 14:26:14 -0700 [Clang 10] Fix -Wimplicit-int-float-conversion compilation warnings in JavaScriptCore 2020-04-06 13:09:14 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 204834 1 fujii fujii darin ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1637951 0 fujii 2020-04-05 14:26:14 -0700 [Clang 10] Fix -Wimplicit-int-float-conversion compilation warnings in JavaScriptCore This is a sub-task of Bug 204834. Clang 10 reports a compilation warning in JavaScriptCore: > ..\..\Source\JavaScriptCore\bytecode/CodeBlock.cpp(3002,24): warning: implicit conversion from 'unsigned long long' to 'double' changes value from 18446744073709551615 to 18446744073709551616 [-Wimplicit-int-float-conversion] > if (doubleResult > std::numeric_limits<size_t>::max()) > ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ See also: r259537 (which is for WTF) 1637954 1 395528 fujii 2020-04-05 14:32:56 -0700 Created attachment 395528 Patch 1638262 2 395528 fujii 2020-04-06 13:08:16 -0700 Comment on attachment 395528 Patch Clearing flags on attachment: 395528 Committed r259588: <https://trac.webkit.org/changeset/259588> 1638263 3 fujii 2020-04-06 13:08:20 -0700 All reviewed patches have been landed. Closing bug. 1638264 4 webkit-bug-importer 2020-04-06 13:09:14 -0700 <rdar://problem/61355692> 395528 2020-04-05 14:32:56 -0700 2020-04-06 13:08:16 -0700 Patch bug-210038-20200406063255.patch text/plain 2166 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5NTM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz YzUyOTUwZmRjMzNiMjUyMTVhODRiNDAwNzUxODhlYzA3YmNlOGU0Li4xMzAyYzkxMmE0NmNkMzgx N2I0MTVjNjViOTk4OGU3ZmI5Mjg0ZmU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMiBAQAorMjAyMC0wNC0wNSAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9yaS5GdWppaUBz b255LmNvbT4KKworICAgICAgICBbQ2xhbmcgMTBdIEZpeCAtV2ltcGxpY2l0LWludC1mbG9hdC1j b252ZXJzaW9uIGNvbXBpbGF0aW9uIHdhcm5pbmdzIGluIEphdmFTY3JpcHRDb3JlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTAwMzgKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDbGFuZyAxMCByZXBvcnRz IGEgY29tcGlsYXRpb24gd2FybmluZyBpbiBKYXZhU2NyaXB0Q29yZToKKyAgICAgICAgPiAuLlwu LlxTb3VyY2VcSmF2YVNjcmlwdENvcmVcYnl0ZWNvZGUvQ29kZUJsb2NrLmNwcCgzMDAyLDI0KTog d2FybmluZzogaW1wbGljaXQgY29udmVyc2lvbiBmcm9tICd1bnNpZ25lZCBsb25nIGxvbmcnIHRv ICdkb3VibGUnIGNoYW5nZXMgdmFsdWUgZnJvbSAxODQ0Njc0NDA3MzcwOTU1MTYxNSB0byAxODQ0 Njc0NDA3MzcwOTU1MTYxNiBbLVdpbXBsaWNpdC1pbnQtZmxvYXQtY29udmVyc2lvbl0KKyAgICAg ICAgPiAgICAgaWYgKGRvdWJsZVJlc3VsdCA+IHN0ZDo6bnVtZXJpY19saW1pdHM8c2l6ZV90Pjo6 bWF4KCkpCisgICAgICAgID4gICAgICAgICAgICAgICAgICAgICAgfiBefn5+fn5+fn5+fn5+fn5+ fn5+fn5+fn5+fn5+fn5+fn5+CisKKyAgICAgICAgVXNlIGEgdGVtcGxhdGUgdmFyaWFibGUgbWF4 UGx1c09uZTxUPiB3aGljaCB3YXMgYWRkZWQgYnkgcjI1OTUzNworICAgICAgICBmb3IgdGhlIHB1 cnBvc2UuCisKKyAgICAgICAgKiBieXRlY29kZS9Db2RlQmxvY2suY3BwOgorICAgICAgICAoSlND OjpDb2RlQmxvY2s6OnByZWRpY3RlZE1hY2hpbmVDb2RlU2l6ZSk6IFJlcGxhY2VkICc+JyB3aXRo ICc+PScsCisgICAgICAgIGFuZCBzdGQ6Om51bWVyaWNfbGltaXRzPHNpemVfdD46Om1heCgpIHdp dGggbWF4UGx1c09uZTxzaXplX3Q+LgorCiAyMDIwLTA0LTA0ICBBbGV4ZXkgU2h2YXlrYSAgPHNo dmFpa2FsZXNoQGdtYWlsLmNvbT4KIAogICAgICAgICAnXHUnIHNob3VsZCB0aHJvdyBhbiBlYXJs eSBTeW50YXhFcnJvciBleGNlcHRpb24sIGJ1dCBpbnN0ZWFkIGV2YWx1YXRlcyB0byAndScKZGlm ZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suY3BwIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9jay5jcHAKaW5kZXggNjU3ZTJi YjNlMjNiYTc1YjQ2NzIwMzBhYWMzOGY2Zjg1M2MyNDlmNS4uMWNhNDhkZWM3N2VjMzgxZDNhMWM2 ODkzNmM3NGM3MDkwMWFhZmI0OSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5 dGVjb2RlL0NvZGVCbG9jay5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2Rl L0NvZGVCbG9jay5jcHAKQEAgLTI5OTksNyArMjk5OSw3IEBAIHNpemVfdCBDb2RlQmxvY2s6OnBy ZWRpY3RlZE1hY2hpbmVDb2RlU2l6ZSgpCiAgICAgLy8gdGhlIGZ1bmN0aW9uIGlzIHNvIGh1Z2Ug dGhhdCB3ZSBjYW4ndCBldmVuIGZpdCBpdCBpbnRvIHZpcnR1YWwgbWVtb3J5IHRoZW4gd2UKICAg ICAvLyBzaG91bGQgcHJvYmFibHkgaGF2ZSBzb21lIG90aGVyIGd1YXJkcyBpbiBwbGFjZSB0byBw cmV2ZW50IHVzIGZyb20gZXZlbiBnZXR0aW5nCiAgICAgLy8gdG8gdGhpcyBwb2ludC4KLSAgICBp ZiAoZG91YmxlUmVzdWx0ID4gc3RkOjpudW1lcmljX2xpbWl0czxzaXplX3Q+OjptYXgoKSkKKyAg ICBpZiAoZG91YmxlUmVzdWx0ID49IG1heFBsdXNPbmU8c2l6ZV90PikKICAgICAgICAgcmV0dXJu IDA7CiAgICAgCiAgICAgcmV0dXJuIHN0YXRpY19jYXN0PHNpemVfdD4oZG91YmxlUmVzdWx0KTsK