210028 2020-04-05 08:56:17 -0700 ensureStillAliveHere can take the value in any location 2020-04-05 16:25:24 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 keith_miller keith_miller ews-watchlist mark.lam msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1637879 0 keith_miller 2020-04-05 08:56:17 -0700 ensureStillAliveHere can take the value in any location 1637880 1 395509 keith_miller 2020-04-05 08:58:41 -0700 Created attachment 395509 Patch 1637884 2 395509 mark.lam 2020-04-05 09:22:53 -0700 Comment on attachment 395509 Patch r=me. Please also fix the variant in JSValue too. 1637886 3 395511 keith_miller 2020-04-05 09:25:24 -0700 Created attachment 395511 Patch for landing 1637887 4 keith_miller 2020-04-05 09:25:49 -0700 (In reply to Mark Lam from comment #2) > Comment on attachment 395509 [details] > Patch > > r=me. Please also fix the variant in JSValue too. Ah, I missed that one. Done. 1637888 5 mark.lam 2020-04-05 09:31:56 -0700 Actually, I think the “clobbers memory” declaration is needed. Otherwise,the compiler can optimize the whole asm statement away. https://gcc.gnu.org/onlinedocs/gcc/Extended-Asm.html “Note, however, that if the code that follows the asm statement makes no use of any of the output operands, the GCC optimizers may discard the asm statement as unneeded (see Volatile).” I think :memory takes care of this. 1637889 6 keith_miller 2020-04-05 09:34:07 -0700 (In reply to Mark Lam from comment #5) > Actually, I think the “clobbers memory” declaration is needed. > Otherwise,the compiler can optimize the whole asm statement away. > > https://gcc.gnu.org/onlinedocs/gcc/Extended-Asm.html > “Note, however, that if the code that follows the asm statement makes no use > of any of the output operands, the GCC optimizers may discard the asm > statement as unneeded (see Volatile).” > > I think :memory takes care of this. That's what the volatile does. https://gcc.gnu.org/onlinedocs/gcc/Extended-Asm.html#Volatile GCC’s optimizers sometimes discard asm statements if they determine there is no need for the output variables. Also, the optimizers may move code out of loops if they believe that the code will always return the same result (i.e. none of its input values change between calls). Using the volatile qualifier disables these optimizations. 1637891 7 395511 mark.lam 2020-04-05 09:35:39 -0700 Comment on attachment 395511 Patch for landing Nevermind. https://gcc.gnu.org/onlinedocs/gcc/Extended-Asm.html#Volatile “ Using the volatile qualifier disables these optimizations. asm statements that have no output operands, including asm goto statements, are implicitly volatile.” 1637902 8 ews-feeder 2020-04-05 09:57:23 -0700 Patch 395511 does not build 1637909 9 395516 keith_miller 2020-04-05 10:27:54 -0700 Created attachment 395516 Patch for landing 1637928 10 ews-feeder 2020-04-05 11:23:32 -0700 Committed r259554: <https://trac.webkit.org/changeset/259554> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395516. 1637929 11 webkit-bug-importer 2020-04-05 11:24:12 -0700 <rdar://problem/61318951> 1637980 12 ysuzuki 2020-04-05 16:08:23 -0700 I think this is not correct. This needs to be a compiler-fence and "memory" is used to make it so. e.g. WTF::compilerFence. 241 // Just a compiler fence. Has no effect on the hardware, but tells the compiler 242 // not to move things around this call. Should not affect the compiler's ability 243 // to do things like register allocation and code motion over pure operations. 244 inline void compilerFence() 245 { 246 #if OS(WINDOWS) && !COMPILER(GCC_COMPATIBLE) 247 _ReadWriteBarrier(); 248 #else 249 asm volatile("" ::: "memory"); 250 #endif 251 } 1637986 13 ysuzuki 2020-04-05 16:25:24 -0700 Committed r259558: <https://trac.webkit.org/changeset/259558> 395509 2020-04-05 08:58:41 -0700 2020-04-05 09:25:23 -0700 Patch bug-210028-20200405085840.patch text/plain 1581 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5NTQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj YjVhMmMwZWU3NjJmOTE1MzY2ZTFiMGEwYjI4OGM2NDMxOTJmZjNkLi5kZTYxNjRlM2JlNjY1YTE1 OTc5ZmMxZDQ3NGMxY2VlMmE2YzFkMzAwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAyMC0wNC0wNSAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBlbnN1cmVTdGlsbEFsaXZlSGVyZSBjYW4gdGFrZSB0aGUgdmFsdWUg aW4gYW55IGxvY2F0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMTAwMjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBJdCBzaG91bGRuJ3QgbWF0dGVyIGlmIHRoZSB2YWx1ZSBpcyBvbiB0aGUgc3RhY2sg b3IgaW4gYSByZWdpc3RlcgorICAgICAgICBiZWNhdXNlIHdlJ3JlIG5vdCBnb2luZyB0byBkbyBh bnl0aGluZyB3aXRoIGl0LiBBbHNvLCB0aGVyZSdzIG5vCisgICAgICAgIHJlYXNvbiB0byBjbG9i YmVyIG1lbW9yeS4KKworICAgICAgICAqIHJ1bnRpbWUvRW5zdXJlU3RpbGxBbGl2ZUhlcmUuaDoK KyAgICAgICAgKEpTQzo6ZW5zdXJlU3RpbGxBbGl2ZUhlcmUpOgorCiAyMDIwLTA0LTA1ICBZdXN1 a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CiAKICAgICAgICAgW0pTQ10gSlNBcnJheUl0 ZXJhdG9yJ3Mgc2l6ZSBpcyB3cm9uZwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvRW5zdXJlU3RpbGxBbGl2ZUhlcmUuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL0Vuc3VyZVN0aWxsQWxpdmVIZXJlLmgKaW5kZXggMGFkYjFjMDY3ZWI5Nzc4NzliOWNm OGY1ZmQ3ZmM0MWM1YmYyMDYwYi4uMzg4ZGM5NDA4N2U3ODAwZjk2YWM1NjIzMTIwNWI0YjI1MWEx YmI3YyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvRW5zdXJlU3Rp bGxBbGl2ZUhlcmUuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9FbnN1cmVT dGlsbEFsaXZlSGVyZS5oCkBAIC0zMSwxMiArMzEsMTIgQEAgbmFtZXNwYWNlIEpTQyB7CiAKIEFM V0FZU19JTkxJTkUgdm9pZCBlbnN1cmVTdGlsbEFsaXZlSGVyZSh1aW50NjRfdCB2YWx1ZSkKIHsK LSAgICBhc20gdm9sYXRpbGUgKCIiIDogOiAiciIodmFsdWUpIDogIm1lbW9yeSIpOworICAgIGFz bSB2b2xhdGlsZSAoIiIgOiA6ICJnIih2YWx1ZSkgOiApOwogfQogCiBBTFdBWVNfSU5MSU5FIHZv aWQgZW5zdXJlU3RpbGxBbGl2ZUhlcmUoY29uc3Qgdm9pZCogcG9pbnRlcikKIHsKLSAgICBhc20g dm9sYXRpbGUgKCIiIDogOiAiciIocG9pbnRlcikgOiAibWVtb3J5Iik7CisgICAgYXNtIHZvbGF0 aWxlICgiIiA6IDogImciKHBvaW50ZXIpIDogKTsKIH0KIAogI2Vsc2UK 395511 2020-04-05 09:25:24 -0700 2020-04-05 10:27:52 -0700 Patch for landing bug-210028-20200405092524.patch text/plain 2301 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5NTQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj YjVhMmMwZWU3NjJmOTE1MzY2ZTFiMGEwYjI4OGM2NDMxOTJmZjNkLi4wMTAyYjQ0YjYyMzE5NWRj NDI0YjZkOTczNjUzMzI1OTVhYzk2MzUwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAyMC0wNC0wNSAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBlbnN1cmVTdGlsbEFsaXZlSGVyZSBjYW4gdGFrZSB0aGUgdmFsdWUg aW4gYW55IGxvY2F0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMTAwMjgKKworICAgICAgICBSZXZpZXdlZCBieSBNYXJrIExhbS4KKworICAgICAg ICBJdCBzaG91bGRuJ3QgbWF0dGVyIGlmIHRoZSB2YWx1ZSBpcyBvbiB0aGUgc3RhY2sgb3IgaW4g YSByZWdpc3RlcgorICAgICAgICBiZWNhdXNlIHdlJ3JlIG5vdCBnb2luZyB0byBkbyBhbnl0aGlu ZyB3aXRoIGl0LiBBbHNvLCB0aGVyZSdzIG5vCisgICAgICAgIHJlYXNvbiB0byBjbG9iYmVyIG1l bW9yeS4KKworICAgICAgICAqIHJ1bnRpbWUvRW5zdXJlU3RpbGxBbGl2ZUhlcmUuaDoKKyAgICAg ICAgKEpTQzo6ZW5zdXJlU3RpbGxBbGl2ZUhlcmUpOgorCiAyMDIwLTA0LTA1ICBZdXN1a2UgU3V6 dWtpICA8eXN1enVraUBhcHBsZS5jb20+CiAKICAgICAgICAgW0pTQ10gSlNBcnJheUl0ZXJhdG9y J3Mgc2l6ZSBpcyB3cm9uZwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvRW5zdXJlU3RpbGxBbGl2ZUhlcmUuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L0Vuc3VyZVN0aWxsQWxpdmVIZXJlLmgKaW5kZXggMGFkYjFjMDY3ZWI5Nzc4NzliOWNmOGY1ZmQ3 ZmM0MWM1YmYyMDYwYi4uMzg4ZGM5NDA4N2U3ODAwZjk2YWM1NjIzMTIwNWI0YjI1MWExYmI3YyAx MDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvRW5zdXJlU3RpbGxBbGl2 ZUhlcmUuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9FbnN1cmVTdGlsbEFs aXZlSGVyZS5oCkBAIC0zMSwxMiArMzEsMTIgQEAgbmFtZXNwYWNlIEpTQyB7CiAKIEFMV0FZU19J TkxJTkUgdm9pZCBlbnN1cmVTdGlsbEFsaXZlSGVyZSh1aW50NjRfdCB2YWx1ZSkKIHsKLSAgICBh c20gdm9sYXRpbGUgKCIiIDogOiAiciIodmFsdWUpIDogIm1lbW9yeSIpOworICAgIGFzbSB2b2xh dGlsZSAoIiIgOiA6ICJnIih2YWx1ZSkgOiApOwogfQogCiBBTFdBWVNfSU5MSU5FIHZvaWQgZW5z dXJlU3RpbGxBbGl2ZUhlcmUoY29uc3Qgdm9pZCogcG9pbnRlcikKIHsKLSAgICBhc20gdm9sYXRp bGUgKCIiIDogOiAiciIocG9pbnRlcikgOiAibWVtb3J5Iik7CisgICAgYXNtIHZvbGF0aWxlICgi IiA6IDogImciKHBvaW50ZXIpIDogKTsKIH0KIAogI2Vsc2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQ0pTVmFsdWUuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL0pTQ0pTVmFsdWUuaAppbmRleCBkZWI2NDAyNTMwZWI1OGJmNTBkMGQ2NzBlZDE2 YmM1NDhiN2Y5MjY5Li41MjlmZTQ0Y2I2N2Q5OGI2ZjcyYjQwNzE2OWEwZTIzNDhhNDBlY2MzIDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0NKU1ZhbHVlLmgKKysr IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNDSlNWYWx1ZS5oCkBAIC02NDIsOSAr NjQyLDkgQEAgYm9vbCBzYW1lVmFsdWUoSlNHbG9iYWxPYmplY3QqLCBKU1ZhbHVlIGEsIEpTVmFs dWUgYik7CiBBTFdBWVNfSU5MSU5FIHZvaWQgZW5zdXJlU3RpbGxBbGl2ZUhlcmUoSlNWYWx1ZSB2 YWx1ZSkKIHsKICNpZiBVU0UoSlNWQUxVRTY0KQotICAgIGFzbSB2b2xhdGlsZSAoIiIgOiA6ICJy IihiaXR3aXNlX2Nhc3Q8dWludDY0X3Q+KHZhbHVlKSkgOiAibWVtb3J5Iik7CisgICAgYXNtIHZv bGF0aWxlICgiIiA6IDogImciKGJpdHdpc2VfY2FzdDx1aW50NjRfdD4odmFsdWUpKSA6ICk7CiAj ZWxzZQotICAgIGFzbSB2b2xhdGlsZSAoIiIgOiA6ICJyIih2YWx1ZS5wYXlsb2FkKCkpIDogIm1l bW9yeSIpOworICAgIGFzbSB2b2xhdGlsZSAoIiIgOiA6ICJnIih2YWx1ZS5wYXlsb2FkKCkpIDog KTsKICNlbmRpZgogfQogI2Vsc2UK 395516 2020-04-05 10:27:54 -0700 2020-04-05 11:23:32 -0700 Patch for landing bug-210028-20200405102753.patch text/plain 2301 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5NTQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj YjVhMmMwZWU3NjJmOTE1MzY2ZTFiMGEwYjI4OGM2NDMxOTJmZjNkLi4wMTAyYjQ0YjYyMzE5NWRj NDI0YjZkOTczNjUzMzI1OTVhYzk2MzUwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAyMC0wNC0wNSAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBlbnN1cmVTdGlsbEFsaXZlSGVyZSBjYW4gdGFrZSB0aGUgdmFsdWUg aW4gYW55IGxvY2F0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMTAwMjgKKworICAgICAgICBSZXZpZXdlZCBieSBNYXJrIExhbS4KKworICAgICAg ICBJdCBzaG91bGRuJ3QgbWF0dGVyIGlmIHRoZSB2YWx1ZSBpcyBvbiB0aGUgc3RhY2sgb3IgaW4g YSByZWdpc3RlcgorICAgICAgICBiZWNhdXNlIHdlJ3JlIG5vdCBnb2luZyB0byBkbyBhbnl0aGlu ZyB3aXRoIGl0LiBBbHNvLCB0aGVyZSdzIG5vCisgICAgICAgIHJlYXNvbiB0byBjbG9iYmVyIG1l bW9yeS4KKworICAgICAgICAqIHJ1bnRpbWUvRW5zdXJlU3RpbGxBbGl2ZUhlcmUuaDoKKyAgICAg ICAgKEpTQzo6ZW5zdXJlU3RpbGxBbGl2ZUhlcmUpOgorCiAyMDIwLTA0LTA1ICBZdXN1a2UgU3V6 dWtpICA8eXN1enVraUBhcHBsZS5jb20+CiAKICAgICAgICAgW0pTQ10gSlNBcnJheUl0ZXJhdG9y J3Mgc2l6ZSBpcyB3cm9uZwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvRW5zdXJlU3RpbGxBbGl2ZUhlcmUuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L0Vuc3VyZVN0aWxsQWxpdmVIZXJlLmgKaW5kZXggMGFkYjFjMDY3ZWI5Nzc4NzliOWNmOGY1ZmQ3 ZmM0MWM1YmYyMDYwYi4uMzg4ZGM5NDA4N2U3ODAwZjk2YWM1NjIzMTIwNWI0YjI1MWExYmI3YyAx MDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvRW5zdXJlU3RpbGxBbGl2 ZUhlcmUuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9FbnN1cmVTdGlsbEFs aXZlSGVyZS5oCkBAIC0zMSwxMiArMzEsMTIgQEAgbmFtZXNwYWNlIEpTQyB7CiAKIEFMV0FZU19J TkxJTkUgdm9pZCBlbnN1cmVTdGlsbEFsaXZlSGVyZSh1aW50NjRfdCB2YWx1ZSkKIHsKLSAgICBh c20gdm9sYXRpbGUgKCIiIDogOiAiciIodmFsdWUpIDogIm1lbW9yeSIpOworICAgIGFzbSB2b2xh dGlsZSAoIiIgOiA6ICJnIih2YWx1ZSkgOiApOwogfQogCiBBTFdBWVNfSU5MSU5FIHZvaWQgZW5z dXJlU3RpbGxBbGl2ZUhlcmUoY29uc3Qgdm9pZCogcG9pbnRlcikKIHsKLSAgICBhc20gdm9sYXRp bGUgKCIiIDogOiAiciIocG9pbnRlcikgOiAibWVtb3J5Iik7CisgICAgYXNtIHZvbGF0aWxlICgi IiA6IDogImciKHBvaW50ZXIpIDogKTsKIH0KIAogI2Vsc2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQ0pTVmFsdWUuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL0pTQ0pTVmFsdWUuaAppbmRleCBkZWI2NDAyNTMwZWI1OGJmNTBkMGQ2NzBlZDE2 YmM1NDhiN2Y5MjY5Li41MjlmZTQ0Y2I2N2Q5OGI2ZjcyYjQwNzE2OWEwZTIzNDhhNDBlY2MzIDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0NKU1ZhbHVlLmgKKysr IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNDSlNWYWx1ZS5oCkBAIC02NDIsOSAr NjQyLDkgQEAgYm9vbCBzYW1lVmFsdWUoSlNHbG9iYWxPYmplY3QqLCBKU1ZhbHVlIGEsIEpTVmFs dWUgYik7CiBBTFdBWVNfSU5MSU5FIHZvaWQgZW5zdXJlU3RpbGxBbGl2ZUhlcmUoSlNWYWx1ZSB2 YWx1ZSkKIHsKICNpZiBVU0UoSlNWQUxVRTY0KQotICAgIGFzbSB2b2xhdGlsZSAoIiIgOiA6ICJy IihiaXR3aXNlX2Nhc3Q8dWludDY0X3Q+KHZhbHVlKSkgOiAibWVtb3J5Iik7CisgICAgYXNtIHZv bGF0aWxlICgiIiA6IDogImciKGJpdHdpc2VfY2FzdDx1aW50NjRfdD4odmFsdWUpKSA6ICk7CiAj ZWxzZQotICAgIGFzbSB2b2xhdGlsZSAoIiIgOiA6ICJyIih2YWx1ZS5wYXlsb2FkKCkpIDogIm1l bW9yeSIpOworICAgIGFzbSB2b2xhdGlsZSAoIiIgOiA6ICJnIih2YWx1ZS5wYXlsb2FkKCkpIDog KTsKICNlbmRpZgogfQogI2Vsc2UK