210018 2020-04-04 22:24:06 -0700 copy jsc CLI into JavaScriptCore.framework earlier 2020-04-05 11:14:58 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified REOPENED InRadar P2 Normal --- 1 keith_miller keith_miller ap ews-watchlist mark.lam msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1637816 0 keith_miller 2020-04-04 22:24:06 -0700 copy jsc CLI into JavaScriptCore.framework earlier 1637817 1 395483 keith_miller 2020-04-04 22:26:16 -0700 Created attachment 395483 Patch 1637822 2 395483 mark.lam 2020-04-04 22:44:10 -0700 Comment on attachment 395483 Patch r=me if EWS bots are happy. 1637828 3 ews-feeder 2020-04-04 23:17:27 -0700 Committed r259545: <https://trac.webkit.org/changeset/259545> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395483. 1637829 4 webkit-bug-importer 2020-04-04 23:18:14 -0700 <rdar://problem/61309849> 1637843 5 mark.lam 2020-04-05 01:42:53 -0700 The patch was rolled out in r259548: <http://trac.webkit.org/r259548> because it was causing CodeSigning error in jsc EWS bot. 1637844 6 ysuzuki 2020-04-05 01:45:04 -0700 https://ews-build.webkit.org/#/builders/1/builds/10407 This is one of the case causing CodeSigning error. 1637846 7 ysuzuki 2020-04-05 01:55:39 -0700 (In reply to Yusuke Suzuki from comment #6) > https://ews-build.webkit.org/#/builders/1/builds/10407 This is one of the > case causing CodeSigning error. Seems that all EWS bots need to be force-cleaned. 1637915 8 ap 2020-04-05 10:49:25 -0700 Can you find a way to avoid the need for clean builds? That’s something that all engineers will have to do too, so it’s quite costly. 1637926 9 keith_miller 2020-04-05 11:14:58 -0700 (In reply to Alexey Proskuryakov from comment #8) > Can you find a way to avoid the need for clean builds? That’s something that > all engineers will have to do too, so it’s quite costly. I don't think engineers should see the build failure if they didn't build while this was in the tree. The problem was that the jsc CLI was placed into the framework unsigned so the next build errored. In a future patch, I don't think this problem should repeat itself. 395483 2020-04-04 22:26:16 -0700 2020-04-04 23:17:27 -0700 Patch bug-210018-20200404222615.patch text/plain 5171 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5NTQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz YzUyOTUwZmRjMzNiMjUyMTVhODRiNDAwNzUxODhlYzA3YmNlOGU0Li41YjQxNWJlMjE0NTA2NzM4 ZjFhYmE1NTM1YTBhMjY3MDRhZTkxZmZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAyMC0wNC0wNCAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBjb3B5IGpzYyBDTEkgaW50byBKYXZhU2NyaXB0Q29yZS5mcmFtZXdv cmsgZWFybGllcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjEwMDE4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgU29tZSBvZiBvdXIgdGVzdCBzY3JpcHRzIG9ubHkgY29weSB0aGUgSmF2YVNjcmlwdENvcmUu ZnJhbWV3b3JrCisgICAgICAgIGludG8gdGhlIHRlc3QgZGlyZWN0b3J5IGFuZCB0cnkgdG8gcnVu IGpzYyBmcm9tIHRoZXJlLiBXZSBzaG91bGQKKyAgICAgICAgY29weSB0aGUganNjIENMSSBBU0FQ IHNvIHdlIGRvbid0IG5lZWQgdG8gYnVpbGQgYWxsIHRoZSBvdGhlciB0ZXN0CisgICAgICAgIGJp bmFyaWVzIHVubGVzcyB3ZSBhY3R1YWxseSBuZWVkIHRoZW0uCisKKyAgICAgICAgKiBKYXZhU2Ny aXB0Q29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qOgorCiAyMDIwLTA0LTA0ICBBbGV4ZXkg U2h2YXlrYSAgPHNodmFpa2FsZXNoQGdtYWlsLmNvbT4KIAogICAgICAgICAnXHUnIHNob3VsZCB0 aHJvdyBhbiBlYXJseSBTeW50YXhFcnJvciBleGNlcHRpb24sIGJ1dCBpbnN0ZWFkIGV2YWx1YXRl cyB0byAndScKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29y ZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0phdmFT Y3JpcHRDb3JlLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oKaW5kZXggOWUwZWUxZGU5ZTM0Nzhj MGRhMzI4NTNjZjE2YmQyMjU3MmFjMmMyYi4uZWJiNTUyNWIyZWI0NThjMDliMTQyODdkZTMwYmY5 ZWJhYzFlYjg5YSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRD b3JlLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L0phdmFTY3JpcHRDb3JlLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oKQEAgLTEwMSw3ICsxMDEs NiBAQAogCQkJaXNhID0gUEJYQWdncmVnYXRlVGFyZ2V0OwogCQkJYnVpbGRDb25maWd1cmF0aW9u TGlzdCA9IDE0OUMyNzZDMDg5MDJBRkUwMDhBOUVGQyAvKiBCdWlsZCBjb25maWd1cmF0aW9uIGxp c3QgZm9yIFBCWEFnZ3JlZ2F0ZVRhcmdldCAiQWxsIiAqLzsKIAkJCWJ1aWxkUGhhc2VzID0gKAot CQkJCTVERjdFMUNDMTg4RTZCODcwMDNGOUE0NiAvKiBDb3B5IGpzYyBpbnRvIEphdmFTY3JpcHRD b3JlLmZyYW1ld29yayAqLywKIAkJCQk1Mzk5NjZFMzIzN0NENjc0MDAzM0IwRDIgLyogQ3JlYXRl IFZlcnNpb25zL0N1cnJlbnQvSGVscGVycyBzeW1saW5rICovLAogCQkJKTsKIAkJCWRlcGVuZGVu Y2llcyA9ICgKQEAgLTEwNjM5LDYgKzEwNjM4LDcgQEAKIAkJCQk5MzJGNUJEQzA4MjJBMUM3MDA3 MzY5NzUgLyogU291cmNlcyAqLywKIAkJCQk5MzJGNUJERTA4MjJBMUM3MDA3MzY5NzUgLyogRnJh bWV3b3JrcyAqLywKIAkJCQk1RDVEOEFCRjBFMEQwQjAzMDBGOUM2OTIgLyogQ3JlYXRlIC91c3Iv bG9jYWwvYmluL2pzYyBzeW1saW5rICovLAorCQkJCTUzQjNFMDRFMjQzOUEwODkwMDFDNDI4MSAv KiBDb3B5IGpzYyBpbnRvIEphdmFTY3JpcHRDb3JlLmZyYW1ld29yayAqLywKIAkJCSk7CiAJCQli dWlsZFJ1bGVzID0gKAogCQkJKTsKQEAgLTEwODkwLDYgKzEwODkwLDI2IEBACiAJCQlzaGVsbFBh dGggPSAvYmluL3NoOwogCQkJc2hlbGxTY3JpcHQgPSAiIyBJZiBvbiBhIGRlZXAtYnVuZGxlIHN5 c3RlbSwgc2V0IHVwIGEgbGluayBmcm9tIEhlbHBlcnMgdG8gVmVyc2lvbnMvQS9IZWxwZXJzXG5c bmlmIFtbIFwiJHtKQVZBU0NSSVBUQ09SRV9IRUxQRVJTX0RJUn1cIiA9fiBcIlZlcnNpb25zXCIg XV07IHRoZW5cbiAgICBpZiBbWyBcIiR7REVQTE9ZTUVOVF9MT0NBVElPTn1cIiA9PSBcIk5PXCIg XV07IHRoZW5cbiAgICAgICAgbG4gLWZocyBWZXJzaW9ucy9DdXJyZW50L0hlbHBlcnMgXCIke0JV SUxUX1BST0RVQ1RTX0RJUn0vJHtKQVZBU0NSSVBUQ09SRV9IRUxQRVJTX0RJUn0vLi4vLi4vLi5c IlxuICAgIGVsc2VcbiAgICAgICAgbG4gLWZocyBWZXJzaW9ucy9DdXJyZW50L0hlbHBlcnMgXCIk e0lOU1RBTExfRElSfS8uLi8uLi8uLlwiXG4gICAgZmlcbmZpXG5leGl0IDBcbiI7CiAJCX07CisJ CTUzQjNFMDRFMjQzOUEwODkwMDFDNDI4MSAvKiBDb3B5IGpzYyBpbnRvIEphdmFTY3JpcHRDb3Jl LmZyYW1ld29yayAqLyA9IHsKKwkJCWlzYSA9IFBCWFNoZWxsU2NyaXB0QnVpbGRQaGFzZTsKKwkJ CWJ1aWxkQWN0aW9uTWFzayA9IDIxNDc0ODM2NDc7CisJCQlmaWxlcyA9ICgKKwkJCSk7CisJCQlp bnB1dEZpbGVMaXN0UGF0aHMgPSAoCisJCQkpOworCQkJaW5wdXRQYXRocyA9ICgKKwkJCQkiJChC VUlMVF9QUk9EVUNUU19ESVIpL2pzYyIsCisJCQkpOworCQkJbmFtZSA9ICJDb3B5IGpzYyBpbnRv IEphdmFTY3JpcHRDb3JlLmZyYW1ld29yayI7CisJCQlvdXRwdXRGaWxlTGlzdFBhdGhzID0gKAor CQkJKTsKKwkJCW91dHB1dFBhdGhzID0gKAorCQkJCSIkKEJVSUxUX1BST0RVQ1RTX0RJUikvJChK QVZBU0NSSVBUQ09SRV9IRUxQRVJTX0RJUikvanNjIiwKKwkJCSk7CisJCQlydW5Pbmx5Rm9yRGVw bG95bWVudFBvc3Rwcm9jZXNzaW5nID0gMDsKKwkJCXNoZWxsUGF0aCA9IC9iaW4vc2g7CisJCQlz aGVsbFNjcmlwdCA9ICJzZXQgLWVcblxuIyBTa2lwIGZvciBQcm9kdWN0aW9uIGJ1aWxkcy5cbmlm IFtbICR7Q09ORklHVVJBVElPTjo9RGVidWd9ID09IFwiUHJvZHVjdGlvblwiIF1dOyB0aGVuXG4g ICAgZXhpdFxuZmlcblxuIyBDb3B5IGFuZCB1cGRhdGUgdGhlIGpzYyBiaW5hcnkgdG8gcmVmZXIg dG8gSmF2YVNjcmlwdENvcmUuZnJhbWV3b3JrIHJlbGF0aXZlIHRvIGl0cyBsb2NhdGlvbi5cbm1r ZGlyIC1wIFwiJHtCVUlMVF9QUk9EVUNUU19ESVJ9LyR7SkFWQVNDUklQVENPUkVfSEVMUEVSU19E SVJ9XCJcbmRpdHRvIFwiJHtCVUlMVF9QUk9EVUNUU19ESVJ9L2pzY1wiIFwiJHtCVUlMVF9QUk9E VUNUU19ESVJ9LyR7SkFWQVNDUklQVENPUkVfSEVMUEVSU19ESVJ9L2pzY1wiXG5pbnN0YWxsX25h bWVfdG9vbCAtY2hhbmdlIFwiJHtKQVZBU0NSSVBUQ09SRV9GUkFNRVdPUktTX0RJUn0vSmF2YVNj cmlwdENvcmUuZnJhbWV3b3JrL1ZlcnNpb25zL0EvSmF2YVNjcmlwdENvcmVcIiBcIkBsb2FkZXJf cGF0aC8uLi9KYXZhU2NyaXB0Q29yZVwiIFwiJHtCVUlMVF9QUk9EVUNUU19ESVJ9LyR7SkFWQVND UklQVENPUkVfSEVMUEVSU19ESVJ9L2pzY1wiXG5cbiI7CisJCX07CiAJCTUzQjRCRDA5MUY2OEFG ODkwMEQyQkVBMyAvKiBHZW5lcmF0ZSBVbmlmaWVkIFNvdXJjZXMgKi8gPSB7CiAJCQlpc2EgPSBQ QlhTaGVsbFNjcmlwdEJ1aWxkUGhhc2U7CiAJCQlidWlsZEFjdGlvbk1hc2sgPSAyMTQ3NDgzNjQ3 OwpAQCAtMTA5NzUsMjIgKzEwOTk1LDYgQEAKIAkJCXNoZWxsUGF0aCA9IC9iaW4vc2g7CiAJCQlz aGVsbFNjcmlwdCA9ICJpZiBbWyBcIiR7U0tJUF9JTlNUQUxMfVwiID09IFwiTk9cIiBdXTsgdGhl blxuICAgIGNwIFwiJHtTUkNST09UfS9BUEkvdGVzdHMvdGVzdGFwaVNjcmlwdHMvdGVzdGFwaS5q c1wiIFwiJHtEU1RST09UfSR7SU5TVEFMTF9QQVRIfS90ZXN0YXBpLmpzXCJcbmZpXG4iOwogCQl9 OwotCQk1REY3RTFDQzE4OEU2Qjg3MDAzRjlBNDYgLyogQ29weSBqc2MgaW50byBKYXZhU2NyaXB0 Q29yZS5mcmFtZXdvcmsgKi8gPSB7Ci0JCQlpc2EgPSBQQlhTaGVsbFNjcmlwdEJ1aWxkUGhhc2U7 Ci0JCQlidWlsZEFjdGlvbk1hc2sgPSAyMTQ3NDgzNjQ3OwotCQkJZmlsZXMgPSAoCi0JCQkpOwot CQkJaW5wdXRQYXRocyA9ICgKLQkJCQkiJChCVUlMVF9QUk9EVUNUU19ESVIpL2pzYyIsCi0JCQkp OwotCQkJbmFtZSA9ICJDb3B5IGpzYyBpbnRvIEphdmFTY3JpcHRDb3JlLmZyYW1ld29yayI7Ci0J CQlvdXRwdXRQYXRocyA9ICgKLQkJCQkiJChCVUlMVF9QUk9EVUNUU19ESVIpLyQoSkFWQVNDUklQ VENPUkVfSEVMUEVSU19ESVIpL2pzYyIsCi0JCQkpOwotCQkJcnVuT25seUZvckRlcGxveW1lbnRQ b3N0cHJvY2Vzc2luZyA9IDA7Ci0JCQlzaGVsbFBhdGggPSAvYmluL3NoOwotCQkJc2hlbGxTY3Jp cHQgPSAic2V0IC1lXG5cbiMgU2tpcCBmb3IgUHJvZHVjdGlvbiBidWlsZHMuXG5pZiBbWyAke0NP TkZJR1VSQVRJT046PURlYnVnfSA9PSBcIlByb2R1Y3Rpb25cIiBdXTsgdGhlblxuICAgIGV4aXRc bmZpXG5cbiMgQ29weSBhbmQgdXBkYXRlIHRoZSBqc2MgYmluYXJ5IHRvIHJlZmVyIHRvIEphdmFT Y3JpcHRDb3JlLmZyYW1ld29yayByZWxhdGl2ZSB0byBpdHMgbG9jYXRpb24uXG5ta2RpciAtcCBc IiR7QlVJTFRfUFJPRFVDVFNfRElSfS8ke0pBVkFTQ1JJUFRDT1JFX0hFTFBFUlNfRElSfVwiXG5k aXR0byBcIiR7QlVJTFRfUFJPRFVDVFNfRElSfS9qc2NcIiBcIiR7QlVJTFRfUFJPRFVDVFNfRElS fS8ke0pBVkFTQ1JJUFRDT1JFX0hFTFBFUlNfRElSfS9qc2NcIlxuaW5zdGFsbF9uYW1lX3Rvb2wg LWNoYW5nZSBcIiR7SkFWQVNDUklQVENPUkVfRlJBTUVXT1JLU19ESVJ9L0phdmFTY3JpcHRDb3Jl LmZyYW1ld29yay9WZXJzaW9ucy9BL0phdmFTY3JpcHRDb3JlXCIgXCJAbG9hZGVyX3BhdGgvLi4v SmF2YVNjcmlwdENvcmVcIiBcIiR7QlVJTFRfUFJPRFVDVFNfRElSfS8ke0pBVkFTQ1JJUFRDT1JF X0hFTFBFUlNfRElSfS9qc2NcIlxuIjsKLQkJfTsKIAkJNjU3ODhBQTAxOEI0MDlFQjAwQzE4OUZG IC8qIE9mZmxpbmUgQXNzZW1ibGUgKi8gPSB7CiAJCQlpc2EgPSBQQlhTaGVsbFNjcmlwdEJ1aWxk UGhhc2U7CiAJCQlidWlsZEFjdGlvbk1hc2sgPSAyMTQ3NDgzNjQ3Owo=