210012 2020-04-04 18:16:09 -0700 run-api-tests spew "setup_environ_for_server" in verbose mode 2020-04-06 10:01:53 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dbates jbedard aakash_jain ews-watchlist glenn jbedard webkit-bug-importer oldest_to_newest 1637789 0 dbates 2020-04-04 18:16:09 -0700 Seen on <https://ews-build.webkit.org/#/builders/9/builds/21136> (Attachment #395467; patch for bug 210010). run-api-tests spew "setup_environ_for_server" in verbose mode. This logging is really noisy and does not seem very informative. If useful, cons the code be made more deterministic to make it unneeded? If not, can it be made more informative or a full sentence? 1637790 1 webkit-bug-importer 2020-04-04 18:16:19 -0700 <rdar://problem/61306056> 1638087 2 395564 jbedard 2020-04-06 08:04:46 -0700 Created attachment 395564 Patch 1638088 3 jbedard 2020-04-06 08:08:14 -0700 Originally, this logging was part of a group of logging statements intended to help debug run-api-tests in the event something went wrong. The other statements are in functions which do something and are run infrequently. setup_environ_for_server just returns a dictionary, so we call it very frequently because it's low cost. The fact that it is low cost means we shouldn't be logging when we call it. 1638137 4 ews-feeder 2020-04-06 10:01:53 -0700 Committed r259574: <https://trac.webkit.org/changeset/259574> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395564. 395564 2020-04-06 08:04:46 -0700 2020-04-06 10:01:53 -0700 Patch bug-210012-20200406080445.patch text/plain 1355 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1OTU2OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIwLTA0LTA2ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBydW4tYXBpLXRlc3RzIHNwZXcgInNldHVwX2Vudmlyb25fZm9yX3NlcnZl ciIgaW4gdmVyYm9zZSBtb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMTAwMTIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzYxMzA2MDU2PgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93 ZWJraXRweS9wb3J0L2lvc19zaW11bGF0b3IucHk6CisgICAgICAgIChJT1NTaW11bGF0b3JQb3J0 LnNldHVwX2Vudmlyb25fZm9yX3NlcnZlcik6IERvIG5vdCBsb2cgdGhpcyBmdW5jdGlvbiB3aGVu IGNhbGxlZC4KKwogMjAyMC0wNC0wNSAgR3VzIENhcGxhbiAgPG1lQGd1cy5ob3N0PiBhbmQgUm9z cyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29ueS5jb20+CiAKICAgICAgICAgRExMTGF1bmNo ZXJNYWluIHByaW50IHRvIGNvbnNvbGUgaW5zdGVhZCBvZiBvcGVuaW5nIHdpbmRvdyBvbiBmYXRh bCBlcnJvcgpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2lvc19zaW11bGF0b3Iu cHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2lvc19zaW11bGF0 b3IucHkJKHJldmlzaW9uIDI1OTU2OCkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9p b3Nfc2ltdWxhdG9yLnB5CSh3b3JraW5nIGNvcHkpCkBAIC03OSw3ICs3OSw2IEBAIGNsYXNzIElP U1NpbXVsYXRvclBvcnQoSU9TUG9ydCk6CiAgICAgICAgIHJldHVybiByZXN1bHQKIAogICAgIGRl ZiBzZXR1cF9lbnZpcm9uX2Zvcl9zZXJ2ZXIoc2VsZiwgc2VydmVyX25hbWU9Tm9uZSk6Ci0gICAg ICAgIF9sb2cuZGVidWcoInNldHVwX2Vudmlyb25fZm9yX3NlcnZlciIpCiAgICAgICAgIGVudiA9 IHN1cGVyKElPU1NpbXVsYXRvclBvcnQsIHNlbGYpLnNldHVwX2Vudmlyb25fZm9yX3NlcnZlcihz ZXJ2ZXJfbmFtZSkKICAgICAgICAgaWYgc2VydmVyX25hbWUgPT0gc2VsZi5kcml2ZXJfbmFtZSgp OgogICAgICAgICAgICAgaWYgc2VsZi5nZXRfb3B0aW9uKCdsZWFrcycpOgo=