210006 2020-04-04 09:57:12 -0700 [GPUP] Remove unnecessary RemoteCDMInstanceSessionIdentifier argument from RemoteCDMFactory::addSession() 2020-04-04 16:45:16 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 209712 1 ddkilzer ddkilzer darin eric.carlson ews-watchlist glenn jer.noble philipj sergio webkit-bug-importer oldest_to_newest 1637697 0 ddkilzer 2020-04-04 09:57:12 -0700 Remove unnecessary RemoteCDMInstanceSessionIdentifier argument from RemoteCDMFactory::addSession(). I noticed this when fixing Bug 209712. 1637698 1 395452 ddkilzer 2020-04-04 10:00:39 -0700 Created attachment 395452 Patch v1 1637769 2 395452 darin 2020-04-04 16:23:50 -0700 Comment on attachment 395452 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=395452&action=review > Source/WebKit/WebProcess/GPU/media/RemoteCDMFactory.cpp:84 > + m_sessions.set(session->identifier(), WTFMove(session)); This also means that we could use a HashSet instead of a HashMap. 1637770 3 395452 darin 2020-04-04 16:24:22 -0700 Comment on attachment 395452 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=395452&action=review >> Source/WebKit/WebProcess/GPU/media/RemoteCDMFactory.cpp:84 >> + m_sessions.set(session->identifier(), WTFMove(session)); > > This also means that we could use a HashSet instead of a HashMap. That’s a slightly more challenging refactoring, but it’s one that would save memory. 1637780 4 ews-feeder 2020-04-04 16:45:00 -0700 Committed r259539: <https://trac.webkit.org/changeset/259539> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395452. 1637781 5 webkit-bug-importer 2020-04-04 16:45:16 -0700 <rdar://problem/61304706> 395452 2020-04-04 10:00:39 -0700 2020-04-04 16:45:01 -0700 Patch v1 bug-210006-20200404100216.patch text/plain 3507 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5NTI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDNkODk1ZjNjMzBiMjdkMDE3 NjYyNTFhMDZhZGY4ZWFlM2I1ZTZkMDMuLjUyOWJkZTQ4MmYwZmJmOWQzMzE1MGUzNTZkNjhlM2Zm YzA1NzRjNmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjAtMDQtMDQgIERhdmlkIEtp bHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBbR1BVUF0gUmVtb3ZlIHVubmVj ZXNzYXJ5IFJlbW90ZUNETUluc3RhbmNlU2Vzc2lvbklkZW50aWZpZXIgYXJndW1lbnQgZnJvbSBS ZW1vdGVDRE1GYWN0b3J5OjphZGRTZXNzaW9uKCkKKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9y Zy9iLzIxMDAwNj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFdlYlByb2Nlc3MvR1BVL21lZGlhL1JlbW90ZUNETUZhY3RvcnkuY3BwOgorICAgICAg ICAoV2ViS2l0OjpSZW1vdGVDRE1GYWN0b3J5OjphZGRTZXNzaW9uKToKKyAgICAgICAgLSBSZW1v dmUgYXJndW1lbnQuIFVzZSBgc2Vzc2lvbmAgcGFyYW1ldGVyIHRvIHJldHJpZXZlIHRoZSBJRC4K KyAgICAgICAgKiBXZWJQcm9jZXNzL0dQVS9tZWRpYS9SZW1vdGVDRE1GYWN0b3J5Lmg6CisgICAg ICAgIChXZWJLaXQ6OlJlbW90ZUNETUZhY3Rvcnk6OmFkZFNlc3Npb24pOgorICAgICAgICAtIFJl bW92ZSBhcmd1bWVudC4KKyAgICAgICAgKiBXZWJQcm9jZXNzL0dQVS9tZWRpYS9SZW1vdGVDRE1J bnN0YW5jZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OlJlbW90ZUNETUluc3RhbmNlOjpjcmVhdGVT ZXNzaW9uKToKKyAgICAgICAgLSBSZW1vdmUgYXJndW1lbnQuCisKIDIwMjAtMDQtMDMgIERhdmlk IEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWJQbGF0Zm9ybVN0cmF0 ZWdpZXM6OntyZWFkQnVmZmVyRnJvbVBhc3RlYm9hcmQsYnVmZmVyRm9yVHlwZX0gc2hvdWxkIHZh bGlkYXRlIHRoZWlyIGBzaXplYCBwYXJhbWV0ZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv V2ViUHJvY2Vzcy9HUFUvbWVkaWEvUmVtb3RlQ0RNRmFjdG9yeS5jcHAgYi9Tb3VyY2UvV2ViS2l0 L1dlYlByb2Nlc3MvR1BVL21lZGlhL1JlbW90ZUNETUZhY3RvcnkuY3BwCmluZGV4IDhmMmQzZDVj NjEwYWY1NGFkMWQzZWY0ZmE2MWM0NTk2NjY1Mjk3YzEuLmJlODc4YzFlMDE5NDgxNmE2YWU0OGRl OWE4ZWViY2VmMDQxMmM2ZTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9H UFUvbWVkaWEvUmVtb3RlQ0RNRmFjdG9yeS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9j ZXNzL0dQVS9tZWRpYS9SZW1vdGVDRE1GYWN0b3J5LmNwcApAQCAtNzgsMTAgKzc4LDEwIEBAIHN0 ZDo6dW5pcXVlX3B0cjxDRE1Qcml2YXRlPiBSZW1vdGVDRE1GYWN0b3J5OjpjcmVhdGVDRE0oY29u c3QgU3RyaW5nJiBrZXlTeXN0ZW0pCiAgICAgcmV0dXJuIFJlbW90ZUNETTo6Y3JlYXRlKG1ha2VX ZWFrUHRyKHRoaXMpLCBXVEZNb3ZlKGlkKSwgV1RGTW92ZShjb25maWd1cmF0aW9uKSk7CiB9CiAK LXZvaWQgUmVtb3RlQ0RNRmFjdG9yeTo6YWRkU2Vzc2lvbihSZW1vdGVDRE1JbnN0YW5jZVNlc3Np b25JZGVudGlmaWVyIGlkLCBSZWY8UmVtb3RlQ0RNSW5zdGFuY2VTZXNzaW9uPiYmIHNlc3Npb24p Cit2b2lkIFJlbW90ZUNETUZhY3Rvcnk6OmFkZFNlc3Npb24oUmVmPFJlbW90ZUNETUluc3RhbmNl U2Vzc2lvbj4mJiBzZXNzaW9uKQogewotICAgIEFTU0VSVCghbV9zZXNzaW9ucy5jb250YWlucyhp ZCkpOwotICAgIG1fc2Vzc2lvbnMuc2V0KGlkLCBXVEZNb3ZlKHNlc3Npb24pKTsKKyAgICBBU1NF UlQoIW1fc2Vzc2lvbnMuY29udGFpbnMoc2Vzc2lvbi0+aWRlbnRpZmllcigpKSk7CisgICAgbV9z ZXNzaW9ucy5zZXQoc2Vzc2lvbi0+aWRlbnRpZmllcigpLCBXVEZNb3ZlKHNlc3Npb24pKTsKIH0K IAogdm9pZCBSZW1vdGVDRE1GYWN0b3J5OjpyZW1vdmVTZXNzaW9uKFJlbW90ZUNETUluc3RhbmNl U2Vzc2lvbklkZW50aWZpZXIgaWQpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nl c3MvR1BVL21lZGlhL1JlbW90ZUNETUZhY3RvcnkuaCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vz cy9HUFUvbWVkaWEvUmVtb3RlQ0RNRmFjdG9yeS5oCmluZGV4IDU4OWVkMDYwMDFjNjYzYmFmMTg1 ZGI5MzE3NDk3ZTkyY2ZiZmMwNmIuLmY0MzE4YzYxMDUwM2M2ZTZlZDE0YjNlZjIwYTMyZmI1NGRm MTc2NDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9HUFUvbWVkaWEvUmVt b3RlQ0RNRmFjdG9yeS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9HUFUvbWVkaWEv UmVtb3RlQ0RNRmFjdG9yeS5oCkBAIC02OCw3ICs2OCw3IEBAIHB1YmxpYzoKIAogICAgIHZvaWQg ZGlkUmVjZWl2ZVNlc3Npb25NZXNzYWdlKElQQzo6Q29ubmVjdGlvbiYsIElQQzo6RGVjb2RlciYp OwogCi0gICAgdm9pZCBhZGRTZXNzaW9uKFJlbW90ZUNETUluc3RhbmNlU2Vzc2lvbklkZW50aWZp ZXIsIFJlZjxSZW1vdGVDRE1JbnN0YW5jZVNlc3Npb24+JiYpOworICAgIHZvaWQgYWRkU2Vzc2lv bihSZWY8UmVtb3RlQ0RNSW5zdGFuY2VTZXNzaW9uPiYmKTsKICAgICB2b2lkIHJlbW92ZVNlc3Np b24oUmVtb3RlQ0RNSW5zdGFuY2VTZXNzaW9uSWRlbnRpZmllcik7CiAKIHByaXZhdGU6CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvR1BVL21lZGlhL1JlbW90ZUNETUluc3Rh bmNlLmNwcCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9HUFUvbWVkaWEvUmVtb3RlQ0RNSW5z dGFuY2UuY3BwCmluZGV4IGYxYWQ3YTZmMmMyNmIwMDc4NzY2YTkxYWY5MDIwMmIwYWZjZTQ3ZDYu LjQzZmI4ZDVmNjNjNTMxN2M4OWExMGNkOTkxMzM4MWQ3NDNjZTM4NWEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9HUFUvbWVkaWEvUmVtb3RlQ0RNSW5zdGFuY2UuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9HUFUvbWVkaWEvUmVtb3RlQ0RNSW5zdGFuY2Uu Y3BwCkBAIC05MSw3ICs5MSw3IEBAIFJlZlB0cjxXZWJDb3JlOjpDRE1JbnN0YW5jZVNlc3Npb24+ IFJlbW90ZUNETUluc3RhbmNlOjpjcmVhdGVTZXNzaW9uKCkKICAgICBpZiAoIWlkKQogICAgICAg ICByZXR1cm4gbnVsbHB0cjsKICAgICBhdXRvIHNlc3Npb24gPSBSZW1vdGVDRE1JbnN0YW5jZVNl c3Npb246OmNyZWF0ZShtYWtlV2Vha1B0cihtX2ZhY3RvcnkuZ2V0KCkpLCBXVEZNb3ZlKGlkKSk7 Ci0gICAgbV9mYWN0b3J5LT5hZGRTZXNzaW9uKHNlc3Npb24tPmlkZW50aWZpZXIoKSwgc2Vzc2lv bi5jb3B5UmVmKCkpOworICAgIG1fZmFjdG9yeS0+YWRkU2Vzc2lvbihzZXNzaW9uLmNvcHlSZWYo KSk7CiAgICAgcmV0dXJuIHNlc3Npb247CiB9CiAK