<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>209999</bug_id>
          
          <creation_ts>2020-04-03 21:54:10 -0700</creation_ts>
          <short_desc>Nullptr crash in CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary with draggable text</short_desc>
          <delta_ts>2020-04-06 14:44:16 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>HTML Editing</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Jack">shihchieh_lee</reporter>
          <assigned_to name="Jack">shihchieh_lee</assigned_to>
          <cc>bfulgham</cc>
    
    <cc>ews-feeder</cc>
    
    <cc>product-security</cc>
    
    <cc>rniwa</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>wenson_hsieh</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1637626</commentid>
    <comment_count>0</comment_count>
    <who name="Jack">shihchieh_lee</who>
    <bug_when>2020-04-03 21:54:10 -0700</bug_when>
    <thetext>&lt;rdar://58978340&gt;

==22496==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000014 (pc 0x00072bba7ae2 bp 0x7ffee215fd50 sp 0x7ffee215fd50 T0)
==22496==The signal is caused by a READ memory access.
==22496==Hint: address points to the zero page.
==22496==WARNING: invalid path to external symbolizer!
==22496==WARNING: Failed to use and restart external symbolizer!
    #0 0x72bba7ae1 in WebCore::Node::getFlag(WebCore::Node::NodeFlags) const (Safari_ASAN_254346_4878c59d1007965234bf2fabf087ce373bfe4e27.app/Contents/Frameworks/WebCore.framework/Versions/A/WebCore:x86_64+0x1afae1)
    #1 0x72bba79d1 in WebCore::Node::hasTagName(WebCore::HTMLQualifiedName const&amp;) const (Safari_ASAN_254346_4878c59d1007965234bf2fabf087ce373bfe4e27.app/Contents/Frameworks/WebCore.framework/Versions/A/WebCore:x86_64+0x1af9d1)
    #2 0x72edcc895 in WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary(WebCore::Position const&amp;) (Safari_ASAN_254346_4878c59d1007965234bf2fabf087ce373bfe4e27.app/Contents/Frameworks/WebCore.framework/Versions/A/WebCore:x86_64+0x33d4895)
    #3 0x72edc96d7 in WebCore::ApplyStyleCommand::applyBlockStyle(WebCore::EditingStyle&amp;) (Safari_ASAN_254346_4878c59d1007965234bf2fabf087ce373bfe4e27.app/Contents/Frameworks/WebCore.framework/Versions/A/WebCore:x86_64+0x33d16d7)
    #4 0x72edc8c52 in WebCore::ApplyStyleCommand::doApply() (Safari_ASAN_254346_4878c59d1007965234bf2fabf087ce373bfe4e27.app/Contents/Frameworks/WebCore.framework/Versions/A/WebCore:x86_64+0x33d0c52)
    #5 0x72edbfb36 in WebCore::CompositeEditCommand::apply() (Safari_ASAN_254346_4878c59d1007965234bf2fabf087ce373bfe4e27.app/Contents/Frameworks/WebCore.framework/Versions/A/WebCore:x86_64+0x33c7b36)
    #6 0x72ee33467 in WebCore::Editor::applyParagraphStyle(WebCore::StyleProperties*, WebCore::EditAction) (Safari_ASAN_254346_4878c59d1007965234bf2fabf087ce373bfe4e27.app/Contents/Frameworks/WebCore.framework/Versions/A/WebCore:x86_64+0x343b467)
    #7 0x72ee7bbf6 in WebCore::executeApplyParagraphStyle(WebCore::Frame&amp;, WebCore::EditorCommandSource, WebCore::EditAction, WebCore::CSSPropertyID, WTF::String const&amp;) (Safari_ASAN_254346_4878c59d1007965234bf2fabf087ce373bfe4e27.app/Contents/Frameworks/WebCore.framework/Versions/A/WebCore:x86_64+0x3483bf6)
    #8 0x72ee74692 in WebCore::executeJustifyCenter(WebCore::Frame&amp;, WebCore::Event*, WebCore::EditorCommandSource, WTF::String const&amp;) (Safari_ASAN_254346_4878c59d1007965234bf2fabf087ce373bfe4e27.app/Contents/Frameworks/WebCore.framework/Versions/A/WebCore:x86_64+0x347c692)
    #9 0x72eaf63d7 in WebCore::Document::execCommand(WTF::String const&amp;, bool, WTF::String const&amp;) (Safari_ASAN_254346_4878c59d1007965234bf2fabf087ce373bfe4e27.app/Contents/Frameworks/WebCore.framework/Versions/A/WebCore:x86_64+0x30fe3d7)
    #10 0x72c4671ba in WebCore::jsDocumentPrototypeFunctionExecCommandBody(JSC::JSGlobalObject*, JSC::CallFrame*, WebCore::JSDocument*, JSC::ThrowScope&amp;) (Safari_ASAN_254346_4878c59d1007965234bf2fabf087ce373bfe4e27.app/Contents/Frameworks/WebCore.framework/Versions/A/WebCore:x86_64+0xa6f1ba)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1637628</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-04-03 21:54:17 -0700</bug_when>
    <thetext>&lt;rdar://problem/61288781&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1637631</commentid>
    <comment_count>2</comment_count>
    <who name="Jack">shihchieh_lee</who>
    <bug_when>2020-04-03 21:59:10 -0700</bug_when>
    <thetext>Root cause: In function moveParagraphContentsToNewBlockIfNecessary, an empty VisiblePosition is derefed for its anchor node.

1. Because span has attribute “draggable” set to true, its “UserSelect” style is set to none.
2. When “justifyCenter” command executes on the shadow element, we try to move the whole paragraph to a new block by calling moveParagraphContentsToNewBlockIfNecessary.
3. In moveParagraphContentsToNewBlockIfNecessary, we find the end of the paragraph by calling endOfParagraph.
4. However, endOfParagraph returns empty visible position because function canonicalPosition cannot find a candidate position.
5. The text node is supposed to be the end of the paragraph, but its parent, &lt;span&gt;, has UserSelect::None style, so it is not selected by canonicalPosition().
6. Later the empty endOfParagraph is deref for its null anchor node, and the code crashes.

&lt;style&gt;
    #SHADOW { initial; -webkit-user-select: text; }
    #LABEL { -webkit-user-select: all; }
&lt;/style&gt;
&lt;script&gt;
window.onload = () =&gt;  {
    window.getSelection().collapse(SHADOW);
    document.execCommand(&quot;justifyCenter&quot;, false);
}
&lt;/script&gt;
&lt;label id=LABEL contenteditable=&quot;true&quot;&gt;&lt;shadow id=SHADOW&gt;&lt;/shadow&gt;&lt;span draggable=&quot;true&quot;&gt;a

BODY	0x60c000086e00 (renderer 0x612000071140) 
	LABEL	0x60c000086ec0 (renderer 0x6110000d1f00) 
		SHADOW	0x60c000086f80 (renderer 0x6110000d2040) 
		SPAN	0x60c000087040 (renderer 0x6110000d2180) 
*			#text	0x6080000501a0 &quot;a\n&quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1637632</commentid>
    <comment_count>3</comment_count>
    <who name="Jack">shihchieh_lee</who>
    <bug_when>2020-04-03 22:00:22 -0700</bug_when>
    <thetext>Please refer to &lt;rdar://58978340&gt;.

(In reply to Radar WebKit Bug Importer from comment #1)
&gt; &lt;rdar://problem/61288781&gt;
This was caused by accidental save of the bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1637646</commentid>
    <comment_count>4</comment_count>
      <attachid>395437</attachid>
    <who name="Jack">shihchieh_lee</who>
    <bug_when>2020-04-03 22:29:15 -0700</bug_when>
    <thetext>Created attachment 395437
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1638247</commentid>
    <comment_count>5</comment_count>
      <attachid>395437</attachid>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2020-04-06 12:43:30 -0700</bug_when>
    <thetext>Comment on attachment 395437
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395437&amp;action=review

&gt; Source/WebCore/editing/CompositeEditCommand.cpp:1184
&gt; +    

Nit: whitespace.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1638248</commentid>
    <comment_count>6</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2020-04-06 12:43:47 -0700</bug_when>
    <thetext>There is no security implication here.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1638251</commentid>
    <comment_count>7</comment_count>
      <attachid>395602</attachid>
    <who name="Jack">shihchieh_lee</who>
    <bug_when>2020-04-06 12:50:05 -0700</bug_when>
    <thetext>Created attachment 395602
Patch for landing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1638324</commentid>
    <comment_count>8</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2020-04-06 14:44:16 -0700</bug_when>
    <thetext>Committed r259595: &lt;https://trac.webkit.org/changeset/259595&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395602.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>395437</attachid>
            <date>2020-04-03 22:29:15 -0700</date>
            <delta_ts>2020-04-06 12:50:04 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-209999-20200403222915.patch</filename>
            <type>text/plain</type>
            <size>4079</size>
            <attacher name="Jack">shihchieh_lee</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5NDM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjE1YTUzZTUzYjFjMzE1
Y2FhNjc2Y2M3ZTA3YmIxZDA5MGNkYWM4OC4uNzFkODI4NzQ5NWQ2YjA3ODhhZDY4N2NjZThlYjM5
OGFkMTlhOWZiOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTA0LTAzICBKYWNr
IExlZSAgPHNoaWhjaGllaF9sZWVAYXBwbGUuY29tPgorCisgICAgICAgIE51bGxwdHIgY3Jhc2gg
aW4gQ29tcG9zaXRlRWRpdENvbW1hbmQ6Om1vdmVQYXJhZ3JhcGhDb250ZW50c1RvTmV3QmxvY2tJ
Zk5lY2Vzc2FyeSB3aXRoIGRyYWdnYWJsZSB0ZXh0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDk5OTkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU4
OTc4MzQwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
IFZpc2libGVQYXJhZ3JhcGhTdGFydC9FbmQgbWF5IHJldHVybiBlbXB0eSBWaXNpYmxlUG9zaXRp
b24gaWYgbm8gcHJvcGVyIGVsZW1lbnQgb3Igbm9kZQorICAgICAgICBjYW4gYmUgdXNlZCBhcyBw
b3NpdGlvbiBjYW5kaWRhdGUuIEFkZCBudWxsIGNoZWNrIGZvciB0aGUgcmV0dXJuZWQgVmlzaWJs
ZVBvc2l0aW9ucy4KKworICAgICAgICBUZXN0OiBmYXN0L2Nzcy9zdHlsZS1jaGFuZ2UtZHJhZ2dh
YmxlLXRleHQuaHRtbAorCisgICAgICAgICogZWRpdGluZy9Db21wb3NpdGVFZGl0Q29tbWFuZC5j
cHA6CisgICAgICAgIChXZWJDb3JlOjpDb21wb3NpdGVFZGl0Q29tbWFuZDo6bW92ZVBhcmFncmFw
aENvbnRlbnRzVG9OZXdCbG9ja0lmTmVjZXNzYXJ5KToKKwogMjAyMC0wNC0wMiAgQW5kcmVzIEdv
bnphbGV6ICA8YW5kcmVzZ18yMkBhcHBsZS5jb20+CiAKICAgICAgICAgQ3Jhc2ggaW4gUmVuZGVy
TWVudUxpc3Q6OmRpZFVwZGF0ZUFjdGl2ZU9wdGlvbi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD
b3JlL2VkaXRpbmcvQ29tcG9zaXRlRWRpdENvbW1hbmQuY3BwIGIvU291cmNlL1dlYkNvcmUvZWRp
dGluZy9Db21wb3NpdGVFZGl0Q29tbWFuZC5jcHAKaW5kZXggNjNiZTkxZTkwNGM4OTM1ZGZmOTU2
MTRjODcwYzkyNGFmMzRkYmE3OS4uMjU2OTdkODU1Zjg4MThmNDBhNjRkNjVhY2Y0ODAwYjJiZGQ2
MjZmNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9Db21wb3NpdGVFZGl0Q29t
bWFuZC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9Db21wb3NpdGVFZGl0Q29tbWFu
ZC5jcHAKQEAgLTExNzksNiArMTE3OSw5IEBAIFJlZlB0cjxOb2RlPiBDb21wb3NpdGVFZGl0Q29t
bWFuZDo6bW92ZVBhcmFncmFwaENvbnRlbnRzVG9OZXdCbG9ja0lmTmVjZXNzYXJ5KGNvCiAgICAg
VmlzaWJsZVBvc2l0aW9uIHZpc2libGVQb3MocG9zLCBWUF9ERUZBVUxUX0FGRklOSVRZKTsKICAg
ICBWaXNpYmxlUG9zaXRpb24gdmlzaWJsZVBhcmFncmFwaFN0YXJ0KHN0YXJ0T2ZQYXJhZ3JhcGgo
dmlzaWJsZVBvcykpOwogICAgIFZpc2libGVQb3NpdGlvbiB2aXNpYmxlUGFyYWdyYXBoRW5kID0g
ZW5kT2ZQYXJhZ3JhcGgodmlzaWJsZVBvcyk7CisgICAgaWYgKHZpc2libGVQYXJhZ3JhcGhTdGFy
dC5pc051bGwoKSB8fCB2aXNpYmxlUGFyYWdyYXBoRW5kLmlzTnVsbCgpKQorICAgICAgICByZXR1
cm4gbnVsbHB0cjsKKyAgICAKICAgICBWaXNpYmxlUG9zaXRpb24gbmV4dCA9IHZpc2libGVQYXJh
Z3JhcGhFbmQubmV4dCgpOwogICAgIFZpc2libGVQb3NpdGlvbiB2aXNpYmxlRW5kID0gbmV4dC5p
c05vdE51bGwoKSA/IG5leHQgOiB2aXNpYmxlUGFyYWdyYXBoRW5kOwogICAgIApkaWZmIC0tZ2l0
IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDYy
MDA0ZTA4M2UxZmIyNzNjNTY2NGUyOTE5YWI5MWUxNmVhNjBiODEuLjAxYzQzNjU0MjJlYzhhZGRk
N2VkYmQ1ZjVkNTU0ZjNlMDAxYWI4MjEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxv
ZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAyMC0wNC0w
MyAgSmFjayBMZWUgIDxzaGloY2hpZWhfbGVlQGFwcGxlLmNvbT4KKworICAgICAgICBOdWxscHRy
IGNyYXNoIGluIENvbXBvc2l0ZUVkaXRDb21tYW5kOjptb3ZlUGFyYWdyYXBoQ29udGVudHNUb05l
d0Jsb2NrSWZOZWNlc3Nhcnkgd2l0aCBkcmFnZ2FibGUgdGV4dAorICAgICAgICBodHRwczovL2J1
Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA5OTk5CisgICAgICAgIDxyZGFyOi8vcHJv
YmxlbS81ODk3ODM0MD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor
ICAgICAgICBBZGRlZCBhIHJlZ3Jlc3Npb24gdGVzdCBmb3IgdGhlIGNyYXNoLgorCisgICAgICAg
ICogZmFzdC9jc3Mvc3R5bGUtY2hhbmdlLWRyYWdnYWJsZS10ZXh0LWV4cGVjdGVkLnR4dDogQWRk
ZWQuCisgICAgICAgICogZmFzdC9jc3Mvc3R5bGUtY2hhbmdlLWRyYWdnYWJsZS10ZXh0Lmh0bWw6
IEFkZGVkLgorCiAyMDIwLTA0LTAyICBKb2huIFdpbGFuZGVyICA8d2lsYW5kZXJAYXBwbGUuY29t
PgogCiAgICAgICAgIFJlYmFzZSBleHBlY3RhdGlvbiBmaWxlcyBmb3IgYW5jaG9yIHRhZyB0ZXN0
cyB3aXRoIGxpbmUgbnVtYmVyIG91dHB1dApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9j
c3Mvc3R5bGUtY2hhbmdlLWRyYWdnYWJsZS10ZXh0LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3Rz
L2Zhc3QvY3NzL3N0eWxlLWNoYW5nZS1kcmFnZ2FibGUtdGV4dC1leHBlY3RlZC50eHQKbmV3IGZp
bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMC4uMTZlODMxZWY1OTQyZjg4ZmVmZTNkYTZkOTZmZGViMWYwZGQ3NWM1ZgotLS0gL2Rldi9u
dWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL3N0eWxlLWNoYW5nZS1kcmFnZ2FibGUtdGV4
dC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSBAQAorVGVzdCBjaGFuZ2luZyBzdHlsZSB3aXRoIGRy
YWdnYWJsZSB0ZXh0LiBUaGUgdGVzdCBwYXNzZXMgaWYgV2ViS2l0IGRvZXNuJ3QgY3Jhc2ggb3Ig
aGl0IGFuIGFzc2VydGlvbmEKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY3NzL3N0eWxl
LWNoYW5nZS1kcmFnZ2FibGUtdGV4dC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3Mvc3R5bGUt
Y2hhbmdlLWRyYWdnYWJsZS10ZXh0Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZDIxMmY3MjZiOGMxZTIxZGQ4
N2Y2ZTljMmI4MWQyNTRjYWY0YjQxMwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zh
c3QvY3NzL3N0eWxlLWNoYW5nZS1kcmFnZ2FibGUtdGV4dC5odG1sCkBAIC0wLDAgKzEsMTQgQEAK
KzxzdHlsZT4KKyAgICAjU0hBRE9XIHsgaW5pdGlhbDsgLXdlYmtpdC11c2VyLXNlbGVjdDogdGV4
dDsgfQorICAgICNMQUJFTCB7IC13ZWJraXQtdXNlci1zZWxlY3Q6IGFsbDsgfQorPC9zdHlsZT4K
KzxzY3JpcHQ+CisgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICAgICAgICB0ZXN0UnVubmVy
LmR1bXBBc1RleHQoKTsKKworICAgIHdpbmRvdy5vbmxvYWQgPSAoKSA9PiAgeworICAgICAgICB3
aW5kb3cuZ2V0U2VsZWN0aW9uKCkuY29sbGFwc2UoU0hBRE9XKTsKKyAgICAgICAgZG9jdW1lbnQu
ZXhlY0NvbW1hbmQoImp1c3RpZnlDZW50ZXIiLCBmYWxzZSk7CisgICAgfQorPC9zY3JpcHQ+Cis8
c3Bhbj5UZXN0IGNoYW5naW5nIHN0eWxlIHdpdGggZHJhZ2dhYmxlIHRleHQuIFRoZSB0ZXN0IHBh
c3NlcyBpZiBXZWJLaXQgZG9lc24ndCBjcmFzaCBvciBoaXQgYW4gYXNzZXJ0aW9uPC9zcGFuPjxs
YWJlbCBpZD1MQUJFTCBjb250ZW50ZWRpdGFibGU9InRydWUiPjxzaGFkb3cgaWQ9U0hBRE9XPjwv
c2hhZG93PjxzcGFuIGRyYWdnYWJsZT0idHJ1ZSI+YQo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>395602</attachid>
            <date>2020-04-06 12:50:05 -0700</date>
            <delta_ts>2020-04-06 14:44:16 -0700</delta_ts>
            <desc>Patch for landing</desc>
            <filename>bug-209999-20200406125004.patch</filename>
            <type>text/plain</type>
            <size>4071</size>
            <attacher name="Jack">shihchieh_lee</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5NDM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjE1YTUzZTUzYjFjMzE1
Y2FhNjc2Y2M3ZTA3YmIxZDA5MGNkYWM4OC4uOWZiZjExYWMxY2FhNzM0YjY3Y2NjMWM3ZTk1ZjU2
OWIwZTMzYjFmOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTA0LTAzICBKYWNr
IExlZSAgPHNoaWhjaGllaF9sZWVAYXBwbGUuY29tPgorCisgICAgICAgIE51bGxwdHIgY3Jhc2gg
aW4gQ29tcG9zaXRlRWRpdENvbW1hbmQ6Om1vdmVQYXJhZ3JhcGhDb250ZW50c1RvTmV3QmxvY2tJ
Zk5lY2Vzc2FyeSB3aXRoIGRyYWdnYWJsZSB0ZXh0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDk5OTkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU4
OTc4MzQwPgorCisgICAgICAgIFJldmlld2VkIGJ5IFJ5b3N1a2UgTml3YS4KKworICAgICAgICBW
aXNpYmxlUGFyYWdyYXBoU3RhcnQvRW5kIG1heSByZXR1cm4gZW1wdHkgVmlzaWJsZVBvc2l0aW9u
IGlmIG5vIHByb3BlciBlbGVtZW50IG9yIG5vZGUKKyAgICAgICAgY2FuIGJlIHVzZWQgYXMgcG9z
aXRpb24gY2FuZGlkYXRlLiBBZGQgbnVsbCBjaGVjayBmb3IgdGhlIHJldHVybmVkIFZpc2libGVQ
b3NpdGlvbnMuCisKKyAgICAgICAgVGVzdDogZmFzdC9jc3Mvc3R5bGUtY2hhbmdlLWRyYWdnYWJs
ZS10ZXh0Lmh0bWwKKworICAgICAgICAqIGVkaXRpbmcvQ29tcG9zaXRlRWRpdENvbW1hbmQuY3Bw
OgorICAgICAgICAoV2ViQ29yZTo6Q29tcG9zaXRlRWRpdENvbW1hbmQ6Om1vdmVQYXJhZ3JhcGhD
b250ZW50c1RvTmV3QmxvY2tJZk5lY2Vzc2FyeSk6CisKIDIwMjAtMDQtMDIgIEFuZHJlcyBHb256
YWxleiAgPGFuZHJlc2dfMjJAYXBwbGUuY29tPgogCiAgICAgICAgIENyYXNoIGluIFJlbmRlck1l
bnVMaXN0OjpkaWRVcGRhdGVBY3RpdmVPcHRpb24uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y
ZS9lZGl0aW5nL0NvbXBvc2l0ZUVkaXRDb21tYW5kLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2VkaXRp
bmcvQ29tcG9zaXRlRWRpdENvbW1hbmQuY3BwCmluZGV4IDYzYmU5MWU5MDRjODkzNWRmZjk1NjE0
Yzg3MGM5MjRhZjM0ZGJhNzkuLjI4NjVjOGQ2ZjZjOTM4NjlkNjY4NWZiNzJiYmYyMzdmNzhlNWU0
MTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvQ29tcG9zaXRlRWRpdENvbW1h
bmQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvQ29tcG9zaXRlRWRpdENvbW1hbmQu
Y3BwCkBAIC0xMTc5LDYgKzExNzksOSBAQCBSZWZQdHI8Tm9kZT4gQ29tcG9zaXRlRWRpdENvbW1h
bmQ6Om1vdmVQYXJhZ3JhcGhDb250ZW50c1RvTmV3QmxvY2tJZk5lY2Vzc2FyeShjbwogICAgIFZp
c2libGVQb3NpdGlvbiB2aXNpYmxlUG9zKHBvcywgVlBfREVGQVVMVF9BRkZJTklUWSk7CiAgICAg
VmlzaWJsZVBvc2l0aW9uIHZpc2libGVQYXJhZ3JhcGhTdGFydChzdGFydE9mUGFyYWdyYXBoKHZp
c2libGVQb3MpKTsKICAgICBWaXNpYmxlUG9zaXRpb24gdmlzaWJsZVBhcmFncmFwaEVuZCA9IGVu
ZE9mUGFyYWdyYXBoKHZpc2libGVQb3MpOworICAgIGlmICh2aXNpYmxlUGFyYWdyYXBoU3RhcnQu
aXNOdWxsKCkgfHwgdmlzaWJsZVBhcmFncmFwaEVuZC5pc051bGwoKSkKKyAgICAgICAgcmV0dXJu
IG51bGxwdHI7CisKICAgICBWaXNpYmxlUG9zaXRpb24gbmV4dCA9IHZpc2libGVQYXJhZ3JhcGhF
bmQubmV4dCgpOwogICAgIFZpc2libGVQb3NpdGlvbiB2aXNpYmxlRW5kID0gbmV4dC5pc05vdE51
bGwoKSA/IG5leHQgOiB2aXNpYmxlUGFyYWdyYXBoRW5kOwogICAgIApkaWZmIC0tZ2l0IGEvTGF5
b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDYyMDA0ZTA4
M2UxZmIyNzNjNTY2NGUyOTE5YWI5MWUxNmVhNjBiODEuLjZmZWY4ZTVkOWI1MzNhMTk4ZTAzNmY5
NGU3OTg0MTEzNjE4YWY1MmYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysg
Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAyMC0wNC0wMyAgSmFj
ayBMZWUgIDxzaGloY2hpZWhfbGVlQGFwcGxlLmNvbT4KKworICAgICAgICBOdWxscHRyIGNyYXNo
IGluIENvbXBvc2l0ZUVkaXRDb21tYW5kOjptb3ZlUGFyYWdyYXBoQ29udGVudHNUb05ld0Jsb2Nr
SWZOZWNlc3Nhcnkgd2l0aCBkcmFnZ2FibGUgdGV4dAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi
a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA5OTk5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81
ODk3ODM0MD4KKworICAgICAgICBSZXZpZXdlZCBieSBSeW9zdWtlIE5pd2EuCisKKyAgICAgICAg
QWRkZWQgYSByZWdyZXNzaW9uIHRlc3QgZm9yIHRoZSBjcmFzaC4KKworICAgICAgICAqIGZhc3Qv
Y3NzL3N0eWxlLWNoYW5nZS1kcmFnZ2FibGUtdGV4dC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAg
ICAgICAqIGZhc3QvY3NzL3N0eWxlLWNoYW5nZS1kcmFnZ2FibGUtdGV4dC5odG1sOiBBZGRlZC4K
KwogMjAyMC0wNC0wMiAgSm9obiBXaWxhbmRlciAgPHdpbGFuZGVyQGFwcGxlLmNvbT4KIAogICAg
ICAgICBSZWJhc2UgZXhwZWN0YXRpb24gZmlsZXMgZm9yIGFuY2hvciB0YWcgdGVzdHMgd2l0aCBs
aW5lIG51bWJlciBvdXRwdXQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY3NzL3N0eWxl
LWNoYW5nZS1kcmFnZ2FibGUtdGV4dC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2Nz
cy9zdHlsZS1jaGFuZ2UtZHJhZ2dhYmxlLXRleHQtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUg
MTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjE2
ZTgzMWVmNTk0MmY4OGZlZmUzZGE2ZDk2ZmRlYjFmMGRkNzVjNWYKLS0tIC9kZXYvbnVsbAorKysg
Yi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9zdHlsZS1jaGFuZ2UtZHJhZ2dhYmxlLXRleHQtZXhwZWN0
ZWQudHh0CkBAIC0wLDAgKzEgQEAKK1Rlc3QgY2hhbmdpbmcgc3R5bGUgd2l0aCBkcmFnZ2FibGUg
dGV4dC4gVGhlIHRlc3QgcGFzc2VzIGlmIFdlYktpdCBkb2Vzbid0IGNyYXNoIG9yIGhpdCBhbiBh
c3NlcnRpb25hCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9zdHlsZS1jaGFuZ2Ut
ZHJhZ2dhYmxlLXRleHQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL3N0eWxlLWNoYW5nZS1k
cmFnZ2FibGUtdGV4dC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmQyMTJmNzI2YjhjMWUyMWRkODdmNmU5YzJi
ODFkMjU0Y2FmNGI0MTMKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9z
dHlsZS1jaGFuZ2UtZHJhZ2dhYmxlLXRleHQuaHRtbApAQCAtMCwwICsxLDE0IEBACis8c3R5bGU+
CisgICAgI1NIQURPVyB7IGluaXRpYWw7IC13ZWJraXQtdXNlci1zZWxlY3Q6IHRleHQ7IH0KKyAg
ICAjTEFCRUwgeyAtd2Via2l0LXVzZXItc2VsZWN0OiBhbGw7IH0KKzwvc3R5bGU+Cis8c2NyaXB0
PgorICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICAgICAgdGVzdFJ1bm5lci5kdW1wQXNU
ZXh0KCk7CisKKyAgICB3aW5kb3cub25sb2FkID0gKCkgPT4gIHsKKyAgICAgICAgd2luZG93Lmdl
dFNlbGVjdGlvbigpLmNvbGxhcHNlKFNIQURPVyk7CisgICAgICAgIGRvY3VtZW50LmV4ZWNDb21t
YW5kKCJqdXN0aWZ5Q2VudGVyIiwgZmFsc2UpOworICAgIH0KKzwvc2NyaXB0PgorPHNwYW4+VGVz
dCBjaGFuZ2luZyBzdHlsZSB3aXRoIGRyYWdnYWJsZSB0ZXh0LiBUaGUgdGVzdCBwYXNzZXMgaWYg
V2ViS2l0IGRvZXNuJ3QgY3Jhc2ggb3IgaGl0IGFuIGFzc2VydGlvbjwvc3Bhbj48bGFiZWwgaWQ9
TEFCRUwgY29udGVudGVkaXRhYmxlPSJ0cnVlIj48c2hhZG93IGlkPVNIQURPVz48L3NoYWRvdz48
c3BhbiBkcmFnZ2FibGU9InRydWUiPmEK
</data>

          </attachment>
      

    </bug>

</bugzilla>