20999 2008-09-22 10:41:44 -0700 Inspector hover to select does not work properly on Windows 2008-09-24 18:10:50 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) PC Windows Vista RESOLVED FIXED InRadar, PlatformOnly P2 Normal --- 1 dev+webkit dev+webkit aroben oldest_to_newest 92149 0 dev+webkit 2008-09-22 10:41:44 -0700 The hover to select functionality does not work properly on Windows - the first node is initially highlighted properly, but then goes all the way out to what appears to be the body element. It is also impossible to actually select the node as clicking does nothing. The highlight window is probably messing with our mouse events. 92151 1 aroben 2008-09-22 10:45:14 -0700 <rdar://problem/6236524> 92248 2 23685 dev+webkit 2008-09-22 17:37:49 -0700 Created attachment 23685 Patch I'm hoping I missed an easier way of doing this... There is still a tendency for the highlight to get "stuck" at a larger, outer element, but it doesn't seem as bad as is in the tree current (but that could just be me). It's definitely something to fix in the future, but this at least gets it working on Windows. 92326 3 23685 dev+webkit 2008-09-23 05:53:02 -0700 Comment on attachment 23685 Patch Clearing the review flag, I think the hover forwarding stuff is wrong, I'd like to into it some more. 92329 4 aroben 2008-09-23 06:40:45 -0700 If you just want all mouse events to pass through the overlay window as if it weren't there, try passing WS_EX_TRANSPARENT to CreateWindowEx. 92645 5 23777 dev+webkit 2008-09-24 18:01:40 -0700 Created attachment 23777 one liner One line patch - I'm an idiot. 92647 6 23777 darin 2008-09-24 18:03:55 -0700 Comment on attachment 23777 one liner r=me 92649 7 dev+webkit 2008-09-24 18:10:50 -0700 Committed revision 36881. 23685 2008-09-22 17:37:49 -0700 2008-09-24 18:01:40 -0700 Patch Bug20999v1 text/plain 4062 dev+webkit SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM2Nzg1 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMDgtMDkt MjIgIE1hdHQgTGlsZWsgIDx3ZWJraXRAbWF0dGxpbGVrLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBCdWcgMjA5OTk6IEluc3BlY3RvciBob3Zl ciB0byBzZWxlY3QgZG9lcyBub3Qgd29yayBwcm9wZXJseSBvbiBXaW5kb3dzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDk5OQorICAgICAgICA8cmRh cjovL3Byb2JsZW0vNjIzNjUyND4KKworICAgICAgICBUaGUgV2luZG93cyBoaWdobGlnaHQgb3Zl cmxheSByZWNlaXZlcyBtb3VzZSBldmVudHMgdW5saWtlIHRoZSBNYWMKKyAgICAgICAgb3Zlcmxh eSAtIGZvcndhcmQgdGhlc2UgZXZlbnRzIG9uIHRvIGJlIHByb2Nlc3NlZCBpbnRlYWQgb2YgZWF0 ZW4uCisKKyAgICAgICAgKiBXZWJOb2RlSGlnaGxpZ2h0LmNwcDoKKyAgICAgICAgKFdlYk5vZGVI aWdobGlnaHQ6On5XZWJOb2RlSGlnaGxpZ2h0KToKKyAgICAgICAgKFdlYk5vZGVIaWdobGlnaHQ6 OnNob3cpOgorICAgICAgICAoV2ViTm9kZUhpZ2hsaWdodDo6b25PdmVybGF5Q2xpY2spOgorICAg ICAgICAoV2ViTm9kZUhpZ2hsaWdodDo6b25PdmVybGF5TW91c2VNb3ZlKToKKyAgICAgICAgKFdl Yk5vZGVIaWdobGlnaHQ6OndpbmRvd1JlY2VpdmVkTWVzc2FnZSk6CisgICAgICAgICogV2ViTm9k ZUhpZ2hsaWdodC5oOgorCiAyMDA4LTA5LTIwICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNv bT4KIAogICAgICAgICAtIGZpeCBidWlsZApJbmRleDogV2ViTm9kZUhpZ2hsaWdodC5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYk5vZGVIaWdobGlnaHQuaAkocmV2aXNpb24gMzY3ODEpCisrKyBXZWJOb2Rl SGlnaGxpZ2h0LmgJKHdvcmtpbmcgY29weSkKQEAgLTYxLDYgKzYxLDggQEAKICAgICB2b2lkIG9u V2ViVmlld1Nob3dXaW5kb3coYm9vbCBzaG93aW5nKTsKICAgICB2b2lkIG9uV2ViVmlld1dpbmRv d1Bvc0NoYW5nZWQoV0lORE9XUE9TKik7CiAgICAgdm9pZCBvblJvb3RXaW5kb3dQb3NDaGFuZ2Vk KFdJTkRPV1BPUyopOworICAgIHZvaWQgb25PdmVybGF5Q2xpY2soVUlOVCBtc2csIFdQQVJBTSwg TFBBUkFNKTsKKyAgICB2b2lkIG9uT3ZlcmxheU1vdXNlTW92ZShVSU5UIG1zZywgV1BBUkFNLCBM UEFSQU0pOwogCiAgICAgV2ViVmlldyogbV9pbnNwZWN0ZWRXZWJWaWV3OwogICAgIEhXTkQgbV9p bnNwZWN0ZWRXZWJWaWV3V2luZG93OwpJbmRleDogV2ViTm9kZUhpZ2hsaWdodC5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViTm9kZUhpZ2hsaWdodC5jcHAJKHJldmlzaW9uIDM2NzgxKQorKysgV2ViTm9k ZUhpZ2hsaWdodC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTYxLDkgKzYxLDggQEAKICAgICAgICAg V2luZG93TWVzc2FnZUJyb2FkY2FzdGVyOjpyZW1vdmVMaXN0ZW5lcihtX29ic2VydmVkV2luZG93 LCB0aGlzKTsKICAgICBpZiAobV9pbnNwZWN0ZWRXZWJWaWV3V2luZG93KQogICAgICAgICBXaW5k b3dNZXNzYWdlQnJvYWRjYXN0ZXI6OnJlbW92ZUxpc3RlbmVyKG1faW5zcGVjdGVkV2ViVmlld1dp bmRvdywgdGhpcyk7Ci0KICAgICBpZiAobV9vdmVybGF5KQotICAgICAgICA6OkRlc3Ryb3lXaW5k b3cobV9vdmVybGF5KTsKKyAgICAgICAgV2luZG93TWVzc2FnZUJyb2FkY2FzdGVyOjpyZW1vdmVM aXN0ZW5lcihtX292ZXJsYXksIHRoaXMpOwogfQogCiB2b2lkIFdlYk5vZGVIaWdobGlnaHQ6OnNl dFNob3dzV2hpbGVXZWJWaWV3SXNWaXNpYmxlKGJvb2wgc2hvd3MpCkBAIC0xMTIsNiArMTExLDcg QEAKICAgICAgICAgbV9vYnNlcnZlZFdpbmRvdyA9IEdldEFuY2VzdG9yKG1faW5zcGVjdGVkV2Vi Vmlld1dpbmRvdywgR0FfUk9PVCk7CiAgICAgICAgIFdpbmRvd01lc3NhZ2VCcm9hZGNhc3Rlcjo6 YWRkTGlzdGVuZXIobV9vYnNlcnZlZFdpbmRvdywgdGhpcyk7CiAgICAgICAgIFdpbmRvd01lc3Nh Z2VCcm9hZGNhc3Rlcjo6YWRkTGlzdGVuZXIobV9pbnNwZWN0ZWRXZWJWaWV3V2luZG93LCB0aGlz KTsKKyAgICAgICAgV2luZG93TWVzc2FnZUJyb2FkY2FzdGVyOjphZGRMaXN0ZW5lcihtX292ZXJs YXksIHRoaXMpOwogICAgIH0KIAogICAgIEFTU0VSVChtX3Nob3dzV2hpbGVXZWJWaWV3SXNWaXNp YmxlKTsKQEAgLTI3NSw2ICsyNzUsMTggQEAKICAgICB1cGRhdGUoKTsKIH0KIAordm9pZCBXZWJO b2RlSGlnaGxpZ2h0Ojpvbk92ZXJsYXlDbGljayhVSU5UIG1zZywgV1BBUkFNIHdQYXJhbSwgTFBB UkFNIGxQYXJhbSkKK3sKKyAgICBBU1NFUlQobV9pbnNwZWN0ZWRXZWJWaWV3KTsKKyAgICBtX2lu c3BlY3RlZFdlYlZpZXctPmhhbmRsZU1vdXNlRXZlbnQobXNnLCB3UGFyYW0sIGxQYXJhbSk7Cit9 CisKK3ZvaWQgV2ViTm9kZUhpZ2hsaWdodDo6b25PdmVybGF5TW91c2VNb3ZlKFVJTlQgbXNnLCBX UEFSQU0gd1BhcmFtLCBMUEFSQU0gbFBhcmFtKQoreworICAgIFdORFBST0MgcHJldlduZEZ1bmMg PSByZWludGVycHJldF9jYXN0PFdORFBST0M+KEdldFdpbmRvd0xvbmcobV9vdmVybGF5LCBHV0xf V05EUFJPQykpOworICAgIENhbGxXaW5kb3dQcm9jKHByZXZXbmRGdW5jLCBtX29ic2VydmVkV2lu ZG93LCBtc2csIHdQYXJhbSwgbFBhcmFtKTsKK30KKwogdm9pZCBXZWJOb2RlSGlnaGxpZ2h0Ojp3 aW5kb3dSZWNlaXZlZE1lc3NhZ2UoSFdORCB3aW5kb3csIFVJTlQgbXNnLCBXUEFSQU0gd1BhcmFt LCBMUEFSQU0gbFBhcmFtKQogewogICAgIGlmICh3aW5kb3cgPT0gbV9pbnNwZWN0ZWRXZWJWaWV3 V2luZG93KSB7CkBAIC0yOTIsMTIgKzMwNCwzNCBAQAogICAgICAgICByZXR1cm47CiAgICAgfQog Ci0gICAgQVNTRVJUKHdpbmRvdyA9PSBtX29ic2VydmVkV2luZG93KTsKLSAgICBzd2l0Y2ggKG1z ZykgewotICAgICAgICBjYXNlIFdNX1dJTkRPV1BPU0NIQU5HRUQ6Ci0gICAgICAgICAgICBvblJv b3RXaW5kb3dQb3NDaGFuZ2VkKHJlaW50ZXJwcmV0X2Nhc3Q8V0lORE9XUE9TKj4obFBhcmFtKSk7 Ci0gICAgICAgICAgICBicmVhazsKLSAgICAgICAgZGVmYXVsdDoKLSAgICAgICAgICAgIGJyZWFr OworICAgIGlmICh3aW5kb3cgPT0gbV9vYnNlcnZlZFdpbmRvdykgeworICAgICAgICBzd2l0Y2gg KG1zZykgeworICAgICAgICAgICAgY2FzZSBXTV9XSU5ET1dQT1NDSEFOR0VEOgorICAgICAgICAg ICAgICAgIG9uUm9vdFdpbmRvd1Bvc0NoYW5nZWQocmVpbnRlcnByZXRfY2FzdDxXSU5ET1dQT1Mq PihsUGFyYW0pKTsKKyAgICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgICAgIGRlZmF1bHQ6 CisgICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgfQorCisgICAgICAgIHJldHVybjsKICAg ICB9CisKKyAgICBpZiAod2luZG93ID09IG1fb3ZlcmxheSkgeworICAgICAgICBzd2l0Y2ggKG1z ZykgeworICAgICAgICAgICAgY2FzZSBXTV9MQlVUVE9ORE9XTjoKKyAgICAgICAgICAgIGNhc2Ug V01fTUJVVFRPTkRPV046CisgICAgICAgICAgICBjYXNlIFdNX1JCVVRUT05ET1dOOgorICAgICAg ICAgICAgICAgIG9uT3ZlcmxheUNsaWNrKG1zZywgd1BhcmFtLCBsUGFyYW0pOworICAgICAgICAg ICAgICAgIGJyZWFrOworICAgICAgICAgICAgY2FzZSBXTV9NT1VTRU1PVkU6CisgICAgICAgICAg ICAgICAgb25PdmVybGF5TW91c2VNb3ZlKG1zZywgd1BhcmFtLCBsUGFyYW0pOworICAgICAgICAg ICAgICAgIGJyZWFrOworICAgICAgICAgICAgZGVmYXVsdDoKKyAgICAgICAgICAgICAgICBicmVh azsKKyAgICAgICAgfQorCisgICAgICAgIHJldHVybjsKKyAgICB9CisKKyAgICBBU1NFUlRfTk9U X1JFQUNIRUQoKTsKIH0K 23777 2008-09-24 18:01:40 -0700 2008-09-24 18:03:55 -0700 one liner Bug20999v2 text/plain 1246 dev+webkit SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM2ODcz KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDgtMDkt MjQgIE1hdHQgTGlsZWsgIDx3ZWJraXRAbWF0dGxpbGVrLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBCdWcgMjA5OTk6IEluc3BlY3RvciBob3Zl ciB0byBzZWxlY3QgZG9lcyBub3Qgd29yayBwcm9wZXJseSBvbiBXaW5kb3dzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDk5OQorICAgICAgICA8cmRh cjovL3Byb2JsZW0vNjIzNjUyND4KKworICAgICAgICAqIFdlYk5vZGVIaWdobGlnaHQuY3BwOgor ICAgICAgICAoV2ViTm9kZUhpZ2hsaWdodDo6c2hvdyk6CisKIDIwMDgtMDktMjIgIEFsaWNlIExp dSAgPGFsaWNlLmxpdUBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkZWQgcmVjb3JkLW1lbW9yeS13 aW4udmNwcm9qIHRvb2wgdG8gdGhlIHNvbHV0aW9uCkluZGV4OiBXZWJOb2RlSGlnaGxpZ2h0LmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJOb2RlSGlnaGxpZ2h0LmNwcAkocmV2aXNpb24gMzY4NzMpCisr KyBXZWJOb2RlSGlnaGxpZ2h0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTAxLDcgKzEwMSw3IEBA CiAgICAgaWYgKCFtX292ZXJsYXkpIHsKICAgICAgICAgcmVnaXN0ZXJPdmVybGF5Q2xhc3MoKTsK IAotICAgICAgICBtX292ZXJsYXkgPSA6OkNyZWF0ZVdpbmRvd0V4KFdTX0VYX0xBWUVSRUQgfCBX U19FWF9UT09MV0lORE9XLCBrT3ZlcmxheVdpbmRvd0NsYXNzTmFtZSwgMCwgV1NfUE9QVVAsCisg ICAgICAgIG1fb3ZlcmxheSA9IDo6Q3JlYXRlV2luZG93RXgoV1NfRVhfTEFZRVJFRCB8IFdTX0VY X1RPT0xXSU5ET1cgfCBXU19FWF9UUkFOU1BBUkVOVCwga092ZXJsYXlXaW5kb3dDbGFzc05hbWUs IDAsIFdTX1BPUFVQLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDAsIDAs IDAsIDAsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbV9pbnNwZWN0ZWRX ZWJWaWV3V2luZG93LCAwLCAwLCAwKTsKICAgICAgICAgaWYgKCFtX292ZXJsYXkpCg==