209983 2020-04-03 13:40:34 -0700 [css-flexbox] WebKit doesn't preserve aspect ratio when computing cross size of flexed images in auto-height flex container 2020-12-01 09:33:59 -0800 1 1 1 Unclassified WebKit Layout and Rendering Safari 13 Unspecified Unspecified RESOLVED FIXED InRadar, WebExposed P2 Normal --- 219343 1 dholbert svillar achristensen bfulgham changseok clopez darin esprehn+autocc ews-watchlist glenn jensimmons jfernandez kondapallykalyan m.goleb+bugzilla oliverjash pdr rego simon.fraser svillar tonikitoo webkit-bug-importer zalan oldest_to_newest 1637513 0 dholbert 2020-04-03 13:40:34 -0700 STR: (1) Load https://bug1362789.bmoattachments.org/attachment.cgi?id=8866580 EXPECTED RESULT: Image should be a large square. (700px wide and tall) ACTUAL RESULT: Image is stretched to be rectangular, destroying aspect ratio -- image is 700px wide but only 300px tall. Chrome has the same problem, which is filed as https://bugs.chromium.org/p/chromium/issues/detail?id=721123 . EdgeHTML and Firefox give EXPECTED RESULTS. The flexbox spec section 9.4 "Cross Size Determination" says the following about how to determine cross sizes (the height in this testcase): # Determine the hypothetical cross size of each item # by performing layout with the used main size # and the available space https://drafts.csswg.org/css-flexbox-1/#cross-sizing Here, the "used main size" is the stretched size (700px), and "performing layout" (for an image with auto height) should involve stretching its height accordingly. The resulting hypothetical main size is used to determine the size of the flex line, which in turn is used as the cross size for all of the line's cross-axis-stretched items (including the image). So, the image should end up 700px tall here. Note: This is kinda similar to bug 199583 and bug 169974, but it's not a dupe of either one, I think, because: - bug 199583 is about min-size resolution & images that are forced to shrink below their normal content size [and Chrome gets that one right whereas it gets this bug here wrong] - bug 169974 is about the opposite sort of influence, where a specified cross size is intended to influence the resolved main size. 1637614 1 webkit-bug-importer 2020-04-03 21:08:48 -0700 <rdar://problem/61288094> 1652464 2 clopez 2020-05-13 18:08:51 -0700 On bug 191460 I'm trying to import the WPT css-flexbox tests into WebKit and also de-deplicate the old versions of the flexbox tests we have, in favor of the new versions from WPT. The WebKit layout test css3/flexbox/flexitem-stretch-image.html is moved to WPT as imported/w3c/web-platform-tests/css/css-flexbox/flexitem-stretch-image.html but this new version of the test causes failures due to this bug. Check https://github.com/web-platform-tests/wpt/commit/557efa4d00 (its the diff between what we had as layout test vs the new version of the WPT test) 1702033 3 jensimmons 2020-10-27 12:52:04 -0700 This is a key bug to fix so that Authors can use Flexbox as intended. At the moment, no one can use Flexbox in a DOM structure where images are flex children. 1702036 4 jensimmons 2020-10-27 12:52:58 -0700 Here's a test: https://labs.jensimmons.com/2017/02-008.html All the circles should be round. 1703825 5 svillar 2020-11-02 23:33:47 -0800 (In reply to Jen Simmons from comment #4) > Here's a test: https://labs.jensimmons.com/2017/02-008.html > > All the circles should be round. I've a patch for this issue. I'll upload it soon 1709500 6 414685 svillar 2020-11-20 08:46:51 -0800 Created attachment 414685 Patch 1709639 7 414685 darin 2020-11-20 14:01:22 -0800 Comment on attachment 414685 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414685&action=review > Source/WebCore/ChangeLog:9 > + Aspect ratio was not preserved in the cross axis because WebKit was stretching the items (as they're auto sized) whitout considering Spelling error here in the word "without". > Source/WebCore/rendering/RenderFlexibleBox.cpp:1555 > + // Aspect ratio is properly handled by RenderReplaced during layout. > + if (child.isRenderReplaced() && child.hasAspectRatio()) > + return false; This is frustratingly specific; I worry about a line of code like this that affects only a single regression test. Are there other things we should be testing? > LayoutTests/ChangeLog:9 > + * css3/flexbox/flexitem.html: Updated expectations. Aspect ratio must be preserved. Do we need to keep this test around? When our tests are duplicates of tests in Web Platform Tests, it would be good for the WebKit project to delete the older WebKit tests, unless they still have separate value. I presume in many cases the WPT test is a descendant of the test that began as a separate WebKit test. It’s better for long term maintainability to cut down the duplication when we can as we notice it. 1709901 8 414685 svillar 2020-11-23 09:02:36 -0800 Comment on attachment 414685 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=414685&action=review >> Source/WebCore/rendering/RenderFlexibleBox.cpp:1555 >> + return false; > > This is frustratingly specific; I worry about a line of code like this that affects only a single regression test. Are there other things we should be testing? It's a single regression test indeed, but it's a very common use case for using images as flex items. Anyway I've filled https://github.com/web-platform-tests/wpt/pull/26617 with a new test. I'll import it before landing this patch. >> LayoutTests/ChangeLog:9 >> + * css3/flexbox/flexitem.html: Updated expectations. Aspect ratio must be preserved. > > Do we need to keep this test around? > > When our tests are duplicates of tests in Web Platform Tests, it would be good for the WebKit project to delete the older WebKit tests, unless they still have separate value. I presume in many cases the WPT test is a descendant of the test that began as a separate WebKit test. It’s better for long term maintainability to cut down the duplication when we can as we notice it. We have to keep it indeed because it's testing some code paths that are not tested by any current WPT test. Actually EWS reported some test failures in the first version of this patch that were triggered by this specific test. That said, I think it's worth thinking about moving this test to WPT in a follow up. 1709906 9 svillar 2020-11-23 09:16:13 -0800 *** Bug 199583 has been marked as a duplicate of this bug. *** 1709975 10 svillar 2020-11-24 01:20:18 -0800 (In reply to Sergio Villar Senin from comment #8) > Comment on attachment 414685 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=414685&action=review > > >> Source/WebCore/rendering/RenderFlexibleBox.cpp:1555 > >> + return false; > > > > This is frustratingly specific; I worry about a line of code like this that affects only a single regression test. Are there other things we should be testing? > > It's a single regression test indeed, but it's a very common use case for > using images as flex items. Anyway I've filled > https://github.com/web-platform-tests/wpt/pull/26617 with a new test. I'll > import it before landing this patch. The patch landed with the new test. I'll proceed to import several aspect ratio tests from the WPT repository once the SVN lockdown is over and then I'll land this patch. 1710974 11 415112 svillar 2020-12-01 01:20:20 -0800 Created attachment 415112 Patch for landing After importing more tests we're passing 3 more tests plus the WebKit test with incorrect expectations 1710975 12 svillar 2020-12-01 01:22:16 -0800 Committed r270288: <https://trac.webkit.org/changeset/270288> 414685 2020-11-20 08:46:51 -0800 2020-11-20 14:01:22 -0800 Patch bug-209983-20201120174649.patch text/plain 5824 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMjcwMTE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjJkNzFkMjkzYjVmMTkw NjVkOGYxYmY4YzkwOTE5NjY0MDZjZTAyMC4uNTFhNmU1MTdmZjI5Yjc4MzYxNDdlNzM3MTlmYjhm ZjU2ZjQ1OWI1MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIwLTExLTIwICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtjc3MtZmxl eGJveF0gV2ViS2l0IGRvZXNuJ3QgcHJlc2VydmUgYXNwZWN0IHJhdGlvIHdoZW4gY29tcHV0aW5n IGNyb3NzIHNpemUgb2YgZmxleGVkIGltYWdlcyBpbiBhdXRvLWhlaWdodCBmbGV4IGNvbnRhaW5l cgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA5OTgz CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82MTI4ODA5ND4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBc3BlY3QgcmF0aW8gd2FzIG5vdCBwcmVzZXJ2 ZWQgaW4gdGhlIGNyb3NzIGF4aXMgYmVjYXVzZSBXZWJLaXQgd2FzIHN0cmV0Y2hpbmcgdGhlIGl0 ZW1zIChhcyB0aGV5J3JlIGF1dG8gc2l6ZWQpIHdoaXRvdXQgY29uc2lkZXJpbmcKKyAgICAgICAg dGhlIGFzcGVjdCByYXRpby4gSW5zdGVhZCBvZiBsZXR0aW5nIGZsZXhib3ggY29kZSBkZWFsIHdp dGggdGhhdCB3ZSBiYXNpY2FsbHkgZG9uJ3Qgc3RyZXRjaCB0aGVtIGFuZCBsZXQgUmVuZGVyUmVw bGFjZWQgY29tcHV0ZSB0aGUKKyAgICAgICAgY3Jvc3Mgc2l6ZSBiYXNlZCBvbiB0aGUgYXNwZWN0 IHJhdGlvIGFzIGl0IGRvZXMgd2l0aCBvdGhlciBlbGVtZW50cyB0aGF0IGFyZSBub3QgZmxleCBp dGVtcy4KKworICAgICAgICBUaGlzIGFsbG93cyB1cyB0byBwYXNzIGNzcy9jc3MtZmxleGJveC9m bGV4aXRlbS1zdHJldGNoLWltYWdlLmh0bWwgZnJvbSB0aGUgV1BUIHRlc3Qgc3VpdGUuCisKKyAg ICAgICAgKiByZW5kZXJpbmcvUmVuZGVyRmxleGlibGVCb3guY3BwOgorICAgICAgICAoV2ViQ29y ZTo6UmVuZGVyRmxleGlibGVCb3g6Om5lZWRUb1N0cmV0Y2hDaGlsZExvZ2ljYWxIZWlnaHQgY29u c3QpOiBSZXR1cm4gZmFsc2UgZm9yIHJlcGxhY2VkIGVsZW1lbnRzIHdpdGggYXNwZWN0IHJhdGlv LgorCiAyMDIwLTExLTIwICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAg ICAgICBNYWtlIHdlYnJ0Yy9jYXB0dXJlQ2FudmFzLXdlYnJ0Yy1zb2Z0d2FyZS1oMjY0LSouaHRt bCB0ZXN0cyB1c2UgY29kZWNzIGluIFdlYlByb2Nlc3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJGbGV4aWJsZUJveC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyRmxleGlibGVCb3guY3BwCmluZGV4IDNjMGY1NTRmZmMyZmU4NTk0MzM4NzA4 NDQ2OTVlNTc5NzAzNDg3YTIuLjU1NGM3YTNiOGE0MTc3NTRjOGFjY2IyMDQwMzlkNWNlMjkxM2E3 YWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGbGV4aWJsZUJv eC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZsZXhpYmxlQm94LmNw cApAQCAtMTU1MCw2ICsxNTUwLDEwIEBAIGJvb2wgUmVuZGVyRmxleGlibGVCb3g6Om5lZWRUb1N0 cmV0Y2hDaGlsZExvZ2ljYWxIZWlnaHQoY29uc3QgUmVuZGVyQm94JiBjaGlsZCkKICAgICBpZiAo aXNIb3Jpem9udGFsRmxvdygpICE9IGNoaWxkLnN0eWxlKCkuaXNIb3Jpem9udGFsV3JpdGluZ01v ZGUoKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCisgICAgLy8gQXNwZWN0IHJhdGlvIGlzIHBy b3Blcmx5IGhhbmRsZWQgYnkgUmVuZGVyUmVwbGFjZWQgZHVyaW5nIGxheW91dC4KKyAgICBpZiAo Y2hpbGQuaXNSZW5kZXJSZXBsYWNlZCgpICYmIGNoaWxkLmhhc0FzcGVjdFJhdGlvKCkpCisgICAg ICAgIHJldHVybiBmYWxzZTsKKwogICAgIHJldHVybiBjaGlsZC5zdHlsZSgpLmxvZ2ljYWxIZWln aHQoKS5pc0F1dG8oKTsKIH0KIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDYyODFlNjAwZjVlMTBhOGJjNTkzM2JhZTZlMDQ1 OGE3Njc5NjhiZDUuLmEzOTg1ZTAzMzkxMDhiYmM1MmQyNmYxMjg4MWM0NGM0YjNmYmRmNDEgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxMyBAQAorMjAyMC0xMS0yMCAgU2VyZ2lvIFZpbGxhciBTZW5pbiAgPHN2 aWxsYXJAaWdhbGlhLmNvbT4KKworICAgICAgICBbY3NzLWZsZXhib3hdIFdlYktpdCBkb2Vzbid0 IHByZXNlcnZlIGFzcGVjdCByYXRpbyB3aGVuIGNvbXB1dGluZyBjcm9zcyBzaXplIG9mIGZsZXhl ZCBpbWFnZXMgaW4gYXV0by1oZWlnaHQgZmxleCBjb250YWluZXIKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwOTk4MworICAgICAgICA8cmRhcjovL3By b2JsZW0vNjEyODgwOTQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBjc3MzL2ZsZXhib3gvZmxleGl0ZW0uaHRtbDogVXBkYXRlZCBleHBlY3RhdGlv bnMuIEFzcGVjdCByYXRpbyBtdXN0IGJlIHByZXNlcnZlZC4KKwogMjAyMC0xMS0yMCAgWW91ZW5u IEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgTWFrZSB3ZWJydGMvY2FwdHVy ZUNhbnZhcy13ZWJydGMtc29mdHdhcmUtaDI2NC0qLmh0bWwgdGVzdHMgdXNlIGNvZGVjcyBpbiBX ZWJQcm9jZXNzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9n IGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwppbmRleCBlYjcxN2IyM2FkYmEz NzY5ZGE3N2Q3OTM1MTJlMjhiNjI2YjhmMWY0Li5hMzVkYzJlZDk4N2RhODJhNGU1ZGIxNWI0YmE3 MmE5Mjk5NWE4ZWJkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdl TG9nCisrKyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx MyBAQAorMjAyMC0xMS0yMCAgU2VyZ2lvIFZpbGxhciBTZW5pbiAgPHN2aWxsYXJAaWdhbGlhLmNv bT4KKworICAgICAgICBbY3NzLWZsZXhib3hdIFdlYktpdCBkb2Vzbid0IHByZXNlcnZlIGFzcGVj dCByYXRpbyB3aGVuIGNvbXB1dGluZyBjcm9zcyBzaXplIG9mIGZsZXhlZCBpbWFnZXMgaW4gYXV0 by1oZWlnaHQgZmxleCBjb250YWluZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIwOTk4MworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjEyODgwOTQ+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3ZWIt cGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1mbGV4Ym94L2ZsZXhpdGVtLXN0cmV0Y2gtaW1hZ2UtZXhw ZWN0ZWQudHh0OiBSZXBsYWNlIEZBSUwgYnkgUEFTUyBleHBlY3RhdGlvbnMuCisKIDIwMjAtMTEt MjAgIFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CiAKICAgICAgICAg W2Nzcy1mbGV4XSBJbWFnZXMgYXMgZmxleCBpdGVtcyBzaG91bGQgdXNlIHRoZSBvdmVycmlkaW5n TG9naWNhbFdpZHRoIHdoZW4gZGVmaW5lZCB0byBjb21wdXRlIHRoZSBsb2dpY2FsIGhlaWdodApk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvY3NzMy9mbGV4Ym94L2ZsZXhpdGVtLmh0bWwgYi9MYXlv dXRUZXN0cy9jc3MzL2ZsZXhib3gvZmxleGl0ZW0uaHRtbAppbmRleCAxMDIyNWE0NTAyMDc2MDY4 MGI4Y2U4MjVlNTNlNTU4NWVhOGI1NjNjLi43ZGEzYTRmODFhMmI3ZDkwOGRiNDRmZGI3Y2E0M2Zi NDlkOTUwODBkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9jc3MzL2ZsZXhib3gvZmxleGl0ZW0u aHRtbAorKysgYi9MYXlvdXRUZXN0cy9jc3MzL2ZsZXhib3gvZmxleGl0ZW0uaHRtbApAQCAtNDcs OCArNDcsOCBAQAogCiA8ZGl2IGNsYXNzPSJmbGV4Ym94Ij4KICAgPGltZyBkYXRhLWV4cGVjdGVk LWRpc3BsYXk9ImJsb2NrIiBkYXRhLWV4cGVjdGVkLXdpZHRoPSIyMDAiIHN0eWxlPSJmbGV4OiAx IDAgYXV0bzsiIHNyYz0iLi4vaW1hZ2VzL3Jlc291cmNlcy9ibHVlLTEwMC5wbmciPgotICA8aW1n IGRhdGEtZXhwZWN0ZWQtZGlzcGxheT0iYmxvY2siIGRhdGEtZXhwZWN0ZWQtd2lkdGg9IjIwMCIg ZGF0YS1leHBlY3RlZC1oZWlnaHQ9IjEwMCIgc3R5bGU9ImZsZXg6IDIgMCAwOyIgc3JjPSJkb2Vz bm90ZXhpc3QucG5nIj4KLSAgPGltZyBkYXRhLWV4cGVjdGVkLWRpc3BsYXk9ImJsb2NrIiBkYXRh LWV4cGVjdGVkLXdpZHRoPSIyMDAiIGRhdGEtZXhwZWN0ZWQtaGVpZ2h0PSIxMDAiIHN0eWxlPSJm bGV4OiAyIDAgMDsiIHNyYz0iZG9lc25vdGV4aXN0LnBuZyIgYWx0PSJwbGFjZWhvbGRlciB0ZXh0 Ij4KKyAgPGltZyBkYXRhLWV4cGVjdGVkLWRpc3BsYXk9ImJsb2NrIiBkYXRhLWV4cGVjdGVkLXdp ZHRoPSIyMDAiIGRhdGEtZXhwZWN0ZWQtaGVpZ2h0PSIyMDAiIHN0eWxlPSJmbGV4OiAyIDAgMDsi IHNyYz0iZG9lc25vdGV4aXN0LnBuZyI+CisgIDxpbWcgZGF0YS1leHBlY3RlZC1kaXNwbGF5PSJi bG9jayIgZGF0YS1leHBlY3RlZC13aWR0aD0iMjAwIiBkYXRhLWV4cGVjdGVkLWhlaWdodD0iMjAw IiBzdHlsZT0iZmxleDogMiAwIDA7IiBzcmM9ImRvZXNub3RleGlzdC5wbmciIGFsdD0icGxhY2Vo b2xkZXIgdGV4dCI+CiA8L2Rpdj4KIAogPGRpdiBjbGFzcz0iZmxleGJveCI+CmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3MtZmxl eGJveC9mbGV4aXRlbS1zdHJldGNoLWltYWdlLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2lt cG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1mbGV4Ym94L2ZsZXhpdGVtLXN0 cmV0Y2gtaW1hZ2UtZXhwZWN0ZWQudHh0CmluZGV4IDA5MTEwMzg0YjFkNjQ2YTVhNzEyYjhkZjQ2 OWQxYmFiMjUzZDcxOGUuLmNkNzlkMGIyZmQ5NWM0NDAzNDhhMjkyNGMwOGYzMDhjNjVjNTU1MjEg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMv Y3NzL2Nzcy1mbGV4Ym94L2ZsZXhpdGVtLXN0cmV0Y2gtaW1hZ2UtZXhwZWN0ZWQudHh0CisrKyBi L0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1mbGV4 Ym94L2ZsZXhpdGVtLXN0cmV0Y2gtaW1hZ2UtZXhwZWN0ZWQudHh0CkBAIC0xLDggKzEsMyBAQAog Ci1GQUlMIC5mbGV4Ym94IDEgYXNzZXJ0X2VxdWFsczoKLTxkaXYgY2xhc3M9ImZsZXhib3giPgot ICA8aW1nIGRhdGEtZXhwZWN0ZWQtZGlzcGxheT0iYmxvY2siIGRhdGEtZXhwZWN0ZWQtd2lkdGg9 IjM0NSIgZGF0YS1leHBlY3RlZC1oZWlnaHQ9IjM0NSIgc3R5bGU9ImZsZXg6IDEgMCBhdXRvOyIg c3JjPSJzdXBwb3J0LzEwMHgxMDAtYmx1ZS5wbmciPgotICA8aW1nIGRhdGEtZXhwZWN0ZWQtZGlz cGxheT0iYmxvY2siIGRhdGEtZXhwZWN0ZWQtd2lkdGg9IjI1NSIgZGF0YS1leHBlY3RlZC1oZWln aHQ9IjM0NSIgc3R5bGU9ImZsZXg6IDEgMCBhdXRvOyIgc3JjPSJzdXBwb3J0LzEweDEwLWdyZWVu LnBuZyI+Ci08L2Rpdj4KLWhlaWdodCBleHBlY3RlZCAzNDUgYnV0IGdvdCAxMDAKK1BBU1MgLmZs ZXhib3ggMQogCg== 415112 2020-12-01 01:20:20 -0800 2020-12-01 01:20:20 -0800 Patch for landing bug-209983-20201201102018.patch text/plain 7398 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMjcwMjg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGY2NjgzMDI0N2JhNGRm MTEzNTg0YjQwZjFjMDg3NDI4NDlmMGNlMy4uNTkxZGMyZjM3ZTlmMDkwZTU0YmMzZmUzOTkzOTM5 MDBjNjRlMzc5MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIwLTEyLTAxICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtjc3MtZmxl eGJveF0gV2ViS2l0IGRvZXNuJ3QgcHJlc2VydmUgYXNwZWN0IHJhdGlvIHdoZW4gY29tcHV0aW5n IGNyb3NzIHNpemUgb2YgZmxleGVkIGltYWdlcyBpbiBhdXRvLWhlaWdodCBmbGV4IGNvbnRhaW5l cgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA5OTgz CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82MTI4ODA5ND4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBc3BlY3QgcmF0aW8gd2FzIG5vdCBwcmVzZXJ2 ZWQgaW4gdGhlIGNyb3NzIGF4aXMgYmVjYXVzZSBXZWJLaXQgd2FzIHN0cmV0Y2hpbmcgdGhlIGl0 ZW1zIChhcyB0aGV5J3JlIGF1dG8gc2l6ZWQpIHdpdGhvdXQgY29uc2lkZXJpbmcKKyAgICAgICAg dGhlIGFzcGVjdCByYXRpby4gSW5zdGVhZCBvZiBsZXR0aW5nIGZsZXhib3ggY29kZSBkZWFsIHdp dGggdGhhdCB3ZSBiYXNpY2FsbHkgZG9uJ3Qgc3RyZXRjaCB0aGVtIGFuZCBsZXQgUmVuZGVyUmVw bGFjZWQgY29tcHV0ZSB0aGUKKyAgICAgICAgY3Jvc3Mgc2l6ZSBiYXNlZCBvbiB0aGUgYXNwZWN0 IHJhdGlvIGFzIGl0IGRvZXMgd2l0aCBvdGhlciBlbGVtZW50cyB0aGF0IGFyZSBub3QgZmxleCBp dGVtcy4KKworICAgICAgICBUaGlzIGFsbG93cyB1cyB0byBwYXNzIDMgdGVzdHMgZnJvbSB0aGUg V1BUIHRlc3Qgc3VpdGUuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyRmxleGlibGVCb3gu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyRmxleGlibGVCb3g6Om5lZWRUb1N0cmV0Y2hD aGlsZExvZ2ljYWxIZWlnaHQgY29uc3QpOiBSZXR1cm4gZmFsc2UgZm9yIHJlcGxhY2VkIGVsZW1l bnRzIHdpdGggYXNwZWN0IHJhdGlvLgorCiAyMDIwLTExLTMwICBBbmRyZXMgR29uemFsZXogIDxh bmRyZXNnXzIyQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdy YXBwZXIgZG9BWEF0dHJpYnV0ZWRTdHJpbmdGb3JSYW5nZV0gbmVlZHMgdG8gcnVuIG9uIHRoZSBt YWluIHRocmVhZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJG bGV4aWJsZUJveC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmxleGlibGVC b3guY3BwCmluZGV4IDNjMGY1NTRmZmMyZmU4NTk0MzM4NzA4NDQ2OTVlNTc5NzAzNDg3YTIuLjU1 NGM3YTNiOGE0MTc3NTRjOGFjY2IyMDQwMzlkNWNlMjkxM2E3YWIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGbGV4aWJsZUJveC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckZsZXhpYmxlQm94LmNwcApAQCAtMTU1MCw2ICsxNTUwLDEw IEBAIGJvb2wgUmVuZGVyRmxleGlibGVCb3g6Om5lZWRUb1N0cmV0Y2hDaGlsZExvZ2ljYWxIZWln aHQoY29uc3QgUmVuZGVyQm94JiBjaGlsZCkKICAgICBpZiAoaXNIb3Jpem9udGFsRmxvdygpICE9 IGNoaWxkLnN0eWxlKCkuaXNIb3Jpem9udGFsV3JpdGluZ01vZGUoKSkKICAgICAgICAgcmV0dXJu IGZhbHNlOwogCisgICAgLy8gQXNwZWN0IHJhdGlvIGlzIHByb3Blcmx5IGhhbmRsZWQgYnkgUmVu ZGVyUmVwbGFjZWQgZHVyaW5nIGxheW91dC4KKyAgICBpZiAoY2hpbGQuaXNSZW5kZXJSZXBsYWNl ZCgpICYmIGNoaWxkLmhhc0FzcGVjdFJhdGlvKCkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKwog ICAgIHJldHVybiBjaGlsZC5zdHlsZSgpLmxvZ2ljYWxIZWlnaHQoKS5pc0F1dG8oKTsKIH0KIApk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CmluZGV4IGQ0ZjEzMTdmMDk4NWQ5NTlkZWM4NzZmNTg3NjFmN2I4ZWZjMDdjYmYuLjQ5ZTcxYjQ5 YThjMmZmMGI2OTBhYjZhNDVhZDBhM2NmOTcxM2MwZjkgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAor MjAyMC0xMi0wMSAgU2VyZ2lvIFZpbGxhciBTZW5pbiAgPHN2aWxsYXJAaWdhbGlhLmNvbT4KKwor ICAgICAgICBbY3NzLWZsZXhib3hdIFdlYktpdCBkb2Vzbid0IHByZXNlcnZlIGFzcGVjdCByYXRp byB3aGVuIGNvbXB1dGluZyBjcm9zcyBzaXplIG9mIGZsZXhlZCBpbWFnZXMgaW4gYXV0by1oZWln aHQgZmxleCBjb250YWluZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIwOTk4MworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjEyODgwOTQ+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBUZXN0RXhwZWN0 YXRpb25zOiBVbnNraXBwZWQgMiB0ZXN0cyB0aGF0IGFyZSB3b3JraW5nIGZpbmUgbm93CisgICAg ICAgICogY3NzMy9mbGV4Ym94L2ZsZXhpdGVtLmh0bWw6IFVwZGF0ZWQgZXhwZWN0YXRpb25zLiBB c3BlY3QgcmF0aW8gbXVzdCBiZSBwcmVzZXJ2ZWQuCisKIDIwMjAtMTItMDEgIERpZWdvIFBpbm8g R2FyY2lhICA8ZHBpbm9AaWdhbGlhLmNvbT4KIAogICAgICAgICBbV1BFXSBVbnJldmlld2VkIHRl c3QgZ2FyZGVuaW5nLiBVcGRhdGUgV1BFIGJhc2VsaW5lcyBvZiBiYXNlbGluZXMgdXBkYXRlZCBy MjM4NzMxLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZyBi L0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKaW5kZXggOWU3Mjc3ZWYzZmU4MjU5 M2I0MzQyYjVjODU2NjlhZDgxMTIyODM4MC4uMzY0Y2Q5OGVhZDAzZmI2ODlhOWRlNjMxNmEzOThh NDA4NmFhZTBhZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxv ZworKysgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMjAtMTItMDEgIFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+ CisKKyAgICAgICAgW2Nzcy1mbGV4Ym94XSBXZWJLaXQgZG9lc24ndCBwcmVzZXJ2ZSBhc3BlY3Qg cmF0aW8gd2hlbiBjb21wdXRpbmcgY3Jvc3Mgc2l6ZSBvZiBmbGV4ZWQgaW1hZ2VzIGluIGF1dG8t aGVpZ2h0IGZsZXggY29udGFpbmVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMDk5ODMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzYxMjg4MDk0Pgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd2ViLXBs YXRmb3JtLXRlc3RzL2Nzcy9jc3MtZmxleGJveC9mbGV4aXRlbS1zdHJldGNoLWltYWdlLWV4cGVj dGVkLnR4dDogUmVwbGFjZSBGQUlMIGJ5IFBBU1MgZXhwZWN0YXRpb25zLgorCiAyMDIwLTExLTMw ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAg QWxsb3cgYmxvYiBVUkxzIHdpdGggZnJhZ21lbnRzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9U ZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucwppbmRleCBhMGY5 ZWFhOTk4MWVhOGRiNzkyNGI2MDc0NTQxYjg4Y2QxOWQ1MDJkLi4zNTQ4NTg2OTJjZDY0MmZhMTY5 NWNlZWNkYjU1NTA4NGQ1MzU0ODI0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0 YXRpb25zCisrKyBiL0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTM5MTIsMTEgKzM5 MTIsOSBAQCB3ZWJraXQub3JnL2IvMjE5MzQzIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVz dHMvY3NzL2Nzcy1mbGV4Ym94L2ZsZXgtYXNwZWN0LQogd2Via2l0Lm9yZy9iLzIxOTM0MyBpbXBv cnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3MtZmxleGJveC9mbGV4LWFzcGVjdC1y YXRpby1pbWctY29sdW1uLTAxNy5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCiB3ZWJraXQub3Jn L2IvMjE5MzQzIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1mbGV4Ym94 L2ZsZXgtYXNwZWN0LXJhdGlvLWltZy1yb3ctMDA2Lmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIF0K IHdlYmtpdC5vcmcvYi8yMTkzNDMgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9jc3Mv Y3NzLWZsZXhib3gvZmxleC1hc3BlY3QtcmF0aW8taW1nLXJvdy0wMDcuaHRtbCBbIEltYWdlT25s eUZhaWx1cmUgXQotd2Via2l0Lm9yZy9iLzIxOTM0MyBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3Jt LXRlc3RzL2Nzcy9jc3MtZmxleGJveC9mbGV4LWFzcGVjdC1yYXRpby1pbWctcm93LTAwOC5odG1s IFsgSW1hZ2VPbmx5RmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMjE5MzQzIGltcG9ydGVkL3czYy93 ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1mbGV4Ym94L2ZsZXgtYXNwZWN0LXJhdGlvLWltZy1y b3ctMDA5Lmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8yMTkzNDMgaW1w b3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9jc3MvY3NzLWZsZXhib3gvZmxleC1hc3BlY3Qt cmF0aW8taW1nLXJvdy0wMTAuaHRtbCBbIEltYWdlT25seUZhaWx1cmUgXQogd2Via2l0Lm9yZy9i LzIxOTM0MyBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3MtZmxleGJveC9m bGV4LWFzcGVjdC1yYXRpby1pbWctcm93LTAxMy5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCi13 ZWJraXQub3JnL2IvMjE5MzQzIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nz cy1mbGV4Ym94L2ZsZXgtYXNwZWN0LXJhdGlvLWltZy1yb3ctMDE0Lmh0bWwgWyBJbWFnZU9ubHlG YWlsdXJlIF0KIAogd2Via2l0Lm9yZy9iLzE0NTE3NiBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3Jt LXRlc3RzL2Nzcy9jc3MtZmxleGJveC9mbGV4Ym94X2FsaWduLWl0ZW1zLXN0cmV0Y2gtMy5odG1s IFsgSW1hZ2VPbmx5RmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMjEwMDkzIGltcG9ydGVkL3czYy93 ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1mbGV4Ym94L3NlbGVjdC1lbGVtZW50LXplcm8taGVp Z2h0LTAwMS5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9jc3MzL2ZsZXhib3gvZmxleGl0ZW0uaHRtbCBiL0xheW91dFRlc3RzL2NzczMvZmxleGJveC9m bGV4aXRlbS5odG1sCmluZGV4IDEwMjI1YTQ1MDIwNzYwNjgwYjhjZTgyNWU1M2U1NTg1ZWE4YjU2 M2MuLjdkYTNhNGY4MWEyYjdkOTA4ZGI0NGZkYjdjYTQzZmI0OWQ5NTA4MGQgMTAwNjQ0Ci0tLSBh L0xheW91dFRlc3RzL2NzczMvZmxleGJveC9mbGV4aXRlbS5odG1sCisrKyBiL0xheW91dFRlc3Rz L2NzczMvZmxleGJveC9mbGV4aXRlbS5odG1sCkBAIC00Nyw4ICs0Nyw4IEBACiAKIDxkaXYgY2xh c3M9ImZsZXhib3giPgogICA8aW1nIGRhdGEtZXhwZWN0ZWQtZGlzcGxheT0iYmxvY2siIGRhdGEt ZXhwZWN0ZWQtd2lkdGg9IjIwMCIgc3R5bGU9ImZsZXg6IDEgMCBhdXRvOyIgc3JjPSIuLi9pbWFn ZXMvcmVzb3VyY2VzL2JsdWUtMTAwLnBuZyI+Ci0gIDxpbWcgZGF0YS1leHBlY3RlZC1kaXNwbGF5 PSJibG9jayIgZGF0YS1leHBlY3RlZC13aWR0aD0iMjAwIiBkYXRhLWV4cGVjdGVkLWhlaWdodD0i MTAwIiBzdHlsZT0iZmxleDogMiAwIDA7IiBzcmM9ImRvZXNub3RleGlzdC5wbmciPgotICA8aW1n IGRhdGEtZXhwZWN0ZWQtZGlzcGxheT0iYmxvY2siIGRhdGEtZXhwZWN0ZWQtd2lkdGg9IjIwMCIg ZGF0YS1leHBlY3RlZC1oZWlnaHQ9IjEwMCIgc3R5bGU9ImZsZXg6IDIgMCAwOyIgc3JjPSJkb2Vz bm90ZXhpc3QucG5nIiBhbHQ9InBsYWNlaG9sZGVyIHRleHQiPgorICA8aW1nIGRhdGEtZXhwZWN0 ZWQtZGlzcGxheT0iYmxvY2siIGRhdGEtZXhwZWN0ZWQtd2lkdGg9IjIwMCIgZGF0YS1leHBlY3Rl ZC1oZWlnaHQ9IjIwMCIgc3R5bGU9ImZsZXg6IDIgMCAwOyIgc3JjPSJkb2Vzbm90ZXhpc3QucG5n Ij4KKyAgPGltZyBkYXRhLWV4cGVjdGVkLWRpc3BsYXk9ImJsb2NrIiBkYXRhLWV4cGVjdGVkLXdp ZHRoPSIyMDAiIGRhdGEtZXhwZWN0ZWQtaGVpZ2h0PSIyMDAiIHN0eWxlPSJmbGV4OiAyIDAgMDsi IHNyYz0iZG9lc25vdGV4aXN0LnBuZyIgYWx0PSJwbGFjZWhvbGRlciB0ZXh0Ij4KIDwvZGl2Pgog CiA8ZGl2IGNsYXNzPSJmbGV4Ym94Ij4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVk L3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1mbGV4Ym94L2ZsZXhpdGVtLXN0cmV0Y2gt aW1hZ2UtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9y bS10ZXN0cy9jc3MvY3NzLWZsZXhib3gvZmxleGl0ZW0tc3RyZXRjaC1pbWFnZS1leHBlY3RlZC50 eHQKaW5kZXggMDkxMTAzODRiMWQ2NDZhNWE3MTJiOGRmNDY5ZDFiYWIyNTNkNzE4ZS4uY2Q3OWQw YjJmZDk1YzQ0MDM0OGEyOTI0YzA4ZjMwOGM2NWM1NTUyMSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9jc3MvY3NzLWZsZXhib3gvZmxleGl0 ZW0tc3RyZXRjaC1pbWFnZS1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQv dzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9jc3MvY3NzLWZsZXhib3gvZmxleGl0ZW0tc3RyZXRjaC1p bWFnZS1leHBlY3RlZC50eHQKQEAgLTEsOCArMSwzIEBACiAKLUZBSUwgLmZsZXhib3ggMSBhc3Nl cnRfZXF1YWxzOgotPGRpdiBjbGFzcz0iZmxleGJveCI+Ci0gIDxpbWcgZGF0YS1leHBlY3RlZC1k aXNwbGF5PSJibG9jayIgZGF0YS1leHBlY3RlZC13aWR0aD0iMzQ1IiBkYXRhLWV4cGVjdGVkLWhl aWdodD0iMzQ1IiBzdHlsZT0iZmxleDogMSAwIGF1dG87IiBzcmM9InN1cHBvcnQvMTAweDEwMC1i bHVlLnBuZyI+Ci0gIDxpbWcgZGF0YS1leHBlY3RlZC1kaXNwbGF5PSJibG9jayIgZGF0YS1leHBl Y3RlZC13aWR0aD0iMjU1IiBkYXRhLWV4cGVjdGVkLWhlaWdodD0iMzQ1IiBzdHlsZT0iZmxleDog MSAwIGF1dG87IiBzcmM9InN1cHBvcnQvMTB4MTAtZ3JlZW4ucG5nIj4KLTwvZGl2PgotaGVpZ2h0 IGV4cGVjdGVkIDM0NSBidXQgZ290IDEwMAorUEFTUyAuZmxleGJveCAxCiAK