209981 2020-04-03 12:33:57 -0700 [Cocoa] Update MESSAGE_CHECK macros used in WebProcessProxy::didCreateSleepDisabler/WebProcessProxy::didDestroySleepDisabler 2020-04-03 13:19:27 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 209676 1 ddkilzer ddkilzer bfulgham darin ggaren pvollan useafterfree oldest_to_newest 1637490 0 ddkilzer 2020-04-03 12:33:57 -0700 Update MESSAGE_CHECK macros used in WebProcessProxy::didCreateSleepDisabler/WebProcessProxy::didDestroySleepDisabler. <rdar://problem/61237674> 1637491 1 395402 ddkilzer 2020-04-03 12:38:03 -0700 Created attachment 395402 Patch v1 1637503 2 395402 darin 2020-04-03 13:10:50 -0700 Comment on attachment 395402 Patch v1 So decoding always checks for both invalid hash table values for identifiers? 1637504 3 395402 darin 2020-04-03 13:11:32 -0700 Comment on attachment 395402 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=395402&action=review > Source/WebKit/ChangeLog:12 > + - Remove MESSAGE_CHECK for `identifier` since decoding detects > + invalid values. Both the empty and deleted values for identifiers as hash table keys are prohibited/checked? 1637506 4 ews-feeder 2020-04-03 13:13:46 -0700 Committed r259505: <https://trac.webkit.org/changeset/259505> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395402. 1637508 5 ggaren 2020-04-03 13:19:27 -0700 > > Source/WebKit/ChangeLog:12 > > + - Remove MESSAGE_CHECK for `identifier` since decoding detects > > + invalid values. > > Both the empty and deleted values for identifiers as hash table keys are > prohibited/checked? Looks like it: template<typename Decoder> static Optional<ObjectIdentifier> decode(Decoder& decoder) { Optional<uint64_t> identifier; decoder >> identifier; if (!identifier || !isValidIdentifier(*identifier)) return WTF::nullopt; return ObjectIdentifier { *identifier }; } static bool isValidIdentifier(uint64_t identifier) { return identifier && identifier != hashTableDeletedValue(); } 395402 2020-04-03 12:38:03 -0700 2020-04-03 13:13:47 -0700 Patch v1 bug-209981-20200403123933.patch text/plain 2159 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5NDcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDc3YmY5MDMyOThjZTQ2Mjhi Mzg5Y2I0OTEwM2Q1OWUwNjU2NGY3Y2UuLmMxOTU1Nzk1Njc1ODUwYWEyYjFjZTNhZjcxYWIzM2Rj MzJlNTEyOTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMjAtMDQtMDMgIERhdmlkIEtp bHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBbQ29jb2FdIFVwZGF0ZSBNRVNT QUdFX0NIRUNLIG1hY3JvcyB1c2VkIGluIFdlYlByb2Nlc3NQcm94eTo6ZGlkQ3JlYXRlU2xlZXBE aXNhYmxlci9XZWJQcm9jZXNzUHJveHk6OmRpZERlc3Ryb3lTbGVlcERpc2FibGVyCisgICAgICAg IDxodHRwczovL3dlYmtpdC5vcmcvYi8yMDk5ODE+CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82 MTIzNzY3ND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFVJUHJvY2Vzcy9XZWJQcm9jZXNzUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQ cm9jZXNzUHJveHk6OmRpZENyZWF0ZVNsZWVwRGlzYWJsZXIpOgorICAgICAgICAtIFJlbW92ZSBN RVNTQUdFX0NIRUNLIGZvciBgaWRlbnRpZmllcmAgc2luY2UgZGVjb2RpbmcgZGV0ZWN0cworICAg ICAgICAgIGludmFsaWQgdmFsdWVzLgorICAgICAgICAtIEFkZCBNRVNTQUdFX0NIRUNLIGZvciBg cmVhc29uYCBzaW5jZSBhIE5VTEwgc3RyaW5nIHdvdWxkIGNhdXNlCisgICAgICAgICAgQ0ZTdHJp bmdDcmVhdGVXaXRoQ1N0cmluZygpIHRvIGNyYXNoIGxhdGVyLgorICAgICAgICAoV2ViS2l0OjpX ZWJQcm9jZXNzUHJveHk6OmRpZERlc3Ryb3lTbGVlcERpc2FibGVyKToKKyAgICAgICAgLSBSZW1v dmUgTUVTU0FHRV9DSEVDSyBmb3IgYGlkZW50aWZpZXJgIHNpbmNlIGRlY29kaW5nIGRldGVjdHMK KyAgICAgICAgICBpbnZhbGlkIHZhbHVlcy4KKwogMjAyMC0wNC0wMyAgQnJlbnQgRnVsZ2hhbSAg PGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgdW5uZWVkZWQgc2FuZGJveCBh Y2Nlc3MgdG8gc29tZSBmaWxlIHBhdGhzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9XZWJQcm9jZXNzUHJveHkuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJv Y2Vzc1Byb3h5LmNwcAppbmRleCA4ZDI4Mzg1ZDU4NTUzMGU4NTAyYjRmZmFjMzBhZDU2NTQ3YzQz YzY2Li43ZWNmNmEyMGIwOGYwY2U0OGQxMzA2NDJkMzc1NDJjN2QxNmQxM2ZiIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzUHJveHkuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlByb2Nlc3NQcm94eS5jcHAKQEAgLTE3ODIsMTQgKzE3ODIs MTMgQEAgdm9pZCBXZWJQcm9jZXNzUHJveHk6OmRpZENyZWF0ZUNvbnRleHRJbkdQVVByb2Nlc3NG b3JWaXNpYmlsaXR5UHJvcGFnYXRpb24oTGF5ZXIKIAogdm9pZCBXZWJQcm9jZXNzUHJveHk6OmRp ZENyZWF0ZVNsZWVwRGlzYWJsZXIoU2xlZXBEaXNhYmxlcklkZW50aWZpZXIgaWRlbnRpZmllciwg Y29uc3QgU3RyaW5nJiByZWFzb24sIGJvb2wgZGlzcGxheSkKIHsKLSAgICBNRVNTQUdFX0NIRUNL KGlkZW50aWZpZXIpOworICAgIE1FU1NBR0VfQ0hFQ0soIXJlYXNvbi5pc051bGwoKSk7CiAgICAg YXV0byBzbGVlcERpc2FibGVyID0gbWFrZVVuaXF1ZTxXZWJDb3JlOjpTbGVlcERpc2FibGVyPihy ZWFzb24udXRmOCgpLmRhdGEoKSwgZGlzcGxheSA/IFBBTDo6U2xlZXBEaXNhYmxlcjo6VHlwZTo6 RGlzcGxheSA6IFBBTDo6U2xlZXBEaXNhYmxlcjo6VHlwZTo6U3lzdGVtKTsKICAgICBtX3NsZWVw RGlzYWJsZXJzLmFkZChpZGVudGlmaWVyLCBXVEZNb3ZlKHNsZWVwRGlzYWJsZXIpKTsKIH0KIAog dm9pZCBXZWJQcm9jZXNzUHJveHk6OmRpZERlc3Ryb3lTbGVlcERpc2FibGVyKFNsZWVwRGlzYWJs ZXJJZGVudGlmaWVyIGlkZW50aWZpZXIpCiB7Ci0gICAgTUVTU0FHRV9DSEVDSyhpZGVudGlmaWVy KTsKICAgICBtX3NsZWVwRGlzYWJsZXJzLnJlbW92ZShpZGVudGlmaWVyKTsKIH0KIAo=