209976 2020-04-03 10:39:40 -0700 ASSERTION FAILED: objectStoreInfo in SQLiteIDBBackingStore::getRecord 2026-04-04 13:31:18 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=311493 InRadar P2 Normal --- 1 sihui_liu sihui_liu alecflett beidson ews-watchlist ggaren jsbell webkit-bug-importer oldest_to_newest 1637437 0 sihui_liu 2020-04-03 10:39:40 -0700 Normally this assertion will not be hit, but we see cases where objectStoreInfo is null as in the radar. So I tried to modify the code a bit by returning error at specific places, and successfully got the assertion failure. Therefore, theoretically it's possible that SQLiteIDBBackingStore does not have requested ObjectStoreInfo in SQLiteIDBBackingStore::getRecord. Then we need to change this assertion to an error and make early return. 1637438 1 sihui_liu 2020-04-03 10:40:04 -0700 <rdar://problem/55005363> 1637440 2 395395 sihui_liu 2020-04-03 10:45:39 -0700 Created attachment 395395 Patch 1637475 3 395395 ggaren 2020-04-03 11:56:19 -0700 Comment on attachment 395395 Patch r=me 1637553 4 ews-feeder 2020-04-03 15:56:03 -0700 Committed r259519: <https://trac.webkit.org/changeset/259519> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395395. 395395 2020-04-03 10:45:39 -0700 2020-04-03 15:56:04 -0700 Patch bug-209976-20200403104539.patch text/plain 2463 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5NDYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTVmMDEyZGJhOTFkOTZm NTlmNDVlNDdjMjNiZDlkOGRkNjA1OWRjNy4uOTdmMzM0YmE5MWRjZTgwZjJkYWE5YjdmNDlmNzU1 YTc5ZDNmNzYzNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTA0LTAzICBTaWh1 aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUuY29tPgorCisgICAgICAgIEFTU0VSVElPTiBGQUlMRUQ6 IG9iamVjdFN0b3JlSW5mbyBpbiBTUUxpdGVJREJCYWNraW5nU3RvcmU6OmdldFJlY29yZAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA5OTc2CisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS81NTAwNTM2Mz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBSZXR1cm4gZXJyb3IgaWYgb2JqZWN0U3RvcmVJbmZvIGlz IG51bGwgaW4gU1FMaXRlSURCQmFja2luZ1N0b3JlOjpnZXRSZWNvcmQsIGJlY2F1c2UgdGhlcmUg aXMgYSBwb3NzaWJpbGl0eSAKKyAgICAgICAgU1FMaXRlSURCQmFja2luZ1N0b3JlIGRvZXMgbm90 IGhhdmUgcmVxdWVzdGVkIG9iamVjdFN0b3JlSW5mby4KKworICAgICAgICAqIE1vZHVsZXMvaW5k ZXhlZGRiL3NlcnZlci9TUUxpdGVJREJCYWNraW5nU3RvcmUuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6SURCU2VydmVyOjpTUUxpdGVJREJCYWNraW5nU3RvcmU6OmdldFJlY29yZCk6CisKIDIwMjAt MDQtMDMgIFNpaHVpIExpdSAgPHNpaHVpX2xpdUBhcHBsZS5jb20+CiAKICAgICAgICAgQVNTRVJU SU9OIEZBSUxFRDogbV9kZWxlZ2F0ZSBpbiBJREJDb25uZWN0aW9uVG9DbGllbnQ6OmlkZW50aWZp ZXIoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvc2VydmVy L1NRTGl0ZUlEQkJhY2tpbmdTdG9yZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4 ZWRkYi9zZXJ2ZXIvU1FMaXRlSURCQmFja2luZ1N0b3JlLmNwcAppbmRleCA0NjEzYTgwYmI1ODEx ZjhkOWEwMjViNTZjYzZhMmU2NGIxMjQwOWJhLi41NjNkZWE4ODBmYTg3OGY1NDIyOTgwZGM3YWZi M2VhNDg5OTg1MjI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRk Yi9zZXJ2ZXIvU1FMaXRlSURCQmFja2luZ1N0b3JlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL2luZGV4ZWRkYi9zZXJ2ZXIvU1FMaXRlSURCQmFja2luZ1N0b3JlLmNwcApAQCAtMjA2 MCw2ICsyMDYwLDEwIEBAIElEQkVycm9yIFNRTGl0ZUlEQkJhY2tpbmdTdG9yZTo6Z2V0UmVjb3Jk KGNvbnN0IElEQlJlc291cmNlSWRlbnRpZmllciYgdHJhbnNhY3RpCiAgICAgaWYgKCF0cmFuc2Fj dGlvbiB8fCAhdHJhbnNhY3Rpb24tPmluUHJvZ3Jlc3MoKSkKICAgICAgICAgcmV0dXJuIElEQkVy cm9yIHsgVW5rbm93bkVycm9yLCAiQXR0ZW1wdCB0byBnZXQgYSByZWNvcmQgZnJvbSBkYXRhYmFz ZSB3aXRob3V0IGFuIGluLXByb2dyZXNzIHRyYW5zYWN0aW9uIl9zIH07CiAKKyAgICBhdXRvKiBv YmplY3RTdG9yZUluZm8gPSBpbmZvRm9yT2JqZWN0U3RvcmUob2JqZWN0U3RvcmVJRCk7CisgICAg aWYgKCFvYmplY3RTdG9yZUluZm8pCisgICAgICAgIHJldHVybiBJREJFcnJvciB7IEludmFsaWRT dGF0ZUVycm9yLCAiT2JqZWN0IHN0b3JlIGNhbm5vdCBiZSBmb3VuZCBpbiB0aGUgYmFja2luZyBz dG9yZSJfcyB9OworCiAgICAgYXV0byBrZXkgPSBrZXlSYW5nZS5sb3dlcktleTsKICAgICBpZiAo a2V5LmlzTnVsbCgpKQogICAgICAgICBrZXkgPSBJREJLZXlEYXRhOjptaW5pbXVtKCk7CkBAIC0y MTc4LDkgKzIxODIsNyBAQCBJREJFcnJvciBTUUxpdGVJREJCYWNraW5nU3RvcmU6OmdldFJlY29y ZChjb25zdCBJREJSZXNvdXJjZUlkZW50aWZpZXImIHRyYW5zYWN0aQogICAgIGlmICghZXJyb3Iu aXNOdWxsKCkpCiAgICAgICAgIHJldHVybiBlcnJvcjsKIAotICAgIGF1dG8qIG9iamVjdFN0b3Jl SW5mbyA9IGluZm9Gb3JPYmplY3RTdG9yZShvYmplY3RTdG9yZUlEKTsKLSAgICBBU1NFUlQob2Jq ZWN0U3RvcmVJbmZvKTsKLSAgICByZXN1bHRWYWx1ZSA9IHsga2V5RGF0YSwgeyB2YWx1ZVJlc3Vs dEJ1ZmZlciwgV1RGTW92ZShibG9iVVJMcyksIFdURk1vdmUoYmxvYkZpbGVQYXRocykgfSwgb2Jq ZWN0U3RvcmVJbmZvLT5rZXlQYXRoKCl9OworICAgIHJlc3VsdFZhbHVlID0geyBrZXlEYXRhLCB7 IHZhbHVlUmVzdWx0QnVmZmVyLCBXVEZNb3ZlKGJsb2JVUkxzKSwgV1RGTW92ZShibG9iRmlsZVBh dGhzKSB9LCBvYmplY3RTdG9yZUluZm8tPmtleVBhdGgoKSB9OwogICAgIHJldHVybiBJREJFcnJv ciB7IH07CiB9CiAK