209956 2020-04-03 01:04:06 -0700 [Flatpak SDK] Call setup_icecc only if use_icecream is defined 2020-04-03 02:14:16 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dpino dpino pnormand webkit-bug-importer oldest_to_newest 1637267 0 dpino 2020-04-03 01:04:06 -0700 [Flatpak SDK] Call setup_icecc only if use_icecream is defined 1637268 1 395356 dpino 2020-04-03 01:04:25 -0700 Created attachment 395356 Patch 1637269 2 dpino 2020-04-03 01:08:57 -0700 I noticed on a host without icecc installed, calls to "Tools/Script/update-webkitwpe-libs" end up on the following error: ``` $ Tools/Scripts/update-webkitwpe-libs Updating Flatpak Release environment error: Unable to allocate instance id Command '['flatpak', 'build', '--die-with-parent', '--talk-name=org.a11y.Bus', '--talk-name=org.gtk.vfs', '--talk-name=org.gtk.vfs.*', '--bind-mount=/run/shm=/dev/shm', '--bind-mount=/run/host//tmp=/tmp', '--bind-mount=/run/systemd/journal=/run/systemd/journal', '--bind-mount=/app/webkit=/home/dpino/workspace/webkit-wpe', '--bind-mount=/app/webkit/WebKitBuild/Release=/home/dpino/workspace/webkit-wpe/WebKitBuild/GTK/Release', '--device=all', '--device=dri', '--filesystem=host', '--share=ipc', '--share=network', '--socket=pulseaudio', '--socket=system-bus', '--socket=wayland', '--socket=x11', '--system-talk-name=org.a11y.Bus', '--system-talk-name=org.freedesktop.GeoClue2', '--talk-name=org.a11y.Bus', '--talk-name=org.freedesktop.Flatpak', '--env=LANG=en_US.UTF-8', '--env=TZ=PST8PDT', '--env=WAYLAND_DISPLAY=wayland-0', '--env=DISPLAY=:0', '--env=WEBKIT_TOP_LEVEL=/app/', '--env=TEST_RUNNER_INJECTED_BUNDLE_FILENAME=/app/webkit/WebKitBuild/Release/lib/libTestRunnerInjectedBundle.so', '/home/dpino/workspace/webkit-wpe/WebKitBuild/UserFlatpak', 'icecc', '--build-native']' returned non-zero exit status 1 ``` I think function setup_icecc(), which ends up running icecc, should only be called if flag use_icecream was set. 1637286 3 ews-feeder 2020-04-03 02:13:37 -0700 Committed r259450: <https://trac.webkit.org/changeset/259450> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395356. 1637287 4 webkit-bug-importer 2020-04-03 02:14:16 -0700 <rdar://problem/61250913> 395356 2020-04-03 01:04:25 -0700 2020-04-03 02:13:37 -0700 Patch bug-209956-20200403100424.patch text/plain 1294 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5NDQ4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzQwYWEwNzg3OTRjYmExYzdkM2E1MmNjOGJlNjFmNTdk OWM3MzQ5ZC4uYmFkZmFiMDUxM2U0MzFjMjM2OGIzMmRkOWFiOWE3NGJmOGIyMTc0MCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDIwLTA0LTAzICBEaWVnbyBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+CisK KyAgICAgICAgW0ZsYXRwYWsgU0RLXSBDYWxsIHNldHVwX2ljZWNjIG9ubHkgaWYgdXNlX2ljZWNy ZWFtIGlzIGRlZmluZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIwOTk1NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogZmxhdHBhay9mbGF0cGFrdXRpbHMucHk6CisgICAgICAgIChXZWJraXRGbGF0cGFr LnNldHVwX2Rldl9lbnYpOgorCiAyMDIwLTA0LTAzICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFw cGxlLmNvbT4KIAogICAgICAgICBbV2luZG93c10gSWdub3JlIHJlbmRlciB0cmVlIGR1bXAgYmFz ZWQgcmVzdWx0cyBvbiBXaW5kb3dzCmRpZmYgLS1naXQgYS9Ub29scy9mbGF0cGFrL2ZsYXRwYWt1 dGlscy5weSBiL1Rvb2xzL2ZsYXRwYWsvZmxhdHBha3V0aWxzLnB5CmluZGV4IDM5ZWNmOGU4ZTRi YmQ4NGRkMTBlNWFjYmEzMGVhZmVhNjkyOGZiYzcuLmU1MDdmNWUxYjlkZGRkMzE0MWQ3NTY5YjUy MTEzNDkwMGQ0YmI2OWEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL2ZsYXRwYWsvZmxhdHBha3V0aWxzLnB5 CisrKyBiL1Rvb2xzL2ZsYXRwYWsvZmxhdHBha3V0aWxzLnB5CkBAIC03OTMsNyArNzkzLDggQEAg Y2xhc3MgV2Via2l0RmxhdHBhazoKICAgICBkZWYgc2V0dXBfZGV2X2VudihzZWxmKToKICAgICAg ICAgaWYgbm90IG9zLnBhdGguZXhpc3RzKG9zLnBhdGguam9pbihzZWxmLmZsYXRwYWtfYnVpbGRf cGF0aCwgInJ1bnRpbWUiLCAib3JnLndlYmtpdC5TZGsiKSkgb3Igc2VsZi51cGRhdGUgb3Igc2Vs Zi5idWlsZF9hbGw6CiAgICAgICAgICAgICBzZWxmLmluc3RhbGxfYWxsKCkKLSAgICAgICAgICAg IHNlbGYuc2V0dXBfaWNlY2MoKQorICAgICAgICAgICAgaWYgc2VsZi51c2VfaWNlY3JlYW06Cisg ICAgICAgICAgICAgICAgc2VsZi5zZXR1cF9pY2VjYygpCiAgICAgICAgICAgICBzZWxmLnNhdmVf Y29uZmlnKCkKIAogICAgICAgICBpZiBub3Qgc2VsZi51cGRhdGU6Cg==