209954 2020-04-03 00:51:18 -0700 [Flatpak SDK] Create platform/Release directory only when build-webkit is called 2020-04-03 04:58:51 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 209960 1 dpino dpino pnormand webkit-bug-importer oldest_to_newest 1637263 0 dpino 2020-04-03 00:51:18 -0700 [WPE] Pass --wpe argument to update-webkit-flatpak 1637264 1 395355 dpino 2020-04-03 00:51:33 -0700 Created attachment 395355 Patch 1637265 2 dpino 2020-04-03 00:57:57 -0700 On calling `Tools/Scripts/update-webkitwpe-libs`, script `update-webkit-flatpak` is called without platform name (--wpe), taking GTK as default. As a result, flatpak argument '--bind-mount=/app/webkit/WebKitBuild/Release' points to '../WebKitBuild/GTK/Release', when it should point to '../WebKitBuild/WPE/Release'. Another consequence is that 'WebKitBuild/GTK' folder is created. 1637270 3 pnormand 2020-04-03 01:09:05 -0700 This shouldn't be necessary, because the same SDK is used for both GTK and WPE. 1637277 4 pnormand 2020-04-03 01:36:27 -0700 (In reply to Diego Pino from comment #2) > On calling `Tools/Scripts/update-webkitwpe-libs`, script > `update-webkit-flatpak` is called without platform name (--wpe), taking GTK > as default. As a result, flatpak argument > '--bind-mount=/app/webkit/WebKitBuild/Release' points to > '../WebKitBuild/GTK/Release', when it should point to > '../WebKitBuild/WPE/Release'. Another consequence is that 'WebKitBuild/GTK' > folder is created. Regarding this, perhaps we can simply avoid to mkdir the build directory unless we're being called by build-webkit. 1637291 5 395360 dpino 2020-04-03 02:35:49 -0700 Created attachment 395360 Patch 1637302 6 ews-feeder 2020-04-03 04:10:43 -0700 Committed r259453: <https://trac.webkit.org/changeset/259453> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395360. 1637303 7 webkit-bug-importer 2020-04-03 04:11:16 -0700 <rdar://problem/61253950> 395355 2020-04-03 00:51:33 -0700 2020-04-03 02:35:46 -0700 Patch bug-209954-20200403095132.patch text/plain 1253 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5NDQ4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzQwYWEwNzg3OTRjYmExYzdkM2E1MmNjOGJlNjFmNTdk OWM3MzQ5ZC4uMTA5MTUwMjhlNTRmMmMzZjJkZDkzZDc1Mzg1OTI3YTM4ZjE1ZDc2NSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDIwLTA0LTAzICBEaWVnbyBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+CisK KyAgICAgICAgW1dQRV0gUGFzcyAtLXdwZSBhcmd1bWVudCB0byB1cGRhdGUtd2Via2l0LWZsYXRw YWsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwOTk1 NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2Ny aXB0cy91cGRhdGUtd2Via2l0d3BlLWxpYnM6CisKIDIwMjAtMDQtMDMgIEFudHRpIEtvaXZpc3Rv ICA8YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAgIFtXaW5kb3dzXSBJZ25vcmUgcmVuZGVyIHRy ZWUgZHVtcCBiYXNlZCByZXN1bHRzIG9uIFdpbmRvd3MKZGlmZiAtLWdpdCBhL1Rvb2xzL1Njcmlw dHMvdXBkYXRlLXdlYmtpdHdwZS1saWJzIGIvVG9vbHMvU2NyaXB0cy91cGRhdGUtd2Via2l0d3Bl LWxpYnMKaW5kZXggY2RjNGM3ZGI4YzY1ZWE3MzIzZDY5MjY4MTk4YTJmNjhiZDUxMzAxNC4uMDMx OWMzMWYxOWI3YTA3YTM5NDM3MTczMDIyZjBlOWQxNDIxODk5YiAxMDA3NTUKLS0tIGEvVG9vbHMv U2NyaXB0cy91cGRhdGUtd2Via2l0d3BlLWxpYnMKKysrIGIvVG9vbHMvU2NyaXB0cy91cGRhdGUt d2Via2l0d3BlLWxpYnMKQEAgLTI1LDUgKzI1LDUgQEAgbXkgJHNjcmlwdHNEaXIgPSByZWxhdGl2 ZVNjcmlwdHNEaXIoKTsKIGlmIChkZWZpbmVkICRFTlZ7J1dFQktJVF9KSEJVSUxEJ30gYW5kICRF TlZ7J1dFQktJVF9KSEJVSUxEJ30pIHsKICAgICBzeXN0ZW0oInBlcmwiLCAiJHNjcmlwdHNEaXIv dXBkYXRlLXdlYmtpdC1saWJzLWpoYnVpbGQiLCAiLS13cGUiLCBAQVJHVikgPT0gMCBvciBkaWUg JCE7CiB9IGVsc2UgewotICAgIHN5c3RlbSgiJHNjcmlwdHNEaXIvdXBkYXRlLXdlYmtpdC1mbGF0 cGFrIiwgQEFSR1YpID09IDAgb3IgZGllICQhOworICAgIHN5c3RlbSgiJHNjcmlwdHNEaXIvdXBk YXRlLXdlYmtpdC1mbGF0cGFrIiwgIi0td3BlIiwgQEFSR1YpID09IDAgb3IgZGllICQhOwogfQo= 395360 2020-04-03 02:35:49 -0700 2020-04-03 04:10:43 -0700 Patch bug-209954-20200403113548.patch text/plain 2839 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5NDQ4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzQwYWEwNzg3OTRjYmExYzdkM2E1MmNjOGJlNjFmNTdk OWM3MzQ5ZC4uYTg3ZWY4NDY4Y2RiNmY0MzgyNDhiMGQxZmM3ZTc5NmVhNTk5YTNkZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDIwLTA0LTAzICBEaWVnbyBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+CisK KyAgICAgICAgW0ZsYXRwYWsgU0RLXSBDcmVhdGUgcGxhdGZvcm0vUmVsZWFzZSBkaXJlY3Rvcnkg b25seSB3aGVuIGJ1aWxkLXdlYmtpdCBpcyBjYWxsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwOTk1NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmxhdHBhay9mbGF0cGFrdXRpbHMucHk6CisgICAg ICAgIChXZWJraXRGbGF0cGFrLmNsZWFuX2FyZ3MpOiBSZW1vdmUgY3JlYXRpb24gb2Ygc2VsZi5i dWlsZF9wYXRoLgorICAgICAgICAoV2Via2l0RmxhdHBhay5ydW5faW5fc2FuZGJveCk6IENyZWF0 ZSBzZWxmLmJ1aWxkX3BhdGggaWYgY29tbWFuZCBpcworICAgICAgICBidWlsZC13ZWJraXQuCisK IDIwMjAtMDQtMDMgIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAg IFtXaW5kb3dzXSBJZ25vcmUgcmVuZGVyIHRyZWUgZHVtcCBiYXNlZCByZXN1bHRzIG9uIFdpbmRv d3MKZGlmZiAtLWdpdCBhL1Rvb2xzL2ZsYXRwYWsvZmxhdHBha3V0aWxzLnB5IGIvVG9vbHMvZmxh dHBhay9mbGF0cGFrdXRpbHMucHkKaW5kZXggMzllY2Y4ZThlNGJiZDg0ZGQxMGU1YWNiYTMwZWFm ZWE2OTI4ZmJjNy4uNTkzZTlmNTEyYjNjNmY3NTA0NzE0YzIzOTdlYThjYjdlNTBkY2IwZiAxMDA2 NDQKLS0tIGEvVG9vbHMvZmxhdHBhay9mbGF0cGFrdXRpbHMucHkKKysrIGIvVG9vbHMvZmxhdHBh ay9mbGF0cGFrdXRpbHMucHkKQEAgLTUxNiwxMSArNTE2LDYgQEAgY2xhc3MgV2Via2l0RmxhdHBh azoKIAogICAgICAgICBidWlsZF9yb290ID0gb3MucGF0aC5qb2luKHNlbGYuc291cmNlX3Jvb3Qs ICdXZWJLaXRCdWlsZCcpCiAgICAgICAgIHNlbGYuYnVpbGRfcGF0aCA9IG9zLnBhdGguam9pbihi dWlsZF9yb290LCBzZWxmLnBsYXRmb3JtLCBzZWxmLmJ1aWxkX3R5cGUpCi0gICAgICAgIHRyeToK LSAgICAgICAgICAgIG9zLm1ha2VkaXJzKHNlbGYuYnVpbGRfcGF0aCkKLSAgICAgICAgZXhjZXB0 IE9TRXJyb3IgYXMgZToKLSAgICAgICAgICAgIGlmIGUuZXJybm8gIT0gZXJybm8uRUVYSVNUOgot ICAgICAgICAgICAgICAgIHJhaXNlIGUKICAgICAgICAgc2VsZi5jb25maWdfZmlsZSA9IG9zLnBh dGguam9pbihzZWxmLmZsYXRwYWtfYnVpbGRfcGF0aCwgJ3dlYmtpdF9mbGF0cGFrX2NvbmZpZy5q c29uJykKIAogICAgICAgICBDb25zb2xlLnF1aWV0ID0gc2VsZi5xdWlldApAQCAtNjI2LDEwICs2 MjEsMTggQEAgY2xhc3MgV2Via2l0RmxhdHBhazoKICAgICAgICAgICAgICAgICAgICAgICAgICAg ICMgd2hpdGUtbGlzdCBpdCBpbiAvcnVuLCBob3BpbmcgdGhpcyBpcyB0aGUgcmlnaHQKICAgICAg ICAgICAgICAgICAgICAgICAgICAgICMgcGF0aC4KICAgICAgICAgICAgICAgICAgICAgICAgICAg ICItLWJpbmQtbW91bnQ9L3J1bi9zeXN0ZW1kL2pvdXJuYWw9L3J1bi9zeXN0ZW1kL2pvdXJuYWwi LAotICAgICAgICAgICAgICAgICAgICAgICAgICAgIi0tYmluZC1tb3VudD0lcz0lcyIgJSAoc2Vs Zi5zYW5kYm94X3NvdXJjZV9yb290LCBzZWxmLnNvdXJjZV9yb290KSwKLSAgICAgICAgICAgICAg ICAgICAgICAgICAgICMgV2UgbW91bnQgV2ViS2l0QnVpbGQvUE9SVE5BTUUvQnVpbGRUeXBlIHRv IC9hcHAvd2Via2l0L1dlYktpdEJ1aWxkL0J1aWxkVHlwZQotICAgICAgICAgICAgICAgICAgICAg ICAgICAgIyBzbyB3ZSBjYW4gYnVpbGQgV1BFIGFuZCBHVEsgaW4gYSBzYW1lIHNvdXJjZSB0cmVl LgotICAgICAgICAgICAgICAgICAgICAgICAgICAgIi0tYmluZC1tb3VudD0lcz0lcyIgJSAoc2Fu ZGJveF9idWlsZF9wYXRoLCBzZWxmLmJ1aWxkX3BhdGgpXQorICAgICAgICAgICAgICAgICAgICAg ICAgICAgIi0tYmluZC1tb3VudD0lcz0lcyIgJSAoc2VsZi5zYW5kYm94X3NvdXJjZV9yb290LCBz ZWxmLnNvdXJjZV9yb290KV0KKworICAgICAgICBpZiBhcmdzIGFuZCBhcmdzWzBdLmVuZHN3aXRo KCJidWlsZC13ZWJraXQiKToKKyAgICAgICAgICAgICMgRW5zdXJlIHNlbGYuYnVpbGRfcGF0aCBl eGlzdHMuCisgICAgICAgICAgICB0cnk6CisgICAgICAgICAgICAgICAgb3MubWFrZWRpcnMoc2Vs Zi5idWlsZF9wYXRoKQorICAgICAgICAgICAgZXhjZXB0IE9TRXJyb3IgYXMgZToKKyAgICAgICAg ICAgICAgICBpZiBlLmVycm5vICE9IGVycm5vLkVFWElTVDoKKyAgICAgICAgICAgICAgICAgICAg cmFpc2UgZQorICAgICAgICAgICAgIyBXZSBtb3VudCBXZWJLaXRCdWlsZC9QT1JUTkFNRS9CdWls ZFR5cGUgdG8gL2FwcC93ZWJraXQvV2ViS2l0QnVpbGQvQnVpbGRUeXBlCisgICAgICAgICAgICAj IHNvIHdlIGNhbiBidWlsZCBXUEUgYW5kIEdUSyBpbiBhIHNhbWUgc291cmNlIHRyZWUuCisgICAg ICAgICAgICBmbGF0cGFrX2NvbW1hbmQuYXBwZW5kKCItLWJpbmQtbW91bnQ9JXM9JXMiICUgKHNh bmRib3hfYnVpbGRfcGF0aCwgc2VsZi5idWlsZF9wYXRoKSkKIAogICAgICAgICBmb3J3YXJkZWQg PSB7CiAgICAgICAgICAgICAiV0VCS0lUX1RPUF9MRVZFTCI6ICIvYXBwLyIsCg==