209951 2020-04-02 21:14:46 -0700 Rename widgetDidHandleWheelEvent back to passWheelEventToWidget and make some functions private 2020-04-02 22:47:16 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser simon.fraser webkit-bug-importer zalan oldest_to_newest 1637229 0 simon.fraser 2020-04-02 21:14:46 -0700 Rename widgetDidHandleWheelEvent back to passWheelEventToWidget and makek some functions private 1637230 1 395344 simon.fraser 2020-04-02 21:16:28 -0700 Created attachment 395344 Patch 1637244 2 ews-feeder 2020-04-02 22:46:21 -0700 Committed r259443: <https://trac.webkit.org/changeset/259443> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395344. 1637245 3 webkit-bug-importer 2020-04-02 22:47:16 -0700 <rdar://problem/61244711> 395344 2020-04-02 21:16:28 -0700 2020-04-02 22:46:22 -0700 Patch bug-209951-20200402211628.patch text/plain 6256 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5NDE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTA0YmRiYjQ5MTk3ODgw YTY0MzIzYWViMzk4ZTI5YWNhOGQxNmI5Ny4uNmEwNDY1NDEyMmNiNGMzMmI2MzMwZGNmNjdjMzc3 NGJkMDU1NGI2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDIwLTA0LTAyICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJlbmFtZSB3aWRn ZXREaWRIYW5kbGVXaGVlbEV2ZW50IGJhY2sgdG8gcGFzc1doZWVsRXZlbnRUb1dpZGdldCBhbmQg bWFrZSBzb21lIGZ1bmN0aW9ucyBwcml2YXRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMDk5NTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBSZXZlcnQgdGhlIHJlbmFtZSBmcm9tIHIxOTkzMzEsIGFuZCBt YWtlIHByaXZhdGUgd2hlZWwtZXZlbnQgcmVsYXRlZCBmdW5jdGlvbnMgdGhhdAorICAgICAgICBh cmUgaW50ZXJuYWwgdG8gRXZlbnRIYW5kbGVyLgorCisgICAgICAgICogcGFnZS9FdmVudEhhbmRs ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RXZlbnRIYW5kbGVyOjpoYW5kbGVXaGVlbEV2ZW50 KToKKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50SGFuZGxlcjo6cGFzc1doZWVsRXZlbnRUb1dpZGdl dCk6CisgICAgICAgIChXZWJDb3JlOjpFdmVudEhhbmRsZXI6OndpZGdldERpZEhhbmRsZVdoZWVs RXZlbnQpOiBEZWxldGVkLgorICAgICAgICAqIHBhZ2UvRXZlbnRIYW5kbGVyLmg6CisgICAgICAg ICogcGFnZS9pb3MvRXZlbnRIYW5kbGVySU9TLm1tOgorICAgICAgICAoV2ViQ29yZTo6RXZlbnRI YW5kbGVyOjpwYXNzV2hlZWxFdmVudFRvV2lkZ2V0KToKKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50 SGFuZGxlcjo6d2lkZ2V0RGlkSGFuZGxlV2hlZWxFdmVudCk6IERlbGV0ZWQuCisgICAgICAgICog cGFnZS9tYWMvRXZlbnRIYW5kbGVyTWFjLm1tOgorICAgICAgICAoV2ViQ29yZTo6RXZlbnRIYW5k bGVyOjpwYXNzV2hlZWxFdmVudFRvV2lkZ2V0KToKKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50SGFu ZGxlcjo6d2lkZ2V0RGlkSGFuZGxlV2hlZWxFdmVudCk6IERlbGV0ZWQuCisKIDIwMjAtMDQtMDEg IFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgU2Nyb2xs IGxhdGNoaW5nIHN0YXRlIGlzIG5vdCBhIHN0YWNrCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxl ci5jcHAKaW5kZXggZTc0MmQ2ZTEyMDgwNzY1OTBmMDgwMzkxOTc4NTc2NGIwYzc4Nzk2OS4uNWMy NGVkYzk3NzMyZjEzNjlkYTI2YjU5Nzk0NGMzYTkxODg1NjBkMCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv RXZlbnRIYW5kbGVyLmNwcApAQCAtMjg2OSw3ICsyODY5LDcgQEAgYm9vbCBFdmVudEhhbmRsZXI6 OmhhbmRsZVdoZWVsRXZlbnQoY29uc3QgUGxhdGZvcm1XaGVlbEV2ZW50JiBldmVudCkKICAgICBp ZiAoZWxlbWVudCkgewogICAgICAgICBpZiAoaXNPdmVyV2lkZ2V0KSB7CiAgICAgICAgICAgICBp ZiAoV2Vha1B0cjxXaWRnZXQ+IHdpZGdldCA9IHdpZGdldEZvckVsZW1lbnQoKmVsZW1lbnQpKSB7 Ci0gICAgICAgICAgICAgICAgaWYgKHdpZGdldERpZEhhbmRsZVdoZWVsRXZlbnQoZXZlbnQsICp3 aWRnZXQuZ2V0KCkpKQorICAgICAgICAgICAgICAgIGlmIChwYXNzV2hlZWxFdmVudFRvV2lkZ2V0 KGV2ZW50LCAqd2lkZ2V0LmdldCgpKSkKICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIGNvbXBs ZXRlV2lkZ2V0V2hlZWxFdmVudChhZGp1c3RlZEV2ZW50LCB3aWRnZXQsIHNjcm9sbGFibGVBcmVh LCBzY3JvbGxhYmxlQ29udGFpbmVyLmdldCgpKTsKICAgICAgICAgICAgIH0KICAgICAgICAgfQpA QCAtNDM3MCw3ICs0MzcwLDcgQEAgYm9vbCBFdmVudEhhbmRsZXI6OnBhc3NNb3VzZVJlbGVhc2VF dmVudFRvU3ViZnJhbWUoTW91c2VFdmVudFdpdGhIaXRUZXN0UmVzdWx0cyYKICAgICByZXR1cm4g dHJ1ZTsKIH0KIAotYm9vbCBFdmVudEhhbmRsZXI6OndpZGdldERpZEhhbmRsZVdoZWVsRXZlbnQo Y29uc3QgUGxhdGZvcm1XaGVlbEV2ZW50JiBldmVudCwgV2lkZ2V0JiB3aWRnZXQpCitib29sIEV2 ZW50SGFuZGxlcjo6cGFzc1doZWVsRXZlbnRUb1dpZGdldChjb25zdCBQbGF0Zm9ybVdoZWVsRXZl bnQmIGV2ZW50LCBXaWRnZXQmIHdpZGdldCkKIHsKICAgICBpZiAoIWlzPEZyYW1lVmlldz4od2lk Z2V0KSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGFnZS9FdmVudEhhbmRsZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmgK aW5kZXggNThmYzljNTZlOTlhNzQzNTdhNzUyNjZlN2ZmOWQ5NWY2NjViYjU4OC4uYWRiMTVkYmI0 YzUzZjhkMWM0OTU3YTY0NmVmZjMwZmU4YzljYzY1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGFnZS9FdmVudEhhbmRsZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFu ZGxlci5oCkBAIC0yMDksMTMgKzIwOSw2IEBAIHB1YmxpYzoKICAgICB2b2lkIGRlZmF1bHRXaGVl bEV2ZW50SGFuZGxlcihOb2RlKiwgV2hlZWxFdmVudCYpOwogICAgIGJvb2wgaGFuZGxlUGFzdGVH bG9iYWxTZWxlY3Rpb24oY29uc3QgUGxhdGZvcm1Nb3VzZUV2ZW50Jik7CiAKLSAgICB2b2lkIGRl dGVybWluZVdoZWVsRXZlbnRUYXJnZXQoY29uc3QgUGxhdGZvcm1XaGVlbEV2ZW50JiwgY29uc3Qg SGl0VGVzdFJlc3VsdCYsIFJlZlB0cjxFbGVtZW50PiYgZXZlbnRUYXJnZXQsIFJlZlB0cjxDb250 YWluZXJOb2RlPiYgc2Nyb2xsYWJsZUNvbnRhaW5lciwgV2Vha1B0cjxTY3JvbGxhYmxlQXJlYT4m LCBib29sJiBpc092ZXJXaWRnZXQpOwotICAgIHZvaWQgcmVjb3JkV2hlZWxFdmVudEZvckRlbHRh RmlsdGVyKGNvbnN0IFBsYXRmb3JtV2hlZWxFdmVudCYpOwotICAgIGJvb2wgcHJvY2Vzc1doZWVs RXZlbnRGb3JTY3JvbGxpbmcoY29uc3QgUGxhdGZvcm1XaGVlbEV2ZW50JiwgQ29udGFpbmVyTm9k ZSogc2Nyb2xsYWJsZUNvbnRhaW5lciwgY29uc3QgV2Vha1B0cjxTY3JvbGxhYmxlQXJlYT4mKTsK LSAgICB2b2lkIHByb2Nlc3NXaGVlbEV2ZW50Rm9yU2Nyb2xsU25hcChjb25zdCBQbGF0Zm9ybVdo ZWVsRXZlbnQmLCBjb25zdCBXZWFrUHRyPFNjcm9sbGFibGVBcmVhPiYpOwotCi0gICAgYm9vbCBw bGF0Zm9ybUNvbXBsZXRlUGxhdGZvcm1XaWRnZXRXaGVlbEV2ZW50KGNvbnN0IFBsYXRmb3JtV2hl ZWxFdmVudCYsIGNvbnN0IFdpZGdldCYsIENvbnRhaW5lck5vZGUqIHNjcm9sbGFibGVDb250YWlu ZXIpOwotCiAjaWYgRU5BQkxFKElPU19UT1VDSF9FVkVOVFMpIHx8IEVOQUJMRShJT1NfR0VTVFVS RV9FVkVOVFMpCiAgICAgdXNpbmcgVG91Y2hBcnJheSA9IFZlY3RvcjxSZWZQdHI8VG91Y2g+PjsK ICAgICB1c2luZyBFdmVudFRhcmdldFRvdWNoTWFwID0gSGFzaE1hcDxFdmVudFRhcmdldCosIFRv dWNoQXJyYXkqPjsKQEAgLTQ0OCw5ICs0NDEsMTYgQEAgcHJpdmF0ZToKICAgICBib29sIHBhc3NX aWRnZXRNb3VzZURvd25FdmVudFRvV2lkZ2V0KFJlbmRlcldpZGdldCopOwogCiAgICAgYm9vbCBw YXNzTW91c2VEb3duRXZlbnRUb1dpZGdldChXaWRnZXQqKTsKLSAgICBib29sIHdpZGdldERpZEhh bmRsZVdoZWVsRXZlbnQoY29uc3QgUGxhdGZvcm1XaGVlbEV2ZW50JiwgV2lkZ2V0Jik7CisKKyAg ICBib29sIHBhc3NXaGVlbEV2ZW50VG9XaWRnZXQoY29uc3QgUGxhdGZvcm1XaGVlbEV2ZW50Jiwg V2lkZ2V0Jik7CisgICAgdm9pZCBkZXRlcm1pbmVXaGVlbEV2ZW50VGFyZ2V0KGNvbnN0IFBsYXRm b3JtV2hlZWxFdmVudCYsIGNvbnN0IEhpdFRlc3RSZXN1bHQmLCBSZWZQdHI8RWxlbWVudD4mIGV2 ZW50VGFyZ2V0LCBSZWZQdHI8Q29udGFpbmVyTm9kZT4mIHNjcm9sbGFibGVDb250YWluZXIsIFdl YWtQdHI8U2Nyb2xsYWJsZUFyZWE+JiwgYm9vbCYgaXNPdmVyV2lkZ2V0KTsKKyAgICB2b2lkIHJl Y29yZFdoZWVsRXZlbnRGb3JEZWx0YUZpbHRlcihjb25zdCBQbGF0Zm9ybVdoZWVsRXZlbnQmKTsK KyAgICBib29sIHByb2Nlc3NXaGVlbEV2ZW50Rm9yU2Nyb2xsaW5nKGNvbnN0IFBsYXRmb3JtV2hl ZWxFdmVudCYsIENvbnRhaW5lck5vZGUqIHNjcm9sbGFibGVDb250YWluZXIsIGNvbnN0IFdlYWtQ dHI8U2Nyb2xsYWJsZUFyZWE+Jik7CisgICAgdm9pZCBwcm9jZXNzV2hlZWxFdmVudEZvclNjcm9s bFNuYXAoY29uc3QgUGxhdGZvcm1XaGVlbEV2ZW50JiwgY29uc3QgV2Vha1B0cjxTY3JvbGxhYmxl QXJlYT4mKTsKICAgICBib29sIGNvbXBsZXRlV2lkZ2V0V2hlZWxFdmVudChjb25zdCBQbGF0Zm9y bVdoZWVsRXZlbnQmLCBjb25zdCBXZWFrUHRyPFdpZGdldD4mLCBjb25zdCBXZWFrUHRyPFNjcm9s bGFibGVBcmVhPiYsIENvbnRhaW5lck5vZGUqKTsKIAorICAgIGJvb2wgcGxhdGZvcm1Db21wbGV0 ZVBsYXRmb3JtV2lkZ2V0V2hlZWxFdmVudChjb25zdCBQbGF0Zm9ybVdoZWVsRXZlbnQmLCBjb25z dCBXaWRnZXQmLCBDb250YWluZXJOb2RlKiBzY3JvbGxhYmxlQ29udGFpbmVyKTsKKwogICAgIHZv aWQgZGVmYXVsdFNwYWNlRXZlbnRIYW5kbGVyKEtleWJvYXJkRXZlbnQmKTsKICAgICB2b2lkIGRl ZmF1bHRCYWNrc3BhY2VFdmVudEhhbmRsZXIoS2V5Ym9hcmRFdmVudCYpOwogICAgIHZvaWQgZGVm YXVsdFRhYkV2ZW50SGFuZGxlcihLZXlib2FyZEV2ZW50Jik7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wYWdlL2lvcy9FdmVudEhhbmRsZXJJT1MubW0gYi9Tb3VyY2UvV2ViQ29yZS9wYWdl L2lvcy9FdmVudEhhbmRsZXJJT1MubW0KaW5kZXggZmI4YjM2ZGU4ZWJkOTVlZWZjZDVmN2FhYzAx ZjM5ODQzNTA5NDg5MC4uMjliZGZjYzk2NDA5ZjM2MjQyYTBiNDIyOWFiNGExYWZhMjRmOTdhOCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9pb3MvRXZlbnRIYW5kbGVySU9TLm1tCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvaW9zL0V2ZW50SGFuZGxlcklPUy5tbQpAQCAtNDE4LDcg KzQxOCw3IEBAIGJvb2wgRXZlbnRIYW5kbGVyOjpwYXNzU3ViZnJhbWVFdmVudFRvU3ViZnJhbWUo TW91c2VFdmVudFdpdGhIaXRUZXN0UmVzdWx0cyYgZXZlCiAgICAgcmV0dXJuIGZhbHNlOwogfQog Ci1ib29sIEV2ZW50SGFuZGxlcjo6d2lkZ2V0RGlkSGFuZGxlV2hlZWxFdmVudChjb25zdCBQbGF0 Zm9ybVdoZWVsRXZlbnQmLCBXaWRnZXQmIHdpZGdldCkKK2Jvb2wgRXZlbnRIYW5kbGVyOjpwYXNz V2hlZWxFdmVudFRvV2lkZ2V0KGNvbnN0IFBsYXRmb3JtV2hlZWxFdmVudCYsIFdpZGdldCYgd2lk Z2V0KQogewogICAgIEJFR0lOX0JMT0NLX09CSkNfRVhDRVBUSU9OUzsKIApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGFnZS9tYWMvRXZlbnRIYW5kbGVyTWFjLm1tIGIvU291cmNlL1dlYkNv cmUvcGFnZS9tYWMvRXZlbnRIYW5kbGVyTWFjLm1tCmluZGV4IDdlMDkyNGVmMTYzOTNkN2ExZjg1 NDc2MDBlYjg0OThmNDI0NzJlZDUuLjk2N2I3MzU5NWQ0YWUyOWVhNDEwYjIxM2IyYzlhODlhZDdh ZGJiYWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvbWFjL0V2ZW50SGFuZGxlck1h Yy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL21hYy9FdmVudEhhbmRsZXJNYWMubW0KQEAg LTQ2Nyw3ICs0NjcsNyBAQCBzdGF0aWMgdm9pZCBzZWxmUmV0YWluaW5nTlNTY3JvbGxWaWV3U2Ny b2xsV2hlZWwoTlNTY3JvbGxWaWV3ICpzZWxmLCBTRUwgc2VsZWN0bwogICAgICAgICBDRlJlbGVh c2UoKF9fYnJpZGdlIENGVHlwZVJlZilzZWxmKTsKIH0KIAotYm9vbCBFdmVudEhhbmRsZXI6Ondp ZGdldERpZEhhbmRsZVdoZWVsRXZlbnQoY29uc3QgUGxhdGZvcm1XaGVlbEV2ZW50JiB3aGVlbEV2 ZW50LCBXaWRnZXQmIHdpZGdldCkKK2Jvb2wgRXZlbnRIYW5kbGVyOjpwYXNzV2hlZWxFdmVudFRv V2lkZ2V0KGNvbnN0IFBsYXRmb3JtV2hlZWxFdmVudCYgd2hlZWxFdmVudCwgV2lkZ2V0JiB3aWRn ZXQpCiB7CiAgICAgQkVHSU5fQkxPQ0tfT0JKQ19FWENFUFRJT05TOwogCg==