209943 2020-04-02 17:09:09 -0700 Fix bugs related to VideoTextureCopierCV and ANGLE roll script 2020-04-03 12:26:13 -0700 1 1 1 Unclassified WebKit WebGL WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 209689 1 kbr kbr dino eric.carlson ews-watchlist glenn graouts jer.noble justin_fan kondapallykalyan philipj sergio webkit-bug-importer oldest_to_newest 1637163 0 kbr 2020-04-02 17:09:09 -0700 While rolling ANGLE forward in Issue 209689, a few preexisting bugs were uncovered in the VideoTextureCopierCV and its GL context usage that should be fixed separately, so that the ANGLE roll is completely self-contained. Also, changes to ANGLE's commit ID generation necessitated fixes to the ANGLE roll script, which would ideally also be separated in case of a revert of the ANGLE roll. 1637184 1 395331 kbr 2020-04-02 18:16:10 -0700 Created attachment 395331 Patch 1637185 2 ews-watchlist 2020-04-02 18:17:15 -0700 Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE 1637487 3 ews-feeder 2020-04-03 12:25:32 -0700 Committed r259482: <https://trac.webkit.org/changeset/259482> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395331. 1637488 4 webkit-bug-importer 2020-04-03 12:26:13 -0700 <rdar://problem/61270228> 395331 2020-04-02 18:16:10 -0700 2020-04-03 12:25:32 -0700 Patch bug-209943-20200402181610.patch text/plain 6940 kbr U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5NDM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggODE5OWJjMTNlM2NmOWJlZTU1YzlhOTdiZjNmM2VlMjdkZjAzNzE3Yy4uNmYzZTNjNGY5ZTc3 MGEyZGQ2ZGFmZDZiZTlhMTJhODBhNDVmMjA3NiAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTA0LTAyICBLZW5uZXRoIFJ1c3NlbGwgIDxrYnJAY2hy b21pdW0ub3JnPgorCisgICAgICAgIEZpeCBidWdzIHJlbGF0ZWQgdG8gVmlkZW9UZXh0dXJlQ29w aWVyQ1YgYW5kIEFOR0xFIHJvbGwgc2NyaXB0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMDk5NDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBVcGRhdGUgdGhlIHVwZGF0ZS1hbmdsZS5zaCBzY3JpcHQgdG8g dGFrZSBpbnRvIGFjY291bnQgdGhlIG5ldworICAgICAgICBwcm9jZWR1cmUgZm9yIGdlbmVyYXRp bmcgQU5HTEUncyBjb21taXQgSUQgaGVhZGVyIGZpbGUuIFRoaXMKKyAgICAgICAgZW5hYmxlcyBB TkdMRSByb2xscyBpbnRvIFdlYktpdCBhZ2Fpbi4KKworICAgICAgICAqIHVwZGF0ZS1hbmdsZS5z aDoKKwogMjAyMC0wMy0yNyAgS2VubmV0aCBSdXNzZWxsICA8a2JyQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBVc2UgQU5HTEVfcm9idXN0X2NsaWVudF9tZW1vcnkgdG8gcmVwbGFjZSBmcmFtZWJ1 ZmZlci90ZXh0dXJlIHZhbGlkYXRpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2MWIzYzljZmQ1ZTdjNjAwMzJk Mzc1NjVkMzFlMjZiZjE4MGY0ODZiLi4yNDExYTQ5MzY0MjdmYzQyN2I4OThjNmNmMjAwM2ZiZGZm MGIyMmNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjkgQEAKKzIwMjAtMDQtMDIgIEtlbm5ldGgg UnVzc2VsbCAgPGtickBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgRml4IGJ1Z3MgcmVsYXRlZCB0 byBWaWRlb1RleHR1cmVDb3BpZXJDViBhbmQgQU5HTEUgcm9sbCBzY3JpcHQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwOTk0MworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeGVkIGxvbmdzdGFuZGluZyBw cmVleGlzdGluZyBidWdzIHJlbGF0ZWQgdG8gY3JlYXRpb24gYW5kCisgICAgICAgIGRlbGV0aW9u IG9mIE9wZW5HTCBvYmplY3RzIGluc2lkZSBWaWRlb1RleHR1cmVDb3BpZXJDViwgaW5jbHVkaW5n CisgICAgICAgIGluIHdoaWNoIGNvbnRleHQgaXRzIGludGVybmFsIGZyYW1lYnVmZmVyIHdhcyBj cmVhdGVkLiBVbmJpbmQgdGhlCisgICAgICAgIG91dHB1dCB0ZXh0dXJlIGFmdGVyIGhvb2tpbmcg aXQgdXAgdG8gdGhlIGZyYW1lYnVmZmVyIHRvIGF2b2lkIGFueQorICAgICAgICBhcHBlYXJhbmNl IG9mIHJlbmRlcmluZyBmZWVkYmFjayBsb29wcy4KKworICAgICAgICBTdG9wIHNldHRpbmcgdGhl IFdlYkdMIGNvbXBhdGliaWxpdHkgY29udGV4dCBjcmVhdGlvbiBhdHRyaWJ1dGUKKyAgICAgICAg Zm9yIFZpZGVvVGV4dHVyZUNvcGllcidzIGNvbnRleHQuCisKKyAgICAgICAgQ292ZXJlZCBieSBw cmVleGlzdGluZyBsYXlvdXQgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9j b2NvYS9HcmFwaGljc0NvbnRleHRHTE9wZW5HTENvY29hLm1tOgorICAgICAgICAoV2ViQ29yZTo6 R3JhcGhpY3NDb250ZXh0R0xPcGVuR0w6OkdyYXBoaWNzQ29udGV4dEdMT3BlbkdMKToKKyAgICAg ICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jdi9WaWRlb1RleHR1cmVDb3BpZXJDVi5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpWaWRlb1RleHR1cmVDb3BpZXJDVjo6VmlkZW9UZXh0dXJlQ29waWVyQ1Yp OgorICAgICAgICAoV2ViQ29yZTo6VmlkZW9UZXh0dXJlQ29waWVyQ1Y6On5WaWRlb1RleHR1cmVD b3BpZXJDVik6CisgICAgICAgIChXZWJDb3JlOjpWaWRlb1RleHR1cmVDb3BpZXJDVjo6Y29weUlt YWdlVG9QbGF0Zm9ybVRleHR1cmUpOgorICAgICAgICAoV2ViQ29yZTo6VmlkZW9UZXh0dXJlQ29w aWVyQ1Y6OmNvcHlWaWRlb1RleHR1cmVUb1BsYXRmb3JtVGV4dHVyZSk6CisKIDIwMjAtMDQtMDIg IEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3Zl IHVudXNlZCBtZWRpYSBjb250cm9scyBjb2RlCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS91cGRhdGUtYW5nbGUuc2ggYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS91cGRhdGUt YW5nbGUuc2gKaW5kZXggY2YxN2UwNjJhYWY1MzUwNDNkMmU4YWJiOWY2YjIzYjg3NWI4NzY4Yy4u OTI0YjhiMmQyNDA1ZjJiZTU4ZDVjMThhMDI4OTJlY2NmMWNlYzJmZiAxMDA3NTUKLS0tIGEvU291 cmNlL1RoaXJkUGFydHkvQU5HTEUvdXBkYXRlLWFuZ2xlLnNoCisrKyBiL1NvdXJjZS9UaGlyZFBh cnR5L0FOR0xFL3VwZGF0ZS1hbmdsZS5zaApAQCAtNjIsMTUgKzYyLDE5IEBAIENPTU1JVF9IQVNI PWBnaXQgcmV2LXBhcnNlIEhFQURgCiBlY2hvICIkQ09NTUlUX0hBU0giCiBlY2hvICIiCiAKK2Vj aG8gIkdlbmVyYXRpbmcgY29tbWl0LmgiCisuL3NyYy9jb21taXRfaWQucHkgZ2VuIGNvbW1pdC5o LlRFTVAKKwogZWNobyAiQXBwbHlpbmcgV2ViS2l0J3MgbG9jYWwgQU5HTEUgY2hhbmdlcyB0byB0 aGUgb2xkIEFOR0xFIHZlcnNpb24uIgogZ2l0IGNoZWNrb3V0IC1CIGRvd25zdHJlYW0tY2hhbmdl cyAiJFBSRVZJT1VTX0NPTU1JVF9IQVNIIgogcHVzaGQgLi4gJj4gL2Rldi9udWxsCiBnaXQgY2hl Y2tvdXQgSEVBRCAtLSBBTkdMRQogcG9wZCAmPiAvZGV2L251bGwKIAotZWNobyAiQ29weWluZyBz cmMvY29tbWl0LmggdG8gc3JjL2lkL2NvbW1pdC5oIgorZWNobyAiQ29weWluZyBjb21taXQuaCB0 byBzcmMvaWQvY29tbWl0LmgiCiBta2RpciAtcCBzcmMvaWQKLWdpdCBzaG93IG9yaWdpbi9tYXN0 ZXI6c3JjL2NvbW1pdC5oID4gc3JjL2lkL2NvbW1pdC5oCitjcCBjb21taXQuaC5URU1QIHNyYy9p ZC9jb21taXQuaAorcm0gY29tbWl0LmguVEVNUAogCiBlY2hvICJVcGRhdGluZyBBTkdMRS5wbGlz dCBjb21taXQgaGFzaGVzLiIKIHNlZCAtaS5iYWsgLWUgInMvXChbXmEtejAtOV1cKVthLXowLTld XHs0MFx9XChbXmEtejAtOV1cKS9cMSRDT01NSVRfSEFTSFwyL2ciIEFOR0xFLnBsaXN0CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9HcmFwaGljc0Nv bnRleHRHTE9wZW5HTENvY29hLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Y29jb2EvR3JhcGhpY3NDb250ZXh0R0xPcGVuR0xDb2NvYS5tbQppbmRleCAxZDgzZTc3MWZiYTZl ZGQxMzY0MDNlOTQ1NDk0NTk4Y2I3MjQ4NDdjLi4xM2YwNmJjMmJiOGYxYmNlYTg0MmI3NWUwYmQ2 OWViMzE4M2UwMTU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9jb2NvYS9HcmFwaGljc0NvbnRleHRHTE9wZW5HTENvY29hLm1tCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL0dyYXBoaWNzQ29udGV4dEdMT3BlbkdMQ29jb2Eu bW0KQEAgLTM0NSw4ICszNDUsMTUgQEAgR3JhcGhpY3NDb250ZXh0R0xPcGVuR0w6OkdyYXBoaWNz Q29udGV4dEdMT3BlbkdMKEdyYXBoaWNzQ29udGV4dEdMQXR0cmlidXRlcyBhdHQKICAgICAgICAg ZWdsQ29udGV4dEF0dHJpYnV0ZXMuYXBwZW5kKEVHTF9DT05URVhUX09QRU5HTF9CQUNLV0FSRFNf Q09NUEFUSUJMRV9BTkdMRSk7CiAgICAgICAgIGVnbENvbnRleHRBdHRyaWJ1dGVzLmFwcGVuZChF R0xfRkFMU0UpOwogICAgIH0KLSAgICBlZ2xDb250ZXh0QXR0cmlidXRlcy5hcHBlbmQoRUdMX0NP TlRFWFRfV0VCR0xfQ09NUEFUSUJJTElUWV9BTkdMRSk7Ci0gICAgZWdsQ29udGV4dEF0dHJpYnV0 ZXMuYXBwZW5kKEVHTF9UUlVFKTsKKyAgICBpZiAoIXNoYXJlZENvbnRleHQpIHsKKyAgICAgICAg Ly8gVGhlIHNoYXJlZCBjb250ZXh0IGlzIG9ubHkgbm9uLW51bGwgd2hlbiBjcmVhdGluZyBhIGNv bnRleHQKKyAgICAgICAgLy8gb24gYmVoYWxmIG9mIHRoZSBWaWRlb1RleHR1cmVDb3BpZXIuIFdl YkdMLXNwZWNpZmljIHJlbmRlcmluZworICAgICAgICAvLyBmZWVkYmFjayBsb29wIHZhbGlkYXRp b24gZG9lcyBub3Qgd29yayBpbiBtdWx0aS1jb250ZXh0CisgICAgICAgIC8vIHNjZW5hcmlvcywg YW5kIG11c3QgYmUgZGlzYWJsZWQgZm9yIHRoZSBWaWRlb1RleHR1cmVDb3BpZXIncworICAgICAg ICAvLyBjb250ZXh0LgorICAgICAgICBlZ2xDb250ZXh0QXR0cmlidXRlcy5hcHBlbmQoRUdMX0NP TlRFWFRfV0VCR0xfQ09NUEFUSUJJTElUWV9BTkdMRSk7CisgICAgICAgIGVnbENvbnRleHRBdHRy aWJ1dGVzLmFwcGVuZChFR0xfVFJVRSk7CisgICAgfQogICAgIC8vIFdlYkdMIHJlcXVpcmVzIHRo YXQgYWxsIHJlc291cmNlcyBhcmUgY2xlYXJlZCBhdCBjcmVhdGlvbi4KICAgICBlZ2xDb250ZXh0 QXR0cmlidXRlcy5hcHBlbmQoRUdMX1JPQlVTVF9SRVNPVVJDRV9JTklUSUFMSVpBVElPTl9BTkdM RSk7CiAgICAgZWdsQ29udGV4dEF0dHJpYnV0ZXMuYXBwZW5kKEVHTF9UUlVFKTsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2N2L1ZpZGVvVGV4dHVyZUNvcGll ckNWLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2N2L1ZpZGVvVGV4dHVy ZUNvcGllckNWLmNwcAppbmRleCA3ZWI2MGQ3MWIxNWQzMWQyMWY2MDE1NzJhOTFmMDkxOTZkODFh M2MwLi4yN2FhODc5MDA2M2E2OTFkOTcyMTIzOGEyOThkMjk5M2FlOGU0MDk4IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jdi9WaWRlb1RleHR1cmVDb3BpZXJD Vi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY3YvVmlkZW9UZXh0 dXJlQ29waWVyQ1YuY3BwCkBAIC0zNzksMTggKzM3OSwxOCBAQCBzdGF0aWMgY29uc3QgVmVjdG9y PEdMZmxvYXQ+IFlDYkNyVG9SR0JNYXRyaXhGb3JSYW5nZUFuZFRyYW5zZmVyRnVuY3Rpb24oUGl4 ZWxSYQogVmlkZW9UZXh0dXJlQ29waWVyQ1Y6OlZpZGVvVGV4dHVyZUNvcGllckNWKEdyYXBoaWNz Q29udGV4dEdMT3BlbkdMJiBjb250ZXh0KQogICAgIDogbV9zaGFyZWRDb250ZXh0KGNvbnRleHQp CiAgICAgLCBtX2NvbnRleHQoR3JhcGhpY3NDb250ZXh0R0xPcGVuR0w6OmNyZWF0ZVNoYXJlZChj b250ZXh0KSkKLSAgICAsIG1fZnJhbWVidWZmZXIoY29udGV4dC5jcmVhdGVGcmFtZWJ1ZmZlcigp KQorICAgICwgbV9mcmFtZWJ1ZmZlcihtX2NvbnRleHQtPmNyZWF0ZUZyYW1lYnVmZmVyKCkpCiB7 CiB9CiAKIFZpZGVvVGV4dHVyZUNvcGllckNWOjp+VmlkZW9UZXh0dXJlQ29waWVyQ1YoKQogewog ICAgIGlmIChtX3ZlcnRleEJ1ZmZlcikKLSAgICAgICAgbV9jb250ZXh0LT5kZWxldGVQcm9ncmFt KG1fdmVydGV4QnVmZmVyKTsKKyAgICAgICAgbV9jb250ZXh0LT5kZWxldGVCdWZmZXIobV92ZXJ0 ZXhCdWZmZXIpOwogICAgIGlmIChtX3Byb2dyYW0pCiAgICAgICAgIG1fY29udGV4dC0+ZGVsZXRl UHJvZ3JhbShtX3Byb2dyYW0pOwogICAgIGlmIChtX3l1dlZlcnRleEJ1ZmZlcikKLSAgICAgICAg bV9jb250ZXh0LT5kZWxldGVQcm9ncmFtKG1feXV2VmVydGV4QnVmZmVyKTsKKyAgICAgICAgbV9j b250ZXh0LT5kZWxldGVCdWZmZXIobV95dXZWZXJ0ZXhCdWZmZXIpOwogICAgIGlmIChtX3l1dlBy b2dyYW0pCiAgICAgICAgIG1fY29udGV4dC0+ZGVsZXRlUHJvZ3JhbShtX3l1dlByb2dyYW0pOwog ICAgIG1fY29udGV4dC0+ZGVsZXRlRnJhbWVidWZmZXIobV9mcmFtZWJ1ZmZlcik7CkBAIC04NDcs NiArODQ3LDcgQEAgYm9vbCBWaWRlb1RleHR1cmVDb3BpZXJDVjo6Y29weUltYWdlVG9QbGF0Zm9y bVRleHR1cmUoQ1ZQaXhlbEJ1ZmZlclJlZiBpbWFnZSwgc2kKICAgICAgICAgTE9HKFdlYkdMLCAi VmlkZW9UZXh0dXJlQ29waWVyQ1Y6OmNvcHlWaWRlb1RleHR1cmVUb1BsYXRmb3JtVGV4dHVyZSgl cCkgLSBVbmFibGUgdG8gY3JlYXRlIGZyYW1lYnVmZmVyIGZvciBvdXRwdXRUZXh0dXJlLiIsIHRo aXMpOwogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgfQorICAgIG1fY29udGV4dC0+YmluZFRl eHR1cmUoR3JhcGhpY3NDb250ZXh0R0w6OlRFWFRVUkVfMkQsIDApOwogCiAgICAgbV9jb250ZXh0 LT51c2VQcm9ncmFtKG1feXV2UHJvZ3JhbSk7CiAgICAgbV9jb250ZXh0LT52aWV3cG9ydCgwLCAw LCB3aWR0aCwgaGVpZ2h0KTsKQEAgLTEwMjYsNiArMTAyNyw3IEBAIGJvb2wgVmlkZW9UZXh0dXJl Q29waWVyQ1Y6OmNvcHlWaWRlb1RleHR1cmVUb1BsYXRmb3JtVGV4dHVyZShQbGF0Zm9ybUdMT2Jq ZWN0IHZpCiAgICAgICAgIExPRyhXZWJHTCwgIlZpZGVvVGV4dHVyZUNvcGllckNWOjpjb3B5Vmlk ZW9UZXh0dXJlVG9QbGF0Zm9ybVRleHR1cmUoJXApIC0gVW5hYmxlIHRvIGNyZWF0ZSBmcmFtZWJ1 ZmZlciBmb3Igb3V0cHV0VGV4dHVyZS4iLCB0aGlzKTsKICAgICAgICAgcmV0dXJuIGZhbHNlOwog ICAgIH0KKyAgICBtX2NvbnRleHQtPmJpbmRUZXh0dXJlKEdyYXBoaWNzQ29udGV4dEdMOjpURVhU VVJFXzJELCAwKTsKIAogICAgIG1fY29udGV4dC0+dXNlUHJvZ3JhbShtX3Byb2dyYW0pOwogICAg IG1fY29udGV4dC0+dmlld3BvcnQoMCwgMCwgd2lkdGgsIGhlaWdodCk7Cg==