209932 2020-04-02 15:08:26 -0700 REGRESSION (r258525): Leak of NSMutableAttributedString in -[WebAccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:spellCheck:] 2020-04-03 12:10:44 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=209980 InRadar P2 Normal --- 209129 1 ddkilzer ddkilzer aboxhall apinheiro cfleizach darin dmazzoni ews-watchlist jcraig jdiggs samuel_white webkit-bug-importer oldest_to_newest 1637091 0 ddkilzer 2020-04-02 15:08:26 -0700 Leak of NSMutableAttributedString in -[WebAccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:spellCheck:]. [...] RefPtr<Range> range = [protectedSelf rangeForTextMarkerRange:textMarkerRange]; NSMutableAttributedString* attrString = [[NSMutableAttributedString alloc] init]; if (!range) return nil; // LEAK. TextIterator it(*range); [...] 1637092 1 webkit-bug-importer 2020-04-02 15:08:33 -0700 <rdar://problem/61228565> 1637094 2 395308 ddkilzer 2020-04-02 15:14:47 -0700 Created attachment 395308 Patch v1 1637121 3 395308 darin 2020-04-02 16:06:15 -0700 Comment on attachment 395308 Patch v1 Thanks for catching that Dave. Strange that we were not using a RetainPtr. 1637154 4 ews-feeder 2020-04-02 16:53:00 -0700 Committed r259428: <https://trac.webkit.org/changeset/259428> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395308. 395308 2020-04-02 15:14:47 -0700 2020-04-02 16:53:00 -0700 Patch v1 bug-209932-20200402151613.patch text/plain 1892 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5MzM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjI3NmI5NjEzMjZiZmJi ZDE0MDAwOWE2OTY4NDczZmVhZDlkN2VkYy4uYTdkMzZhMzJlZWY3NTBjODgyYWQ3MjgxNzcyN2Vi N2JjM2RiNTA5NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTA0LTAyICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjI1 ODUyNSk6IExlYWsgb2YgTlNNdXRhYmxlQXR0cmlidXRlZFN0cmluZyBpbiAtW1dlYkFjY2Vzc2li aWxpdHlPYmplY3RXcmFwcGVyIGRvQVhBdHRyaWJ1dGVkU3RyaW5nRm9yVGV4dE1hcmtlclJhbmdl OnNwZWxsQ2hlY2s6XQorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMjA5OTMyPgorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vNjEyMjg1NjU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L21hYy9XZWJBY2Nlc3NpYmls aXR5T2JqZWN0V3JhcHBlck1hYy5tbToKKyAgICAgICAgKC1bV2ViQWNjZXNzaWJpbGl0eU9iamVj dFdyYXBwZXIgZG9BWEF0dHJpYnV0ZWRTdHJpbmdGb3JUZXh0TWFya2VyUmFuZ2U6c3BlbGxDaGVj azpdKToKKyAgICAgICAgTW92ZSBlYXJseSByZXR1cm4gdG8gYXZvaWQgbGVha2luZyBOU011dGFi bGVBdHRyaWJ1dGVkU3RyaW5nLgorCiAyMDIwLTAzLTMxICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5m cmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgRnJhbWVWaWV3IGFuZCBGcmFtZSBUZXh0 U3RyZWFtLWxvZ2dhYmxlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5 L21hYy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlck1hYy5tbSBiL1NvdXJjZS9XZWJDb3Jl L2FjY2Vzc2liaWxpdHkvbWFjL1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyTWFjLm1tCmlu ZGV4IGY2YTcyMzE2YTY3NzM3Y2I2NWI5ZGIyOGQ1MTMyNDE1NDdiNmIzNmIuLjk4NDM1YTJhNzc2 NzczMTBjYjc1MGIyNzU2MTcxMzhhNWMwYjg3YTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2FjY2Vzc2liaWxpdHkvbWFjL1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyTWFjLm1tCisr KyBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvbWFjL1dlYkFjY2Vzc2liaWxpdHlPYmpl Y3RXcmFwcGVyTWFjLm1tCkBAIC0xMjUzLDkgKzEyNTMsOSBAQCAtIChOU0F0dHJpYnV0ZWRTdHJp bmcqKWRvQVhBdHRyaWJ1dGVkU3RyaW5nRm9yVGV4dE1hcmtlclJhbmdlOihpZCl0ZXh0TWFya2Vy UmFuZwogICAgICAgICAgICAgcmV0dXJuIG5pbDsKIAogICAgICAgICBSZWZQdHI8UmFuZ2U+IHJh bmdlID0gW3Byb3RlY3RlZFNlbGYgcmFuZ2VGb3JUZXh0TWFya2VyUmFuZ2U6dGV4dE1hcmtlclJh bmdlXTsKLSAgICAgICAgTlNNdXRhYmxlQXR0cmlidXRlZFN0cmluZyogYXR0clN0cmluZyA9IFtb TlNNdXRhYmxlQXR0cmlidXRlZFN0cmluZyBhbGxvY10gaW5pdF07CiAgICAgICAgIGlmICghcmFu Z2UpCiAgICAgICAgICAgICByZXR1cm4gbmlsOworICAgICAgICBOU011dGFibGVBdHRyaWJ1dGVk U3RyaW5nKiBhdHRyU3RyaW5nID0gW1tOU011dGFibGVBdHRyaWJ1dGVkU3RyaW5nIGFsbG9jXSBp bml0XTsKICAgICAgICAgVGV4dEl0ZXJhdG9yIGl0KCpyYW5nZSk7CiAgICAgICAgIHdoaWxlICgh aXQuYXRFbmQoKSkgewogICAgICAgICAgICAgTm9kZSYgbm9kZSA9IGl0LnJhbmdlKCkuc3RhcnQu Y29udGFpbmVyOwo=