20992 2008-09-22 08:54:46 -0700 Build fails on GTK+ Mac OS 2008-09-24 00:45:21 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 0 richard webkit-unassigned oldest_to_newest 92132 0 richard 2008-09-22 08:54:46 -0700 JavaScriptCore/wtf/ThreadingGtk.cpp has this snippet at the beginning: #if !PLATFORM(DARWIN) static ThreadIdentifier mainThreadIdentifier; #endif Later in the same file the variable is used unconditionally, causing a build error when building with GTK+ on Mac OS. I'm not sure why it is conditionalized at all, my guess is that the right fix is to just remove the #if. 92438 1 23736 jmalonzo 2008-09-23 17:10:42 -0700 Created attachment 23736 remove platform ifdefs on ThreadingGtk Removed platform ifdef as suggested by Richard. 92454 2 23736 eric 2008-09-23 19:58:32 -0700 Comment on attachment 23736 remove platform ifdefs on ThreadingGtk There was a separate bug about this which I reviewed recently and had a different fix. I thought that had landed already. Are you sure you're up to date? 92455 3 23736 eric 2008-09-23 19:59:22 -0700 Comment on attachment 23736 remove platform ifdefs on ThreadingGtk Oh, nevermind. I think I was thinking of Qt. This code was probably copied from Qt, and probably doesn't need those #ifdefs. 92460 4 23736 alp 2008-09-23 20:40:49 -0700 Comment on attachment 23736 remove platform ifdefs on ThreadingGtk r=me 92479 5 jmalonzo 2008-09-24 00:45:21 -0700 landed in r36846 23736 2008-09-23 17:10:42 -0700 2008-09-23 20:40:49 -0700 remove platform ifdefs on ThreadingGtk gtk-mac-buildfix.patch text/plain 1257 jmalonzo ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCA1ZWExOTZmLi4yOGZjYTI1IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMDgtMDktMjMgIEphbiBNaWNoYWVsIEFsb256byAgPGptYWxvbnpvQHdlYmtpdC5vcmc+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwOTkyCisgICAgICAgIEJ1aWxkIGZh aWxzIG9uIEdUSysgTWFjIE9TCisKKyAgICAgICAgUmVtb3ZlIHBsYXRmb3JtIGlmZGVmIGFzIHN1 Z2dlc3RlZCBieSBSaWNoYXJkIEh1bHQuCisKKyAgICAgICAgKiB3dGYvVGhyZWFkaW5nR3RrLmNw cDoKKyAgICAgICAgKFdURjo6aW5pdGlhbGl6ZVRocmVhZGluZyk6CisKIDIwMDgtMDktMjMgIEtl dmluIE1jQ3VsbG91Z2ggIDxrbWNjdWxsb3VnaEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgRGFyaW4uCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS93dGYvVGhyZWFkaW5nR3Rr LmNwcCBiL0phdmFTY3JpcHRDb3JlL3d0Zi9UaHJlYWRpbmdHdGsuY3BwCmluZGV4IDFkYTU4ODAu LmQ0OWNkZGIgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL3d0Zi9UaHJlYWRpbmdHdGsuY3Bw CisrKyBiL0phdmFTY3JpcHRDb3JlL3d0Zi9UaHJlYWRpbmdHdGsuY3BwCkBAIC00MCw5ICs0MCw3 IEBAIG5hbWVzcGFjZSBXVEYgewogCiBNdXRleCogYXRvbWljYWxseUluaXRpYWxpemVkU3RhdGlj TXV0ZXg7CiAKLSNpZiAhUExBVEZPUk0oREFSV0lOKQogc3RhdGljIFRocmVhZElkZW50aWZpZXIg bWFpblRocmVhZElkZW50aWZpZXI7Ci0jZW5kaWYKIAogc3RhdGljIE11dGV4JiB0aHJlYWRNYXBN dXRleCgpCiB7CkBAIC02MCw5ICs1OCw3IEBAIHZvaWQgaW5pdGlhbGl6ZVRocmVhZGluZygpCiAg ICAgICAgIGF0b21pY2FsbHlJbml0aWFsaXplZFN0YXRpY011dGV4ID0gbmV3IE11dGV4OwogICAg ICAgICB0aHJlYWRNYXBNdXRleCgpOwogICAgICAgICB3dGZfcmFuZG9tX2luaXQoKTsKLSNpZiAh UExBVEZPUk0oREFSV0lOKQogICAgICAgICBtYWluVGhyZWFkSWRlbnRpZmllciA9IGN1cnJlbnRU aHJlYWQoKTsKLSNlbmRpZgogICAgICAgICBpbml0aWFsaXplTWFpblRocmVhZCgpOwogICAgIH0K IH0K