209914 2020-04-02 10:33:44 -0700 [iOS] Remove use of 'apple-signed-executable?' from Sandbox 2020-04-02 13:38:48 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham pvollan webkit-bug-importer oldest_to_newest 1636938 0 bfulgham 2020-04-02 10:33:44 -0700 Some of the rules imported from the system sandbox make decisions based on whether the software is an apple-signed executable or not. These are not relevant for the WebKit processes, and should be removed. This patch also switches from the deprecated 'com.apple.ReportCrash.SimulateCrash' XPC service to its correct name 'com.apple.osanalytics.osanalyticshelper'. 1636939 1 bfulgham 2020-04-02 10:34:23 -0700 <rdar://problem/45088481> 1636944 2 395279 bfulgham 2020-04-02 10:39:41 -0700 Created attachment 395279 Patch 1636946 3 395279 pvollan 2020-04-02 10:47:23 -0700 Comment on attachment 395279 Patch R=me. 1636979 4 bfulgham 2020-04-02 11:49:25 -0700 Windows test failures are not related to this iOS sandbox file edit. 1637040 5 ews-feeder 2020-04-02 13:38:48 -0700 Committed r259409: <https://trac.webkit.org/changeset/259409> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395279. 395279 2020-04-02 10:39:41 -0700 2020-04-02 13:38:48 -0700 Patch bug-209914-20200402103941.patch text/plain 6450 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5MzkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDAxMjg5NWFhNGNiYmMzOTlk NTQyMDU1MTE0MWMzMmUyMjNkYzZjOTQuLjczMTZiNGY1ZmIwODc1MTUxYTU3YmEyMzYzNmViNDBl OTM4YTViYzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjcgQEAKKzIwMjAtMDQtMDIgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gUmVtb3ZlIHVzZSBv ZiAnYXBwbGUtc2lnbmVkLWV4ZWN1dGFibGU/JyBmcm9tIFNhbmRib3gKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwOTkxNAorICAgICAgICA8cmRhcjov L3Byb2JsZW0vNDUwODg0ODE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgU29tZSBvZiB0aGUgcnVsZXMgaW1wb3J0ZWQgZnJvbSB0aGUgc3lzdGVtIHNh bmRib3ggbWFrZSBkZWNpc2lvbnMgYmFzZWQgb24gd2hldGhlciB0aGUgc29mdHdhcmUgaXMKKyAg ICAgICAgYW4gYXBwbGUtc2lnbmVkIGV4ZWN1dGFibGUgb3Igbm90LiBUaGlzIHByZWRpY2F0ZSBp cyBub3QgcmVsZXZhbnQgZm9yIHRoZSBXZWJLaXQgcHJvY2Vzc2VzLCBhbmQKKyAgICAgICAgc2hv dWxkIGJlIHJlbW92ZWQgKGl0IGlzIGFsd2F5cyBhcHBsZS1zaWduZWQpLgorCisgICAgICAgIFRo aXMgcGF0Y2ggbWFrZXMgdGhlIGZvbGxvd2luZyBjaGFuZ2VzOgorICAgICAgICAxLiBSZW1vdmVz IGFsbCB1c2VzIG9mICdhcHBsZS1zaWduZWQtZXhlY3V0YWJsZT8nIChzaW5jZSBpdCBpcyBhbHdh eXMgdHJ1ZSBmb3IgV2ViS2l0KS4KKyAgICAgICAgMi4gUmVtb3ZlZCB0d28gaUNsb3VkIHByZWZl cmVuY2UgcmVhZHMgdGhhdCBhcmUgbm90IHVzZWQgaW4gV2ViS2l0LgorICAgICAgICAzLiBTd2l0 Y2hlcyBmcm9tIHRoZSBkZXByZWNhdGVkICdjb20uYXBwbGUuUmVwb3J0Q3Jhc2guU2ltdWxhdGVD cmFzaCcgWFBDIHNlcnZpY2UgdG8gaXRzCisgICAgICAgIGNvcnJlY3QgbmFtZSAnY29tLmFwcGxl Lm9zYW5hbHl0aWNzLm9zYW5hbHl0aWNzaGVscGVyJy4KKworICAgICAgICBDb3ZlcmVkIGJ5IGV4 aXN0aW5nIHJlZ3Jlc3Npb24gdGVzdHMuCisKKyAgICAgICAgKiBSZXNvdXJjZXMvU2FuZGJveFBy b2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LkdQVS5zYjoKKyAgICAgICAgKiBSZXNvdXJjZXMv U2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0Lk5ldHdvcmtpbmcuc2I6CisgICAg ICAgICogUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5XZWJD b250ZW50LnNiOgorCiAyMDIwLTA0LTAyICB5b3Vlbm4gZmFibGV0ICA8eW91ZW5uQGFwcGxlLmNv bT4KIAogICAgICAgICBEZWJ1ZyBjcmFzaDogQVNTRVJUSU9OIEZBSUxFRDogbV9vbmdvaW5nRmV0 Y2hlcy5jb250YWlucyh0YXNrLmZldGNoSWRlbnRpZmllcigpKQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9SZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LkdQ VS5zYiBiL1NvdXJjZS9XZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFw cGxlLldlYktpdC5HUFUuc2IKaW5kZXggZmQ1YWI1MmU3YzIzZWRlN2NmYjZiZjBiMmU3YjQ2NDFk OGE3MDk3Ni4uNWU4MmRmODU1NWUzMTU5M2JiZjdkNGFhMjRiMmZiYjI3MGNjMWE0ZiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9SZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBw bGUuV2ViS2l0LkdQVS5zYgorKysgYi9Tb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94UHJv ZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuR1BVLnNiCkBAIC00MzYsMTYgKzQzNiwxMCBAQAog CiAoZGVueSBmaWxlLXdyaXRlLW1vdW50IGZpbGUtd3JpdGUtdW5tb3VudCkKIAotKGFsbG93IGZp bGUtcmVhZC1tZXRhZGF0YSAod2l0aCBuby10aW1lcykKLSAgICAgICAodm5vZGUtdHlwZSBESVJF Q1RPUlkpKQotKHdpdGgtZmlsdGVyIChhcHBsZS1zaWduZWQtZXhlY3V0YWJsZT8pCi0gIChhbGxv dyBmaWxlLXJlYWQtbWV0YWRhdGEKLSAgICAgICAgICh2bm9kZS10eXBlIERJUkVDVE9SWSkpKQor KGFsbG93IGZpbGUtcmVhZC1tZXRhZGF0YQorICAgICh2bm9kZS10eXBlIERJUkVDVE9SWSkpCiAK LSh3aXRoLWZpbHRlciAoYXBwbGUtc2lnbmVkLWV4ZWN1dGFibGU/KQotICAobWFuYWdlZC1jb25m aWd1cmF0aW9uLXJlYWQgIkNsb3VkQ29uZmlndXJhdGlvbkRldGFpbHMucGxpc3QiKQotICAobWFu YWdlZC1jb25maWd1cmF0aW9uLXJlYWQgIkNsb3VkQ29uZmlndXJhdGlvblNldEFzaWRlRGV0YWls cy5wbGlzdCIpCi0gIChtb2JpbGUtcHJlZmVyZW5jZXMtcmVhZCAiY29tLmFwcGxlLnNlY3VyaXR5 IikpCisobW9iaWxlLXByZWZlcmVuY2VzLXJlYWQgImNvbS5hcHBsZS5zZWN1cml0eSIpCiAKICh3 aXRoLWZpbHRlciAoc3lzdGVtLWF0dHJpYnV0ZSBhcHBsZS1pbnRlcm5hbCkKICAgKG1vYmlsZS1w cmVmZXJlbmNlcy1yZWFkICJjb20uYXBwbGUuUHJvdG90eXBlVG9vbHMiKSkKQEAgLTY1Miw5ICs2 NDYsNiBAQAogKGFsbG93IHByb2Nlc3MtaW5mby1ydXNhZ2UgKHRhcmdldCBzZWxmKSkKIChhbGxv dyBwcm9jZXNzLWluZm8tY29kZXNpZ25hdHVyZSAodGFyZ2V0IHNlbGYpKQogCi0od2l0aC1maWx0 ZXIgKGFwcGxlLXNpZ25lZC1leGVjdXRhYmxlPykKLSAgICAobW9iaWxlLXByZWZlcmVuY2VzLXJl YWQgImNvbS5hcHBsZS5kZW1vLXNldHRpbmdzIikpCi0KIDs7OwogOzs7IEVuZCBjb21tb24uc2Ig Y29udGVudAogOzs7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94 UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuTmV0d29ya2luZy5zYiBiL1NvdXJjZS9XZWJL aXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5OZXR3b3Jr aW5nLnNiCmluZGV4IDAwOTQyYjQwMDdmYjgyMjE0M2NhOTQ3NTQwNGI1YmEyOGM1NDdmZmQuLjQx YTViZmM4YjRlNDVmYTliMjcwMzMxMzZjMWFhMGU3MTM0NDYzMjcgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5O ZXR3b3JraW5nLnNiCisrKyBiL1NvdXJjZS9XZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxl cy9pb3MvY29tLmFwcGxlLldlYktpdC5OZXR3b3JraW5nLnNiCkBAIC0xMjUsOCArMTI1LDcgQEAK ICAgICAod2l0aC1maWx0ZXIgKGVudGl0bGVtZW50LWlzLXByZXNlbnQgImNvbS5hcHBsZS5wcml2 YXRlLm5ldHdvcmtleHRlbnNpb24uY29uZmlndXJhdGlvbiIpCiAgICAgICAgICAgIChhbGxvdyBm aWxlLXJlYWQqIChsaXRlcmFsICIvcHJpdmF0ZS92YXIvcHJlZmVyZW5jZXMvY29tLmFwcGxlLm5l dHdvcmtleHRlbnNpb24ucGxpc3QiKSkpCiAKLSAgICAod2l0aC1maWx0ZXIgKGFwcGxlLXNpZ25l ZC1leGVjdXRhYmxlPykKLSAgICAgICAgKGFsbG93IGZpbGUtcmVhZCogKGxpdGVyYWwgIi9wcml2 YXRlL3Zhci9wcmVmZXJlbmNlcy9jb20uYXBwbGUubmV0d29ya2V4dGVuc2lvbi51dWlkY2FjaGUu cGxpc3QiKSkpCisgICAgKGFsbG93IGZpbGUtcmVhZCogKGxpdGVyYWwgIi9wcml2YXRlL3Zhci9w cmVmZXJlbmNlcy9jb20uYXBwbGUubmV0d29ya2V4dGVuc2lvbi51dWlkY2FjaGUucGxpc3QiKSkK IAogICAgIChhbGxvdyBtYWNoLWxvb2t1cAogICAgICAgICAgICAoZ2xvYmFsLW5hbWUgImNvbS5h cHBsZS5BcHBTU08uc2VydmljZS14cGMiKSkKQEAgLTE1NSwxNCArMTU0LDkgQEAKICAgICAgICAg ICAgICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLm5ldHdvcmtkX3ByaXZpbGVnZWQiKSkpCiAK ICAgICA7OyA8cmRhcjovL3Byb2JsZW0vMjAyMDE1OTM+Ci0gICAgKHdpdGgtZmlsdGVyIChyZXF1 aXJlLWFueQotICAgICAgICAgICAgICAgICAgIChhcHBsZS1zaWduZWQtZXhlY3V0YWJsZT8pCi0g ICAgICAgICAgICAgICAgICAgKHJlcXVpcmUtZW50aXRsZW1lbnQgImNvbS5hcHBsZS5hdXRoa2l0 LmNsaWVudCIpCi0gICAgICAgICAgICAgICAgICAgKHJlcXVpcmUtZW50aXRsZW1lbnQgImNvbS5h cHBsZS5hdXRoa2l0LmNsaWVudC5wcml2YXRlIikKLSAgICAgICAgICAgICAgICAgICAocmVxdWly ZS1lbnRpdGxlbWVudCAiY29tLmFwcGxlLmF1dGhraXQuY2xpZW50LmludGVybmFsIikpCi0gICAg ICAgIChhbGxvdyBtYWNoLWxvb2t1cAotICAgICAgICAgICAgICAgKGdsb2JhbC1uYW1lICJjb20u YXBwbGUuYWsuYW5pc2V0dGUueHBjIikKLSAgICAgICAgICAgICAgIChnbG9iYWwtbmFtZSAiY29t LmFwcGxlLmFrLmF1dGgueHBjIikpKQorICAgIChhbGxvdyBtYWNoLWxvb2t1cAorICAgICAgICAo Z2xvYmFsLW5hbWUgImNvbS5hcHBsZS5hay5hbmlzZXR0ZS54cGMiKQorICAgICAgICAoZ2xvYmFs LW5hbWUgImNvbS5hcHBsZS5hay5hdXRoLnhwYyIpKQogCiAgICAgOzsgPHJkYXI6Ly9wcm9ibGVt LzE1ODk3NzgxPgogICAgIChhbGxvdyBtYWNoLWxvb2t1cApAQCAtMjgxLDkgKzI3NSw4IEBACiAg ICAgICAgIChtb2JpbGUtcHJlZmVyZW5jZXMtcmVhZCAiY29tLmFwcGxlLmhhbmd0cmFjZXIiKQog CiAgICAgICAgIDs7IDxyZGFyOi8vcHJvYmxlbS85MDkwNjI3PgotICAgICAgICAod2l0aC1maWx0 ZXIgKGFwcGxlLXNpZ25lZC1leGVjdXRhYmxlPykKLSAgICAgICAgICAoYWxsb3cgbWFjaC1sb29r dXAKLSAgICAgICAgICAgICAgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUuUmVwb3J0Q3Jhc2gu U2ltdWxhdGVDcmFzaCIpKSkpCisgICAgICAgIChhbGxvdyBtYWNoLWxvb2t1cAorICAgICAgICAg ICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLm9zYW5hbHl0aWNzLm9zYW5hbHl0aWNzaGVscGVy IikpKQogCiAoZGVmaW5lLW9uY2UgKGxvZ2QtZGlhZ25vc3RpYy1wYXRocykKICAgICAocmVxdWly ZS1hbnkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxl cy9pb3MvY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50LnNiIGIvU291cmNlL1dlYktpdC9SZXNv dXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQuc2IK aW5kZXggZGZjZGUxZmZlMmJmY2I5MjYxYzRkZTgxYWM3ZWIyMjUzMDQzYzlkMy4uNTg5MzM3ODI2 YTRhMGU1MDc1NjkxZjRhYmY3ZTI4YjkwZThlMzE1YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9SZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LldlYkNvbnRl bnQuc2IKKysrIGIvU291cmNlL1dlYktpdC9SZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9j b20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQuc2IKQEAgLTM5NCwxNiArMzk0LDEwIEBACiAKIChk ZW55IGZpbGUtd3JpdGUtbW91bnQgZmlsZS13cml0ZS11bm1vdW50KQogCi0oYWxsb3cgZmlsZS1y ZWFkLW1ldGFkYXRhICh3aXRoIG5vLXRpbWVzKQotICAgICAgICh2bm9kZS10eXBlIERJUkVDVE9S WSkpCi0od2l0aC1maWx0ZXIgKGFwcGxlLXNpZ25lZC1leGVjdXRhYmxlPykKLSAgKGFsbG93IGZp bGUtcmVhZC1tZXRhZGF0YQotICAgICAgICAgKHZub2RlLXR5cGUgRElSRUNUT1JZKSkpCisoYWxs b3cgZmlsZS1yZWFkLW1ldGFkYXRhCisgICAgKHZub2RlLXR5cGUgRElSRUNUT1JZKSkKIAotKHdp dGgtZmlsdGVyIChhcHBsZS1zaWduZWQtZXhlY3V0YWJsZT8pCi0gIChtYW5hZ2VkLWNvbmZpZ3Vy YXRpb24tcmVhZCAiQ2xvdWRDb25maWd1cmF0aW9uRGV0YWlscy5wbGlzdCIpCi0gIChtYW5hZ2Vk LWNvbmZpZ3VyYXRpb24tcmVhZCAiQ2xvdWRDb25maWd1cmF0aW9uU2V0QXNpZGVEZXRhaWxzLnBs aXN0IikKLSAgKG1vYmlsZS1wcmVmZXJlbmNlcy1yZWFkICJjb20uYXBwbGUuc2VjdXJpdHkiKSkK Kyhtb2JpbGUtcHJlZmVyZW5jZXMtcmVhZCAiY29tLmFwcGxlLnNlY3VyaXR5IikKIAogKHdpdGgt ZmlsdGVyIChzeXN0ZW0tYXR0cmlidXRlIGFwcGxlLWludGVybmFsKQogICAobW9iaWxlLXByZWZl cmVuY2VzLXJlYWQgImNvbS5hcHBsZS5Qcm90b3R5cGVUb29scyIpKQpAQCAtNjAzLDkgKzU5Nyw2 IEBACiAoYWxsb3cgcHJvY2Vzcy1pbmZvLXJ1c2FnZSAodGFyZ2V0IHNlbGYpKQogKGFsbG93IHBy b2Nlc3MtaW5mby1jb2Rlc2lnbmF0dXJlICh0YXJnZXQgc2VsZikpCiAKLSh3aXRoLWZpbHRlciAo YXBwbGUtc2lnbmVkLWV4ZWN1dGFibGU/KQotICAgIChtb2JpbGUtcHJlZmVyZW5jZXMtcmVhZCAi Y29tLmFwcGxlLmRlbW8tc2V0dGluZ3MiKSkKLQogOzs7CiA7OzsgRW5kIGNvbW1vbi5zYiBjb250 ZW50CiA7OzsK