209901 2020-04-02 06:02:52 -0700 [Flatpak SDK] Path references shouldn't point to the sandbox in compile_commands.json 2020-05-14 02:42:15 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 svillar pnormand pnormand webkit-bug-importer zan oldest_to_newest 1636862 0 svillar 2020-04-02 06:02:52 -0700 The problem is that the paths specified in the compilation database are flatpak's paths, so any tool using the compilation database like ycmd, ccls, etc... is unable to find references to the source files in it. 1636872 1 svillar 2020-04-02 06:47:16 -0700 BTW for those using VSCode there is a workaround. Just need to use path mappings setting, for example: "ccls.clang.pathMappings": [ "/app/webkit>PATH_TO_YOUR_WEBKIT_CHECKOUT_ROOT" ], Note the ">" in between paths, it's superimportant :) 1637276 2 pnormand 2020-04-03 01:35:18 -0700 Is there something to fix then? Or this is "only" a matter of documentation :) 1637308 3 pnormand 2020-04-03 04:53:32 -0700 What's your use-case for this? Are you building WebKit from VSCode? 1638231 4 svillar 2020-04-06 12:23:24 -0700 (In reply to Philippe Normand from comment #3) > What's your use-case for this? Are you building WebKit from VSCode? The use case is having semantic autocompletion when using LSP tools with different editors: VSCode, emacs..., is not about building. 1648253 5 pnormand 2020-05-02 10:59:49 -0700 So you use LSP in Emacs for WebKit dev? Can you share your config? :D 1648497 6 398360 svillar 2020-05-04 05:38:03 -0700 Created attachment 398360 Emacs config Not my default editor anymore, but here you are the relevant bits. Note that the path mapping setting is not used anymore as I'm using jhbuild again because I could not make it work with flatpak builds. 1649130 7 pnormand 2020-05-05 02:06:06 -0700 Perhaps the SDK could ship ccls and have it running in the sandbox. This needs investigation but is down below in my TODO. 1650607 8 398863 pnormand 2020-05-08 08:49:45 -0700 Created attachment 398863 Patch 1651658 9 pnormand 2020-05-12 01:09:47 -0700 (In reply to Philippe Normand from comment #3) > What's your use-case for this? Are you building WebKit from VSCode? FWIW I now have compilation errors reported in Emacs thanks to LSP/CCLS. 1652564 10 ews-feeder 2020-05-14 02:41:47 -0700 Committed r261681: <https://trac.webkit.org/changeset/261681> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398863. 1652565 11 webkit-bug-importer 2020-05-14 02:42:15 -0700 <rdar://problem/63220932> 398360 2020-05-04 05:38:03 -0700 2020-05-04 05:38:03 -0700 Emacs config emacs-config.tgz application/x-compressed-tar 1836 svillar H4sIAAAAAAAAA+3WV1DT+RYH8ABSpUoVEBAQWSKQBgFCkSBFULogqGAgkRYMBAjSDRrAFRUMNRLp KE1acJFFepEmVaUsyCLiLhCKlKWz+rAz3rn3zr7c3Z078/+8nPnN7zz8Hs6c7y+A5IXHY4iq+AA/ NRxezSMU9L8H+UITgfhaoUgNyLf1KxhUAw6CwjU1EF/aIDANEOTLAQ4HyUH+grf8m6CAQAxRTg4U gCN6eBH+e9+f3f+fkr3LxSXKW+4CYgv4l0kAtTlO+CggBaP6XKE1lAU0FtnpLxIr0kUhCkQoB1P0 k9A4ZklplcPYUCydsr+CVCir8kHJXuZCCF4a7NmdtYN/7u3lu31P0yQUg87IYTl+aJeWI9ylUdr0 lE4RYVxBP6HNLSzEnNGvKTCUyl+a3atv1qZOwduHo7lVEYEcimBfztJgC/VHMTbxjG7F1LSjr3ke uFI3uD4pKmw+1QVjL9xJDvDR8mgKrx0/SHihUjIQVtKVaIJDHEVE23UdiuaRaGAtY5/MNbdR423G pkRnqjLoUByxUWkP1hgCFWpOmHOWqqO3FfRm2OnQklDVsutEdg6kSMV7gwMWja403Rht5Y3xLD4J tSxNunO2s9WTIQVHqr5f4NKe56M1fZmZ8ufKb0ea4uQkR5vfy2zNT7qfbx8zx7r0Oh0+WFuR3xfz j0AfWGL7MKbFy/5T5HMskh/JRXHmN4uKT0T48hTfgo+UiduWDjic4gWJTKGOEStJ6aKGdheT8zyb WZPPsRwfpLnL9hP6jT5Cbip6xzN2psXs0HPwcfAdlzFr1PssgavVmAtbBGxiQnYVz3QuAw+KGDN3 hLlxjKZiFHyHeRzsJWL2P9QUsWpOk+Uk48GOTSHMV9APw7XYQ16vroNzC2hzalPGXqaWUqPM4YNZ 3RuFzGbf72Q6CvpfPlpkc25yIAnSFTriLeotY0Dfl8TldLHLU+/kmKLsJ8EWDh/rl4XOW2T3BCXh NUkFedA46yRrTwuZs20yA4t5bvY8AxqQrRXD62gkYZKttfKUFXkPTH5QrvmQJ+ui8Gr35x4UOequ dlWLsZhO9CUzlQ754FvLsKzn4DUd81rw0eCTnOIvd4VIxnVSXWNSTS3hAjeOTHE8YuesEegOZg85 uWOWVuOir8fgGHk9RYVrZa5+Im9kR1mDE9+cfbwFM/A607pz45P9dCECTZuxuMwwiVUeEwnmin5h /Kbq7lvKTwLGYC8Tm5ufHuNvZWZW7avzLFNnCelmG1VthOmmeema8IMMzmB6Mt96HEWp30RlCbRU 2EfBwHSnx+6v9Nqu6nRMNoQNQ9+FbZAXd16rZtiOjw/6nn66k2IsHE2yGSxhodUjKtj0mc+CbPx2 NmX12sNwtpQFycuuzGOytJH+KP7atl9sOS528g1ie9Jetfj/mBPMpyWZFSmekEiwa1fnGOk+okKb UWEltJyeKJaU2KaS85eUHU/8tM/qaL07Wp32TswIC743s9nCK2/Dmm54zfaKm2d+s3DG/KkwPnaB rLpFbiOSR+76YU+De0LKKbQnCgq8808EiTPqVeGlA/amSfQGxEh+CAjl9kLmNtnkt+NLSeF1FItN gWf3WydxFbFnZp21ajnBpmc/BPs8R3kgnbp49VIDp1I3xc0vxETMcncsSbpl2VJCmOfagmzxZgl4 1VBe2+Pb+cuvV7R+TpU95rtZStLffebZvQvGBDYaIDarOcO1++pZqs1urMbw/tOLDvAf/bH1/YgE b5x7YMBf8Qn4k/yHIOGIP/JfA4mEfcl/BBICBfL/7/A1/7cPf5v/30wCKNnuPGEcwqun3oCGQM4Z ZtewkbzJLOBQcOgozsO5wF2tUtEskLrw7kEl/UH16YEVebK8bKbM2QlbmNpFv1Es1v3YDN5FTgjB v2ouulPZcc0U/8qDg+C/4s3sLLw3OEbjgDkJ11qebl33fbmdd21o5tIaXoKGj+nP0bWYDM3f15hI DGjnQPK7oOsnJ10wgYueYYwffUBBUWWWkcaPoUFpEDC/IV8u883jGkcIsRwTx58e3SDXLhKZiyN6 phSvQEQW5sQ1rVrfXAhJzTV0FYFe6RxhsxhNEleaX/XgWSApFZaKnu8UFtbaZsuv466QPmH1XtRh RulAIU4nYSXxoSD3r0+LagXY3h4dSkHr7UHjL/cNp3zAKL57azCQnedQtr57c8JJEJs96DJ3XWls yMjmauWRXxsJJ2Csv/UJKmz5OtQWfXTuG7KJikolrhf8fGAkIpAxZUrzjlxM1lYOC3APvS1mV10/ 7RTDlNMVn5CVHqHn9jz8IbHxO/sxewZnVFJFNWqNOZxAtaKVWgabpEtf1UXdT9BrUzaK/MzoR3C7 qsGtvy9ZK36pA9YljEjvRFKLkWEna6JYyqeexZaz/dOTBQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA /m6/A/zsEnQAKAAA 398863 2020-05-08 08:49:45 -0700 2020-05-14 02:41:48 -0700 Patch bug-209901-20200508164944.patch text/plain 2608 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxMzc1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggY2JlNDNjMjZkMTE5YWVlYTQ4ZTdkMmEyNjQ4NmM1NTFm MmJkZjA0Yy4uMGM4OGZjYzk0ZGJiZTcxYzNhNTQ0MDJkZjA2MGE2NmYxYzllOTU2ZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDIwLTA1LTA4ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4K KworICAgICAgICBbRmxhdHBhayBTREtdIFBhdGggcmVmZXJlbmNlcyBzaG91bGRuJ3QgcG9pbnQg dG8gdGhlIHNhbmRib3ggaW4gY29tcGlsZV9jb21tYW5kcy5qc29uCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDk5MDEKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgY2NscyB0byB0aGUgU0RLLiBJdCBj YW4gdGhlbiBiZSB1c2VkIHRocm91Z2ggYSB3cmFwcGVyIHNjcmlwdCBieSBFbWFjcydzIGxzcC1t b2RlLgorICAgICAgICAKKyAgICAgICAgKiBidWlsZHN0cmVhbS9lbGVtZW50cy9zZGstYnVpbGQt ZGVwZW5kcy9yYXBpZGpzb24uYnN0OiBBZGRlZC4KKyAgICAgICAgKiBidWlsZHN0cmVhbS9lbGVt ZW50cy9zZGstcGxhdGZvcm0uYnN0OgorICAgICAgICAqIGJ1aWxkc3RyZWFtL2VsZW1lbnRzL3Nk ay9jY2xzLmJzdDogQWRkZWQuCisKIDIwMjAtMDUtMDggIFBhdWxvIE1hdG9zICA8cG1hdG9zQGln YWxpYS5jb20+CiAKICAgICAgICAgQWRkIG15c2VsZiBhcyBjb21taXR0ZXIgdG8gY29udHJpYnV0 b3JzLmpzb24KZGlmZiAtLWdpdCBhL1Rvb2xzL2J1aWxkc3RyZWFtL2VsZW1lbnRzL3Nkay1idWls ZC1kZXBlbmRzL3JhcGlkanNvbi5ic3QgYi9Ub29scy9idWlsZHN0cmVhbS9lbGVtZW50cy9zZGst YnVpbGQtZGVwZW5kcy9yYXBpZGpzb24uYnN0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjI0NTdjZDIyOTgyMjgxMTNi MDg0M2M0NTA1M2I0OGZlMGU5ZDU4YTYKLS0tIC9kZXYvbnVsbAorKysgYi9Ub29scy9idWlsZHN0 cmVhbS9lbGVtZW50cy9zZGstYnVpbGQtZGVwZW5kcy9yYXBpZGpzb24uYnN0CkBAIC0wLDAgKzEs MTMgQEAKK2tpbmQ6IGNtYWtlCisKK2J1aWxkLWRlcGVuZHM6CistIGZyZWVkZXNrdG9wLXNkay5i c3Q6cHVibGljLXN0YWNrcy9idWlsZHN5c3RlbS1jbWFrZS5ic3QKKworZGVwZW5kczoKKy0gZnJl ZWRlc2t0b3Atc2RrLmJzdDpib290c3RyYXAtaW1wb3J0LmJzdAorCitzb3VyY2VzOgorLSBraW5k OiBnaXRfdGFnCisgIHVybDogZ2l0aHViX2NvbTpUZW5jZW50L3JhcGlkanNvbgorICB0cmFjazog bWFzdGVyCisgIHJlZjogdjEuMS4wLTU0OS1nOGY0YzAyMWZhMmYxZTAwMWQyMzc2MDk1OTI4ZmMw NTMyYWRmMmFlNgpkaWZmIC0tZ2l0IGEvVG9vbHMvYnVpbGRzdHJlYW0vZWxlbWVudHMvc2RrLXBs YXRmb3JtLmJzdCBiL1Rvb2xzL2J1aWxkc3RyZWFtL2VsZW1lbnRzL3Nkay1wbGF0Zm9ybS5ic3QK aW5kZXggNGYwNGZkMDljYmZkNzA3OGNjMGRlNzQ2YTc5ZjBiNDJiNjM0YmRmZi4uMDc2ZmVlNWU3 MzcxNDVlOGM0OTBkNjZiNjNhMDkzYmFiMTk0ZjQ0MSAxMDA2NDQKLS0tIGEvVG9vbHMvYnVpbGRz dHJlYW0vZWxlbWVudHMvc2RrLXBsYXRmb3JtLmJzdAorKysgYi9Ub29scy9idWlsZHN0cmVhbS9l bGVtZW50cy9zZGstcGxhdGZvcm0uYnN0CkBAIC0xNCw2ICsxNCw3IEBAIGRlcGVuZHM6CiAtIHNk ay9hdGsuYnN0CiAtIHNkay9icm90bGkuYnN0CiAtIHNkay9jYXBucC5ic3QKKy0gc2RrL2NjbHMu YnN0CiAtIHNkay9lbmNoYW50LTIuYnN0CiAtIHNkay9nbGliLW5ldHdvcmtpbmcuYnN0CiAtIHNk ay9nbGliLmJzdApkaWZmIC0tZ2l0IGEvVG9vbHMvYnVpbGRzdHJlYW0vZWxlbWVudHMvc2RrL2Nj bHMuYnN0IGIvVG9vbHMvYnVpbGRzdHJlYW0vZWxlbWVudHMvc2RrL2NjbHMuYnN0Cm5ldyBmaWxl IG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAuLjZiYjA1N2NhYWZlMTkyNWM4ZmUzZjBjMjI0MTZiNzk3NzU0MWY4MDkKLS0tIC9kZXYvbnVs bAorKysgYi9Ub29scy9idWlsZHN0cmVhbS9lbGVtZW50cy9zZGsvY2Nscy5ic3QKQEAgLTAsMCAr MSwxNSBAQAora2luZDogY21ha2UKKworc291cmNlczoKKy0ga2luZDogZ2l0X3RhZworICB1cmw6 IGdpdGh1Yl9jb206TWFza1JheS9jY2xzLmdpdAorICB0cmFjazogMC4yMDE5MDgyMy42CisgIHJl ZjogMC4yMDE5MDgyMy42LTAtZ2IzZDY5NGI4YmQ0MTA1ZmZlNGU1N2Y5YWUyOTAyNDVhZWE2ZWYw ZmMKKworYnVpbGQtZGVwZW5kczoKKy0gZnJlZWRlc2t0b3Atc2RrLmJzdDpwdWJsaWMtc3RhY2tz L2J1aWxkc3lzdGVtLWNtYWtlLmJzdAorLSBzZGstYnVpbGQtZGVwZW5kcy9yYXBpZGpzb24uYnN0 CisKK2RlcGVuZHM6CistIGZyZWVkZXNrdG9wLXNkay5ic3Q6Ym9vdHN0cmFwLWltcG9ydC5ic3QK Ky0gZnJlZWRlc2t0b3Atc2RrLmJzdDpjb21wb25lbnRzL2xsdm0uYnN0Cg==