209873 2020-04-01 13:20:19 -0700 Regression(r257963) didFailProvisionalNavigation delegate no longer gets called when cancelling a cross-site provisional navigation 2020-04-01 14:01:46 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 208670 1 cdumez cdumez achristensen beidson david_quesada ggaren webkit-bug-importer oldest_to_newest 1636624 0 cdumez 2020-04-01 13:20:19 -0700 Regression(PSON) didFailProvisionalNavigation delegate no longer gets called when cancelling a cross-site provisional navigation. 1636625 1 cdumez 2020-04-01 13:20:29 -0700 <rdar://problem/61132068> 1636630 2 395196 cdumez 2020-04-01 13:33:48 -0700 Created attachment 395196 Patch 1636637 3 395196 achristensen 2020-04-01 13:38:52 -0700 Comment on attachment 395196 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395196&action=review > Source/WebKit/UIProcess/ProvisionalPageProxy.cpp:136 > + FrameInfoData frameInfo { FrameInfoData is supposed to only be created in the web process because otherwise it is out of date and the frame could've navigated underneath us. I don't see another way to do this though. 1636650 4 ews-feeder 2020-04-01 14:01:46 -0700 Committed r259362: <https://trac.webkit.org/changeset/259362> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395196. 395196 2020-04-01 13:33:48 -0700 2020-04-01 14:01:46 -0700 Patch bug-209873-20200401133347.patch text/plain 5758 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5MzQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDRkNWFlNmNmOGRlNDdhNzky ODE3YjI0ZjZmN2NiOGZjNmFmMzEzYjMuLjhjNGE4NWQyYTBhZDViODk4MDgyM2U1OGExN2QxZWZh Njg4OTM1OGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMjAtMDQtMDEgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBSZWdyZXNzaW9uKHIyNTc5NjMpIGRp ZEZhaWxQcm92aXNpb25hbE5hdmlnYXRpb24gZGVsZWdhdGUgbm8gbG9uZ2VyIGdldHMgY2FsbGVk IHdoZW4gY2FuY2VsbGluZyBhIGNyb3NzLXNpdGUgcHJvdmlzaW9uYWwgbmF2aWdhdGlvbgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA5ODczCisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS82MTEzMjA2OD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBQcm92aXNpb25hbFBhZ2VQcm94eTo6Y2FuY2VsKCkgd2Fz IGNhbGxpbmcgZGlkRmFpbFByb3Zpc2lvbmFsTG9hZEZvckZyYW1lKCkgd2FzIG5vdCBwYXNzaW5n IGEgdmFsaWQKKyAgICAgICAgRnJhbWVJbmZvRGF0YSBzdHJ1Y3QgYXMgcGFyYW1ldGVyLiBBcyBh IHJlc3VsdCwgRnJhbWVJbmZvRGF0YTo6aXNNYWluRnJhbWUgZW5kZWQgdXAgYmVpbmcgZmFsc2UK KyAgICAgICAgaW5zdGVhZCBvZiB0cnVlLiBUaGlzIHdhcyBhbiBpc3N1ZSBiZWNhdXNlIE5hdmln YXRpb25TdGF0ZTo6TmF2aWdhdGlvbkNsaWVudDo6ZGlkRmFpbFByb3Zpc2lvbmFsTmF2aWdhdGlv bldpdGhFcnJvcigpCisgICAgICAgIHdhcyByZWx5aW5nIG9uIHRoaXMgZmxhZyB0byBkZWNpZGUg d2hldGhlciB0byBjYWxsIHdlYlZpZXdEaWRGYWlsUHJvdmlzaW9uYWxOYXZpZ2F0aW9uV2l0aEVy cm9yIG9yCisgICAgICAgIHdlYlZpZXdOYXZpZ2F0aW9uRGlkRmFpbFByb3Zpc2lvbmFsTG9hZElu U3ViZnJhbWVXaXRoRXJyb3IsIHNpbmNlIHIyNTc5NjMuCisKKyAgICAgICAgQ2hhbmdlIGlzIGNv dmVyZWQgYnkgbmV3IEFQSSB0ZXN0cy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9Qcm92aXNpb25h bFBhZ2VQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OlByb3Zpc2lvbmFsUGFnZVByb3h5Ojpj YW5jZWwpOgorCiAyMDIwLTA0LTAxICB5b3Vlbm4gZmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4K IAogICAgICAgICBTdXBwb3J0IHJlc29sdXRpb24gb2YgSVB2NiBTVFVOL1RVUk4gYWRkcmVzc2Vz CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Qcm92aXNpb25hbFBhZ2VQcm94 eS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Qcm92aXNpb25hbFBhZ2VQcm94eS5jcHAK aW5kZXggMzkwNTZiNmM4ZWZkMTZkMzFkZTkxNjFlZGQ1ZGU0MjgwYmE1YzcxMy4uYzg2Y2U4MTFj MTE4ODExNjE3MTc4MDk1ZDYyMDkwMTJiMGQyOGQ2NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvUHJvdmlzaW9uYWxQYWdlUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL1Byb3Zpc2lvbmFsUGFnZVByb3h5LmNwcApAQCAtMTMzLDcgKzEzMywxNCBAQCB2 b2lkIFByb3Zpc2lvbmFsUGFnZVByb3h5OjpjYW5jZWwoKQogICAgIEFTU0VSVChtX21haW5GcmFt ZSk7CiAgICAgYXV0byBlcnJvciA9IFdlYktpdDo6Y2FuY2VsbGVkRXJyb3IobV9yZXF1ZXN0KTsK ICAgICBlcnJvci5zZXRUeXBlKFdlYkNvcmU6OlJlc291cmNlRXJyb3I6OlR5cGU6OkNhbmNlbGxh dGlvbik7Ci0gICAgZGlkRmFpbFByb3Zpc2lvbmFsTG9hZEZvckZyYW1lKG1fbWFpbkZyYW1lLT5m cmFtZUlEKCksIHsgfSwgeyB9LCBtX25hdmlnYXRpb25JRCwgbV9wcm92aXNpb25hbExvYWRVUkws IGVycm9yLCBXZWJDb3JlOjpXaWxsQ29udGludWVMb2FkaW5nOjpObywgVXNlckRhdGEgeyB9KTsg Ly8gV2lsbCBkZWxldGUgfHRoaXN8LgorICAgIEZyYW1lSW5mb0RhdGEgZnJhbWVJbmZvIHsKKyAg ICAgICAgdHJ1ZSwgLy8gaXNNYWluRnJhbWUKKyAgICAgICAgbV9yZXF1ZXN0LAorICAgICAgICBT ZWN1cml0eU9yaWdpbkRhdGE6OmZyb21VUkwobV9yZXF1ZXN0LnVybCgpKSwKKyAgICAgICAgbV9t YWluRnJhbWUtPmZyYW1lSUQoKSwKKyAgICAgICAgV1RGOjpudWxsb3B0LAorICAgIH07CisgICAg ZGlkRmFpbFByb3Zpc2lvbmFsTG9hZEZvckZyYW1lKG1fbWFpbkZyYW1lLT5mcmFtZUlEKCksIFdU Rk1vdmUoZnJhbWVJbmZvKSwgUmVzb3VyY2VSZXF1ZXN0IHsgbV9yZXF1ZXN0IH0sIG1fbmF2aWdh dGlvbklELCBtX3Byb3Zpc2lvbmFsTG9hZFVSTCwgZXJyb3IsIFdlYkNvcmU6OldpbGxDb250aW51 ZUxvYWRpbmc6Ok5vLCBVc2VyRGF0YSB7IH0pOyAvLyBXaWxsIGRlbGV0ZSB8dGhpc3wuCiB9CiAK IHZvaWQgUHJvdmlzaW9uYWxQYWdlUHJveHk6OmluaXRpYWxpemVXZWJQYWdlKFJlZlB0cjxBUEk6 OldlYnNpdGVQb2xpY2llcz4mJiB3ZWJzaXRlUG9saWNpZXMpCmRpZmYgLS1naXQgYS9Ub29scy9D aGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjVhZDY4YTVkMjg0MDg5NDdkOTA1ZjI3 YzQxYWZjYzUzMmFjMDVhMi4uZDMyYjQzYzNmYTY0YmE4Njg4ZDRmNTNmZDBlMGIyNTgxYTViYzIx NyAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE1IEBACisyMDIwLTA0LTAxICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+ CisKKyAgICAgICAgUmVncmVzc2lvbihyMjU3OTYzKSBkaWRGYWlsUHJvdmlzaW9uYWxOYXZpZ2F0 aW9uIGRlbGVnYXRlIG5vIGxvbmdlciBnZXRzIGNhbGxlZCB3aGVuIGNhbmNlbGxpbmcgYSBjcm9z cy1zaXRlIHByb3Zpc2lvbmFsIG5hdmlnYXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIwOTg3MworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjEx MzIwNjg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QWRkIEFQSSB0ZXN0IGNvdmVyYWdlLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9X ZWJLaXRDb2NvYS9Qcm9jZXNzU3dhcE9uTmF2aWdhdGlvbi5tbToKKwogMjAyMC0wNC0wMSAgUGhp bGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0ZsYXRwYWsg U0RLXSBNaWdyYXRpb24gdG8gdmVyc2lvbiAwLjIKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJL aXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvUHJvY2Vzc1N3YXBPbk5hdmlnYXRpb24ubW0gYi9Ub29s cy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1Byb2Nlc3NTd2FwT25OYXZpZ2F0aW9u Lm1tCmluZGV4IGUyNzMyNTY3MjQwMDAxYjdkN2FhNGVmMDIyYmRlZDk2YjdlNWNiZjQuLjc5ZWIw Y2M1YWY0NTJlZThkYjViYmI1ZWIwY2NlMTEzYTA0OTJkN2MgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rl c3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvUHJvY2Vzc1N3YXBPbk5hdmlnYXRpb24ubW0K KysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9Qcm9jZXNzU3dhcE9u TmF2aWdhdGlvbi5tbQpAQCAtMzEyNCw2ICszMTI0LDUwIEBAIFRFU1QoUHJvY2Vzc1N3YXAsIE5h dmlnYXRlQ3Jvc3NTaXRlQmVmb3JlUGFnZUxvYWRFbmQpCiAgICAgRVhQRUNUX1dLX1NUUkVRKEAi cHNvbjovL3d3dy5hcHBsZS5jb20vbWFpbi5odG1sIiwgW1t3ZWJWaWV3IFVSTF0gYWJzb2x1dGVT dHJpbmddKTsKIH0KIAorc3RhdGljIHZvaWQgcnVuQ2FuY2VsQ3Jvc3NTaXRlUHJvdmlzaW9uYWxM b2FkVGVzdChTaG91bGRFbmFibGVQU09OIHNob3VsZEVuYWJsZVBTT04pCit7CisgICAgYXV0byBw cm9jZXNzUG9vbENvbmZpZ3VyYXRpb24gPSBwc29uUHJvY2Vzc1Bvb2xDb25maWd1cmF0aW9uKCk7 CisgICAgcHJvY2Vzc1Bvb2xDb25maWd1cmF0aW9uLmdldCgpLnByb2Nlc3NTd2Fwc09uTmF2aWdh dGlvbiA9IHNob3VsZEVuYWJsZVBTT04gPT0gU2hvdWxkRW5hYmxlUFNPTjo6WWVzOworICAgIGF1 dG8gcHJvY2Vzc1Bvb2wgPSBhZG9wdE5TKFtbV0tQcm9jZXNzUG9vbCBhbGxvY10gX2luaXRXaXRo Q29uZmlndXJhdGlvbjpwcm9jZXNzUG9vbENvbmZpZ3VyYXRpb24uZ2V0KCldKTsKKworICAgIGF1 dG8gd2ViVmlld0NvbmZpZ3VyYXRpb24gPSBhZG9wdE5TKFtbV0tXZWJWaWV3Q29uZmlndXJhdGlv biBhbGxvY10gaW5pdF0pOworICAgIFt3ZWJWaWV3Q29uZmlndXJhdGlvbiBzZXRQcm9jZXNzUG9v bDpwcm9jZXNzUG9vbC5nZXQoKV07CisgICAgYXV0byBoYW5kbGVyID0gYWRvcHROUyhbW1BTT05T Y2hlbWUgYWxsb2NdIGluaXRdKTsKKyAgICBbd2ViVmlld0NvbmZpZ3VyYXRpb24gc2V0VVJMU2No ZW1lSGFuZGxlcjpoYW5kbGVyLmdldCgpIGZvclVSTFNjaGVtZTpAIlBTT04iXTsKKworICAgIGF1 dG8gd2ViVmlldyA9IGFkb3B0TlMoW1tXS1dlYlZpZXcgYWxsb2NdIGluaXRXaXRoRnJhbWU6TlNN YWtlUmVjdCgwLCAwLCA4MDAsIDYwMCkgY29uZmlndXJhdGlvbjp3ZWJWaWV3Q29uZmlndXJhdGlv bi5nZXQoKV0pOworICAgIGF1dG8gbmF2aWdhdGlvbkRlbGVnYXRlID0gYWRvcHROUyhbW1BTT05O YXZpZ2F0aW9uRGVsZWdhdGUgYWxsb2NdIGluaXRdKTsKKyAgICBbd2ViVmlldyBzZXROYXZpZ2F0 aW9uRGVsZWdhdGU6bmF2aWdhdGlvbkRlbGVnYXRlLmdldCgpXTsKKworICAgIGZhaWxlZCA9IGZh bHNlOworICAgIE5TVVJMUmVxdWVzdCAqcmVxdWVzdCA9IFtOU1VSTFJlcXVlc3QgcmVxdWVzdFdp dGhVUkw6W05TVVJMIFVSTFdpdGhTdHJpbmc6QCJwc29uOi8vd3d3LndlYmtpdC5vcmcvbWFpbi5o dG1sIl1dOworICAgIFt3ZWJWaWV3IGxvYWRSZXF1ZXN0OnJlcXVlc3RdOworCisgICAgVGVzdFdl YktpdEFQSTo6VXRpbDo6cnVuKCZkb25lKTsKKyAgICBkb25lID0gZmFsc2U7CisKKyAgICBFWFBF Q1RfRkFMU0UoZmFpbGVkKTsKKworICAgIG5hdmlnYXRpb25EZWxlZ2F0ZS0+ZGlkU3RhcnRQcm92 aXNpb25hbE5hdmlnYXRpb25IYW5kbGVyID0gXnsKKyAgICAgICAgW3dlYlZpZXcgc3RvcExvYWRp bmddOworICAgIH07CisKKyAgICByZXF1ZXN0ID0gW05TVVJMUmVxdWVzdCByZXF1ZXN0V2l0aFVS TDpbTlNVUkwgVVJMV2l0aFN0cmluZzpAInBzb246Ly93d3cuYXBwbGUuY29tL21haW4uaHRtbCJd XTsKKyAgICBbd2ViVmlldyBsb2FkUmVxdWVzdDpyZXF1ZXN0XTsKKworICAgIFRlc3RXZWJLaXRB UEk6OlV0aWw6OnJ1bigmZmFpbGVkKTsKKyAgICBmYWlsZWQgPSBmYWxzZTsKK30KKworVEVTVChQ cm9jZXNzU3dhcCwgQ2FuY2VsQ3Jvc3NTaXRlUHJvdmlzaW9uYWxMb2FkV2l0aG91dFBTT04pCit7 CisgICAgcnVuQ2FuY2VsQ3Jvc3NTaXRlUHJvdmlzaW9uYWxMb2FkVGVzdChTaG91bGRFbmFibGVQ U09OOjpObyk7Cit9CisKK1RFU1QoUHJvY2Vzc1N3YXAsIENhbmNlbENyb3NzU2l0ZVByb3Zpc2lv bmFsTG9hZFdpdGhQU09OKQoreworICAgIHJ1bkNhbmNlbENyb3NzU2l0ZVByb3Zpc2lvbmFsTG9h ZFRlc3QoU2hvdWxkRW5hYmxlUFNPTjo6WWVzKTsKK30KIAogVEVTVChQcm9jZXNzU3dhcCwgRG9T YW1lU2l0ZU5hdmlnYXRpb25BZnRlckNyb3NzU2l0ZVByb3Zpc2lvbmFsTG9hZFN0YXJ0ZWQpCiB7 Cg==