209868 2020-04-01 11:21:27 -0700 Context menu for local storage puts quotes around key and value 2020-04-02 18:25:15 -0700 1 1 1 Unclassified WebKit Web Inspector Safari 13 Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jonlee hi hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1636579 0 jonlee 2020-04-01 11:21:27 -0700 In the LocalStorage table, right clicking on a cell shows a context menu that either says Edit "Key" Edit "Value" based on the cell column. Using quotes is weird because it's not the name of the key, and unnecessary. Typically it would just say Edit Key Edit Value 1636614 1 395193 hi 2020-04-01 12:58:14 -0700 Created attachment 395193 Patch 1636620 2 395193 joepeck 2020-04-01 13:07:30 -0700 Comment on attachment 395193 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395193&action=review rs=me > Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:454 > localizedStrings["Edit \u201C%s\u201D"] = "Edit \u201C%s\u201D"; Seems this string is still used somewhere. Does its case still make sense? 1637158 3 395193 hi 2020-04-02 16:56:21 -0700 Comment on attachment 395193 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395193&action=review >> Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:454 >> localizedStrings["Edit \u201C%s\u201D"] = "Edit \u201C%s\u201D"; > > Seems this string is still used somewhere. Does its case still make sense? Actually, it isn't 😅 I had an out-of-date localizedStrings.js. 1637159 4 395325 hi 2020-04-02 16:57:09 -0700 Created attachment 395325 Patch 1637186 5 ews-feeder 2020-04-02 18:24:53 -0700 Committed r259437: <https://trac.webkit.org/changeset/259437> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395325. 1637187 6 webkit-bug-importer 2020-04-02 18:25:15 -0700 <rdar://problem/61236498> 395193 2020-04-01 12:58:14 -0700 2020-04-02 16:57:07 -0700 Patch bug-209868-20200401135813.patch text/plain 2865 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDAxYmQxYjQ3NzY1NDk2MjhjNzIwM2QyNmU5MzVk ZGFmMzc2MmQyMzAuLjdlNDg0ZTE1N2Q5MDI1ODhiYzMwNDJmOWE2ZTU2OTcyMzZhMmQxZjQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTA0LTAxICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBDb250ZXh0IG1lbnUgZm9y IGxvY2FsIHN0b3JhZ2UgcHV0cyBxdW90ZXMgYXJvdW5kIGtleSBhbmQgdmFsdWUKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwOTg2OAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZXJlIGFyZSBvbmx5IHR3 byBgV0kuRGF0YUdyaWRgIHRoYXQgc3VwcG9ydCBlZGl0aW5nIHJpZ2h0IG5vdy4gQm90aCBvZiB0 aGVtIHVzZSBvYnZpb3VzCisgICAgICAgIG5hbWVzIGZvciB0aGVpciBjb2x1bW5zIChlLmcuICJL ZXkiLCAiTmFtZSIsICJWYWx1ZSIsIGV0Yy4pLCBzbyByYXRoZXIgdGhhbiBxdW90ZSB0aGUgY29s dW1uCisgICAgICAgIG5hbWUgaW4gdGhlIGNvbnRleHQgbWVudSwganVzdCBkaXNwbGF5IGl0IGFz IGlzLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9EYXRhR3JpZC5qczoKKyAgICAg ICAgKFdJLkRhdGFHcmlkLnByb3RvdHlwZS5fY29udGV4dE1lbnVJbkRhdGFUYWJsZSk6CisKKyAg ICAgICAgKiBMb2NhbGl6YXRpb25zL2VuLmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanM6CisKIDIw MjAtMDMtMzEgIEpvbiBEYXZpcyAgPGpvbmRAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZGVkIG5l dyBXZWJTb2NrZXQgaWNvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL0xvY2Fs aXphdGlvbnMvZW4ubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Mb2NhbGl6YXRpb25zL2VuLmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanMKaW5kZXggYmEw ZWU2MjVmNzUxZmQxOGQ2NWNjMGQ5MWFmMThhZjIzZTI3ODRlMS4uNWMwOTBhM2Q2NTM3NWUwYmYz MGQ0NTFmYWUwMzJkYTVlNmRhZTYzNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJ L0xvY2FsaXphdGlvbnMvZW4ubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qcworKysgYi9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvTG9jYWxpemF0aW9ucy9lbi5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpz CkBAIC00NDgsNiArNDQ4LDcgQEAgbG9jYWxpemVkU3RyaW5nc1siRHluYW1pY2FsbHkgY2FsY3Vs YXRlZCBmb3IgdGhlIHNlbGVjdGVkIGVsZW1lbnQgYW5kIGRpZCBub3QgbWEKIC8qIExhYmVsIGZv ciBhIGd1aWRlIHdpdGhpbiB0aGUgY29sb3IgcGlja2VyICovCiBsb2NhbGl6ZWRTdHJpbmdzWyJF ZGdlIG9mIHNSR0IgY29sb3Igc3BhY2UiXSA9ICJFZGdlIG9mIHNSR0IgY29sb3Igc3BhY2UiOwog bG9jYWxpemVkU3RyaW5nc1siRWRpdCJdID0gIkVkaXQiOworbG9jYWxpemVkU3RyaW5nc1siRWRp dCAlcyJdID0gIkVkaXQgJXMiOwogbG9jYWxpemVkU3RyaW5nc1siRWRpdCBCcmVha3BvaW50XHUy MDI2Il0gPSAiRWRpdCBCcmVha3BvaW50XHUyMDI2IjsKIGxvY2FsaXplZFN0cmluZ3NbIkVkaXQg TG9jYWwgT3ZlcnJpZGVcdTIwMjYiXSA9ICJFZGl0IExvY2FsIE92ZXJyaWRlXHUyMDI2IjsKIGxv Y2FsaXplZFN0cmluZ3NbIkVkaXQgXHUyMDFDJXNcdTIwMUQiXSA9ICJFZGl0IFx1MjAxQyVzXHUy MDFEIjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL0RhdGFHcmlkLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvRGF0YUdyaWQuanMKaW5kZXggMGQ3MTU5NWYzN2YyOGJhNWY5NDZiNjUyNDhhY2NkMjAwMGYx YmVmMi4uOGY2MGU3ZTcwODFhNDE1NjliYzJjZTQwZGY3MzQ3ZTQxNGZjYTYxNCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRGF0YUdyaWQuanMK KysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRGF0YUdyaWQu anMKQEAgLTE2NzAsNyArMTY3MCw3IEBAIFdJLkRhdGFHcmlkID0gY2xhc3MgRGF0YUdyaWQgZXh0 ZW5kcyBXSS5WaWV3CiAgICAgICAgICAgICAgICAgICAgICAgICBsZXQgZWxlbWVudCA9IGV2ZW50 LnRhcmdldC5jbG9zZXN0KCJ0ZCIpOwogICAgICAgICAgICAgICAgICAgICAgICAgbGV0IGNvbHVt bklkZW50aWZpZXIgPSBlbGVtZW50Ll9fY29sdW1uSWRlbnRpZmllcjsKICAgICAgICAgICAgICAg ICAgICAgICAgIGxldCBjb2x1bW5UaXRsZSA9IHRoaXMuZGF0YUdyaWQuY29sdW1ucy5nZXQoY29s dW1uSWRlbnRpZmllcilbInRpdGxlIl07Ci0gICAgICAgICAgICAgICAgICAgICAgICBjb250ZXh0 TWVudS5hcHBlbmRJdGVtKFdJLlVJU3RyaW5nKCJFZGl0IFx1MjAxQyVzXHUyMDFEIikuZm9ybWF0 KGNvbHVtblRpdGxlKSwgdGhpcy5fc3RhcnRFZGl0aW5nLmJpbmQodGhpcywgZXZlbnQudGFyZ2V0 KSk7CisgICAgICAgICAgICAgICAgICAgICAgICBjb250ZXh0TWVudS5hcHBlbmRJdGVtKFdJLlVJ U3RyaW5nKCJFZGl0ICVzIikuZm9ybWF0KGNvbHVtblRpdGxlKSwgdGhpcy5fc3RhcnRFZGl0aW5n LmJpbmQodGhpcywgZXZlbnQudGFyZ2V0KSk7CiAgICAgICAgICAgICAgICAgICAgIH0KICAgICAg ICAgICAgICAgICB9CiAK 395325 2020-04-02 16:57:09 -0700 2020-04-02 18:24:53 -0700 Patch bug-209868-20200402175708.patch text/plain 3177 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDU4ZmI0ZDA3MDE1ZDk5MmNjNDhlY2MzYWRiYmE4 Njk1Y2MyOTQ1YzAuLmQ0N2I0MDNkMGQ5MzA0NzVlYWQwMWMxZmQ4M2JkNjY2MTZjZDVhMjQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTA0LTAyICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBDb250ZXh0IG1lbnUgZm9y IGxvY2FsIHN0b3JhZ2UgcHV0cyBxdW90ZXMgYXJvdW5kIGtleSBhbmQgdmFsdWUKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwOTg2OAorCisgICAgICAg IFJldmlld2VkIGJ5IEpvc2VwaCBQZWNvcmFyby4KKworICAgICAgICBUaGVyZSBhcmUgb25seSB0 d28gYFdJLkRhdGFHcmlkYCB0aGF0IHN1cHBvcnQgZWRpdGluZyByaWdodCBub3cuIEJvdGggb2Yg dGhlbSB1c2Ugb2J2aW91cworICAgICAgICBuYW1lcyBmb3IgdGhlaXIgY29sdW1ucyAoZS5nLiAi S2V5IiwgIk5hbWUiLCAiVmFsdWUiLCBldGMuKSwgc28gcmF0aGVyIHRoYW4gcXVvdGUgdGhlIGNv bHVtbgorICAgICAgICBuYW1lIGluIHRoZSBjb250ZXh0IG1lbnUsIGp1c3QgZGlzcGxheSBpdCBh cyBpcy4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvRGF0YUdyaWQuanM6CisgICAg ICAgIChXSS5EYXRhR3JpZC5wcm90b3R5cGUuX2NvbnRleHRNZW51SW5EYXRhVGFibGUpOgorCisg ICAgICAgICogTG9jYWxpemF0aW9ucy9lbi5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzOgorCiAy MDIwLTA0LTAyICBOaWtpdGEgVmFzaWx5ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgogCiAgICAg ICAgIFdlYiBJbnNwZWN0b3I6IE5ldHdvcmsgdGFiIHN1bW1hcnkgYmFyIGppZ2dsZXMKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Mb2NhbGl6YXRpb25zL2VuLmxwcm9qL2xvY2Fs aXplZFN0cmluZ3MuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvTG9jYWxpemF0aW9ucy9lbi5s cHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzCmluZGV4IGJhMGVlNjI1Zjc1MWZkMThkNjVjYzBkOTFh ZjE4YWYyM2UyNzg0ZTEuLmFlMjNhOWNjN2M0ZGQ1N2Q0MjQxZTJiMWI5ZTZlNjU4ZjIzMDczOTEg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Mb2NhbGl6YXRpb25zL2VuLmxwcm9q L2xvY2FsaXplZFN0cmluZ3MuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0xvY2FsaXph dGlvbnMvZW4ubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qcwpAQCAtNDQ4LDkgKzQ0OCw5IEBAIGxv Y2FsaXplZFN0cmluZ3NbIkR5bmFtaWNhbGx5IGNhbGN1bGF0ZWQgZm9yIHRoZSBzZWxlY3RlZCBl bGVtZW50IGFuZCBkaWQgbm90IG1hCiAvKiBMYWJlbCBmb3IgYSBndWlkZSB3aXRoaW4gdGhlIGNv bG9yIHBpY2tlciAqLwogbG9jYWxpemVkU3RyaW5nc1siRWRnZSBvZiBzUkdCIGNvbG9yIHNwYWNl Il0gPSAiRWRnZSBvZiBzUkdCIGNvbG9yIHNwYWNlIjsKIGxvY2FsaXplZFN0cmluZ3NbIkVkaXQi XSA9ICJFZGl0IjsKK2xvY2FsaXplZFN0cmluZ3NbIkVkaXQgJXMiXSA9ICJFZGl0ICVzIjsKIGxv Y2FsaXplZFN0cmluZ3NbIkVkaXQgQnJlYWtwb2ludFx1MjAyNiJdID0gIkVkaXQgQnJlYWtwb2lu dFx1MjAyNiI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJFZGl0IExvY2FsIE92ZXJyaWRlXHUyMDI2Il0g PSAiRWRpdCBMb2NhbCBPdmVycmlkZVx1MjAyNiI7Ci1sb2NhbGl6ZWRTdHJpbmdzWyJFZGl0IFx1 MjAxQyVzXHUyMDFEIl0gPSAiRWRpdCBcdTIwMUMlc1x1MjAxRCI7CiBsb2NhbGl6ZWRTdHJpbmdz WyJFZGl0IFx1MjAxQ2JveC1zaGFkb3dcdTIwMUQiXSA9ICJFZGl0IFx1MjAxQ2JveC1zaGFkb3dc dTIwMUQiOwogbG9jYWxpemVkU3RyaW5nc1siRWRpdCBcdTIwMUNjdWJpYy1iZXppZXJcdTIwMUQg ZnVuY3Rpb24iXSA9ICJFZGl0IFx1MjAxQ2N1YmljLWJlemllclx1MjAxRCBmdW5jdGlvbiI7CiBs b2NhbGl6ZWRTdHJpbmdzWyJFZGl0IFx1MjAxQ3NwcmluZ1x1MjAxRCBmdW5jdGlvbiJdID0gIkVk aXQgXHUyMDFDc3ByaW5nXHUyMDFEIGZ1bmN0aW9uIjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RhdGFHcmlkLmpzIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRGF0YUdyaWQuanMKaW5kZXggMGQ3MTU5NWYz N2YyOGJhNWY5NDZiNjUyNDhhY2NkMjAwMGYxYmVmMi4uOGY2MGU3ZTcwODFhNDE1NjliYzJjZTQw ZGY3MzQ3ZTQxNGZjYTYxNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvRGF0YUdyaWQuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvRGF0YUdyaWQuanMKQEAgLTE2NzAsNyArMTY3MCw3IEBAIFdJLkRh dGFHcmlkID0gY2xhc3MgRGF0YUdyaWQgZXh0ZW5kcyBXSS5WaWV3CiAgICAgICAgICAgICAgICAg ICAgICAgICBsZXQgZWxlbWVudCA9IGV2ZW50LnRhcmdldC5jbG9zZXN0KCJ0ZCIpOwogICAgICAg ICAgICAgICAgICAgICAgICAgbGV0IGNvbHVtbklkZW50aWZpZXIgPSBlbGVtZW50Ll9fY29sdW1u SWRlbnRpZmllcjsKICAgICAgICAgICAgICAgICAgICAgICAgIGxldCBjb2x1bW5UaXRsZSA9IHRo aXMuZGF0YUdyaWQuY29sdW1ucy5nZXQoY29sdW1uSWRlbnRpZmllcilbInRpdGxlIl07Ci0gICAg ICAgICAgICAgICAgICAgICAgICBjb250ZXh0TWVudS5hcHBlbmRJdGVtKFdJLlVJU3RyaW5nKCJF ZGl0IFx1MjAxQyVzXHUyMDFEIikuZm9ybWF0KGNvbHVtblRpdGxlKSwgdGhpcy5fc3RhcnRFZGl0 aW5nLmJpbmQodGhpcywgZXZlbnQudGFyZ2V0KSk7CisgICAgICAgICAgICAgICAgICAgICAgICBj b250ZXh0TWVudS5hcHBlbmRJdGVtKFdJLlVJU3RyaW5nKCJFZGl0ICVzIikuZm9ybWF0KGNvbHVt blRpdGxlKSwgdGhpcy5fc3RhcnRFZGl0aW5nLmJpbmQodGhpcywgZXZlbnQudGFyZ2V0KSk7CiAg ICAgICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICB9CiAK