209863 2020-04-01 10:48:56 -0700 ASSERTION FAILED: m_wrapper on webgl/max-active-contexts-webglcontextlost-prevent-default.html 2020-04-01 14:51:25 -0700 1 1 1 Unclassified WebKit WebCore JavaScript Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=209660 InRadar P2 Normal --- 1 ap cdumez cdumez darin dino esprehn+autocc ews-watchlist ggaren graouts gyuyoung.kim kondapallykalyan rniwa sabouhallawa webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1636563 0 ap 2020-04-01 10:48:56 -0700 I get a reproducible assertion failure on webgl/max-active-contexts-webglcontextlost-prevent-default.html run-webkit-tests -v --repeat-each 10 -1 --additional-env-var=JSC_slowPathAllocsBetweenGCs=25 LayoutTests/webgl/max-active-contexts-*.html --child-processes=1 ASSERTION FAILED: m_wrapper ./bindings/js/JSEventListener.h(125) : JSC::JSObject *WebCore::JSEventListener::ensureJSFunction(WebCore::ScriptExecutionContext &) const 1 0x10eb71779 WTFCrash 2 0x1289cd03b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x12abd376f WebCore::JSEventListener::ensureJSFunction(WebCore::ScriptExecutionContext&) const 4 0x12abd2add WebCore::JSEventListener::handleEvent(WebCore::ScriptExecutionContext&, WebCore::Event&) 5 0x12b21f107 WebCore::EventTarget::innerInvokeEventListeners(WebCore::Event&, WTF::Vector<WTF::RefPtr<WebCore::RegisteredEventListener, WTF::DumbPtrTraits<WebCore::RegisteredEventListener> >, 1ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>, WebCore::EventTarget::EventInvokePhase) 6 0x12b21b364 WebCore::EventTarget::fireEventListeners(WebCore::Event&, WebCore::EventTarget::EventInvokePhase) 7 0x12b2915a2 WebCore::Node::handleLocalEvents(WebCore::Event&, WebCore::EventTarget::EventInvokePhase) 8 0x12b209bf1 WebCore::EventContext::handleLocalEvents(WebCore::Event&, WebCore::EventTarget::EventInvokePhase) const 9 0x12b20a6bf WebCore::dispatchEventInDOM(WebCore::Event&, WebCore::EventPath const&) 10 0x12b20a1f7 WebCore::EventDispatcher::dispatchEvent(WebCore::Node&, WebCore::Event&) 11 0x12b2915fd WebCore::Node::dispatchEvent(WebCore::Event&) 12 0x12b7cf9a7 WebCore::WebGLRenderingContextBase::scheduleTaskToDispatchContextLostEvent()::$_13::operator()() const 13 0x12b7cf90e WTF::Detail::CallableWrapper<WebCore::WebGLRenderingContextBase::scheduleTaskToDispatchContextLostEvent()::$_13, void>::call() 14 0x1289df8a2 WTF::Function<void ()>::operator()() const 15 0x12b7cef7e void WebCore::ActiveDOMObject::queueTaskKeepingObjectAlive<WebCore::HTMLCanvasElement>(WebCore::HTMLCanvasElement&, WebCore::TaskSource, WTF::Function<void ()>&&)::'lambda'()::operator()() const 16 0x12b7cecae WTF::Detail::CallableWrapper<void WebCore::ActiveDOMObject::queueTaskKeepingObjectAlive<WebCore::HTMLCanvasElement>(WebCore::HTMLCanvasElement&, WebCore::TaskSource, WTF::Function<void ()>&&)::'lambda'(), void>::call() 17 0x1289df8a2 WTF::Function<void ()>::operator()() const 18 0x12b20f89e WebCore::EventLoopFunctionDispatchTask::execute() 19 0x12b20ce05 WebCore::EventLoop::run() 20 0x12b36229c WebCore::WindowEventLoop::didReachTimeToRun() 21 0x12b365307 decltype(*(std::__1::forward<WebCore::WindowEventLoop*&>(fp0)).*fp()) std::__1::__invoke<void (WebCore::WindowEventLoop::*&)(), WebCore::WindowEventLoop*&, void>(void (WebCore::WindowEventLoop::*&)(), WebCore::WindowEventLoop*&) 22 0x12b365280 std::__1::__bind_return<void (WebCore::WindowEventLoop::*)(), std::__1::tuple<WebCore::WindowEventLoop*>, std::__1::tuple<>, __is_valid_bind_return<void (WebCore::WindowEventLoop::*)(), std::__1::tuple<WebCore::WindowEventLoop*>, std::__1::tuple<> >::value>::type std::__1::__apply_functor<void (WebCore::WindowEventLoop::*)(), std::__1::tuple<WebCore::WindowEventLoop*>, 0ul, std::__1::tuple<> >(void (WebCore::WindowEventLoop::*&)(), std::__1::tuple<WebCore::WindowEventLoop*>&, std::__1::__tuple_indices<0ul>, std::__1::tuple<>&&) 23 0x12b365239 std::__1::__bind_return<void (WebCore::WindowEventLoop::*)(), std::__1::tuple<WebCore::WindowEventLoop*>, std::__1::tuple<>, __is_valid_bind_return<void (WebCore::WindowEventLoop::*)(), std::__1::tuple<WebCore::WindowEventLoop*>, std::__1::tuple<> >::value>::type std::__1::__bind<void (WebCore::WindowEventLoop::*&)(), WebCore::WindowEventLoop*>::operator()<>() 24 0x12b3651de WTF::Detail::CallableWrapper<std::__1::__bind<void (WebCore::WindowEventLoop::*&)(), WebCore::WindowEventLoop*>, void>::call() 25 0x1289df8a2 WTF::Function<void ()>::operator()() const 26 0x128a9986e WebCore::Timer::fired() 27 0x12c006c54 WebCore::ThreadTimers::sharedTimerFiredInternal() 28 0x12c00e361 WebCore::ThreadTimers::setSharedTimer(WebCore::SharedTimer*)::$_0::operator()() const 29 0x12c00e30e WTF::Detail::CallableWrapper<WebCore::ThreadTimers::setSharedTimer(WebCore::SharedTimer*)::$_0, void>::call() 30 0x1289df8a2 WTF::Function<void ()>::operator()() const 31 0x12bfd362b WebCore::MainThreadSharedTimer::fired() 1636564 1 webkit-bug-importer 2020-04-01 10:49:09 -0700 <rdar://problem/61164936> 1636567 2 cdumez 2020-04-01 10:55:37 -0700 Which revision? 1636568 3 ap 2020-04-01 11:01:12 -0700 r259292 1636586 4 cdumez 2020-04-01 11:29:13 -0700 Since r259130, WebGLRenderingContextBase::scheduleTaskToDispatchContextLostEvent() keeps the wrapper alive while the event is pending. Give that we're crashing still, I believe this indicates the JS wrapper can get destroyed before scheduleTaskToDispatchContextLostEvent() even gets called. 1636587 5 cdumez 2020-04-01 11:33:22 -0700 The provided command reproduced the issue for me, thanks. 1636605 6 395192 cdumez 2020-04-01 12:26:40 -0700 Created attachment 395192 Patch 1636628 7 395192 darin 2020-04-01 13:29:42 -0700 Comment on attachment 395192 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395192&action=review > Source/WebCore/html/HTMLCanvasElement.cpp:963 > + if (is<WebGLRenderingContextBase>(m_context.get())) { > + // WebGL rendering context may fire contextlost / contextchange / contextrestored events at any point. > + return m_hasRelevantWebGLEventListener && !downcast<WebGLRenderingContextBase>(*m_context).isContextUnrecoverablyLost(); > + } Why not include is<WebGLRenderingContextBase>(m_context.get()) in the cached m_hasRelevantWebGLEventListener boolean to have one less check to do here? > Source/WebCore/html/HTMLCanvasElement.cpp:980 > +#if ENABLE(WEBGL) > + m_hasRelevantWebGLEventListener = hasEventListeners(eventNames().webglcontextchangedEvent) > + || hasEventListeners(eventNames().webglcontextlostEvent) > + || hasEventListeners(eventNames().webglcontextrestoredEvent); > +#endif We’re caching this because this is too expensive to do inside virtualHasPendingActivity? 1636641 8 395192 cdumez 2020-04-01 13:43:50 -0700 Comment on attachment 395192 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=395192&action=review >> Source/WebCore/html/HTMLCanvasElement.cpp:963 >> + } > > Why not include is<WebGLRenderingContextBase>(m_context.get()) in the cached m_hasRelevantWebGLEventListener boolean to have one less check to do here? I like having the is<WebGLRenderingContextBase>() check in this function since I am doing a downcast<WebGLRenderingContextBase>() right after. I think doing it as you suggest would probably look less safe. >> Source/WebCore/html/HTMLCanvasElement.cpp:980 >> +#endif > > We’re caching this because this is too expensive to do inside virtualHasPendingActivity? 2 reasons: - Performance - virtualHasPendingActivity() gets called on a GC thread. 1636642 9 cdumez 2020-04-01 13:50:22 -0700 Seems to be causing some crashes on the bots for some reason. I am investigating. 1636653 10 395202 cdumez 2020-04-01 14:10:39 -0700 Created attachment 395202 Patch 1636670 11 ews-feeder 2020-04-01 14:51:23 -0700 Committed r259364: <https://trac.webkit.org/changeset/259364> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395202. 395192 2020-04-01 12:26:40 -0700 2020-04-01 14:10:37 -0700 Patch bug-209863-20200401122640.patch text/plain 6490 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5MzQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzQyNjYxYjEwMGE1NmI2 M2I0MzhmYmJiYTdlOThmY2RiNTE5YWQxZi4uMmQyMjAzOWFmMGViNTIzZWYxN2I5YjcyZjUzOGQ5 NTAxZGY4YWNhZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMwIEBACisyMDIwLTA0LTAxICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQVNTRVJUSU9OIEZBSUxFRDog bV93cmFwcGVyIG9uIHdlYmdsL21heC1hY3RpdmUtY29udGV4dHMtd2ViZ2xjb250ZXh0bG9zdC1w cmV2ZW50LWRlZmF1bHQuaHRtbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjA5ODYzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82MTE2NDkzNj4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgSFRNTENh bnZhc0VsZW1lbnQgSlMgd3JhcHBlciBuZWVkcyB0byBzdGF5IGFsaXZlIGFzIGxvbmcgYXMgSlMg ZXZlbnRzIG1heSBuZWVkIHRvIGJlIGZpcmVkLgorICAgICAgICBXaGVuIHRoZSBjYW52YXMgaGFz IGEgV2ViR0wgY29udGV4dCwgdGhlIFdlYkdMIGNvbnRleHQgbWF5IGNhdXNlIGNvbnRleHRsb3N0 IC8gY29udGV4dHJlc3RvcmVkCisgICAgICAgIC8gY29udGV4dGNoYW5nZWQgZXZlbnRzIGF0IGFu eSBwb2ludCwgdW5sZXNzIHRoZSBjb250ZXh0IGlzIHVucmVjb3ZlcmFibHkgbG9zdC4gVG8gZml4 IHRoZQorICAgICAgICBpc3N1ZSwgd2Ugbm93IG92ZXJyaWRlIHZpcnR1YWxIYXNQZW5kaW5nQWN0 aXZpdHkoKSBpbiBIVE1MQ2FudmFzRWxlbWVudCBhbmQgcmV0dXJuIHRydWUgaWYKKyAgICAgICAg aXQgaGFzIGEgV2ViR0wgY29udGV4dCB0aGF0IGlzIG5vdCB1bnJlY292ZXJhYmx5IGxvc3QgYW5k IGlmIHJlbGV2YW50IFdlYkdMIGV2ZW50IGxpc3RlbmVycworICAgICAgICBhcmUgcmVnaXN0ZWQu IEkgYWxzbyBtYWtlIHN1cmUgdG8gY2xlYXIgdGhlIGNvbnRleHQgaW4gc3RvcCgpIHRvIGF2b2lk IGxlYWtzLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgY292ZXJlZCBieSBleGlzdGluZyB0ZXN0 LgorCisgICAgICAgICogaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJD b3JlOjpIVE1MQ2FudmFzRWxlbWVudDo6fkhUTUxDYW52YXNFbGVtZW50KToKKyAgICAgICAgKFdl YkNvcmU6OkhUTUxDYW52YXNFbGVtZW50Ojp2aXJ0dWFsSGFzUGVuZGluZ0FjdGl2aXR5IGNvbnN0 KToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxDYW52YXNFbGVtZW50OjpzdG9wKToKKyAgICAgICAg KFdlYkNvcmU6OkhUTUxDYW52YXNFbGVtZW50OjpldmVudExpc3RlbmVyc0RpZENoYW5nZSk6Cisg ICAgICAgICogaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5oOgorICAgICAgICAqIGh0bWwvY2FudmFz L1dlYkdMUmVuZGVyaW5nQ29udGV4dEJhc2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V2ViR0xS ZW5kZXJpbmdDb250ZXh0QmFzZTo6aXNDb250ZXh0VW5yZWNvdmVyYWJseUxvc3QgY29uc3QpOgor ICAgICAgICAqIGh0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dEJhc2UuaDoKKwogMjAy MC0wNC0wMSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIEFTU0VS VElPTiBGQUlMRUQ6IG1fd3JhcHBlciBvbiBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3Rz L2h0bWwvc2VtYW50aWNzL2VtYmVkZGVkLWNvbnRlbnQvbWVkaWEtZWxlbWVudHMvcmVhZHktc3Rh dGVzL2F1dG9wbGF5Lmh0bWwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTENh bnZhc0VsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5j cHAKaW5kZXggZTZhMjI2ODY3YjNiZmJkYjQ3M2M4YjlmMDI3ZWFhNzgyOWMxNTliNi4uNjFlMDlk MTY2NTE1NDJjMjE2NTNiZWI3YmU5NDIxYTFlNzYyOTZmZSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MQ2FudmFzRWxlbWVudC5jcHAKQEAgLTEzOSw4ICsxMzksNyBAQCBIVE1MQ2FudmFzRWxl bWVudDo6fkhUTUxDYW52YXNFbGVtZW50KCkKICAgICAvLyBhdm9pZGVkIGluIGRlc3RydWN0b3Jz LCBidXQgd29ya3MgYXMgbG9uZyBhcyBpdCdzIGRvbmUgYmVmb3JlIEhUTUxDYW52YXNFbGVtZW50 IGRlc3RydWN0cyBjb21wbGV0ZWx5LgogICAgIG5vdGlmeU9ic2VydmVyc0NhbnZhc0Rlc3Ryb3ll ZCgpOwogCi0gICAgbV9jb250ZXh0ID0gbnVsbHB0cjsgLy8gRW5zdXJlIHRoaXMgZ29lcyBhd2F5 IGJlZm9yZSB0aGUgSW1hZ2VCdWZmZXIuCi0gICAgc2V0SW1hZ2VCdWZmZXIobnVsbHB0cik7Cisg ICAgc3RvcCgpOwogfQogCiB2b2lkIEhUTUxDYW52YXNFbGVtZW50OjpwYXJzZUF0dHJpYnV0ZShj b25zdCBRdWFsaWZpZWROYW1lJiBuYW1lLCBjb25zdCBBdG9tU3RyaW5nJiB2YWx1ZSkKQEAgLTk1 NSw0ICs5NTQsMzAgQEAgY29uc3QgY2hhciogSFRNTENhbnZhc0VsZW1lbnQ6OmFjdGl2ZURPTU9i amVjdE5hbWUoKSBjb25zdAogICAgIHJldHVybiAiSFRNTENhbnZhc0VsZW1lbnQiOwogfQogCiti b29sIEhUTUxDYW52YXNFbGVtZW50Ojp2aXJ0dWFsSGFzUGVuZGluZ0FjdGl2aXR5KCkgY29uc3QK K3sKKyNpZiBFTkFCTEUoV0VCR0wpCisgICAgaWYgKGlzPFdlYkdMUmVuZGVyaW5nQ29udGV4dEJh c2U+KG1fY29udGV4dC5nZXQoKSkpIHsKKyAgICAgICAgLy8gV2ViR0wgcmVuZGVyaW5nIGNvbnRl eHQgbWF5IGZpcmUgY29udGV4dGxvc3QgLyBjb250ZXh0Y2hhbmdlIC8gY29udGV4dHJlc3RvcmVk IGV2ZW50cyBhdCBhbnkgcG9pbnQuCisgICAgICAgIHJldHVybiBtX2hhc1JlbGV2YW50V2ViR0xF dmVudExpc3RlbmVyICYmICFkb3duY2FzdDxXZWJHTFJlbmRlcmluZ0NvbnRleHRCYXNlPigqbV9j b250ZXh0KS5pc0NvbnRleHRVbnJlY292ZXJhYmx5TG9zdCgpOworICAgIH0KKyNlbmRpZgorICAg IHJldHVybiBmYWxzZTsKK30KKwordm9pZCBIVE1MQ2FudmFzRWxlbWVudDo6c3RvcCgpCit7Cisg ICAgbV9jb250ZXh0ID0gbnVsbHB0cjsgLy8gRW5zdXJlIHRoaXMgZ29lcyBhd2F5IGJlZm9yZSB0 aGUgSW1hZ2VCdWZmZXIuCisgICAgc2V0SW1hZ2VCdWZmZXIobnVsbHB0cik7Cit9CisKK3ZvaWQg SFRNTENhbnZhc0VsZW1lbnQ6OmV2ZW50TGlzdGVuZXJzRGlkQ2hhbmdlKCkKK3sKKyNpZiBFTkFC TEUoV0VCR0wpCisgICAgbV9oYXNSZWxldmFudFdlYkdMRXZlbnRMaXN0ZW5lciA9IGhhc0V2ZW50 TGlzdGVuZXJzKGV2ZW50TmFtZXMoKS53ZWJnbGNvbnRleHRjaGFuZ2VkRXZlbnQpCisgICAgICAg IHx8IGhhc0V2ZW50TGlzdGVuZXJzKGV2ZW50TmFtZXMoKS53ZWJnbGNvbnRleHRsb3N0RXZlbnQp CisgICAgICAgIHx8IGhhc0V2ZW50TGlzdGVuZXJzKGV2ZW50TmFtZXMoKS53ZWJnbGNvbnRleHRy ZXN0b3JlZEV2ZW50KTsKKyNlbmRpZgorfQorCiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxDYW52YXNFbGVtZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxDYW52 YXNFbGVtZW50LmgKaW5kZXggMmU2Mjg5MTFjMTk4ZDg0ZWE3ZmExMDIwNTMyY2ZjZWNjMjJkNjYy NS4uMTcxMzA2OTRhNTAzNWJhMDNhYmFkZjkxNjRlOTU2NTY1Mzk5MGFjOCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTENhbnZhc0VsZW1lbnQuaApAQCAtMTMzLDcgKzEzMywxNCBAQCBwcml2YXRl OgogICAgIEhUTUxDYW52YXNFbGVtZW50KGNvbnN0IFF1YWxpZmllZE5hbWUmLCBEb2N1bWVudCYp OwogCiAgICAgYm9vbCBpc0hUTUxDYW52YXNFbGVtZW50KCkgY29uc3QgZmluYWwgeyByZXR1cm4g dHJ1ZTsgfQorCisgICAgLy8gQWN0aXZlRE9NT2JqZWN0LgogICAgIGNvbnN0IGNoYXIqIGFjdGl2 ZURPTU9iamVjdE5hbWUoKSBjb25zdCBmaW5hbDsKKyAgICBib29sIHZpcnR1YWxIYXNQZW5kaW5n QWN0aXZpdHkoKSBjb25zdCBmaW5hbDsKKyAgICB2b2lkIHN0b3AoKSBmaW5hbDsKKworICAgIC8v IEV2ZW50VGFyZ2V0LgorICAgIHZvaWQgZXZlbnRMaXN0ZW5lcnNEaWRDaGFuZ2UoKSBmaW5hbDsK IAogICAgIHZvaWQgcGFyc2VBdHRyaWJ1dGUoY29uc3QgUXVhbGlmaWVkTmFtZSYsIGNvbnN0IEF0 b21TdHJpbmcmKSBmaW5hbDsKICAgICBSZW5kZXJQdHI8UmVuZGVyRWxlbWVudD4gY3JlYXRlRWxl bWVudFJlbmRlcmVyKFJlbmRlclN0eWxlJiYsIGNvbnN0IFJlbmRlclRyZWVQb3NpdGlvbiYpIGZp bmFsOwpAQCAtMTcxLDYgKzE3OCw5IEBAIHByaXZhdGU6CiAgICAgLy8gbV9oYXNDcmVhdGVkSW1h Z2VCdWZmZXIgbWVhbnMgd2UgdHJpZWQgdG8gbWFsbG9jIHRoZSBidWZmZXIuIFdlIGRpZG4ndCBu ZWNlc3NhcmlseSBnZXQgaXQuCiAgICAgbXV0YWJsZSBib29sIG1faGFzQ3JlYXRlZEltYWdlQnVm ZmVyIHsgZmFsc2UgfTsKICAgICBtdXRhYmxlIGJvb2wgbV9kaWRDbGVhckltYWdlQnVmZmVyIHsg ZmFsc2UgfTsKKyNpZiBFTkFCTEUoV0VCR0wpCisgICAgYm9vbCBtX2hhc1JlbGV2YW50V2ViR0xF dmVudExpc3RlbmVyIHsgZmFsc2UgfTsKKyNlbmRpZgogCiAgICAgbXV0YWJsZSBSZWZQdHI8SW1h Z2U+IG1fcHJlc2VudGVkSW1hZ2U7CiAgICAgbXV0YWJsZSBSZWZQdHI8SW1hZ2U+IG1fY29waWVk SW1hZ2U7IC8vIEZJWE1FOiBUaGlzIGlzIHRlbXBvcmFyeSBmb3IgcGxhdGZvcm1zIHRoYXQgaGF2 ZSB0byBjb3B5IHRoZSBpbWFnZSBidWZmZXIgdG8gcmVuZGVyIChhbmQgZm9yIENTU0NhbnZhc1Zh bHVlKS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVy aW5nQ29udGV4dEJhc2UuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5k ZXJpbmdDb250ZXh0QmFzZS5jcHAKaW5kZXggOTQyOTJlMzdjNmJjOTgzZTdkOTY0N2VkMDg3MTMy YTZiNWU4Njk3ZC4uNGJlOTAxNmY5NDZiNGZlMjA0MjAyYzMwN2JjMzFjNjY1YmZlNDM0ZSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0 QmFzZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdD b250ZXh0QmFzZS5jcHAKQEAgLTU1MDIsNiArNTUwMiwxMSBAQCB2b2lkIFdlYkdMUmVuZGVyaW5n Q29udGV4dEJhc2U6OmZvcmNlUmVzdG9yZUNvbnRleHQoKQogICAgICAgICBtX3Jlc3RvcmVUaW1l ci5zdGFydE9uZVNob3QoMF9zKTsKIH0KIAorYm9vbCBXZWJHTFJlbmRlcmluZ0NvbnRleHRCYXNl Ojppc0NvbnRleHRVbnJlY292ZXJhYmx5TG9zdCgpIGNvbnN0Cit7CisgICAgcmV0dXJuIG1fY29u dGV4dExvc3QgJiYgIW1fcmVzdG9yZUFsbG93ZWQ7Cit9CisKIFBsYXRmb3JtTGF5ZXIqIFdlYkdM UmVuZGVyaW5nQ29udGV4dEJhc2U6OnBsYXRmb3JtTGF5ZXIoKSBjb25zdAogewogICAgIHJldHVy biAoIWlzQ29udGV4dExvc3QoKSAmJiAhbV9pc1BlbmRpbmdQb2xpY3lSZXNvbHV0aW9uKSA/IG1f Y29udGV4dC0+cGxhdGZvcm1MYXllcigpIDogMDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dEJhc2UuaCBiL1NvdXJjZS9XZWJDb3Jl L2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dEJhc2UuaAppbmRleCBkNzBjYjI1ODkx OGI5ZjFiMDZkNmQxMzY5OGVhM2I0ZTY2MWViNzEyLi43N2IyZmQ5NmVhZmU2N2RhZDAwMzU4NTFi ZGExYjcwNzE0OGZkM2NkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9X ZWJHTFJlbmRlcmluZ0NvbnRleHRCYXNlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52 YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0QmFzZS5oCkBAIC0zNTksNiArMzU5LDggQEAgcHVibGlj OgogICAgIAogICAgIHVuc2lnbmVkIGdldE1heFZlcnRleEF0dHJpYnMoKSBjb25zdCB7IHJldHVy biBtX21heFZlcnRleEF0dHJpYnM7IH0KIAorICAgIGJvb2wgaXNDb250ZXh0VW5yZWNvdmVyYWJs eUxvc3QoKSBjb25zdDsKKwogICAgIC8vIEluc3RhbmNlZCBBcnJheSBoZWxwZXIgZnVuY3Rpb25z LgogICAgIHZvaWQgZHJhd0FycmF5c0luc3RhbmNlZChHQ0dMZW51bSBtb2RlLCBHQ0dMaW50IGZp cnN0LCBHQ0dMc2l6ZWkgY291bnQsIEdDR0xzaXplaSBwcmltY291bnQpOwogICAgIHZvaWQgZHJh d0VsZW1lbnRzSW5zdGFuY2VkKEdDR0xlbnVtIG1vZGUsIEdDR0xzaXplaSBjb3VudCwgR0NHTGVu dW0gdHlwZSwgbG9uZyBsb25nIG9mZnNldCwgR0NHTHNpemVpIHByaW1jb3VudCk7Cg== 395202 2020-04-01 14:10:39 -0700 2020-04-01 14:51:24 -0700 Patch bug-209863-20200401141038.patch text/plain 5884 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5MzQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzQyNjYxYjEwMGE1NmI2 M2I0MzhmYmJiYTdlOThmY2RiNTE5YWQxZi4uZDYzMjQ1ZWMyYjdmN2YyYWNmYzA1OTc4YWFlMTVj M2NhNTIxY2JjZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMwIEBACisyMDIwLTA0LTAxICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQVNTRVJUSU9OIEZBSUxFRDog bV93cmFwcGVyIG9uIHdlYmdsL21heC1hY3RpdmUtY29udGV4dHMtd2ViZ2xjb250ZXh0bG9zdC1w cmV2ZW50LWRlZmF1bHQuaHRtbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjA5ODYzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82MTE2NDkzNj4KKwor ICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KKworICAgICAgICBUaGUgSFRNTENhbnZh c0VsZW1lbnQgSlMgd3JhcHBlciBuZWVkcyB0byBzdGF5IGFsaXZlIGFzIGxvbmcgYXMgSlMgZXZl bnRzIG1heSBuZWVkIHRvIGJlIGZpcmVkLgorICAgICAgICBXaGVuIHRoZSBjYW52YXMgaGFzIGEg V2ViR0wgY29udGV4dCwgdGhlIFdlYkdMIGNvbnRleHQgbWF5IGNhdXNlIGNvbnRleHRsb3N0IC8g Y29udGV4dHJlc3RvcmVkCisgICAgICAgIC8gY29udGV4dGNoYW5nZWQgZXZlbnRzIGF0IGFueSBw b2ludCwgdW5sZXNzIHRoZSBjb250ZXh0IGlzIHVucmVjb3ZlcmFibHkgbG9zdC4gVG8gZml4IHRo ZQorICAgICAgICBpc3N1ZSwgd2Ugbm93IG92ZXJyaWRlIHZpcnR1YWxIYXNQZW5kaW5nQWN0aXZp dHkoKSBpbiBIVE1MQ2FudmFzRWxlbWVudCBhbmQgcmV0dXJuIHRydWUgaWYKKyAgICAgICAgaXQg aGFzIGEgV2ViR0wgY29udGV4dCB0aGF0IGlzIG5vdCB1bnJlY292ZXJhYmx5IGxvc3QgYW5kIGlm IHJlbGV2YW50IFdlYkdMIGV2ZW50IGxpc3RlbmVycworICAgICAgICBhcmUgcmVnaXN0ZWQuCisK KyAgICAgICAgTm8gbmV3IHRlc3RzLCBjb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3QuCisKKyAgICAg ICAgKiBodG1sL0hUTUxDYW52YXNFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxD YW52YXNFbGVtZW50Ojp+SFRNTENhbnZhc0VsZW1lbnQpOgorICAgICAgICAoV2ViQ29yZTo6SFRN TENhbnZhc0VsZW1lbnQ6OnZpcnR1YWxIYXNQZW5kaW5nQWN0aXZpdHkgY29uc3QpOgorICAgICAg ICAoV2ViQ29yZTo6SFRNTENhbnZhc0VsZW1lbnQ6OnN0b3ApOgorICAgICAgICAoV2ViQ29yZTo6 SFRNTENhbnZhc0VsZW1lbnQ6OmV2ZW50TGlzdGVuZXJzRGlkQ2hhbmdlKToKKyAgICAgICAgKiBo dG1sL0hUTUxDYW52YXNFbGVtZW50Lmg6CisgICAgICAgICogaHRtbC9jYW52YXMvV2ViR0xSZW5k ZXJpbmdDb250ZXh0QmFzZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXZWJHTFJlbmRlcmluZ0Nv bnRleHRCYXNlOjppc0NvbnRleHRVbnJlY292ZXJhYmx5TG9zdCBjb25zdCk6CisgICAgICAgICog aHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0QmFzZS5oOgorCiAyMDIwLTA0LTAxICBD aHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgQVNTRVJUSU9OIEZBSUxF RDogbV93cmFwcGVyIG9uIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9zZW1h bnRpY3MvZW1iZWRkZWQtY29udGVudC9tZWRpYS1lbGVtZW50cy9yZWFkeS1zdGF0ZXMvYXV0b3Bs YXkuaHRtbApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQ2FudmFzRWxlbWVu dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxDYW52YXNFbGVtZW50LmNwcAppbmRleCBl NmEyMjY4NjdiM2JmYmRiNDczYzhiOWYwMjdlYWE3ODI5YzE1OWI2Li5lZjJiNTY0NTQzZGE2NWM2 ZDdiYjY0MDZjYjBmYTg4NzgwMzQyMTE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1s L0hUTUxDYW52YXNFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxDYW52 YXNFbGVtZW50LmNwcApAQCAtOTU1LDQgKzk1NSwyOCBAQCBjb25zdCBjaGFyKiBIVE1MQ2FudmFz RWxlbWVudDo6YWN0aXZlRE9NT2JqZWN0TmFtZSgpIGNvbnN0CiAgICAgcmV0dXJuICJIVE1MQ2Fu dmFzRWxlbWVudCI7CiB9CiAKK2Jvb2wgSFRNTENhbnZhc0VsZW1lbnQ6OnZpcnR1YWxIYXNQZW5k aW5nQWN0aXZpdHkoKSBjb25zdAoreworICAgIGlmIChpc0NvbnRleHRTdG9wcGVkKCkpCisgICAg ICAgIHJldHVybiBmYWxzZTsKKworI2lmIEVOQUJMRShXRUJHTCkKKyAgICBpZiAoaXM8V2ViR0xS ZW5kZXJpbmdDb250ZXh0QmFzZT4obV9jb250ZXh0LmdldCgpKSkgeworICAgICAgICAvLyBXZWJH TCByZW5kZXJpbmcgY29udGV4dCBtYXkgZmlyZSBjb250ZXh0bG9zdCAvIGNvbnRleHRjaGFuZ2Ug LyBjb250ZXh0cmVzdG9yZWQgZXZlbnRzIGF0IGFueSBwb2ludC4KKyAgICAgICAgcmV0dXJuIG1f aGFzUmVsZXZhbnRXZWJHTEV2ZW50TGlzdGVuZXIgJiYgIWRvd25jYXN0PFdlYkdMUmVuZGVyaW5n Q29udGV4dEJhc2U+KCptX2NvbnRleHQpLmlzQ29udGV4dFVucmVjb3ZlcmFibHlMb3N0KCk7Cisg ICAgfQorI2VuZGlmCisKKyAgICByZXR1cm4gZmFsc2U7Cit9CisKK3ZvaWQgSFRNTENhbnZhc0Vs ZW1lbnQ6OmV2ZW50TGlzdGVuZXJzRGlkQ2hhbmdlKCkKK3sKKyNpZiBFTkFCTEUoV0VCR0wpCisg ICAgbV9oYXNSZWxldmFudFdlYkdMRXZlbnRMaXN0ZW5lciA9IGhhc0V2ZW50TGlzdGVuZXJzKGV2 ZW50TmFtZXMoKS53ZWJnbGNvbnRleHRjaGFuZ2VkRXZlbnQpCisgICAgICAgIHx8IGhhc0V2ZW50 TGlzdGVuZXJzKGV2ZW50TmFtZXMoKS53ZWJnbGNvbnRleHRsb3N0RXZlbnQpCisgICAgICAgIHx8 IGhhc0V2ZW50TGlzdGVuZXJzKGV2ZW50TmFtZXMoKS53ZWJnbGNvbnRleHRyZXN0b3JlZEV2ZW50 KTsKKyNlbmRpZgorfQorCiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxD YW52YXNFbGVtZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxDYW52YXNFbGVtZW50LmgK aW5kZXggMmU2Mjg5MTFjMTk4ZDg0ZWE3ZmExMDIwNTMyY2ZjZWNjMjJkNjYyNS4uNTBlN2MyY2Rl ZTEwNTgyYjZhOTdjY2QyYTc3NTY3NDkwOGRmZjM4YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRN TENhbnZhc0VsZW1lbnQuaApAQCAtMTMzLDcgKzEzMywxMyBAQCBwcml2YXRlOgogICAgIEhUTUxD YW52YXNFbGVtZW50KGNvbnN0IFF1YWxpZmllZE5hbWUmLCBEb2N1bWVudCYpOwogCiAgICAgYm9v bCBpc0hUTUxDYW52YXNFbGVtZW50KCkgY29uc3QgZmluYWwgeyByZXR1cm4gdHJ1ZTsgfQorCisg ICAgLy8gQWN0aXZlRE9NT2JqZWN0LgogICAgIGNvbnN0IGNoYXIqIGFjdGl2ZURPTU9iamVjdE5h bWUoKSBjb25zdCBmaW5hbDsKKyAgICBib29sIHZpcnR1YWxIYXNQZW5kaW5nQWN0aXZpdHkoKSBj b25zdCBmaW5hbDsKKworICAgIC8vIEV2ZW50VGFyZ2V0LgorICAgIHZvaWQgZXZlbnRMaXN0ZW5l cnNEaWRDaGFuZ2UoKSBmaW5hbDsKIAogICAgIHZvaWQgcGFyc2VBdHRyaWJ1dGUoY29uc3QgUXVh bGlmaWVkTmFtZSYsIGNvbnN0IEF0b21TdHJpbmcmKSBmaW5hbDsKICAgICBSZW5kZXJQdHI8UmVu ZGVyRWxlbWVudD4gY3JlYXRlRWxlbWVudFJlbmRlcmVyKFJlbmRlclN0eWxlJiYsIGNvbnN0IFJl bmRlclRyZWVQb3NpdGlvbiYpIGZpbmFsOwpAQCAtMTcxLDYgKzE3Nyw5IEBAIHByaXZhdGU6CiAg ICAgLy8gbV9oYXNDcmVhdGVkSW1hZ2VCdWZmZXIgbWVhbnMgd2UgdHJpZWQgdG8gbWFsbG9jIHRo ZSBidWZmZXIuIFdlIGRpZG4ndCBuZWNlc3NhcmlseSBnZXQgaXQuCiAgICAgbXV0YWJsZSBib29s IG1faGFzQ3JlYXRlZEltYWdlQnVmZmVyIHsgZmFsc2UgfTsKICAgICBtdXRhYmxlIGJvb2wgbV9k aWRDbGVhckltYWdlQnVmZmVyIHsgZmFsc2UgfTsKKyNpZiBFTkFCTEUoV0VCR0wpCisgICAgYm9v bCBtX2hhc1JlbGV2YW50V2ViR0xFdmVudExpc3RlbmVyIHsgZmFsc2UgfTsKKyNlbmRpZgogCiAg ICAgbXV0YWJsZSBSZWZQdHI8SW1hZ2U+IG1fcHJlc2VudGVkSW1hZ2U7CiAgICAgbXV0YWJsZSBS ZWZQdHI8SW1hZ2U+IG1fY29waWVkSW1hZ2U7IC8vIEZJWE1FOiBUaGlzIGlzIHRlbXBvcmFyeSBm b3IgcGxhdGZvcm1zIHRoYXQgaGF2ZSB0byBjb3B5IHRoZSBpbWFnZSBidWZmZXIgdG8gcmVuZGVy IChhbmQgZm9yIENTU0NhbnZhc1ZhbHVlKS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0 bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dEJhc2UuY3BwIGIvU291cmNlL1dlYkNvcmUv aHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0QmFzZS5jcHAKaW5kZXggOTQyOTJlMzdj NmJjOTgzZTdkOTY0N2VkMDg3MTMyYTZiNWU4Njk3ZC4uNGJlOTAxNmY5NDZiNGZlMjA0MjAyYzMw N2JjMzFjNjY1YmZlNDM0ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMv V2ViR0xSZW5kZXJpbmdDb250ZXh0QmFzZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9j YW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0QmFzZS5jcHAKQEAgLTU1MDIsNiArNTUwMiwxMSBA QCB2b2lkIFdlYkdMUmVuZGVyaW5nQ29udGV4dEJhc2U6OmZvcmNlUmVzdG9yZUNvbnRleHQoKQog ICAgICAgICBtX3Jlc3RvcmVUaW1lci5zdGFydE9uZVNob3QoMF9zKTsKIH0KIAorYm9vbCBXZWJH TFJlbmRlcmluZ0NvbnRleHRCYXNlOjppc0NvbnRleHRVbnJlY292ZXJhYmx5TG9zdCgpIGNvbnN0 Cit7CisgICAgcmV0dXJuIG1fY29udGV4dExvc3QgJiYgIW1fcmVzdG9yZUFsbG93ZWQ7Cit9CisK IFBsYXRmb3JtTGF5ZXIqIFdlYkdMUmVuZGVyaW5nQ29udGV4dEJhc2U6OnBsYXRmb3JtTGF5ZXIo KSBjb25zdAogewogICAgIHJldHVybiAoIWlzQ29udGV4dExvc3QoKSAmJiAhbV9pc1BlbmRpbmdQ b2xpY3lSZXNvbHV0aW9uKSA/IG1fY29udGV4dC0+cGxhdGZvcm1MYXllcigpIDogMDsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dEJh c2UuaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dEJh c2UuaAppbmRleCBkNzBjYjI1ODkxOGI5ZjFiMDZkNmQxMzY5OGVhM2I0ZTY2MWViNzEyLi43N2Iy ZmQ5NmVhZmU2N2RhZDAwMzU4NTFiZGExYjcwNzE0OGZkM2NkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHRCYXNlLmgKKysrIGIvU291 cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0QmFzZS5oCkBAIC0z NTksNiArMzU5LDggQEAgcHVibGljOgogICAgIAogICAgIHVuc2lnbmVkIGdldE1heFZlcnRleEF0 dHJpYnMoKSBjb25zdCB7IHJldHVybiBtX21heFZlcnRleEF0dHJpYnM7IH0KIAorICAgIGJvb2wg aXNDb250ZXh0VW5yZWNvdmVyYWJseUxvc3QoKSBjb25zdDsKKwogICAgIC8vIEluc3RhbmNlZCBB cnJheSBoZWxwZXIgZnVuY3Rpb25zLgogICAgIHZvaWQgZHJhd0FycmF5c0luc3RhbmNlZChHQ0dM ZW51bSBtb2RlLCBHQ0dMaW50IGZpcnN0LCBHQ0dMc2l6ZWkgY291bnQsIEdDR0xzaXplaSBwcmlt Y291bnQpOwogICAgIHZvaWQgZHJhd0VsZW1lbnRzSW5zdGFuY2VkKEdDR0xlbnVtIG1vZGUsIEdD R0xzaXplaSBjb3VudCwgR0NHTGVudW0gdHlwZSwgbG9uZyBsb25nIG9mZnNldCwgR0NHTHNpemVp IHByaW1jb3VudCk7Cg==