209862 2020-04-01 10:43:22 -0700 ASSERTION FAILED: m_wrapper on fast/events/scoped/editing-commands.html 2020-05-21 11:03:42 -0700 1 1 1 Unclassified WebKit WebCore JavaScript Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ap cdumez cdumez darin esprehn+autocc ews-watchlist ggaren kangil.han rniwa sihui_liu webkit-bot-watchers-bugzilla webkit-bug-importer ysuzuki oldest_to_newest 1636559 0 ap 2020-04-01 10:43:22 -0700 I get a reproducible assertion failure on fast/events/scoped/editing-commands.html. run-webkit-tests -v --repeat-each 10 -1 --additional-env-var=JSC_slowPathAllocsBetweenGCs=25 LayoutTests/fast/events/scoped/editing-commands.html ASSERTION FAILED: m_wrapper ./bindings/js/JSEventListener.h(125) : JSC::JSObject *WebCore::JSEventListener::ensureJSFunction(WebCore::ScriptExecutionContext &) const 1 0x110217779 WTFCrash 2 0x12804603b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x12a24c76f WebCore::JSEventListener::ensureJSFunction(WebCore::ScriptExecutionContext&) const 4 0x12a24badd WebCore::JSEventListener::handleEvent(WebCore::ScriptExecutionContext&, WebCore::Event&) 5 0x12a898107 WebCore::EventTarget::innerInvokeEventListeners(WebCore::Event&, WTF::Vector<WTF::RefPtr<WebCore::RegisteredEventListener, WTF::DumbPtrTraits<WebCore::RegisteredEventListener> >, 1ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>, WebCore::EventTarget::EventInvokePhase) 6 0x12a894364 WebCore::EventTarget::fireEventListeners(WebCore::Event&, WebCore::EventTarget::EventInvokePhase) 7 0x12a90a5a2 WebCore::Node::handleLocalEvents(WebCore::Event&, WebCore::EventTarget::EventInvokePhase) 8 0x12a882bf1 WebCore::EventContext::handleLocalEvents(WebCore::Event&, WebCore::EventTarget::EventInvokePhase) const 9 0x12a8836bf WebCore::dispatchEventInDOM(WebCore::Event&, WebCore::EventPath const&) 10 0x12a8831f7 WebCore::EventDispatcher::dispatchEvent(WebCore::Node&, WebCore::Event&) 11 0x12a90a5fd WebCore::Node::dispatchEvent(WebCore::Event&) 12 0x12a952b9e WebCore::ScopedEventQueue::dispatchEvent(WebCore::Event&) const 13 0x12a952c25 WebCore::ScopedEventQueue::dispatchAllEvents() 14 0x12a952ddd WebCore::ScopedEventQueue::decrementScopingLevel() 15 0x12a7ba709 WebCore::EventQueueScope::~EventQueueScope() 16 0x12a782d15 WebCore::EventQueueScope::~EventQueueScope() 17 0x12a7a0daa WebCore::Document::execCommand(WTF::String const&, bool, WTF::String const&) 18 0x1288fc9e4 WebCore::jsDocumentPrototypeFunctionExecCommandBody(JSC::JSGlobalObject*, JSC::CallFrame*, WebCore::JSDocument*, JSC::ThrowScope&) 19 0x128802d72 long long WebCore::IDLOperation<WebCore::JSDocument>::call<&(WebCore::jsDocumentPrototypeFunctionExecCommandBody(JSC::JSGlobalObject*, JSC::CallFrame*, WebCore::JSDocument*, JSC::ThrowScope&)), (WebCore::CastedThisErrorBehavior)0>(JSC::JSGlobalObject&, JSC::CallFrame&, char const*) 20 0x128802a54 WebCore::jsDocumentPrototypeFunctionExecCommand(JSC::JSGlobalObject*, JSC::CallFrame*) 21 0x4f297d401178 22 0x1107185b9 llint_entry 23 0x1106fb233 vmEntryToJavaScript 24 0x111484957 JSC::JITCode::execute(JSC::VM*, JSC::ProtoCallFrame*) 25 0x111483f34 JSC::Interpreter::executeProgram(JSC::SourceCode const&, JSC::JSGlobalObject*, JSC::JSObject*) 26 0x1117ecc9c JSC::evaluate(JSC::JSGlobalObject*, JSC::SourceCode const&, JSC::JSValue, WTF::NakedPtr<JSC::Exception>&) 27 0x1117ece48 JSC::profiledEvaluate(JSC::JSGlobalObject*, JSC::ProfilingReason, JSC::SourceCode const&, JSC::JSValue, WTF::NakedPtr<JSC::Exception>&) 28 0x12a2d0018 WebCore::JSExecState::profiledEvaluate(JSC::JSGlobalObject*, JSC::ProfilingReason, JSC::SourceCode const&, JSC::JSValue, WTF::NakedPtr<JSC::Exception>&) 29 0x12a2cfc67 WebCore::ScriptController::evaluateInWorld(WebCore::ScriptSourceCode const&, WebCore::DOMWrapperWorld&) 30 0x12a2cfab9 WebCore::ScriptController::evaluateInWorldIgnoringException(WebCore::ScriptSourceCode const&, WebCore::DOMWrapperWorld&) 31 0x12a2d02f5 WebCore::ScriptController::evaluateIgnoringException(WebCore::ScriptSourceCode const&) 1636560 1 webkit-bug-importer 2020-04-01 10:43:33 -0700 <rdar://problem/61164607> 1636569 2 ap 2020-04-01 11:01:20 -0700 r259292 1654590 3 399876 cdumez 2020-05-20 12:51:24 -0700 Created attachment 399876 Patch 1654707 4 399876 sihui_liu 2020-05-20 16:18:54 -0700 Comment on attachment 399876 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399876&action=review > Source/WebCore/ChangeLog:10 > + so that it keeps alive alive both the target and its JS wrapper. double "alive" > Source/WebCore/dom/ScopedEventQueue.cpp:64 > + Vector<ScopedEvent> queuedEvents = WTFMove(m_queuedEvents); Is there a difference between releasing wrapper after all events are dispatched and releasing wrapper after each event is dispatched? 1654940 5 399959 cdumez 2020-05-21 09:09:48 -0700 Created attachment 399959 Patch 1654961 6 399959 darin 2020-05-21 09:47:34 -0700 Comment on attachment 399959 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399959&action=review > Source/WebCore/dom/ScopedEventQueue.cpp:50 > + ScopedEvent scopedEvent = { WTFMove(event), target }; 3 ways to write this: 1: ScopedEvent scopedEvent { WTFMove(event), target }; 2: ScopedEvent scopedEvent = { WTFMove(event), target }; 3: auto scopedEvent = ScopedEvent { WTFMove(event), target }; Style (1) seems like the most "normal". Antti convinced me to use style (3) in new WebKit code I am writing. > Source/WebCore/dom/ScopedEventQueue.cpp:64 > + Vector<ScopedEvent> queuedEvents = WTFMove(m_queuedEvents); I suggest using auto here. > Source/WebCore/dom/ScopedEventQueue.h:59 > + void dispatchEvent(ScopedEvent&) const; Why does this take a reference? Is this an in/out in some way? 1654964 7 399959 cdumez 2020-05-21 09:50:17 -0700 Comment on attachment 399959 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399959&action=review >> Source/WebCore/dom/ScopedEventQueue.cpp:64 >> + Vector<ScopedEvent> queuedEvents = WTFMove(m_queuedEvents); > > I suggest using auto here. Technically, based on your recent comments, it is supposed to use std::exchange() instead of WTFMove() too since m_queuedEvents is reused after that. 1654967 8 399959 darin 2020-05-21 09:52:46 -0700 Comment on attachment 399959 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=399959&action=review >>> Source/WebCore/dom/ScopedEventQueue.cpp:64 >>> + Vector<ScopedEvent> queuedEvents = WTFMove(m_queuedEvents); >> >> I suggest using auto here. > > Technically, based on your recent comments, it is supposed to use std::exchange() instead of WTFMove() too since m_queuedEvents is reused after that. Good point! 1654971 9 399961 cdumez 2020-05-21 10:04:16 -0700 Created attachment 399961 Patch 1655003 10 ews-feeder 2020-05-21 11:03:41 -0700 Committed r262016: <https://trac.webkit.org/changeset/262016> All reviewed patches have been landed. Closing bug and clearing flags on attachment 399961. 399876 2020-05-20 12:51:24 -0700 2020-05-21 09:09:45 -0700 Patch bug-209862-20200520125123.patch text/plain 3421 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxOTM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzI4NDM3MmVjOGZjYjU2 YTM2YjdmNzBhYTQ3ZGRjMTk4ZGVkOTI4OC4uOGVjZjg1YTE1N2E4N2JmZDljNjQxZDU2ZGVhMzEw YjRjNGE0MGJlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDIwLTA1LTIwICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQVNTRVJUSU9OIEZBSUxFRDog bV93cmFwcGVyIG9uIGZhc3QvZXZlbnRzL3Njb3BlZC9lZGl0aW5nLWNvbW1hbmRzLmh0bWwKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwOTg2MgorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vNjExNjQ2MDc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSBzdXJlIFNjb3BlZEV2ZW50UXVldWUga2VlcHMg aXRzIGV2ZW50IHRhcmdldHMgYWxpdmUgdXNpbmcgYSBHQ1JlYWNoYWJsZVJlZjxOb2RlPgorICAg ICAgICBzbyB0aGF0IGl0IGtlZXBzIGFsaXZlIGFsaXZlIGJvdGggdGhlIHRhcmdldCBhbmQgaXRz IEpTIHdyYXBwZXIuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBjb3ZlcmVkIGJ5IGV4aXN0aW5n IHRlc3QuCisKKyAgICAgICAgKiBkb20vU2NvcGVkRXZlbnRRdWV1ZS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpTY29wZWRFdmVudFF1ZXVlOjplbnF1ZXVlRXZlbnQpOgorICAgICAgICAoV2ViQ29y ZTo6U2NvcGVkRXZlbnRRdWV1ZTo6ZGlzcGF0Y2hFdmVudCBjb25zdCk6CisgICAgICAgIChXZWJD b3JlOjpTY29wZWRFdmVudFF1ZXVlOjpkaXNwYXRjaEFsbEV2ZW50cyk6CisgICAgICAgICogZG9t L1Njb3BlZEV2ZW50UXVldWUuaDoKKwogMjAyMC0wNS0yMCAgQ2hhbmdTZW9rIE9oICA8Y2hhbmdz ZW9rQHdlYmtpdC5vcmc+CiAKICAgICAgICAgTW92ZSB0aGUgVGV4dFN0cmVhbSBsb2dnaW5nIGRl ZmluaXRpb24gaW4gVmlzaWJsZVNlbGVjdGlvbi5jcHAgdG8gdGhlIG91dHNpZGUgb2YgdGhlIFRS RUVfREVCVUdHSU5HIGd1YXJkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vU2NvcGVk RXZlbnRRdWV1ZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vU2NvcGVkRXZlbnRRdWV1ZS5jcHAK aW5kZXggN2E4MzFmMDFmM2JjZWY5OTk4NGM2YWUzMWZmYWE1Y2IyM2VjOGJjZC4uOTI0OTMyZTg3 ZTBkMGM0ZTFlNmUyZDUwODhkMzZlY2U4Y2E5NDFiOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvZG9tL1Njb3BlZEV2ZW50UXVldWUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9TY29w ZWRFdmVudFF1ZXVlLmNwcApAQCAtNDYsMjAgKzQ2LDIyIEBAIFNjb3BlZEV2ZW50UXVldWUmIFNj b3BlZEV2ZW50UXVldWU6OnNpbmdsZXRvbigpCiB2b2lkIFNjb3BlZEV2ZW50UXVldWU6OmVucXVl dWVFdmVudChSZWY8RXZlbnQ+JiYgZXZlbnQpCiB7CiAgICAgQVNTRVJUKGlzPE5vZGU+KGV2ZW50 LT50YXJnZXQoKSkpOworICAgIGF1dG8mIHRhcmdldCA9IGRvd25jYXN0PE5vZGU+KCpldmVudC0+ dGFyZ2V0KCkpOworICAgIFNjb3BlZEV2ZW50IHNjb3BlZEV2ZW50ID0geyBXVEZNb3ZlKGV2ZW50 KSwgdGFyZ2V0IH07CiAgICAgaWYgKG1fc2NvcGluZ0xldmVsKQotICAgICAgICBtX3F1ZXVlZEV2 ZW50cy5hcHBlbmQoV1RGTW92ZShldmVudCkpOworICAgICAgICBtX3F1ZXVlZEV2ZW50cy5hcHBl bmQoV1RGTW92ZShzY29wZWRFdmVudCkpOwogICAgIGVsc2UKLSAgICAgICAgZGlzcGF0Y2hFdmVu dChldmVudCk7CisgICAgICAgIGRpc3BhdGNoRXZlbnQoc2NvcGVkRXZlbnQpOwogfQogCi12b2lk IFNjb3BlZEV2ZW50UXVldWU6OmRpc3BhdGNoRXZlbnQoRXZlbnQmIGV2ZW50KSBjb25zdAordm9p ZCBTY29wZWRFdmVudFF1ZXVlOjpkaXNwYXRjaEV2ZW50KFNjb3BlZEV2ZW50JiBldmVudCkgY29u c3QKIHsKLSAgICBkb3duY2FzdDxOb2RlPigqZXZlbnQudGFyZ2V0KCkpLmRpc3BhdGNoRXZlbnQo ZXZlbnQpOworICAgIGV2ZW50LnRhcmdldC0+ZGlzcGF0Y2hFdmVudChldmVudC5ldmVudCk7CiB9 CiAKIHZvaWQgU2NvcGVkRXZlbnRRdWV1ZTo6ZGlzcGF0Y2hBbGxFdmVudHMoKQogewotICAgIFZl Y3RvcjxSZWY8RXZlbnQ+PiBxdWV1ZWRFdmVudHMgPSBXVEZNb3ZlKG1fcXVldWVkRXZlbnRzKTsK KyAgICBWZWN0b3I8U2NvcGVkRXZlbnQ+IHF1ZXVlZEV2ZW50cyA9IFdURk1vdmUobV9xdWV1ZWRF dmVudHMpOwogICAgIGZvciAoYXV0byYgcXVldWVkRXZlbnQgOiBxdWV1ZWRFdmVudHMpCiAgICAg ICAgIGRpc3BhdGNoRXZlbnQocXVldWVkRXZlbnQpOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvZG9tL1Njb3BlZEV2ZW50UXVldWUuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9TY29wZWRF dmVudFF1ZXVlLmgKaW5kZXggM2FiODk5MjhlMmQ0NTk4NDQzMDMzMTYxYWEzNWRkODBjYjE3Y2Zi Yi4uNDFkYzU3MWIwY2I2ODQ0YTVkZDNmNTNlNTM2OWU4ZTJlNzJkN2RlYiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvZG9tL1Njb3BlZEV2ZW50UXVldWUuaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9kb20vU2NvcGVkRXZlbnRRdWV1ZS5oCkBAIC0zMCw2ICszMCw3IEBACiAKICNwcmFnbWEgb25j ZQogCisjaW5jbHVkZSAiR0NSZWFjaGFibGVSZWYuaCIKICNpbmNsdWRlIDx3dGYvRm9yd2FyZC5o PgogI2luY2x1ZGUgPHd0Zi9Ob25jb3B5YWJsZS5oPgogI2luY2x1ZGUgPHd0Zi9SZWYuaD4KQEAg LTUwLDEyICs1MSwxNyBAQCBwcml2YXRlOgogICAgIFNjb3BlZEV2ZW50UXVldWUoKSA9IGRlZmF1 bHQ7CiAgICAgflNjb3BlZEV2ZW50UXVldWUoKSA9IGRlbGV0ZTsKIAotICAgIHZvaWQgZGlzcGF0 Y2hFdmVudChFdmVudCYpIGNvbnN0OworICAgIHN0cnVjdCBTY29wZWRFdmVudCB7CisgICAgICAg IFJlZjxFdmVudD4gZXZlbnQ7CisgICAgICAgIEdDUmVhY2hhYmxlUmVmPE5vZGU+IHRhcmdldDsK KyAgICB9OworCisgICAgdm9pZCBkaXNwYXRjaEV2ZW50KFNjb3BlZEV2ZW50JikgY29uc3Q7CiAg ICAgdm9pZCBkaXNwYXRjaEFsbEV2ZW50cygpOwogICAgIHZvaWQgaW5jcmVtZW50U2NvcGluZ0xl dmVsKCk7CiAgICAgdm9pZCBkZWNyZW1lbnRTY29waW5nTGV2ZWwoKTsKIAotICAgIFZlY3RvcjxS ZWY8RXZlbnQ+PiBtX3F1ZXVlZEV2ZW50czsKKyAgICBWZWN0b3I8U2NvcGVkRXZlbnQ+IG1fcXVl dWVkRXZlbnRzOwogICAgIHVuc2lnbmVkIG1fc2NvcGluZ0xldmVsIHsgMCB9OwogCiAgICAgZnJp ZW5kIGNsYXNzIFdURjo6TmV2ZXJEZXN0cm95ZWQ8V2ViQ29yZTo6U2NvcGVkRXZlbnRRdWV1ZT47 Cg== 399959 2020-05-21 09:09:48 -0700 2020-05-21 10:04:13 -0700 Patch bug-209862-20200521090947.patch text/plain 3348 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyMDA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzg0NGI4OWY3MWU3OGYx MjA5ZGMxYzgzMmNmYzIxMmQxZDkzNzI0Yi4uYzEwMDVlMTFjYzJjNTNiNmEwNzMwN2Y1N2UwOGY5 NTFhYTJlOGUwNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDIwLTA1LTIxICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQVNTRVJUSU9OIEZBSUxFRDog bV93cmFwcGVyIG9uIGZhc3QvZXZlbnRzL3Njb3BlZC9lZGl0aW5nLWNvbW1hbmRzLmh0bWwKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwOTg2MgorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vNjExNjQ2MDc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSBzdXJlIFNjb3BlZEV2ZW50UXVldWUga2VlcHMg aXRzIGV2ZW50IHRhcmdldHMgYWxpdmUgdXNpbmcgYSBHQ1JlYWNoYWJsZVJlZjxOb2RlPgorICAg ICAgICBzbyB0aGF0IGl0IGtlZXBzIGFsaXZlIGJvdGggdGhlIHRhcmdldCBhbmQgaXRzIEpTIHdy YXBwZXIuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBjb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3Qu CisKKyAgICAgICAgKiBkb20vU2NvcGVkRXZlbnRRdWV1ZS5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpTY29wZWRFdmVudFF1ZXVlOjplbnF1ZXVlRXZlbnQpOgorICAgICAgICAoV2ViQ29yZTo6U2Nv cGVkRXZlbnRRdWV1ZTo6ZGlzcGF0Y2hFdmVudCBjb25zdCk6CisgICAgICAgIChXZWJDb3JlOjpT Y29wZWRFdmVudFF1ZXVlOjpkaXNwYXRjaEFsbEV2ZW50cyk6CisgICAgICAgICogZG9tL1Njb3Bl ZEV2ZW50UXVldWUuaDoKKwogMjAyMC0wNS0yMSAgRG91ZyBLZWxseSAgPGRvdWdrQGFwcGxlLmNv bT4KIAogICAgICAgICBEaXNwYXRjaCBwZW5kaW5nIGV2ZW50cyBvbmx5IGZvciBjdXJyZW50IHBh Z2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9TY29wZWRFdmVudFF1ZXVlLmNwcCBi L1NvdXJjZS9XZWJDb3JlL2RvbS9TY29wZWRFdmVudFF1ZXVlLmNwcAppbmRleCA3YTgzMWYwMWYz YmNlZjk5OTg0YzZhZTMxZmZhYTVjYjIzZWM4YmNkLi45MjQ5MzJlODdlMGQwYzRlMWU2ZTJkNTA4 OGQzNmVjZThjYTk0MWI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vU2NvcGVkRXZl bnRRdWV1ZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL1Njb3BlZEV2ZW50UXVldWUuY3Bw CkBAIC00NiwyMCArNDYsMjIgQEAgU2NvcGVkRXZlbnRRdWV1ZSYgU2NvcGVkRXZlbnRRdWV1ZTo6 c2luZ2xldG9uKCkKIHZvaWQgU2NvcGVkRXZlbnRRdWV1ZTo6ZW5xdWV1ZUV2ZW50KFJlZjxFdmVu dD4mJiBldmVudCkKIHsKICAgICBBU1NFUlQoaXM8Tm9kZT4oZXZlbnQtPnRhcmdldCgpKSk7Cisg ICAgYXV0byYgdGFyZ2V0ID0gZG93bmNhc3Q8Tm9kZT4oKmV2ZW50LT50YXJnZXQoKSk7CisgICAg U2NvcGVkRXZlbnQgc2NvcGVkRXZlbnQgPSB7IFdURk1vdmUoZXZlbnQpLCB0YXJnZXQgfTsKICAg ICBpZiAobV9zY29waW5nTGV2ZWwpCi0gICAgICAgIG1fcXVldWVkRXZlbnRzLmFwcGVuZChXVEZN b3ZlKGV2ZW50KSk7CisgICAgICAgIG1fcXVldWVkRXZlbnRzLmFwcGVuZChXVEZNb3ZlKHNjb3Bl ZEV2ZW50KSk7CiAgICAgZWxzZQotICAgICAgICBkaXNwYXRjaEV2ZW50KGV2ZW50KTsKKyAgICAg ICAgZGlzcGF0Y2hFdmVudChzY29wZWRFdmVudCk7CiB9CiAKLXZvaWQgU2NvcGVkRXZlbnRRdWV1 ZTo6ZGlzcGF0Y2hFdmVudChFdmVudCYgZXZlbnQpIGNvbnN0Cit2b2lkIFNjb3BlZEV2ZW50UXVl dWU6OmRpc3BhdGNoRXZlbnQoU2NvcGVkRXZlbnQmIGV2ZW50KSBjb25zdAogewotICAgIGRvd25j YXN0PE5vZGU+KCpldmVudC50YXJnZXQoKSkuZGlzcGF0Y2hFdmVudChldmVudCk7CisgICAgZXZl bnQudGFyZ2V0LT5kaXNwYXRjaEV2ZW50KGV2ZW50LmV2ZW50KTsKIH0KIAogdm9pZCBTY29wZWRF dmVudFF1ZXVlOjpkaXNwYXRjaEFsbEV2ZW50cygpCiB7Ci0gICAgVmVjdG9yPFJlZjxFdmVudD4+ IHF1ZXVlZEV2ZW50cyA9IFdURk1vdmUobV9xdWV1ZWRFdmVudHMpOworICAgIFZlY3RvcjxTY29w ZWRFdmVudD4gcXVldWVkRXZlbnRzID0gV1RGTW92ZShtX3F1ZXVlZEV2ZW50cyk7CiAgICAgZm9y IChhdXRvJiBxdWV1ZWRFdmVudCA6IHF1ZXVlZEV2ZW50cykKICAgICAgICAgZGlzcGF0Y2hFdmVu dChxdWV1ZWRFdmVudCk7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vU2NvcGVk RXZlbnRRdWV1ZS5oIGIvU291cmNlL1dlYkNvcmUvZG9tL1Njb3BlZEV2ZW50UXVldWUuaAppbmRl eCAzYWI4OTkyOGUyZDQ1OTg0NDMwMzMxNjFhYTM1ZGQ4MGNiMTdjZmJiLi40MWRjNTcxYjBjYjY4 NDRhNWRkM2Y1M2U1MzY5ZThlMmU3MmQ3ZGViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9k b20vU2NvcGVkRXZlbnRRdWV1ZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9TY29wZWRFdmVu dFF1ZXVlLmgKQEAgLTMwLDYgKzMwLDcgQEAKIAogI3ByYWdtYSBvbmNlCiAKKyNpbmNsdWRlICJH Q1JlYWNoYWJsZVJlZi5oIgogI2luY2x1ZGUgPHd0Zi9Gb3J3YXJkLmg+CiAjaW5jbHVkZSA8d3Rm L05vbmNvcHlhYmxlLmg+CiAjaW5jbHVkZSA8d3RmL1JlZi5oPgpAQCAtNTAsMTIgKzUxLDE3IEBA IHByaXZhdGU6CiAgICAgU2NvcGVkRXZlbnRRdWV1ZSgpID0gZGVmYXVsdDsKICAgICB+U2NvcGVk RXZlbnRRdWV1ZSgpID0gZGVsZXRlOwogCi0gICAgdm9pZCBkaXNwYXRjaEV2ZW50KEV2ZW50Jikg Y29uc3Q7CisgICAgc3RydWN0IFNjb3BlZEV2ZW50IHsKKyAgICAgICAgUmVmPEV2ZW50PiBldmVu dDsKKyAgICAgICAgR0NSZWFjaGFibGVSZWY8Tm9kZT4gdGFyZ2V0OworICAgIH07CisKKyAgICB2 b2lkIGRpc3BhdGNoRXZlbnQoU2NvcGVkRXZlbnQmKSBjb25zdDsKICAgICB2b2lkIGRpc3BhdGNo QWxsRXZlbnRzKCk7CiAgICAgdm9pZCBpbmNyZW1lbnRTY29waW5nTGV2ZWwoKTsKICAgICB2b2lk IGRlY3JlbWVudFNjb3BpbmdMZXZlbCgpOwogCi0gICAgVmVjdG9yPFJlZjxFdmVudD4+IG1fcXVl dWVkRXZlbnRzOworICAgIFZlY3RvcjxTY29wZWRFdmVudD4gbV9xdWV1ZWRFdmVudHM7CiAgICAg dW5zaWduZWQgbV9zY29waW5nTGV2ZWwgeyAwIH07CiAKICAgICBmcmllbmQgY2xhc3MgV1RGOjpO ZXZlckRlc3Ryb3llZDxXZWJDb3JlOjpTY29wZWRFdmVudFF1ZXVlPjsK 399961 2020-05-21 10:04:16 -0700 2020-05-21 11:03:41 -0700 Patch bug-209862-20200521100415.patch text/plain 3353 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyMDA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzg0NGI4OWY3MWU3OGYx MjA5ZGMxYzgzMmNmYzIxMmQxZDkzNzI0Yi4uYmI0ZDhkYWIyNDljYjE3NDdiMmI3MDM5M2RhM2I0 NmZiNDY3MmQ4MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDIwLTA1LTIxICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQVNTRVJUSU9OIEZBSUxFRDog bV93cmFwcGVyIG9uIGZhc3QvZXZlbnRzL3Njb3BlZC9lZGl0aW5nLWNvbW1hbmRzLmh0bWwKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwOTg2MgorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vNjExNjQ2MDc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFy aW4gQWRsZXIuCisKKyAgICAgICAgTWFrZSBzdXJlIFNjb3BlZEV2ZW50UXVldWUga2VlcHMgaXRz IGV2ZW50IHRhcmdldHMgYWxpdmUgdXNpbmcgYSBHQ1JlYWNoYWJsZVJlZjxOb2RlPgorICAgICAg ICBzbyB0aGF0IGl0IGtlZXBzIGFsaXZlIGJvdGggdGhlIHRhcmdldCBhbmQgaXRzIEpTIHdyYXBw ZXIuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBjb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3QuCisK KyAgICAgICAgKiBkb20vU2NvcGVkRXZlbnRRdWV1ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpT Y29wZWRFdmVudFF1ZXVlOjplbnF1ZXVlRXZlbnQpOgorICAgICAgICAoV2ViQ29yZTo6U2NvcGVk RXZlbnRRdWV1ZTo6ZGlzcGF0Y2hFdmVudCBjb25zdCk6CisgICAgICAgIChXZWJDb3JlOjpTY29w ZWRFdmVudFF1ZXVlOjpkaXNwYXRjaEFsbEV2ZW50cyk6CisgICAgICAgICogZG9tL1Njb3BlZEV2 ZW50UXVldWUuaDoKKwogMjAyMC0wNS0yMSAgRG91ZyBLZWxseSAgPGRvdWdrQGFwcGxlLmNvbT4K IAogICAgICAgICBEaXNwYXRjaCBwZW5kaW5nIGV2ZW50cyBvbmx5IGZvciBjdXJyZW50IHBhZ2UK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9TY29wZWRFdmVudFF1ZXVlLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2RvbS9TY29wZWRFdmVudFF1ZXVlLmNwcAppbmRleCA3YTgzMWYwMWYzYmNl Zjk5OTg0YzZhZTMxZmZhYTVjYjIzZWM4YmNkLi43YmI5YjAxN2JmZDZlNjI2NGY0M2FhNGM3MTI3 MDM1ZmJmOTlhMjIxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vU2NvcGVkRXZlbnRR dWV1ZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL1Njb3BlZEV2ZW50UXVldWUuY3BwCkBA IC00NiwyMCArNDYsMjIgQEAgU2NvcGVkRXZlbnRRdWV1ZSYgU2NvcGVkRXZlbnRRdWV1ZTo6c2lu Z2xldG9uKCkKIHZvaWQgU2NvcGVkRXZlbnRRdWV1ZTo6ZW5xdWV1ZUV2ZW50KFJlZjxFdmVudD4m JiBldmVudCkKIHsKICAgICBBU1NFUlQoaXM8Tm9kZT4oZXZlbnQtPnRhcmdldCgpKSk7CisgICAg YXV0byYgdGFyZ2V0ID0gZG93bmNhc3Q8Tm9kZT4oKmV2ZW50LT50YXJnZXQoKSk7CisgICAgU2Nv cGVkRXZlbnQgc2NvcGVkRXZlbnQgPSB7IFdURk1vdmUoZXZlbnQpLCB0YXJnZXQgfTsKICAgICBp ZiAobV9zY29waW5nTGV2ZWwpCi0gICAgICAgIG1fcXVldWVkRXZlbnRzLmFwcGVuZChXVEZNb3Zl KGV2ZW50KSk7CisgICAgICAgIG1fcXVldWVkRXZlbnRzLmFwcGVuZChXVEZNb3ZlKHNjb3BlZEV2 ZW50KSk7CiAgICAgZWxzZQotICAgICAgICBkaXNwYXRjaEV2ZW50KGV2ZW50KTsKKyAgICAgICAg ZGlzcGF0Y2hFdmVudChzY29wZWRFdmVudCk7CiB9CiAKLXZvaWQgU2NvcGVkRXZlbnRRdWV1ZTo6 ZGlzcGF0Y2hFdmVudChFdmVudCYgZXZlbnQpIGNvbnN0Cit2b2lkIFNjb3BlZEV2ZW50UXVldWU6 OmRpc3BhdGNoRXZlbnQoY29uc3QgU2NvcGVkRXZlbnQmIGV2ZW50KSBjb25zdAogewotICAgIGRv d25jYXN0PE5vZGU+KCpldmVudC50YXJnZXQoKSkuZGlzcGF0Y2hFdmVudChldmVudCk7CisgICAg ZXZlbnQudGFyZ2V0LT5kaXNwYXRjaEV2ZW50KGV2ZW50LmV2ZW50KTsKIH0KIAogdm9pZCBTY29w ZWRFdmVudFF1ZXVlOjpkaXNwYXRjaEFsbEV2ZW50cygpCiB7Ci0gICAgVmVjdG9yPFJlZjxFdmVu dD4+IHF1ZXVlZEV2ZW50cyA9IFdURk1vdmUobV9xdWV1ZWRFdmVudHMpOworICAgIGF1dG8gcXVl dWVkRXZlbnRzID0gc3RkOjpleGNoYW5nZShtX3F1ZXVlZEV2ZW50cywgeyB9KTsKICAgICBmb3Ig KGF1dG8mIHF1ZXVlZEV2ZW50IDogcXVldWVkRXZlbnRzKQogICAgICAgICBkaXNwYXRjaEV2ZW50 KHF1ZXVlZEV2ZW50KTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9TY29wZWRF dmVudFF1ZXVlLmggYi9Tb3VyY2UvV2ViQ29yZS9kb20vU2NvcGVkRXZlbnRRdWV1ZS5oCmluZGV4 IDNhYjg5OTI4ZTJkNDU5ODQ0MzAzMzE2MWFhMzVkZDgwY2IxN2NmYmIuLmZmMjZlNmUwMzU0OWNj NGM5MmFiYzQ1MGYzNmYxMGE1YWE1ZmJjNDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Rv bS9TY29wZWRFdmVudFF1ZXVlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL1Njb3BlZEV2ZW50 UXVldWUuaApAQCAtMzAsNiArMzAsNyBAQAogCiAjcHJhZ21hIG9uY2UKIAorI2luY2x1ZGUgIkdD UmVhY2hhYmxlUmVmLmgiCiAjaW5jbHVkZSA8d3RmL0ZvcndhcmQuaD4KICNpbmNsdWRlIDx3dGYv Tm9uY29weWFibGUuaD4KICNpbmNsdWRlIDx3dGYvUmVmLmg+CkBAIC01MCwxMiArNTEsMTcgQEAg cHJpdmF0ZToKICAgICBTY29wZWRFdmVudFF1ZXVlKCkgPSBkZWZhdWx0OwogICAgIH5TY29wZWRF dmVudFF1ZXVlKCkgPSBkZWxldGU7CiAKLSAgICB2b2lkIGRpc3BhdGNoRXZlbnQoRXZlbnQmKSBj b25zdDsKKyAgICBzdHJ1Y3QgU2NvcGVkRXZlbnQgeworICAgICAgICBSZWY8RXZlbnQ+IGV2ZW50 OworICAgICAgICBHQ1JlYWNoYWJsZVJlZjxOb2RlPiB0YXJnZXQ7CisgICAgfTsKKworICAgIHZv aWQgZGlzcGF0Y2hFdmVudChjb25zdCBTY29wZWRFdmVudCYpIGNvbnN0OwogICAgIHZvaWQgZGlz cGF0Y2hBbGxFdmVudHMoKTsKICAgICB2b2lkIGluY3JlbWVudFNjb3BpbmdMZXZlbCgpOwogICAg IHZvaWQgZGVjcmVtZW50U2NvcGluZ0xldmVsKCk7CiAKLSAgICBWZWN0b3I8UmVmPEV2ZW50Pj4g bV9xdWV1ZWRFdmVudHM7CisgICAgVmVjdG9yPFNjb3BlZEV2ZW50PiBtX3F1ZXVlZEV2ZW50czsK ICAgICB1bnNpZ25lZCBtX3Njb3BpbmdMZXZlbCB7IDAgfTsKIAogICAgIGZyaWVuZCBjbGFzcyBX VEY6Ok5ldmVyRGVzdHJveWVkPFdlYkNvcmU6OlNjb3BlZEV2ZW50UXVldWU+Owo=