209860 2020-04-01 09:01:12 -0700 REGRESSION(r259282): Caused memory corruption (Requested by ap on #webkit). 2020-04-01 09:04:13 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 209790 1 commit-queue commit-queue simon.fraser webkit-bug-importer zalan oldest_to_newest 1636513 0 commit-queue 2020-04-01 09:01:12 -0700 https://trac.webkit.org/changeset/259282 broke the build: Caused memory corruption (Requested by ap on #webkit). This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail. 1636515 1 395172 commit-queue 2020-04-01 09:01:18 -0700 Created attachment 395172 REVERT of r259282 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the revert will be successful. This process takes approximately 15 minutes. If you would like to land the revert faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 1636517 2 ap 2020-04-01 09:03:02 -0700 rdar://problem/61126964 1636518 3 ews-feeder 2020-04-01 09:04:13 -0700 Committed r259347: <https://trac.webkit.org/changeset/259347> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395172. 395172 2020-04-01 09:01:18 -0700 2020-04-01 09:04:13 -0700 REVERT of r259282 bug-209860-20200401090117.patch text/plain 6980 commit-queue U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5MzQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGE1MjZiOTMxNDUzM2Yx MTk1YTMzYTU3NWFiYWE4NGZkNjdkYzdkZi4uMGQxZjQxNGI3OThjNzhkY2FiNDhhZmRiNDVhMWU0 NGE3NjQ4ZDgxMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTA0LTAxICBDb21t aXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KKworICAgICAgICBVbnJldmlld2Vk LCByZXZlcnRpbmcgcjI1OTI4Mi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIwOTg2MAorCisgICAgICAgIENhdXNlZCBtZW1vcnkgY29ycnVwdGlvbiAo UmVxdWVzdGVkIGJ5IGFwIG9uICN3ZWJraXQpLgorCisgICAgICAgIFJldmVydGVkIGNoYW5nZXNl dDoKKworICAgICAgICAiU2Nyb2xsIGxhdGNoaW5nIHN0YXRlIGlzIG5vdCBhIHN0YWNrIgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA5NzkwCisgICAg ICAgIGh0dHBzOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8yNTkyODIKKwogMjAyMC0wNC0w MSAgeW91ZW5uIGZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgQnVtcCBsaWJ3 ZWJydGMgdG8gTTgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2UuY3BwIGIv U291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmNwcAppbmRleCBmY2RlZWI4NDI1OWRkYzdhNDg1NTU4 MmFiODliYzc4ZmE1MjZhZjY2Li45ZjBhNDA2ZGU0MTQ5MTgzZjg1MTE2MTI0YjNlZDVjMTliMWVm MmViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2UuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvUGFnZS5jcHAKQEAgLTI5NDMsMjYgKzI5NDMsNDEgQEAgdm9pZCBQYWdl OjphcHBsaWNhdGlvbkRpZEJlY29tZUFjdGl2ZSgpCiAjaWYgRU5BQkxFKFdIRUVMX0VWRU5UX0xB VENISU5HKQogU2Nyb2xsTGF0Y2hpbmdTdGF0ZSogUGFnZTo6bGF0Y2hpbmdTdGF0ZSgpCiB7Ci0g ICAgcmV0dXJuIG1fbGF0Y2hpbmdTdGF0ZS5nZXQoKTsKKyAgICBpZiAobV9sYXRjaGluZ1N0YXRl LmlzRW1wdHkoKSkKKyAgICAgICAgcmV0dXJuIG51bGxwdHI7CisKKyAgICByZXR1cm4gJm1fbGF0 Y2hpbmdTdGF0ZS5sYXN0KCk7CiB9CiAKLXZvaWQgUGFnZTo6c2V0TGF0Y2hpbmdTdGF0ZShzdGQ6 OnVuaXF1ZV9wdHI8U2Nyb2xsTGF0Y2hpbmdTdGF0ZT4mJiBzdGF0ZSkKK3ZvaWQgUGFnZTo6cHVz aE5ld0xhdGNoaW5nU3RhdGUoU2Nyb2xsTGF0Y2hpbmdTdGF0ZSYmIHN0YXRlKQogewotICAgIG1f bGF0Y2hpbmdTdGF0ZSA9IFdURk1vdmUoc3RhdGUpOworICAgIG1fbGF0Y2hpbmdTdGF0ZS5hcHBl bmQoV1RGTW92ZShzdGF0ZSkpOwogfQogCiB2b2lkIFBhZ2U6OnJlc2V0TGF0Y2hpbmdTdGF0ZSgp CiB7Ci0gICAgbV9sYXRjaGluZ1N0YXRlID0gbnVsbHB0cjsKKyAgICBtX2xhdGNoaW5nU3RhdGUu Y2xlYXIoKTsKK30KKwordm9pZCBQYWdlOjpwb3BMYXRjaGluZ1N0YXRlKCkKK3sKKyAgICBtX2xh dGNoaW5nU3RhdGUucmVtb3ZlTGFzdCgpOworICAgIExPR19XSVRIX1NUUkVBTShTY3JvbGxMYXRj aGluZywgc3RyZWFtIDw8ICJQYWdlOjpwb3BMYXRjaGluZ1N0YXRlKCkgLSBuZXcgc3RhdGUgIiA8 PCBtX2xhdGNoaW5nU3RhdGUpOwogfQogCiB2b2lkIFBhZ2U6OnJlbW92ZUxhdGNoaW5nU3RhdGVG b3JUYXJnZXQoRWxlbWVudCYgdGFyZ2V0Tm9kZSkKIHsKLSAgICBpZiAoIW1fbGF0Y2hpbmdTdGF0 ZSkKKyAgICBpZiAobV9sYXRjaGluZ1N0YXRlLmlzRW1wdHkoKSkKICAgICAgICAgcmV0dXJuOwog Ci0gICAgaWYgKG1fbGF0Y2hpbmdTdGF0ZS0+d2hlZWxFdmVudEVsZW1lbnQoKSA9PSAmdGFyZ2V0 Tm9kZSkKLSAgICAgICAgbV9sYXRjaGluZ1N0YXRlID0gbnVsbHB0cjsKKyAgICBtX2xhdGNoaW5n U3RhdGUucmVtb3ZlQWxsTWF0Y2hpbmcoWyZ0YXJnZXROb2RlXSAoU2Nyb2xsTGF0Y2hpbmdTdGF0 ZSYgc3RhdGUpIHsKKyAgICAgICAgYXV0byogd2hlZWxFbGVtZW50ID0gc3RhdGUud2hlZWxFdmVu dEVsZW1lbnQoKTsKKyAgICAgICAgaWYgKCF3aGVlbEVsZW1lbnQpCisgICAgICAgICAgICByZXR1 cm4gZmFsc2U7CisKKyAgICAgICAgcmV0dXJuIHRhcmdldE5vZGUuaXNFcXVhbE5vZGUod2hlZWxF bGVtZW50KTsKKyAgICB9KTsKKyAgICBMT0dfV0lUSF9TVFJFQU0oU2Nyb2xsTGF0Y2hpbmcsIHN0 cmVhbSA8PCAiUGFnZTo6cmVtb3ZlTGF0Y2hpbmdTdGF0ZUZvclRhcmdldCgpIC0gbmV3IHN0YXRl ICIgPDwgbV9sYXRjaGluZ1N0YXRlKTsKIH0KICNlbmRpZiAvLyBFTkFCTEUoV0hFRUxfRVZFTlRf TEFUQ0hJTkcpCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5oIGIvU291 cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmgKaW5kZXggOTNjZjllNjUzYTkxYjY3M2U2YTUwMDkzNjBm ZTJhOTZlOTQ1NGI1Ny4uZTI0ODRmNjNkZGNjMTM1NzUwMTZkZTk3NjIyNzYyNThlMjU1ODVhYyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmgKKysrIGIvU291cmNlL1dlYkNv cmUvcGFnZS9QYWdlLmgKQEAgLTQzMCw3ICs0MzAsOSBAQCBwdWJsaWM6CiAKICNpZiBFTkFCTEUo V0hFRUxfRVZFTlRfTEFUQ0hJTkcpCiAgICAgU2Nyb2xsTGF0Y2hpbmdTdGF0ZSogbGF0Y2hpbmdT dGF0ZSgpOwotICAgIHZvaWQgc2V0TGF0Y2hpbmdTdGF0ZShzdGQ6OnVuaXF1ZV9wdHI8U2Nyb2xs TGF0Y2hpbmdTdGF0ZT4mJik7CisgICAgY29uc3QgVmVjdG9yPFNjcm9sbExhdGNoaW5nU3RhdGU+ JiBsYXRjaGluZ1N0YXRlU3RhY2soKSBjb25zdCB7IHJldHVybiBtX2xhdGNoaW5nU3RhdGU7IH0K KyAgICB2b2lkIHB1c2hOZXdMYXRjaGluZ1N0YXRlKFNjcm9sbExhdGNoaW5nU3RhdGUmJik7Cisg ICAgdm9pZCBwb3BMYXRjaGluZ1N0YXRlKCk7CiAgICAgdm9pZCByZXNldExhdGNoaW5nU3RhdGUo KTsKICAgICB2b2lkIHJlbW92ZUxhdGNoaW5nU3RhdGVGb3JUYXJnZXQoRWxlbWVudCYpOwogI2Vu ZGlmIC8vIEVOQUJMRShXSEVFTF9FVkVOVF9MQVRDSElORykKQEAgLTk3OCw3ICs5ODAsNyBAQCBw cml2YXRlOgogCiAgICAgc3RkOjp1bmlxdWVfcHRyPFBlcmZvcm1hbmNlTG9nZ2luZz4gbV9wZXJm b3JtYW5jZUxvZ2dpbmc7CiAjaWYgRU5BQkxFKFdIRUVMX0VWRU5UX0xBVENISU5HKQotICAgIHN0 ZDo6dW5pcXVlX3B0cjxTY3JvbGxMYXRjaGluZ1N0YXRlPiBtX2xhdGNoaW5nU3RhdGU7CisgICAg VmVjdG9yPFNjcm9sbExhdGNoaW5nU3RhdGU+IG1fbGF0Y2hpbmdTdGF0ZTsKICNlbmRpZgogI2lm IFBMQVRGT1JNKE1BQykgJiYgKEVOQUJMRShTRVJWSUNFX0NPTlRST0xTKSB8fCBFTkFCTEUoVEVM RVBIT05FX05VTUJFUl9ERVRFQ1RJT04pKQogICAgIHN0ZDo6dW5pcXVlX3B0cjxTZXJ2aWNlc092 ZXJsYXlDb250cm9sbGVyPiBtX3NlcnZpY2VzT3ZlcmxheUNvbnRyb2xsZXI7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wYWdlL21hYy9FdmVudEhhbmRsZXJNYWMubW0gYi9Tb3VyY2UvV2Vi Q29yZS9wYWdlL21hYy9FdmVudEhhbmRsZXJNYWMubW0KaW5kZXggZWY1ZTNjZTBlYzdhNjEyMTgx MDI0MWVlNzUxZmFkMzVmY2FhNTA1MC4uNjQ0MjcwMTc2YTE4NTY3OTM5NjZhZDZmZDkwNzY5ZTM1 ODk4NDY2OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9tYWMvRXZlbnRIYW5kbGVy TWFjLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvbWFjL0V2ZW50SGFuZGxlck1hYy5tbQpA QCAtOTgzLDIzICs5ODMsMjMgQEAgdm9pZCBFdmVudEhhbmRsZXI6OnBsYXRmb3JtUHJlcGFyZUZv cldoZWVsRXZlbnRzKGNvbnN0IFBsYXRmb3JtV2hlZWxFdmVudCYgd2hlZWwKICAgICAgICAgaWYg KHNjcm9sbGFibGVDb250YWluZXIgJiYgc2Nyb2xsYWJsZUFyZWEpIHsKICAgICAgICAgICAgIGJv b2wgc3RhcnRpbmdBdFNjcm9sbExpbWl0ID0gc2Nyb2xsZWRUb0VkZ2VJbkRvbWluYW50RGlyZWN0 aW9uKCpzY3JvbGxhYmxlQ29udGFpbmVyLCAqc2Nyb2xsYWJsZUFyZWEuZ2V0KCksIHdoZWVsRXZl bnQuZGVsdGFYKCksIHdoZWVsRXZlbnQuZGVsdGFZKCkpOwogICAgICAgICAgICAgaWYgKCFzdGFy dGluZ0F0U2Nyb2xsTGltaXQpIHsKLSAgICAgICAgICAgICAgICBhdXRvIGxhdGNoaW5nU3RhdGUg PSBXVEY6Om1ha2VVbmlxdWU8U2Nyb2xsTGF0Y2hpbmdTdGF0ZT4oKTsKLSAgICAgICAgICAgICAg ICBsYXRjaGluZ1N0YXRlLT5zZXRTdGFydGVkR2VzdHVyZUF0U2Nyb2xsTGltaXQoZmFsc2UpOwot ICAgICAgICAgICAgICAgIGxhdGNoaW5nU3RhdGUtPnNldFdoZWVsRXZlbnRFbGVtZW50KHdoZWVs RXZlbnRUYXJnZXQuZ2V0KCkpOwotICAgICAgICAgICAgICAgIGxhdGNoaW5nU3RhdGUtPnNldEZy YW1lKCZtX2ZyYW1lKTsKLSAgICAgICAgICAgICAgICBsYXRjaGluZ1N0YXRlLT5zZXRTY3JvbGxh YmxlQ29udGFpbmVyKHNjcm9sbGFibGVDb250YWluZXIuZ2V0KCkpOwotICAgICAgICAgICAgICAg IGxhdGNoaW5nU3RhdGUtPnNldFdpZGdldElzTGF0Y2hlZChyZXN1bHQuaXNPdmVyV2lkZ2V0KCkp OwotICAgICAgICAgICAgICAgIHBhZ2UtPnNldExhdGNoaW5nU3RhdGUoV1RGTW92ZShsYXRjaGlu Z1N0YXRlKSk7CisgICAgICAgICAgICAgICAgU2Nyb2xsTGF0Y2hpbmdTdGF0ZSBsYXRjaGluZ1N0 YXRlOworICAgICAgICAgICAgICAgIGxhdGNoaW5nU3RhdGUuc2V0U3RhcnRlZEdlc3R1cmVBdFNj cm9sbExpbWl0KGZhbHNlKTsKKyAgICAgICAgICAgICAgICBsYXRjaGluZ1N0YXRlLnNldFdoZWVs RXZlbnRFbGVtZW50KHdoZWVsRXZlbnRUYXJnZXQuZ2V0KCkpOworICAgICAgICAgICAgICAgIGxh dGNoaW5nU3RhdGUuc2V0RnJhbWUoJm1fZnJhbWUpOworICAgICAgICAgICAgICAgIGxhdGNoaW5n U3RhdGUuc2V0U2Nyb2xsYWJsZUNvbnRhaW5lcihzY3JvbGxhYmxlQ29udGFpbmVyLmdldCgpKTsK KyAgICAgICAgICAgICAgICBsYXRjaGluZ1N0YXRlLnNldFdpZGdldElzTGF0Y2hlZChyZXN1bHQu aXNPdmVyV2lkZ2V0KCkpOworICAgICAgICAgICAgICAgIHBhZ2UtPnB1c2hOZXdMYXRjaGluZ1N0 YXRlKFdURk1vdmUobGF0Y2hpbmdTdGF0ZSkpOwogCiAgICAgICAgICAgICAgICAgcGFnZS0+d2hl ZWxFdmVudERlbHRhRmlsdGVyKCktPmJlZ2luRmlsdGVyaW5nRGVsdGFzKCk7CiAgICAgICAgICAg ICAgICAgaXNPdmVyV2lkZ2V0ID0gcmVzdWx0LmlzT3ZlcldpZGdldCgpOwogICAgICAgICAgICAg fQogCi0gICAgICAgICAgICBMT0dfV0lUSF9TVFJFQU0oU2Nyb2xsTGF0Y2hpbmcsIHN0cmVhbSA8 PCAiRXZlbnRIYW5kbGVyOjpwbGF0Zm9ybVByZXBhcmVGb3JXaGVlbEV2ZW50cygpIC0gY29uc2lk ZXJpbmcgbGF0Y2hpbmcgZm9yICIgPDwgd2hlZWxFdmVudCA8PCAiLCBhdCBzY3JvbGwgbGltaXQg IiA8PCBzdGFydGluZ0F0U2Nyb2xsTGltaXQgPDwgIiwgbGF0Y2hpbmcgc3RhdGUgIiA8PCBWYWx1 ZU9yTnVsbChwYWdlLT5sYXRjaGluZ1N0YXRlKCkpKTsKKyAgICAgICAgICAgIExPR19XSVRIX1NU UkVBTShTY3JvbGxMYXRjaGluZywgc3RyZWFtIDw8ICJFdmVudEhhbmRsZXI6OnBsYXRmb3JtUHJl cGFyZUZvcldoZWVsRXZlbnRzKCkgLSBjb25zaWRlcmluZyBsYXRjaGluZyBmb3IgIiA8PCB3aGVl bEV2ZW50IDw8ICIsIGF0IHNjcm9sbCBsaW1pdCAiIDw8IHN0YXJ0aW5nQXRTY3JvbGxMaW1pdCA8 PCAiLCBsYXRjaGluZyBzdGF0ZSAiIDw8IHBhZ2UtPmxhdGNoaW5nU3RhdGVTdGFjaygpKTsKICAg ICAgICAgfQogICAgIH0gZWxzZSBpZiAod2hlZWxFdmVudC5zaG91bGRSZXNldExhdGNoaW5nKCkp IHsKICAgICAgICAgY2xlYXJMYXRjaGVkU3RhdGUoKTsKLSAgICAgICAgTE9HX1dJVEhfU1RSRUFN KFNjcm9sbExhdGNoaW5nLCBzdHJlYW0gPDwgIkV2ZW50SGFuZGxlcjo6cGxhdGZvcm1QcmVwYXJl Rm9yV2hlZWxFdmVudHMoKSAtIHJlc2V0IGxhdGNoaW5nIGZvciBldmVudCAiIDw8IHdoZWVsRXZl bnQgPDwgIiBsYXRjaGluZyBzdGF0ZSAiIDw8IFZhbHVlT3JOdWxsKHBhZ2UtPmxhdGNoaW5nU3Rh dGUoKSkpOworICAgICAgICBMT0dfV0lUSF9TVFJFQU0oU2Nyb2xsTGF0Y2hpbmcsIHN0cmVhbSA8 PCAiRXZlbnRIYW5kbGVyOjpwbGF0Zm9ybVByZXBhcmVGb3JXaGVlbEV2ZW50cygpIC0gcmVzZXQg bGF0Y2hpbmcgZm9yIGV2ZW50ICIgPDwgd2hlZWxFdmVudCA8PCAiIGxhdGNoaW5nIHN0YXRlICIg PDwgcGFnZS0+bGF0Y2hpbmdTdGF0ZVN0YWNrKCkpOwogICAgIH0KIAogICAgIGlmICghd2hlZWxF dmVudC5zaG91bGRSZXNldExhdGNoaW5nKCkgJiYgbGF0Y2hpbmdTdGF0ZSAmJiBsYXRjaGluZ1N0 YXRlLT53aGVlbEV2ZW50RWxlbWVudCgpKSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w YWdlL3Njcm9sbGluZy9TY3JvbGxMYXRjaGluZ1N0YXRlLmggYi9Tb3VyY2UvV2ViQ29yZS9wYWdl L3Njcm9sbGluZy9TY3JvbGxMYXRjaGluZ1N0YXRlLmgKaW5kZXggNDY4ZDQ4YzhhNTNmZmQzMDRk OTI4NGYyY2Q3NGM2MDJmOTFkNDlhMC4uZjk0YzNjYjEyZWUyMmM4MTg3NjhmYjYzYzJlYjJhYjc5 MmM5OTZjNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xs TGF0Y2hpbmdTdGF0ZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9s bExhdGNoaW5nU3RhdGUuaApAQCAtMzgsNyArMzgsNiBAQCBjbGFzcyBFbGVtZW50OwogY2xhc3Mg RnJhbWU7CiAKIGNsYXNzIFNjcm9sbExhdGNoaW5nU3RhdGUgZmluYWwgewotICAgIFdURl9NQUtF X0ZBU1RfQUxMT0NBVEVEOwogcHVibGljOgogICAgIFNjcm9sbExhdGNoaW5nU3RhdGUoKTsKICAg ICB+U2Nyb2xsTGF0Y2hpbmdTdGF0ZSgpOwo=