209826 2020-03-31 12:25:18 -0700 Make FrameView and Frame TextStream-loggable 2020-03-31 19:50:15 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser darin simon.fraser webkit-bug-importer oldest_to_newest 1636175 0 simon.fraser 2020-03-31 12:25:18 -0700 Make FrameView and Frame TextStream-loggable 1636176 1 395078 simon.fraser 2020-03-31 12:26:29 -0700 Created attachment 395078 Patch 1636182 2 395078 darin 2020-03-31 12:34:53 -0700 Comment on attachment 395078 Patch I totally want to reverse the ValueOrNull thing for TextStream. By default pointers should log "value of pointed to thing or null" and we should have a function you can call on a pointer to make it instead log a hex pointer value. Also, if we keep ValueOrNull we can leave off the "OrNull" part. The real question is whether to log the pointer or the pointed-to thing. Not sure the word "value" is unambiguous about that, but it’s cool. 1636362 3 ews-feeder 2020-03-31 19:49:38 -0700 Committed r259335: <https://trac.webkit.org/changeset/259335> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395078. 1636363 4 webkit-bug-importer 2020-03-31 19:50:15 -0700 <rdar://problem/61137062> 395078 2020-03-31 12:26:29 -0700 2020-03-31 19:49:38 -0700 Patch bug-209826-20200331122628.patch text/plain 4247 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5MzAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDkwYTAzZTI1ZDg5MDM0 YjU2MDg1NGVkYjdiMDUxNTEzOWI5ZTBhMy4uOTllYjExNTM4YmQ4MzU4NjFlZmMxYzE2M2FlMzNk OWFhMGI3MzgxMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIwLTAzLTMxICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIE1ha2UgRnJhbWVW aWV3IGFuZCBGcmFtZSBUZXh0U3RyZWFtLWxvZ2dhYmxlCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDk4MjYKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQcm92aWRlIG9wZXJhdG9yPDwoVGV4dFN0cmVhbSYs IC4uLikgZm9yIEZyYW1lIGFuZCBGcmFtZVZpZXcgc28gdGhleSBjYW4gYmUgbG9nZ2VkLgorICAg ICAgICBPbmx5IGJhc2ljIGRhdGEgbG9nZ2luZyBjdXJyZW50bHk7IHRoaXMgY2FuIGJlIGFkanVz dGVkIGFzIG5lY2Vzc2FyeS4KKworICAgICAgICAqIHBhZ2UvRnJhbWUuY3BwOgorICAgICAgICAo V2ViQ29yZTo6b3BlcmF0b3I8PCk6CisgICAgICAgICogcGFnZS9GcmFtZS5oOgorICAgICAgICAq IHBhZ2UvRnJhbWVWaWV3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Om9wZXJhdG9yPDwpOgorICAg ICAgICAqIHBhZ2UvRnJhbWVWaWV3Lmg6CisKIDIwMjAtMDMtMzEgIENocmlzIER1bWV6ICA8Y2R1 bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBBU1NFUlRJT04gRkFJTEVEOiBtX3dyYXBwZXIgb24g aW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL3NlbWFudGljcy9lbWJlZGRlZC1j b250ZW50L21lZGlhLWVsZW1lbnRzL3JlYWR5LXN0YXRlcy9hdXRvcGxheS5odG1sCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv RnJhbWUuY3BwCmluZGV4IDUxOWYzZWZiZjczZDUzZDRkZjQ2MjBkOTllZjkwNzJjMzliZjJjOGUu LjY5MTQ2YzM3NWIzMmNlYzUxMmQ3NzUwZjExNGEwYTRmOGU2MTRmMWEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJh bWUuY3BwCkBAIC0xMDYsNiArMTA2LDcgQEAKICNpbmNsdWRlIDx3dGYvUmVmQ291bnRlZExlYWtD b3VudGVyLmg+CiAjaW5jbHVkZSA8d3RmL1N0ZExpYkV4dHJhcy5oPgogI2luY2x1ZGUgPHd0Zi90 ZXh0L1N0cmluZ0J1aWxkZXIuaD4KKyNpbmNsdWRlIDx3dGYvdGV4dC9UZXh0U3RyZWFtLmg+CiAK ICNkZWZpbmUgUkVMRUFTRV9MT0dfRVJST1JfSUZfQUxMT1dFRChjaGFubmVsLCBmbXQsIC4uLikg UkVMRUFTRV9MT0dfRVJST1JfSUYoaXNBbHdheXNPbkxvZ2dpbmdBbGxvd2VkKCksIGNoYW5uZWws ICIlcCAtIEZyYW1lOjoiIGZtdCwgdGhpcywgIyNfX1ZBX0FSR1NfXykKIApAQCAtMTA1Miw2ICsx MDUzLDEyIEBAIHZvaWQgRnJhbWU6OnNlbGZPbmx5RGVyZWYoKQogICAgIGRlcmVmKCk7CiB9CiAK K1RleHRTdHJlYW0mIG9wZXJhdG9yPDwoVGV4dFN0cmVhbSYgdHMsIGNvbnN0IEZyYW1lJiBmcmFt ZSkKK3sKKyAgICB0cyA8PCAiRnJhbWUgIiA8PCAmZnJhbWUgPDwgIiB2aWV3ICIgPDwgZnJhbWUu dmlldygpIDw8ICIgKGlzIG1haW4gZnJhbWUgIiA8PCBmcmFtZS5pc01haW5GcmFtZSgpIDw8ICIp ICIgPDwgKGZyYW1lLmRvY3VtZW50KCkgPyBmcmFtZS5kb2N1bWVudCgpLT5kb2N1bWVudFVSSSgp IDogZW1wdHlTdHJpbmcoKSk7CisgICAgcmV0dXJuIHRzOworfQorCiB9IC8vIG5hbWVzcGFjZSBX ZWJDb3JlCiAKICN1bmRlZiBSRUxFQVNFX0xPR19FUlJPUl9JRl9BTExPV0VECmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lLmggYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1l LmgKaW5kZXggNmZkZmE2OGJmNGM3NTM1MzE1NDIxN2E4NWQ5YWEyZmZiZGI0NWM3Yy4uMjUyMGUw MzdhNTQ5MzBmYTFlMWJmNzBlMWNjMmFhMTgzNmI1N2I4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGFnZS9GcmFtZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWUuaApAQCAt NTksNiArNTksMTAgQEAgbmFtZXNwYWNlIEpTQyB7IG5hbWVzcGFjZSBZYXJyIHsKIGNsYXNzIFJl Z3VsYXJFeHByZXNzaW9uOwogfSB9CiAKK25hbWVzcGFjZSBXVEYgeworY2xhc3MgVGV4dFN0cmVh bTsKK30KKwogbmFtZXNwYWNlIFdlYkNvcmUgewogCiBjbGFzcyBDU1NBbmltYXRpb25Db250cm9s bGVyOwpAQCAtNDEyLDYgKzQxNiw4IEBAIGlubGluZSBGcmFtZSYgRnJhbWU6Om1haW5GcmFtZSgp IGNvbnN0CiAgICAgcmV0dXJuIG1fbWFpbkZyYW1lOwogfQogCitXVEY6OlRleHRTdHJlYW0mIG9w ZXJhdG9yPDwoV1RGOjpUZXh0U3RyZWFtJiwgY29uc3QgRnJhbWUmKTsKKwogfSAvLyBuYW1lc3Bh Y2UgV2ViQ29yZQogCiBTUEVDSUFMSVpFX1RZUEVfVFJBSVRTX0JFR0lOKFdlYkNvcmU6OkZyYW1l KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwIGIvU291cmNl L1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCmluZGV4IGY5ODRmYzJmZjE4MGNhODllMjhhNzdh ZjAwNjhhNmQ0MDM0MzU2YzguLjc5YTQxZTlhNGM1YjBmNjZkYzE3NmQ1ZjRkZjhkNzFjOTE3Yjdi MmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKQEAgLTUwODksNyArNTA4OSw2IEBAIGJv b2wgRnJhbWVWaWV3Ojp3aGVlbEV2ZW50KGNvbnN0IFBsYXRmb3JtV2hlZWxFdmVudCYgd2hlZWxF dmVudCkKICAgICByZXR1cm4gU2Nyb2xsYWJsZUFyZWE6OmhhbmRsZVdoZWVsRXZlbnQod2hlZWxF dmVudCk7CiB9CiAKLQogYm9vbCBGcmFtZVZpZXc6OmlzVmVydGljYWxEb2N1bWVudCgpIGNvbnN0 CiB7CiAgICAgUmVuZGVyVmlldyogcmVuZGVyVmlldyA9IHRoaXMtPnJlbmRlclZpZXcoKTsKQEAg LTU0NDUsNiArNTQ0NCwxMiBAQCBib29sIEZyYW1lVmlldzo6c2hvdWxkUGxhY2VCbG9ja0RpcmVj dGlvblNjcm9sbGJhck9uTGVmdCgpIGNvbnN0CiAgICAgcmV0dXJuIHJlbmRlclZpZXcoKSAmJiBy ZW5kZXJWaWV3KCktPnNob3VsZFBsYWNlQmxvY2tEaXJlY3Rpb25TY3JvbGxiYXJPbkxlZnQoKTsK IH0KIAorVGV4dFN0cmVhbSYgb3BlcmF0b3I8PChUZXh0U3RyZWFtJiB0cywgY29uc3QgRnJhbWVW aWV3JiB2aWV3KQoreworICAgIHRzIDw8ICJGcmFtZVZpZXcgIiA8PCAmdmlldyA8PCAiIGZyYW1l ICIgPDwgdmlldy5mcmFtZSgpOworICAgIHJldHVybiB0czsKK30KKwogfSAvLyBuYW1lc3BhY2Ug V2ViQ29yZQogCiAjdW5kZWYgUEFHRV9JRApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFn ZS9GcmFtZVZpZXcuaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmgKaW5kZXggMmYz MzNlMTVkYTFlYzkwYTZkYTlmMmU4NWJmODI1ZDc1MTViMjE5My4uYmI5NTc4NWNjODEyN2EzN2Zm NjE1MDZmZjY4MTYyZjQ4MTU3ZGRmNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9G cmFtZVZpZXcuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5oCkBAIC00OSw2 ICs0OSwxMCBAQAogI2luY2x1ZGUgPHd0Zi9XZWFrSGFzaFNldC5oPgogI2luY2x1ZGUgPHd0Zi90 ZXh0L1dURlN0cmluZy5oPgogCituYW1lc3BhY2UgV1RGIHsKK2NsYXNzIFRleHRTdHJlYW07Cit9 CisKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogY2xhc3MgQVhPYmplY3RDYWNoZTsKQEAgLTk1NCw2 ICs5NTgsOCBAQCBpbmxpbmUgdm9pZCBGcmFtZVZpZXc6OmluY3JlbWVudFZpc3VhbGx5Tm9uRW1w dHlQaXhlbENvdW50KGNvbnN0IEludFNpemUmIHNpemUpCiAgICAgbV92aXN1YWxseU5vbkVtcHR5 UGl4ZWxDb3VudCArPSBzaXplLndpZHRoKCkgKiBzaXplLmhlaWdodCgpOwogfQogCitXVEY6OlRl eHRTdHJlYW0mIG9wZXJhdG9yPDwoV1RGOjpUZXh0U3RyZWFtJiwgY29uc3QgRnJhbWVWaWV3Jik7 CisKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKIAogU1BFQ0lBTElaRV9UWVBFX1RSQUlUU19XSURH RVQoRnJhbWVWaWV3LCBpc0ZyYW1lVmlldygpKQo=